Re: [Sugar-devel] [PATCH sugar] Anly approve and not handle channels in the shell, part of OLPC #10738

2011-04-18 Thread Sascha Silbe
self): logging.debug('__get_filters_cb') return [{ CHANNEL + '.ChannelType': CHANNEL_TYPE_TEXT, CHANNEL + '.TargetHandleType': CONNECTION_HANDLE_TYPE_ROOM, }] (The content seems to be static, so it wouldn't make sense to log

Re: [Sugar-devel] [PATCH sugar-toolkit] Handle DBUS tubes in the activity telepathy client, part of OLPC #10738

2011-04-18 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Apr 14 19:43:05 +0200 2011: > This adds the handling of DBUS tube channels to the > 'HandlerChannelFilter' in activity's telepathy client. It would be nice to have some rationale for the change. Why didn't we do this before and in what way is the ne

[Sugar-devel] [PATCH sugar-toolkit] remove obsolete comment

2011-04-11 Thread Sascha Silbe
GTK bug #502871 [1] has been fixed in 2007. [1] http://bugzilla.gnome.org/show_bug.cgi?id=502871 Signed-off-by: Sascha Silbe --- src/sugar/graphics/icon.py |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/sugar/graphics/icon.py b/src/sugar/graphics/icon.py index

Re: [Sugar-devel] [PATCH sugar] Fix search on external device OLPC #10808

2011-04-11 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Apr 04 17:54:51 +0200 2011: > We passed the wrong ordering of arguments to _get_file_metadata, > regression fix. Acked-by: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PG

Re: [Sugar-devel] [PATCH sugar] Copy to external device: do not fail on custom binary metadata OLPC #10807

2011-04-11 Thread Sascha Silbe
e > enough and the guidelines should maybe ask the activity authors > to not use binary blobs for metadata, or base64 them before storing > them in the metadata. More reasoning and background information > in the ticket itself. I've followed up on the ticket. Acked-By: Sascha Sil

Re: [Sugar-devel] [PATCH sugar] Journal detail view copy-palette: fallback to more generic icon when needed, part of OLPC #10805

2011-04-11 Thread Sascha Silbe
has 'drive' which > is the > usb icon. This adds the fallback code to make it more robust and display the > icon. Acked-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___

Re: [Sugar-devel] [PATCH] The activity icon does not handle the case of a activity without metadata.

2011-04-03 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Thu Mar 31 17:21:19 +0200 2011: > If the activity is initiated with create_object=False > > Acked-by: Sascha Silbe Pushed as 35cb4e3 [1] (master) and a883557 [2] (sucrose-0.92). Thanks for the patch! Sascha [1] http://git.sugarlabs.org

Re: [Sugar-devel] [PATCH] revise timezone list, #2195

2011-04-03 Thread Sascha Silbe
Excerpts from James Cameron's message of Wed Mar 23 00:58:09 +0100 2011: > > Thanks for the patch! It's a good start, but unfortunately not enough. > > POSIX defines TZ as "std offset dst offset, rule" [1], ... > > No, according to [1] only the "std offset" form is required, the remaining > field

Re: [Sugar-devel] icon search path

2011-04-02 Thread Sascha Silbe
Excerpts from Walter Bender's message of Sat Apr 02 18:24:05 +0200 2011: > Is there a way to add to the path used to search for icons by name? >From sugar.activity.main.main(): gtk.icon_theme_get_default().append_search_path(bundle.get_icons_path()) So something like: icon_theme = gtk.

Re: [Sugar-devel] [PATCH] adding support for Tuquito GNU/Linux distribution

2011-03-31 Thread Sascha Silbe
Excerpts from Alvar Maciel's message of Thu Mar 31 17:53:28 +0200 2011: > From 50c37da039dc8baafccd925b6b3f034a4ffbaaa9 Mon Sep 17 00:00:00 2001 > From: amaciel > Date: Tue, 29 Mar 2011 15:10:53 -0300 > Subject: [PATCH] Adding support for Tuquito GNU/Linux distribution [...] Thanks for the patc

Re: [Sugar-devel] [PATCH sugar-datastore 1/3] Add regression test for SL#2668

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 18:16:00 +0200 2011: > Ahh, I see - there is the plan for a full testsuite (aehm, unreviewed), > go for it then. Thanks! I added your Ack to the patch, but will hold off on pushing it until after the test suite enters mainline. On that note,

Re: [Sugar-devel] [PATCH sugar-datastore 2/3] Make sure data store checkouts are read-only

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 18:20:48 +0200 2011: > Ok, that sounds tricky indeed. So go for it without the conversion. Thanks! Pushed as a7644fc [1] to master and sucrose-0.92. Sascha [1] http://git.sugarlabs.org/sugar-datastore/mainline/commit/a7644fcca13db182cd4437

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Sascha Silbe
n upstream ticket. Acked-by: Sascha Silbe Thanks for the patch! Yet another small step towards solving SL#1169 [1]. Owner buddy fix anyone? :) Sascha [1] https://bugs.sugarlabs.org/ticket/1169#comment:8 -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.as

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 19:01:23 +0200 2011: > +def __button_clicked_cb(self, button): > +self.palette.popup(immediate=True, state=1) I guess this should use the Palette.SECONDARY constant instead of hard coding an integer value. FWIW, the way I did thi

Re: [Sugar-devel] [PATCH sugar-datastore 2/3] Make sure data store checkouts are read-only

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 21:31:20 +0200 2011: > On 03/05/2011 03:26 PM, Sascha Silbe wrote: > > We don't want anyone to be able to alter a file that is inside the data > > store, > > bypassing the API. > What happens to the files th

Re: [Sugar-devel] [PATCH sugar-datastore 3/3] don't destroy unchanged data store entries (SL#2668)

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 21:29:22 +0200 2011: > This part of the patch looks good. I added a test case to [1] to make > sure we can test it accordingly. [...] > Acked-by: Simon Schampijer Thanks! Pushed as ad9244e [1]. Sascha [1] http://git.sugarlabs.org/sugar-

Re: [Sugar-devel] [PATCH sugar-datastore 1/3] Add regression test for SL#2668

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 21:35:33 +0200 2011: > In general: I wonder if we should add test suites for specific bugs, or > if they should be just test the available API. Maybe a test that can be > done by a human [1] is good enough for those bugs. The best way to en

Re: [Sugar-devel] [PATCH] The activity icon does not handle the case of a activity without metadata.

2011-03-31 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Wed Mar 30 19:22:43 +0200 2011: > +if metadata is not None and metadata.get('icon-color', ''): We can drop the second parameter of the get(). The default is None which will be evaluated as False, like the empty string d

Re: [Sugar-devel] [PATCH sugar-toolkit] Store all the buddies that have been joined in the activity metadata OLPC #10578

2011-03-31 Thread Sascha Silbe
id join. The > '_buddies' dictionary keeps on tracking the users currently in the > activity. Is this a regression from pre-0.90? If so, please mention that in the description. Acked-by: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/

Re: [Sugar-devel] [PATCH sugar] Fix inviting from friends view OLPC #10767

2011-03-31 Thread Sascha Silbe
ne/blobs/master/src/jarabe/model/friends.py#line57 Acked-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 17:41:26 +0200 2011: > Hmm, the default behavior is that the Invoker does cache the palette > [1]. OK, good point. So as a pure bug fix, your current patch is more in line with the existing code. Therefore: Acked-by: Sascha

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-31 Thread Sascha Silbe
ding_reconnect = account.UpdateParameters( > +{'jid': account_id}, > +dbus.Array([], 's'), dbus_interface=ACCOUNT) Similarly, all parameters fit on a single line. Acked-by: Sascha Silbe Thanks for the patch! Sascha -- http:

Re: [Sugar-devel] [PATCH] Do startup animation of the activity icon using scaling and alpha - v2

2011-03-31 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Mon Mar 28 05:35:22 +0200 2011: > Thanks for review this patch. I can't wait for faster startup in activities > :) > I attach a new patch and reply your comments here I accidentally pulled in the OLPC Sugar 0.92 packages into my Dextrose test images and t

Re: [Sugar-devel] [PATCH sugar] Construct the published name based on the public key OLPC #10737

2011-03-29 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 18:37:19 +0200 2011: Acked-by: Sascha Silbe If you care enough, some minor corrections would be: > Limit the name to be only 8 characters maximum. The avahi > service name has a 64 character limit. It consists of > the

Re: [Sugar-devel] Why cannot collections of ---.xo files on a USB stick be run without installation in sugar?

2011-03-27 Thread Sascha Silbe
Excerpts from James Cameron's message of Tue Mar 01 07:38:47 +0100 2011: > Subject: [PATCH] sugar-install-bundle to accept multiple files > > Signed-off-by: James Cameron Thanks, pushed as ada2844 [1]. > +for line in fileinput.input(): Nice trick (I didn't know about the fileinput module yet)

Re: [Sugar-devel] [PATCH sugar-datastore 0/3] fix SL#2668

2011-03-27 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Sat Mar 05 21:26:33 +0100 2011: > Fix a nasty data store bug that was probably with us since 0.84. Ping. I'd like us to ship the fix in 0.92.1. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature _

Re: [Sugar-devel] [PATCH sugar-toolkit] Avoid showing decorated windows during start-up (OLPC#10713)

2011-03-27 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 08 00:13:43 +0100 2011: > I actually tried similar already as well. The issue can still be seen, > it seem a bit less visible but I can still see it. Do you mean that even with my patch, you can still trigger this issue? If so, can you give a r

Re: [Sugar-devel] [PATCH sugar-toolkit] fix regressions introduced by 29582de67f3189d232e170b1e07e9bf34233fb51

2011-03-27 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 16:54:22 +0100 2011: > Acked-by: Simon Schampijer Thanks, pushed with the requested change (PRIORITY_LOW) and a slightly improved description as 85e714e [1]. Sascha [1] http://git.sugarlabs.org/sugar-toolkit/mainline/commit/85e714ecb1e00e

Re: [Sugar-devel] [PATCH sugar] ActivityListPalette: fix bundle_changed disconnection

2011-03-27 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 16:18:20 +0100 2011: > Acked-by: Simon Schampijer Thanks, pushed as 5b5ec61 [1]. Sascha [1] http://git.sugarlabs.org/sugar/mainline/commit/5b5ec6156bbba69a5a5f6e7caef19eaceb823c33 -- http://sascha.silbe.org/ http://www.infra-silbe.de/

Re: [Sugar-devel] [PATCH sugar] Limit the nick name to be only 8 characters maximum #10737

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 22 22:49:53 +0100 2011: > Avahi uses "GetHostName" (on the XO this is something like 'xo-a7-2e-70' > based on the HW address). If GetHostName is based on gethostname(), then it is far from unique. Most distributions default to a constant name l

Re: [Sugar-devel] [PATCH v4 sugar] Time out on registration process to prevent indefinite UI hang (SL#2289)

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 15:04:29 +0100 2011: > > PS: Filing bugs upstream will a) increase the chance they get fixed by > > someone else, b) avoid duplicate work by sharing test results and c) > > give both upstream and other downstreams a better overview of what's >

Re: [Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 21:16:32 +0100 2011: > The patch does cache the palette of the Owner, this has been > the behavior before 356641c332d6cc889b265dfc29598004cf37763c. As > registering (and therefore the change of the palette) happens > rather seldom compared to

Re: [Sugar-devel] [PATCH] Do startup animation of the activity icon using scaling and alpha - v2

2011-03-25 Thread Sascha Silbe
Excerpts from godiard's message of Wed Mar 23 19:40:47 +0100 2011: Thanks for your patch! I can't wait for an accelerated launcher screen. ;) > This render the SVG image only one time, and then use alpha and scaling > of the rendered icon and will speed up the overall activity startup. Any patc

Re: [Sugar-devel] [PATCH sugar] Fix inviting from friends view OLPC #10767

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 21:52:04 +0100 2011: > Add the contact_id and the account information to the buddymodel used in > the group view. We do not store it in the friends model as the id and the > account information may vary. Why do we need those two when adding a

Re: [Sugar-devel] [AToiDeJouer] New activity from OLPC-France for animated story editing ... work in progress

2011-03-24 Thread Sascha Silbe
Excerpts from Florent Pigout's message of Thu Mar 24 18:10:43 +0100 2011: > With OLPC-France, we are currently working on a new activity named > 'AToiDeJouer' ('YourTurnToPlay'). Nice! > I developed and tested the activity on a trisquel-sugar-4.1 virtualbox > instance. Also I tried it once on a

Re: [Sugar-devel] Git rep for the ad-hoc mayan icons?

2011-03-24 Thread Sascha Silbe
Excerpts from Gary Martin's message of Thu Mar 24 18:19:44 +0100 2011: > > http://git.sugarlabs.org/~garycmartin/sugar-artwork/garycmartins-emblem-clone Your clone seems to be out of date. Try: git remote add mainline git://git.sugarlabs.org/sugar-artwork/mainline.git git pull mainline mast

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 15:01:44 +0100 2011: > http://lists.sugarlabs.org/archive/sugar-devel/2011-March/030439.html > This is the message, so that looks right to me. Ah, looks like a copy & paste error: Message-ID: 1300298237-10204-1-git-send-email-si...@schampije

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011: What message is <300298237-10204-1-git-send-email-si...@schampijer.de>? It never arrived here. And why did both Gonzalo and you make your (unrelated) patches a reply to it? This is really confusing. Please use --in-reply

Re: [Sugar-devel] [PATCH v4 sugar] Time out on registration process to prevent indefinite UI hang (SL#2289)

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 21:05:56 +0100 2011: > I lately see this error [1] when trying to connect to a schoolserver. > Maybe you (or someone else) have an idea what the issue is. If I do > construct the ServerProxy without the _TimeoutTransport the registration >

Re: [Sugar-devel] [PATCH sugar] Language: restore undo functionality in control panel section #10754

2011-03-22 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 22 21:52:26 +0100 2011: > Pushed as: > 86899b424e3e04dbbb6a6d681ef5a7fe2ac1dba9 You forgot the Tested-By: from Samuel. To make sure you include all tags you can pull patches from Patchwork. E.g.: wget -O https://patchwork.sugarlabs.org/patch/72

Re: [Sugar-devel] [PATCH] revise timezone list, #2195

2011-03-22 Thread Sascha Silbe
Excerpts from James Cameron's message of Mon Mar 21 04:09:27 +0100 2011: > - remove GMT offsets as useless, since GMT tracks UTC and this is not > expected to change, > > - fix #2195 by translating from ISO 8601 to POSIX.1 format, by > reversing the sign, > > - increase UTC timezone coverage

Re: [Sugar-devel] [PATCH sugar-presence-service] Make PS not dependent on buddy-icon.jpg to be around OLPC #10739

2011-03-22 Thread Sascha Silbe
vely. > > Signed-off-by: Simon Schampijer Acked-by: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists

Re: [Sugar-devel] [PATCH sugar] Remove leftovers that try to sync friends in the PS #10736

2011-03-22 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 16 21:11:54 +0100 2011: > Signed-off-by: Simon Schampijer Acked-by: Sascha Silbe Something like the following would be nice as part of the patch description: This avoids breaking if sugar-presence-service doesn't start (e.g. be

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-22 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 16 18:57:17 +0100 2011: > Signed-off-by: Simon Schampijer As usual I'm missing some kind of explanation on the background (why UpdateParameters is needed etc.). :) [src/jarabe/model/neighborhood.py] > @@ -812,10 +812,22 @@ class Neighborhood(

Re: [Sugar-devel] [PATCH sugar] Limit the nick name to be only 8 characters maximum #10737

2011-03-22 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 16 20:41:08 +0100 2011: > > And what are the adverse consequences if there is a conflict between > > JoseMariaSuarez and JoseMariaRamirez ? > > > > I think you'd want to show that the potential bugginess is not so bad, > > or else hash the names

Re: [Sugar-devel] [PATCH sugar] Limit the nick name to be only 8 characters maximum #10737

2011-03-22 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 16 19:40:11 +0100 2011: [src/jarabe/model/neighborhood.py] > > +def _limit_published_name(nick): > > A self is missing here. Gets introduced in "Fully update the salut > account information when the nick name changes #10749" (which depends

Re: [Sugar-devel] [PATCH sugar] Language: restore undo functionality in control panel section #10754

2011-03-22 Thread Sascha Silbe
rphism strikes again. :-/ Acked-by: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Nick name in file-transfer palette needs to be a string #10735

2011-03-22 Thread Sascha Silbe
condary_text = _('Transfer from %r') % nick > +self.props.secondary_text = _('Transfer from %s') % nick For consistency I'd prefer "(nick, )". It also makes it less likely that we forget to wrap the value in a tuple if the value is a tuple itself.

[Sugar-devel] [PATCH sugar-toolkit v2] sugar.datastore.datastore: Avoid data update if the file hasn't been changed

2011-03-15 Thread Sascha Silbe
data, but changes only the metadata. Reported-By: Daniel Drake Signed-off-by: Sascha Silbe --- v1->v2: cope with file_path being explicitly set to '' instead of None (like sugar.activity.activity.Activity._initialize_journal_object() does) src/sugar/datast

[Sugar-devel] [PATCH PoC sugar v2] add "favourites" view for XDG applications

2011-03-12 Thread Sascha Silbe
This is proof-of-concept code ("executable mock-up") for a favourites view based on XDG desktop entry files [1]. It shows icons for "legacy" applications (e.g. Gnome or KDE applications); the activity favourites view is left intact. XDG applications are started directly, without support for startu

[Sugar-devel] [PATCH sugar v2] Don't break if we may not own NetworkManagerUserSettings

2011-03-10 Thread Sascha Silbe
The user might not have privileges to handle user settings - e.g. because they are logging in remotely (LTSP-style setups), or because NetworkManager was only installed for testing purposes or dependency reasons. Signed-off-by: Sascha Silbe --- v1->v2: use DummyNMSettings class instead

Re: [Sugar-devel] [PATCH Pippy] Fix Pippy sound library on non-OLPC OS systems (SL#638)

2011-03-07 Thread Sascha Silbe
Excerpts from James Cameron's message of Thu Mar 03 23:37:23 +0100 2011: > Acked-by: James Cameron Thanks! Who is / are the current Pippy maintainers? You and Rafael? If you find some time, please update the MAINTAINERS file [1] in the repository, the Modules wiki page [2] and the a.sl.o entry [

Re: [Sugar-devel] [Server-devel] Hidden SSID and Proxy settings

2011-03-07 Thread Sascha Silbe
Excerpts from Jerry Vonau's message of Mon Mar 07 09:51:30 +0100 2011: > Yes, think that would be a good idea, with this method connections.cfg > can be empty. Perhaps network.py can just use/create the needed file > for /etc/NetworkManager/system-connections/ or make that an option > available in

[Sugar-devel] [PATCH sugar-datastore] Avoid recalculating checksum on metadata-only update

2011-03-05 Thread Sascha Silbe
If an empty file path has been passed (indicating a metadata-only update), there is no need to read the potentially huge data file and recalculate its checksum. Signed-off-by: Sascha Silbe --- src/carquinyol/datastore.py | 26 +- 1 files changed, 21 insertions(+), 5

[Sugar-devel] [PATCH sugar-toolkit] sugar.datastore.datastore: Avoid data update if the file hasn't been changed

2011-03-05 Thread Sascha Silbe
data, but changes only the metadata. Reported-By: Daniel Drake Signed-off-by: Sascha Silbe --- src/sugar/datastore/datastore.py | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/sugar/datastore/datastore.py b/src/sugar/datastore/datastore.py ind

[Sugar-devel] [PATCH sugar-datastore 2/3] Make sure data store checkouts are read-only

2011-03-05 Thread Sascha Silbe
We don't want anyone to be able to alter a file that is inside the data store, bypassing the API. Signed-off-by: Sascha Silbe --- src/carquinyol/filestore.py | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/src/carquinyol/filestore.py b/src/carqu

[Sugar-devel] [PATCH sugar-datastore 3/3] don't destroy unchanged data store entries (SL#2668)

2011-03-05 Thread Sascha Silbe
() without unlinking it first. Fix this by unlinking the destination file if it exists. Reported-By: Daniel Drake Signed-off-by: Sascha Silbe --- src/carquinyol/filestore.py |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/carquinyol/filestore.py b/src/carquinyol

[Sugar-devel] [PATCH sugar-datastore 1/3] Add regression test for SL#2668

2011-03-05 Thread Sascha Silbe
Signed-off-by: Sascha Silbe --- tests/test_sl2668.py | 71 ++ 1 files changed, 71 insertions(+), 0 deletions(-) create mode 100755 tests/test_sl2668.py diff --git a/tests/test_sl2668.py b/tests/test_sl2668.py new file mode 100755 index 000

[Sugar-devel] [PATCH sugar-datastore 0/3] fix SL#2668

2011-03-05 Thread Sascha Silbe
Fix a nasty data store bug that was probably with us since 0.84. Sascha Silbe (3): Add regression test for SL#2668 Make sure data store checkouts are read-only don't destroy unchanged data store entries (SL#2668) src/carquinyol/filestore.py | 13 ++- tests/test_sl26

Re: [Sugar-devel] [PATCH sugar-toolkit] Avoid showing decorated windows during start-up (OLPC#10713)

2011-03-05 Thread Sascha Silbe
Excerpts from Daniel Drake's message of Sat Mar 05 13:11:51 +0100 2011: > Out of interest, where is the existing code that makes things go > maximized/fullscreen (even if it does happen a bit late)? Check out jarabe.model.shell.ShellModel._window_opened_cb(): [...] if activity_id:

[Sugar-devel] [PATCH sugar-toolkit] Avoid showing decorated windows during start-up (OLPC#10713)

2011-03-05 Thread Sascha Silbe
As a side effect, activity start-up is now subjectively faster, maybe even objectively (due to avoiding a resize). Tested on XO-1 running Debian Squeeze. Signed-off-by: Sascha Silbe --- src/sugar/graphics/window.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src

Re: [Sugar-devel] about about my xo

2011-03-04 Thread Sascha Silbe
Excerpts from Erik Blankinship's message of Fri Mar 04 04:51:37 +0100 2011: > Is there a way for a sugar activity (and gnome) to query the version and > build information which is displayed in "about my xo" in the sugar control > panel? In general, you shouldn't do that. Check for the feature you

[Sugar-devel] [PATCH sugar] ActivityListPalette: fix bundle_changed disconnection

2011-03-03 Thread Sascha Silbe
: /scratch/build-area/glib2.0-2.24.2/gobject/gsignal.c:2390: instance `0x35022b0' has no handler with id `2278' self.disconnect(self._activity_changed_sid) Signed-off-by: Sascha Silbe --- src/jarabe/desktop/activitieslist.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) di

[Sugar-devel] [PATCH sugar-toolkit] fix regressions introduced by 29582de67f3189d232e170b1e07e9bf34233fb51

2011-03-03 Thread Sascha Silbe
GTK pops down the palette before it invokes the actions on the menu item. We need to postpone destruction of the palette until after all signals have propagated from the menu item to the palette owner. Signed-off-by: Sascha Silbe --- I don't really consider this a good solution (w

[Sugar-devel] [PATCH Pippy v2] Run graphics (pygame) examples in full screen mode (OLPC#10688)

2011-03-03 Thread Sascha Silbe
Sugar < 0.86 used a special window manager that put every window in full screen mode automatically. To achieve the same with "regular" window managers like we use in Sugar 0.86+, we need to tell pygame that we want full screen mode. Signed-off-by: Sascha Silbe --- v1->v2: f

[Sugar-devel] [PATCH Pippy] Fix Pippy sound library on non-OLPC OS systems (SL#638)

2011-03-03 Thread Sascha Silbe
Replace the hardcoded paths with corresponding lookups and raise an exception if the TamTamEdit sound library cannot be found. Inspired by patches from Julie Pichon . Signed-off-by: Sascha Silbe --- library/pippy/sound.py | 32 ++-- 1 files changed, 22 insertions

[Sugar-devel] [PATCH Pippy] Run graphics (pygame) examples in full screen mode (OLPC#10688)

2011-03-03 Thread Sascha Silbe
From: Sascha Silbe Sugar < 0.86 used a special window manager that put every window in full screen mode automatically. To achieve the same with "regular" window managers like we use in Sugar 0.86+, we need to tell pygame that we want full screen mode. Signed-off-by: Sascha Sil

Re: [Sugar-devel] [PATCH] Open content bundles on a external device #1748

2011-03-02 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 02 18:31:57 +0100 2011: > Signed-off-by: Gonzalo Odiard > Acked-By: Simon Schampijer Reviewed-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PG

Re: [Sugar-devel] [PATCH sugar] Open content bundles on a external device #1748

2011-03-02 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 02 18:28:31 +0100 2011: > Signed-off-by: Gonzalo Odiard > Acked-By: Simon Schampijer Reviewed-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PG

Re: [Sugar-devel] [PATCH sugar] Sugar Ad-hoc network: reconnect after suspend SL #2187

2011-03-02 Thread Sascha Silbe
el 1. I increased the > timeout to 60 seconds because during testing I found to > get more reliable results like that. Acked-By: Sascha Silbe [src/jarabe/model/adhoc.py] > self._idle_source = gobject.timeout_add_seconds( \ > -self._AUTOCONNECT_TIMEOUT, self.

Re: [Sugar-devel] [PATCH sugar] Make sure to listen on the new device after suspend OLPC #10672

2011-03-02 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 01 23:47:23 +0100 2011: > --- > src/jarabe/desktop/meshbox.py |3 ++- > src/jarabe/model/adhoc.py |1 + > 2 files changed, 3 insertions(+), 1 deletions(-) [...] Acked-By: Sascha Silbe Sascha -- http://sasch

[Sugar-devel] [PATCH sugar] jarabe.desktop.transitionbox: don't set icon size to float value

2011-02-26 Thread Sascha Silbe
Icon sizes are measured in pixels, so they should be integer values. Signed-off-by: Sascha Silbe --- This bug might have caused the following kind of warning (see e.g. SL#870 [1]): /usr/lib/python2.6/site-packages/sugar/graphics/icon.py:136: DeprecationWarning: integer argument expected, got

Re: [Sugar-devel] [PATCH Read] Show TopBar (fullscreen mode)

2011-02-24 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Thu Feb 24 17:54:19 +0100 2011: > I have applied the 3 patchs. > I will push a patch with pep8 corrections now. Great, thanks! Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature

[Sugar-devel] [PATCH Read] battery display (fullscreen mode): replace HAL with UPower

2011-02-24 Thread Sascha Silbe
HAL is deprecated, UPower is the designated replacement w.r.t. power supplies. Tested on XO-1.5 running Debian Squeeze with stock UPower (0.9.5-5) and a 2.6.35 OLPC kernel. Signed-off-by: Sascha Silbe --- readtopbar.py | 152 - 1 files

[Sugar-devel] [PATCH Read] Show TopBar (fullscreen mode)

2011-02-24 Thread Sascha Silbe
d-off-by: Sascha Silbe --- readactivity.py | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/readactivity.py b/readactivity.py index 9904910..d486f0c 100644 --- a/readactivity.py +++ b/readactivity.py @@ -143,7 +143,6 @@ class ReadActivity(activity.Act

[Sugar-devel] [PATCH Read] initialise EvinceViewer._view_notify_zoom_handler

2011-02-24 Thread Sascha Silbe
le "/home/sascha.silbe/sugar-jhbuild/install/share/sugar/activities/Read.activity/evinceadapter.py", line 130, in set_zoom if not self._view_notify_zoom_handler: AttributeError: EvinceViewer instance has no attribute '_view_notify_zoom_handler' Signed-off-by: Sascha Silbe

Re: [Sugar-devel] [PATCH sugar] Copy a Journal entry including the metadata to a removable device

2011-02-23 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Feb 21 21:44:25 +0100 2011: Acked-by: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-

Re: [Sugar-devel] [PATCH sugar] Convert Journal entries that have been saved to a storage device pre 0.84

2011-02-23 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Feb 22 17:27:59 +0100 2011: > Converts the entries to the new format [1] when the device is plugged > into the machine. Acked-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Descr

Re: [Sugar-devel] [PATCH sugar] Fix up style issues introduced by commit 3f8a1e1

2011-02-23 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Feb 21 21:34:41 +0100 2011: > All good - thanks - go for it! Pushed as ff47b24 [1], thanks! Sascha [1] http://git.sugarlabs.org/sugar/mainline/commit/ff47b24c5aa032f830c6f3dc3ae32dfed3c72229 -- http://sascha.silbe.org/ http://www.infra-silbe.de/

Re: [Sugar-devel] [PATCH] Don't set default timezone

2011-02-23 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Feb 22 23:01:30 +0100 2011: > For me it is ok to let the patch in 0.92 is a simple bugfix in the end. ok, pushed as 0c0b745 [1]. Thanks for the patch, Daniel! Sascha [1] http://git.sugarlabs.org/sugar/mainline/commit/0c0b7450a282608a004ff78960751

Re: [Sugar-devel] [PATCH] Don't set default timezone

2011-02-21 Thread Sascha Silbe
control panel. Acked-by: Sascha Silbe Please don't push yet; I'll merge your patch once we split off sucrose-0.92. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel

[Sugar-devel] [PATCH sugar] Fix up style issues introduced by commit 3f8a1e1

2011-02-21 Thread Sascha Silbe
Signed-off-by: Sascha Silbe --- extensions/deviceicon/battery.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/deviceicon/battery.py b/extensions/deviceicon/battery.py index 0d18a5f..4c1ef37 100644 --- a/extensions/deviceicon/battery.py +++ b

Re: [Sugar-devel] [PATCH sugar v3] battery frame device: replace HAL with UPower

2011-02-21 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Feb 21 15:30:37 +0100 2011: > device = bus.get_object('org.freedesktop.UPower', device_path) Oops, of course. Sorry, will send a fix-up patch. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signatur

Re: [Sugar-devel] [PATCH sugar] Restore setting a language with the command line OLPC #10681

2011-02-20 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Feb 17 23:28:01 +0100 2011: > Move the code that handles the list given by the view > to a separate function to make it clearer. Acked-by: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc

Re: [Sugar-devel] [PATCH] Convert Journal entries that have been saved to a storage device in 0.82

2011-02-19 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Feb 14 23:04:42 +0100 2011: [src/jarabe/journal/volumestoolbar.py] > +import cPickle I was about to suggest "import cPickle as pickle" instead, but can't find anything in the docs to back up my preference. > +import json Like for the other patch w

Re: [Sugar-devel] [PATCH sugar v3] battery frame device: replace HAL with UPower

2011-02-18 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Fri Feb 18 23:38:13 +0100 2011: > HAL is deprecated, UPower is the designated replacement w.r.t. power > supplies. As a bonus the time displayed is now correct (calculated at > run-time by UPower, self-adjusting to changes in power consumption). Ack'ed by S

[Sugar-devel] [PATCH sugar v3] battery frame device: replace HAL with UPower

2011-02-18 Thread Sascha Silbe
kernel. Signed-off-by: Sascha Silbe --- v2->v3: Some style fixes v1->v2: Rebased on mainline/master extensions/deviceicon/battery.py | 200 +++--- 1 files changed, 102 insertions(+), 98 deletions(-) diff --git a/extensions/deviceicon/battery.py b/exte

Re: [Sugar-devel] [PATCH] Journal entry sharing using a mass storage device

2011-02-18 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Feb 14 23:13:40 +0100 2011: > http://wiki.sugarlabs.org/go/Features/Journal_Entry_Sharing We should come up with a better description before we push the patch. [src/jarabe/journal/model.py] > +import json As agreed on in IRC, we should stick with

Re: [Sugar-devel] [PATCH sugar v2] use ConsoleKit instead of HAL for shutdown/reboot

2011-02-17 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Sat Jan 22 13:34:28 +0100 2011: > HAL is dead, ConsoleKit now handles shutdown / reboot. Ack'ed by Simon on #sugar and pushed with a slightly extended description as fd15e61 [1]. CanRestart and CanStop support would require UI changes (tracked as part of #2

Re: [Sugar-devel] [PATCH] fix recognition of JEBs outside of data store

2011-02-17 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Sun Jul 04 23:08:06 +0200 2010: > Add a MIME type definition for Journal Entry Bundles (JEBs) so they get > detected properly if encountered outside of the data store. Ack'ed by Simon on #sugar and pushed as 6ba79fc [1]. Sascha [1] http://git.sugarlabs.o

Re: [Sugar-devel] [PATCH] Window: allow removing the toolbar_box

2011-02-17 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Sun Jul 04 22:34:14 +0200 2010: > Allow the toolbar_box to be removed by setting it to None, like is supported > for canvas. Ack'ed by Simon on #sugar and pushed as 17537c7 [1]. Sascha [1] http://git.sugarlabs.org/sugar-toolkit/mainline/commit/17537c7710

Re: [Sugar-devel] [PATCH] localization support for GNOME version

2011-02-16 Thread Sascha Silbe
Excerpts from Walter Bender's message of Wed Feb 16 17:16:35 +0100 2011: [bindtextdomain() etc.] > That is exactly what we do already. The problem is that es is not > recognized as a valid locale for setting LC_NUMERIC. gettext and locale specific functions are more or less independent of each ot

Re: [Sugar-devel] [PATCH] localization support for GNOME version

2011-02-16 Thread Sascha Silbe
Excerpts from Walter Bender's message of Tue Feb 15 12:39:45 +0100 2011: > > Opportunity: maybe Sugar has a different approach to i18n than GNOME > > has? None in general. I don't know exactly what your problem is, but there are two potential sources of difference between Sugar and Gnome: 1. Sug

[Sugar-devel] School server vs. AP (was: Re: [Dextrose] [DESIGN] Reflect internet connectivity in the 'Network' frame icon)

2011-02-16 Thread Sascha Silbe
Excerpts from Martin Langhoff's message of Tue Feb 15 14:54:50 +0100 2011: [splitting of sub-thread to sugar-devel] > One of the thoughts I have on this specific topic is that we want to > associate the XS icon to the AP, and/or have a badge on any AP that > can reach an XS. Interesting idea.

Re: [Sugar-devel] [DESIGN] Reflect internet connectivity in the 'Network' frame icon

2011-02-16 Thread Sascha Silbe
Excerpts from Martin Langhoff's message of Tue Feb 15 14:57:01 +0100 2011: > Going back to your original post to note something important: these > statuses aren't important _just_ to show in the UI. This should be a > system status property that can be queried by activities and by > cronjobs / cli

Re: [Sugar-devel] [DESIGN] [PATCH sugar] Speaker frame device: pop up palette on left-click instead of toggling mute

2011-02-15 Thread Sascha Silbe
Excerpts from James Cameron's message of Mon Feb 14 10:29:12 +0100 2011: > Reviewed-by: James Cameron Thanks! The change was also agreed upon during the Design Team meeting on Sunday [1] so I now pushed it as 7b44b42 [2]. Sascha [1] http://meeting.sugarlabs.org/sugar-meeting/meetings/2011-02

Re: [Sugar-devel] [PATCH sugar 1/2] recognise translations using pgettext

2011-02-15 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Fri Feb 11 20:24:23 +0100 2011: > Since Python doesn't support pgettext, we need to teach xgettext to recognise > it. Ack'ed by Simon on #sugar and pushed as bfb7922 [1]. Sascha [1] http://git.sugarlabs.org/sugar/mainline/commit/bfb7922bff09f3e7845a3e770

Re: [Sugar-devel] [PATCH sugar-toolkit] fix whitespace mistake introduced by c7a80a1

2011-02-15 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Tue Feb 15 20:47:53 +0100 2011: > from sugar.bundle.bundleversion import InvalidVersionError > > + > class ActivityBundle(Bundle): Ack'ed by Simon on #sugar and pushed as 9d45394 [1]. Sascha [1] http://git.sugarlabs.org/sugar-toolkit/mainline/commit/

Re: [Sugar-devel] [PATCH sugar-toolkit v2] sugar.activity.i18n: add pgettext()

2011-02-15 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Tue Feb 15 20:49:10 +0100 2011: > Python 2 will never have pgettext() [1], so we need to ship our own version. > sugar.activity.i18n is the best place for that. Ack'ed by Simon on #sugar and pushed as 11bfce1 [1]. Sascha [1] http://git.sugarlabs.org/suga

Re: [Sugar-devel] [Dextrose] [PATCH sugar-toolkit] Cursor moves to beginning while trying to edit activity instance name #2608

2011-02-15 Thread Sascha Silbe
Excerpts from Bernie Innocenti's message of Tue Feb 15 21:19:57 +0100 2011: > The above patch isn't sufficient in this race-condition between the user > typing and the metadata update: even if we reset the cursor position to > the right place, the text that we set back into the widget is likely to

<    1   2   3   4   5   6   7   8   9   10   >