decide to keep the file for some reason:
Acked-by: Sascha Silbe
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
pgpvzWTpZ4aUc.pgp
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists
Simon Schampijer writes:
> From: Daniel Narvaez
>
> It was moved inside jarabe and ported to GTK+.
This file should be removed in the same patch that added the code to
jarabe, so that the code movement can easily be tracked and the actual
code changes be examined.
Sascha
--
http://sascha.silb
Simon Schampijer writes:
> From: Daniel Narvaez
>
> The SpreadLayout derives now from the ViewLayout. The ViewLayout
> has a grid by default and the allocation happens here as well.
I don't see any code moves in this patch, just removal. Like for "Drop
unused intro.py" (7/7), the removal should
Simon Schampijer writes:
> This is a patch series to make the Sugar shell hippo free. Based on the
> work that has been done in [1] and [2]. It incorporates the patch from
> Sascha to move the EventIcon into the shell temporary.
[...]
Thanks for the patch series and especially for the detailed
Simon Schampijer writes:
[...]
> src/jarabe/desktop/transitionbox.py | 50 +
> src/jarabe/journal/detailview.py | 73 +++
[...]
[src/jarabe/desktop/Makefile.am]
> @@ -15,4 +15,5 @@ sugar_PYTHON = \
> schoolserver.py \
> snowflakel
Simon Schampijer writes:
[src/intro/intro.py]
> It has been moved a long time ago, outside this patch series. I guess
> Daniel came across this when grepping for hippo.
OK. Please mention in the commit message that it has been unused since
1f91f7f7afd34143721ac66936546e950369.
Sascha
--
h
Simon Schampijer writes:
[docs/controls.txt]
> It is a spec. I would leave it and someone can look at updating it or
> remove it. But has not to be decided in this patch series.
OK, let's just merge Daniel's patch as-is then:
Acked-by: Sascha Silbe
Sascha
--
http://sascha
ly too bad, but I am pretty sure that
> gtk.EventBox.set_visible_window(False) should work fine here.
Doesn't look that way to me:
<>
So for the original patch:
Acked-by: Sascha Silbe
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
handler that sets the
requested size of the label to the actual allocation.
[1] https://bugzilla.gnome.org/show_bug.cgi?id=318276
Signed-off-by: Sascha Silbe
---
v5->v4: no changes
v4: introduced this patch into the series
extensions/cpsection/network/view.py |
d-off-by: Sascha Silbe
---
v4->v5: no changes
original version->v4: Add support for no_proxy, some minor changes
bin/sugar-session| 29 +
extensions/cpsection/network/view.py | 34 +-
2 files changed, 62 inser
minor change over v4 that doesn't affect
the behaviour (including UI layout).
Sascha Silbe (3):
Properly wrap labels in the Network Control Panel (GTK#318276
workaround)
Add proxy configuration support to Network Control Panel
sugar-session: export manual Gnome proxy settings as $http_
same keys as Gnome 2 [2].
This implements the Proxy Settings Feature [3].
[1] https://en.wikipedia.org/wiki/Web_Proxy_Autodiscovery_Protocol
[2] http://people.gnome.org/~bmsmith/gconf-docs/C/gnome-vfs.html
[3] https://wiki.sugarlabs.org/go/Features/Proxy_Settings
Signed-off-by: Sascha Silbe
Kartik Kumar writes:
> Then I made changes to aboutcomputer/view.py to load the CSS: (changes are
> highlighted in bold):
Diffs are usually easier to read, especially in MUAs that don't render
font attributes for HTML mails. If you want all of the previous code to
be included in the diff, you ca
Dear Sugar Labs members,
== Executive Summary ==
The current review process isn't a good fit for the current Sugar
contributors and causes a lot of frustration on both sides. There are
better ways to reach the same goals. The two major changes to the review
process I'll propose in this email are
Simon Schampijer writes:
> I would suggest the following new behavior:
>
> - the entry is unfocused by default, the canvas is focused
>
> - the entry contains a hint (e.g. "Search in your Journal..."), adding a
> placeholder text is available in GTK+3.2 [2]
>
> - when the user starts typing the
Simon Schampijer writes:
> As well the clipboard icons will reveal now the Palette on left
> click. This is also true when selecting a clipboard item. Technically we
> have to listen to the 'button-release-event' of the child widget
> as the RadioToolButton does only emit a clicked signal. Using
Simon Schampijer writes:
>> VI. Accept patches into mainline that are likely to increase the number
>> of contributors using Sugar themselves (A) or to increase their
>> usage of Sugar, even if the patch doesn't directly benefit the XO
>> target user base. It should not have a
Simon Schampijer writes:
> -
- review process and code acceptance policy [1]
Sascha
[1] message-id:"toek3x5b15n@mimosa.sascha.silbe.org"
https://lists.sugarlabs.org/archive/sugar-devel/2012-August/thread.html#38893
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
pgpuiI2Hcu5
Martin Abente Lahaye writes:
[src/jarabe/journal/volumestoolbar.py]
[_set_up_activities_examples()]
[...]
> +activities = []
> +for home_activity in home_model._activities:
> +if home_activity.is_journal():
> +continue
> +
> +activity_name =
Gary Martin writes:
> +1 though this is raises the question of what resolution would be good
> enough. Ideally we would store images at the full display resolution,
> and try to minimise the storage space tradeoff by being more
> aggressive on compression.
+1 on storing in native display size. F
Gary Martin writes:
> Duplicate
> Do you want to duplicate ? ((x) Cancel
> ((√) Duplicate)
For erasing Activities and Journal entries, a confirmation alert is
important as there's no way to recover from a mistake. For Duplicate,
however, it's easy to just delete the new entry.
Simon Schampijer writes:
> - if you did a search in View A and then switch to View B the search
> from A will not be applied in B, if you switch back to A the search you
> did before in A has been cached and is still applied (behavior before
> 0.97.2)
IMO this makes the most sense to the user
networks is "Ad-hoc
Network ".
2. Upstream network connections shared by Dextrose (and probably
future Sugar upstream versions). These use an SSID of "
network".
For any other network, we'll try DHCP, just in case it's an ad-hoc
network created with nm-apple
Martin Langhoff writes:
> Manuel Kaufmann has been looking at SL#394, and looking at the bug
> report, it struck me that it was reported backwards. I would have
> written: "I filled up my disk and it knocked the system out, Sugar
> would not start again, etc. Oh, btw, it was with Browse".
I agre
Hello everyone,
I am stepping down as maintainer for Sugar and some related
services. This is mostly due to lack of time, but even if I had more of
that to spare for Sugar, the way I work is sufficiently different from
that of the most active contributors that I'd do more harm than good.
For some
Excerpts from Benjamin Berg's message of Thu Sep 23 16:55:11 +0200 2010:
> This patch fixes building bundles for me. Without it sugar-jhbuild directly
> tries to install the module without first updating and building it.
> And with a clean checkout that means it will fail, because the repository
>
Excerpts from Alberto Arruda de Oliveira's message of Thu Sep 23 00:58:18 +0200
2010:
> Although it's not working perfectly yet, I hope it will be soon. I'm just
> having a little problem with the keep button. My activity creates the
> journal entry like it should when I exit through the close bu
Excerpts from Tomeu Vizoso's message of Fri Sep 24 15:10:07 +0200 2010:
> > It could be that the Journal is reindexing. (For a large Journal, this
> > sometimes has the appearance of an empty or nearly empty Journal.) If
> > you wait for the indexing to complete, everything reappears as normal.
>
Excerpts from Tim McNamara's message of Fri Sep 24 22:37:18 +0200 2010:
> The New Zealand testing groups will be operating in a few hours. If you have
> any requests for things to be explored, please respond within 5 hours.
That was a bit short notice. For the next test session, it would be nice
Excerpts from Tabitha Roder's message of Sat Sep 25 10:49:42 +0200 2010:
> > In Auckland we did test Backup and Restore today. We post our testing
> summaries to two mailing lists: test...@lists.laptop.org,
> olpc...@lists.laptop.org
Great, thanks!
> Basically they worked, though it was a bit c
Excerpts from Simon Schampijer's message of Tue Sep 28 21:00:22 +0200 2010:
> Ok, Lucian just explained me the rationale behind the Fedora version.
> Version 79 is coming from the evince-2-30 branch [1]. And the bundle is
> from his personal repository [2].
Can somebody merge that in mainline a
Excerpts from Tim McNamara's message of Sun Sep 26 22:04:56 +0200 2010:
> Sorry about that Sascha. We meet every weekend (Friday evening in Europe,
> Friday afternoon USA) , but haven't received many direct requests in a
> while.
Ah, good to know.
> If it would be worthwhile, I can send out remi
Excerpts from Dipankar Patro's message of Wed Sep 29 19:32:22 +0200 2010:
> @@ -42,6 +43,7 @@ def set_nick(nick):
> if not nick:
> raise ValueError(_("You must enter a name."))
> if not isinstance(nick, unicode):
> +nick = re.sub(r':', '_', nick)
> nick = unicod
Excerpts from Sameer Verma's message of Wed Sep 29 20:39:05 +0200 2010:
> Is there a documented way (or a script) to process all available
> metadata from the Journal? I am looking for timestamps, type of data
> stored, collaborated with, etc. and not the actual content of the
> activity.
Depends
Excerpts from Ishan Bansal's message of Thu Sep 30 18:03:21 +0200 2010:
> +[3, 3, 3, ('='), self.col_gray1, lambda w:
> self._parent.process()],
You dropped the underscore (shortcut name of gettext.gettext), but I'm
wondering whether we need to translate it at all (if not, the
parent
Excerpts from Bernie Innocenti's message of Thu Sep 30 17:42:17 +0200 2010:
> In the absense of a real test schoolserver, [...]
It would be nice if somebody could prepare a VM image containing an XS
installation.
> Note that the editable field for the collaboration server in the CP does
> not af
to
> activity.
No need to mention "the calculator activity" as there's nothing else in
this repository.
Please adjust the summary as well.
> v1 was Reviewed-By Sascha Silbe
Not really. I reviewed it, but since there were things I wanted to be
changed, I did not "grant"
Excerpts from Bernie Innocenti's message of Sat Oct 02 00:03:35 +0200 2010:
> > > In the absense of a real test schoolserver, [...]
> >
> > It would be nice if somebody could prepare a VM image containing an XS
> > installation.
>
> We already have one: schoolserver.sugarlabs.org. Unfortunately,
Excerpts from Dipankar Patro's message of Fri Oct 01 21:00:57 +0200 2010:
> Thanks Sascha for the patch.
The credit belongs to Tim McNamara, not me. :)
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
signature.asc
Description: PGP signature
__
Excerpts from Ishan Bansal's message of Fri Oct 01 19:58:23 +0200 2010:
> 2. To do the git email configuration for your system refer to
> http://paste.ubuntu.com/488777/
From there:
> 17 git send-email --to "sugar-devel@lists.sugarlabs.org" patchname.patch
FWIW, you don't need to create the pat
Excerpts from Shanjit Singh Jajmann's message of Sat Oct 02 08:54:39 +0200 2010:
> I just made patch for Issue 2324, and forwarded it to the list. A lot of
> unwanted characters seem to have crept in, however when i send it to my
> inbox, or any other, no such thing happens.
>
> Could some pointe
Excerpts from Art Hunkins's message of Sun Oct 03 21:00:19 +0200 2010:
> Please indicate where, in your wonderful manual (or elsewhere), I can find a
> simple example of retreiving Journal entries. (I cannot readily locate one.)
> I need to retrieve an Ogg Vorbis (.ogg) or other audio file, and
Excerpts from Tomeu Vizoso's message of Mon Oct 04 12:56:24 +0200 2010:
> A change that I think can be made without asking first is the addition
> of the 1.0 milestone, but I think we still need to agree on the
> meaning of moving a ticket to that milestone.
You are faster to complain than I can
Excerpts from James Simmons's message of Mon Oct 04 01:28:03 +0200 2010:
> There is a chapter called "Fun With The Journal" which has examples of
> listing out Journal entries. What you need to do is figure out what
> the MIME type of the Ogg entries in the Journal are and write code to
> list th
Hi!
I just added a "1.0" milestone to Trac and used it for a ticket. The
intended meaning is "we should change (or at least look at) this before
we declare the API 'stable' (whatever that means ;) )". If anyone has
a better name for that milestone we can rename it. Similarly, if we
decided to call
Excerpts from James Simmons's message of Mon Oct 04 16:15:32 +0200 2010:
> If we get to the point where an Activity cannot list
> out Journal entries (other than using the Object Chooser) at any time
> then I've got a beef.
I don't understand the part with the beef, but assume it's meant to
mean
Excerpts from Frederick Grose's message of Mon Oct 04 18:09:18 +0200 2010:
> The SEETA Developer: field might better be adjusted to Developer:, and we
> could use a convention to tag the developer's name, such as, [SEETA] Ishan
What would be the difference between Owner and Developer then?
Sasch
Excerpts from Art Hunkins's message of Mon Oct 04 19:33:19 +0200 2010:
> There is the Object Chooser method, which seems to do what I need (a
> *general* audio files listing is the appropriate), but is basically
> inoperable on XO-1.
The Object Chooser is hardware agnostic. What leads you to be
Excerpts from Tomeu Vizoso's message of Mon Oct 04 19:48:36 +0200 2010:
> Can submitters reply to their own messages for those that are intended
> to go in before we branch?
This patch of mine is a bug fix and should go into 0.90.1:
[sugar] fix recognition of JEBs outside of data store [1]
Thes
Excerpts from Art Hunkins's message of Mon Oct 04 21:10:02 +0200 2010:
> What made me think that Object Chooser was not feasible in 0.82?
Ah, you seem to equate XO-1 with Sugar 0.82. That's an incorrect
assumption, in both directions: Debian Lenny ships Sugar 0.82 and many
XO-1s now run Sugar 0.8
systems) would suffice.
Also the summary should be more "active" (e.g. "fix address completion").
Please adjust these before pushing. Thanks!
Acked-By: Sascha Silbe
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
signature.as
Excerpts from Simon Schampijer's message of Wed Oct 06 15:21:29 +0200 2010:
> I have been bumping into [1] [...]
Just to avoid confusion: This has nothing to do with how you run Sugar
(i.e. it will occur both with sugar-emulator and running Sugar as a
"regular" desktop session). It is (according
Excerpts from Simon Schampijer's message of Wed Oct 06 15:31:07 +0200 2010:
> Hmm, Lucian was to quick.
Hehe. No problem; I don't think this particular patch is going to
matter when hunting down some issue and there's enough information
in the description, even if just through an indirection (bug
Hi!
We could take one or two leaves out of Google Chromiums book [1]...
Sascha
[1] http://www.google.com/googlebooks/chrome/
[2] http://sandboxing.org/?page_id=13
sudo aptitude install bsdgames || sudo yum install bsd-games
rot13 << EOF
Jbexvat vfbyngvba (if. artyrpgrq Envaobj)
Havg grfgvat
Nhg
Excerpts from Sugar Labs Bugs's message of Wed Oct 06 18:16:49 UTC 2010:
> I decided to keep poking at this for Physics and there does seem to be an
> activity level fix. As per a long, long lost email from Tomeu (thanks
> Tomeu, only took me two years to re-investigate and take action). I'm
>
[Moving this to sugar-devel as I don't see any need to keep it private]
Excerpts from Simon Schampijer's message of Tue Oct 05 14:58:24 +0200 2010:
> #1106 Browse: No preview in Journal for downloaded image
> https://patchwork.sugarlabs.org/patch/273/
>
> I checked the pixbuf API and there is on
Excerpts from simon's message of Wed Oct 06 14:11:04 +0200 2010:
> Patch needed in 0.90
AFAICT it's needed on Fedora 14, not Sugar 0.90.
Are we sure yet this was an intentional change by libvte and not just a
mistake? In the latter case we should probably make the setting depend
on specific libvte
Excerpts from Lucian Branescu's message of Wed Oct 06 21:30:44 +0200 2010:
> > OK, then let's land both patches now (unless Lucian vetoes), but keep
> > the tickets open so we can give a closer look later.
> Fine by me. Will you do it Sascha, or shall I?
Gonzalo, you already have push rights, so
Excerpts from Tomeu Vizoso's message of Thu Oct 07 10:28:03 +0200 2010:
> Sounds like a very good idea to me.
Filed as #2416 so we don't forget about it. Not marked as sugar-love as
X11/GTK callbacks can get rather tricky.
Sascha
[1] https://bugs.sugarlabs.org/ticket/2416
--
http://sascha.silbe
Excerpts from Simon Schampijer's message of Thu Oct 07 09:52:19 +0200 2010:
> Bernie can you give some light on the issue in Xorg and where it has
> been fixed, if?
See [1] for a start.
> Right, best would be of course to get the Xorg fix in distros.
That would require someone to isolate the c
Excerpts from Anurag Chowdhury's message of Thu Oct 07 20:26:41 +0200 2010:
> +COUNTER = 1
>
> class Animator(gobject.GObject):
Please see PEP-8 [1], "Code lay-out", "Blank Lines", first paragraph.
> +for COUNTER in range(0, 5):
> + easing = EASE_IN_EXPO
> +
Excerpts from Anurag Chowdhury's message of Fri Oct 08 00:06:02 +0200 2010:
> v2 was Reviewed-By: Sascha Silbe
No, I certainly did NOT give my Reviewed-By on this code. As I already
told Ishan [2]:
>> I reviewed it, but since there were things I wanted to be
>> changed,
Excerpts from Anurag Chowdhury's message of Thu Oct 07 22:14:23 +0200 2010:
> Sorry , in that case , as I misunderstood the meaning of the tag
> Reviewed-by and will keep this fact in my mind while making future
> patches and will certainly remove your name from the reviewed by tag
> of this patch
Excerpts from Walter Bender's message of Fri Oct 08 01:45:21 +0200 2010:
> I am struggling with getting my activities to behave in consistent
> ways when using the chooser and datastore.find() between Sugar 0.84
> and more recent Sugar versions. (For example, I cannot get find() to
> process mime
Excerpts from Tomeu Vizoso's message of Fri Oct 08 10:01:37 +0200 2010:
> >> The SEETA Developer: field might better be adjusted to Developer:, and we
> >> could use a convention to tag the developer's name, such as, [SEETA] Ishan
> >
> > What would be the difference between Owner and Developer th
Excerpts from Ishan Bansal's message of Fri Oct 08 10:08:46 +0200 2010:
> From: Ishan Bansal ,Anubhav Aggarwal
AFAICT git still doesn't grok multiple authors [1]. The suggested
workaround is to use a tag Co-authored-by:
>> Co-authored-by: Some One
> New global variable 'newtotranslate' adde
Excerpts from Walter Bender's message of Fri Oct 08 11:28:33 +0200 2010:
[skipped full quote detailing what properties are searchable in which data
store version]
> Thanks. I'll write a test program to confirm all of the above and put
> the results in the wiki.
Great, thanks!
Sascha
--
http://s
Excerpts from Lucian Branescu's message of Tue Sep 28 22:34:01 +0200 2010:
> Epub support is not complete, you can see epubs, but none of the
> toolbars work. [...]
FWIW, I'd much rather see a working, but stripped-down Read upstream
and in all distros than a working, stripped-down one in Fedora
This is proof-of-concept code ("executable mock-up") for a favourites view
based on XDG desktop entry files [1]. It shows icons for "legacy" applications
(e.g. Gnome or KDE applications); the activity favourites view is left intact.
XDG applications are started directly, without support for startu
Excerpts from Gary C Martin's message of Fri Oct 01 17:46:56 +0200 2010:
> As per your request on irc for some icon alternatives/clean-ups for your
> Backup and Restore activities, here are a few variations/iterations.
Thanks a lot and sorry for taking so long to respond!
I like #2 (Journal ->
Excerpts from Tomeu Vizoso's message of Mon Oct 11 11:34:37 +0200 2010:
> Meaning that the palette will be disposed when it pops down.
I don't know how all this palette magic works, mainly because there's
no documentation on it and it involves non-trivial interactions and
cross-references between
Excerpts from Simon Schampijer's message of Wed Oct 13 12:45:09 +0200 2010:
> when working on the issue in Read that the dpad keys do not work
> directly when in ebook mode [1], I postulated that Read when it comes up
> should always grab the focus on the view so scrolling using the arrow
> key
Excerpts from Gonzalo Odiard's message of Wed Oct 13 17:33:50 +0200 2010:
> bus.add_signal_receiver(my_func,
> dbus_interface="org.freedesktop.Hal.Device",
> signal_name="PropertyModified")
HAL has been deprecated [1] and will not be available anymo
Excerpts from Ayush Goyal's message of Wed Oct 13 18:50:00 +0200 2010:
> The select tool is less than optimally discoverable in English because
> of the name 'Rectangular Marquee'. The name is changed to 'Select
> Area'.
[...]
Please mention the name of the module (activity in this case) the pat
Excerpts from Daniel Drake's message of Thu Oct 14 17:59:24 +0200 2010:
[ebook switch]
> It already is an input event, but I suspect that diving down into
> opening input devices is the wrong thing to do. Next sensible step
> would be to look at how GNOME does it.
Does Gnome support ebook switche
Excerpts from Tomeu Vizoso's message of Thu Oct 14 18:50:49 +0200 2010:
> Meaning that the palette will be cached after it's created.
> ---
Looks good AFAICT.
> +"""Whether the invoker will cache the palette after its creation.
> Defaults
> +to True.
> +"""
This is OK, though what
Excerpts from Tomeu Vizoso's message of Thu Oct 14 18:03:33 +0200 2010:
> It's no big deal, but I think we should stop caching as many palettes
> as possible.
+1 in general. Natural exceptions are palettes that are (potentially)
expensive to create - e.g. the ones in activity tool bars.
Sascha
Excerpts from Gonzalo Odiard's message of Thu Oct 14 20:29:30 +0200 2010:
[ebook switch]
> It's a very specific XO thing ...
It isn't, but at least until recently it was rather unusual for devices
capable of running Gnome.
> I probably don't are explaining well what I need.
Looks like it. What
Excerpts from godiard's message of Thu Oct 14 20:10:14 +0200 2010:
> Fix the tickets OLPC #5291, OLPC #1925, SL #2127
Please provide some background information as part of the patch
description. What are you changing and why?
Please mention the module name as part of the patch summary, e.g.:
[P
Excerpts from Gonzalo Odiard's message of Thu Oct 14 22:09:09 +0200 2010:
> It's simple and it's explained in http://dev.laptop.org/ticket/10396
At least in Read (and in most if not all activities), the dpad should
work the same regardless of whether the keyboard is available (non-ebook
mode) or
Excerpts from godiard's message of Thu Oct 14 21:27:31 +0200 2010:
> From: Gonzalo Odiard
>
> This ticket have a patch writed by iwikiwi
If Vamsi authored the patch, he should appear in From:.
You can add yourself in Signed-Off-By: (after the patch description,
like for the Reviewed-By: tag).
Make sugar-datastore as PEP8 / pylint clean as possible (again). All remaining
complaints are pylint bugs (doesn't recognise keyword arguments in decorators)
resp. shortcomings in pep8 (cannot selectively disable a warning for a
specific piece of code).
Sascha Silbe (3):
PEP8 cle
Signed-off-by: Sascha Silbe
diff --git a/src/carquinyol/filestore.py b/src/carquinyol/filestore.py
index 9eb975f..5f518ab 100644
--- a/src/carquinyol/filestore.py
+++ b/src/carquinyol/filestore.py
@@ -155,7 +155,8 @@ class FileStore(object):
os.remove(file_path)
def
No other name I can think of is a better fit and no external code is using
this class, so it isn't an issue.
Disabling the warning reduces pylint clutter and makes it easier to spot real
issues.
Signed-off-by: Sascha Silbe
diff --git a/src/carquinyol/indexstore.py b/src/carquinyol/indexsto
Caught by pylint.
Signed-off-by: Sascha Silbe
diff --git a/src/carquinyol/datastore.py b/src/carquinyol/datastore.py
index 86d5b02..28d7247 100644
--- a/src/carquinyol/datastore.py
+++ b/src/carquinyol/datastore.py
@@ -19,7 +19,6 @@ import logging
import uuid
import time
import os
-import
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/graphics/palettewindow.py
b/src/sugar/graphics/palettewindow.py
index fcdc2e3..81540e3 100644
--- a/src/sugar/graphics/palettewindow.py
+++ b/src/sugar/graphics/palettewindow.py
@@ -147,6 +147,7 @@ class PaletteWindow(gtk.Window):
self
ood a time as
any to land the changes. With AC/SEETA hacking away fervently now and
in the foreseeable future (awesome!) we're not going to have a window
where there are only a few patches pending. We'll always hurt someone
so it's better to get it in early in the release cycle.
Sa
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/activity/activityhandle.py
b/src/sugar/activity/activityhandle.py
index 4aeac71..b29973e 100644
--- a/src/sugar/activity/activityhandle.py
+++ b/src/sugar/activity/activityhandle.py
@@ -69,7 +69,7 @@ class ActivityHandle(object):
def
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 0094693..e3654d8 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -928,7 +928,7 @@ class _ClientHandler(dbus.service.Object, DBusProperties):
def
pep8 wants inline comments to be prefixed by at least two spaces. Let's just
move them to a separate line as that's easier to read anyway.
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/graphics/icon.py b/src/sugar/graphics/icon.py
index 100f05a..ea3a9c0 100644
--- a/src/suga
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/datastore/datastore.py b/src/sugar/datastore/datastore.py
index 3f5188e..2b01366 100644
--- a/src/sugar/datastore/datastore.py
+++ b/src/sugar/datastore/datastore.py
@@ -153,7 +153,7 @@ class DSObject(object):
return self._object_id
Caught by pep8.
Signed-off-by: Sascha Silbe
diff --git a/examples/radiopalette.py b/examples/radiopalette.py
index 85b43ce..f8336bd 100644
--- a/examples/radiopalette.py
+++ b/examples/radiopalette.py
@@ -17,6 +17,7 @@ box.pack_start(toolbar, False)
text_view = gtk.TextView()
box.pack_start
has_key() has been deprecated for quite some time now.
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 183d4a8..0094693 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -256,7 +256,7 @@ class
We know that our code is correct and column should always be assigned, but it
never hurts to act defensively and guard against bugs in other pieces of the
code (or other components like GTK).
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/graphics/palettewindow.py
b/src/sugar/graphics
Caught by PEP8. This is important for Sugar because the XO has a small screen
where long lines would make the code hard to understand (because you need to
constantly scroll horizontally).
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
I've left the powers as-is because IMO they should directly follow the base,
unlike other operators.
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/activity/bundlebuilder.py
b/src/sugar/activity/bundlebuilder.py
index fc8ebc8..2952d71 100644
--- a/src/sugar/activity/bundlebuilder.py
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/presence/connectionmanager.py
b/src/sugar/presence/connectionmanager.py
index 78b744e..502b7a8 100644
--- a/src/sugar/presence/connectionmanager.py
+++ b/src/sugar/presence/connectionmanager.py
@@ -24,8 +24,7 @@ from functools import partial
"format" is the name of a parameter of the function we are wrapping, so we
shouldn't change it.
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/wm.py b/src/sugar/wm.py
index 00c6fd0..8f1903f 100644
--- a/src/sugar/wm.py
+++ b/src/sugar/wm.py
@@ -38,6 +38,7 @@ def _property_get
This avoids the overhead from the string formatting on production systems.
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/wm.py b/src/sugar/wm.py
index eaa196e..00c6fd0 100644
--- a/src/sugar/wm.py
+++ b/src/sugar/wm.py
@@ -32,7 +32,7 @@ def _property_get_trapped(window, prop, prop_type
Signed-off-by: Sascha Silbe
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 64bc840..7229096 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -823,6 +823,7 @@ class Activity(Window, gtk.Container):
try
601 - 700 of 1408 matches
Mail list logo
