[Sugar-devel] [PATCH 09/21 sugar-toolkit] PEP8 cleanup: fix deprecated raise syntax

Signed-off-by: Sascha Silbe diff --git a/src/sugar/graphics/style.py b/src/sugar/graphics/style.py index d5f82ff..7f48d9a 100644 --- a/src/sugar/graphics/style.py +++ b/src/sugar/graphics/style.py @@ -83,7 +83,7 @@ class Color(object): if html_color[0] == '#':

[Sugar-devel] [PATCH 10/21 sugar-toolkit] style cleanup: use """ everywhere

Most of the code uses """, so adjust the few deviations. Signed-off-by: Sascha Silbe diff --git a/src/sugar/activity/bundlebuilder.py b/src/sugar/activity/bundlebuilder.py index 7bf02ed..d058b55 100644 --- a/src/sugar/activity/bundlebuilder.py +++ b/src/sugar/activity/b

[Sugar-devel] [PATCH 21/21 sugar-toolkit] bundlebuilder: ignore incorrect pylint warning

pylint isn't smart enough to figure out the return type of Popen.communicate(), so squelch the warning. Signed-off-by: Sascha Silbe diff --git a/src/sugar/activity/bundlebuilder.py b/src/sugar/activity/bundlebuilder.py index 1d7b613..60721d3 100644 --- a/src/sugar/activity/bundlebuild

[Sugar-devel] [PATCH 12/21 sugar-toolkit] pylint cleanup: replace disable-msg with disable

Adapt to upstream format change. Signed-off-by: Sascha Silbe diff --git a/src/sugar/activity/activityfactory.py b/src/sugar/activity/activityfactory.py index 6bd661f..a206d15 100644 --- a/src/sugar/activity/activityfactory.py +++ b/src/sugar/activity/activityfactory.py @@ -58,7 +58,7 @@ def

[Sugar-devel] [PATCH 14/21 sugar-toolkit] sugar.util: use logging.exception instead of traceback.format_exc()

logging.exception() handles exceptions nicely for us, no need to explicitly use traceback. Signed-off-by: Sascha Silbe diff --git a/src/sugar/util.py b/src/sugar/util.py index 889cc62..e0a431b 100644 --- a/src/sugar/util.py +++ b/src/sugar/util.py @@ -29,7 +29,6 @@ import gettext import

[Sugar-devel] [PATCH 18/21 sugar-toolkit] ToolInvoker._get_alignments: fix missing self parameter

Caught by pylint. I wonder if we need this piece of code as nobody every triggered it. Signed-off-by: Sascha Silbe diff --git a/src/sugar/graphics/palettewindow.py b/src/sugar/graphics/palettewindow.py index 81540e3..c5deecd 100644 --- a/src/sugar/graphics/palettewindow.py +++ b/src/sugar

[Sugar-devel] [PATCH 11/21 sugar-toolkit] style cleanup: prefer ' for strings

Tomeu prefers ' for strings, so let's use it wherever we don't have a good reason to use ". Signed-off-by: Sascha Silbe diff --git a/examples/radiopalette.py b/examples/radiopalette.py index f8336bd..3117aec 100644 --- a/examples/radiopalette.py +++ b/examples/radiopalet

Re: [Sugar-devel] branching off sucrose-0.90

Excerpts from Simon Schampijer's message of Fri Oct 15 17:54:14 +0200 2010: > On 10/15/2010 02:04 PM, Tomeu Vizoso wrote: > > patches are accumulating as we wait for 0.90 branches in Pootle. > > > > Anybody opposes to branching now in git? > > No, let's do it. Thought about it several times alread

Re: [Sugar-devel] Review: [PATCH] Downgrading activities not allowed. (#2164)

Excerpts from Manusheel Gupta's message of Sat Oct 09 04:46:02 +0200 2010: > Ishan tried to add the tag - "Coauthored by" in his patch, and that line > gets scrubbed off. Have you added it right at the end, like you would do with the Reviewed-By: tag? E.g.: (assuming author is set to Shanjit Sin

Re: [Sugar-devel] [PATCH] Change the logic used to determine the format used to save files.

Excerpts from Gonzalo Odiard's message of Thu Oct 14 22:23:35 +0200 2010: > > Please mention the module name as part of the patch summary, e.g.: > > > > [PATCH Write] keep file type across load/save (SL #2127) > > > > > The subject is created by git send-email. I can change the first line from > t

Re: [Sugar-devel] [PATCH] Downgrading activities not allowed. (#2164)

Excerpts from shanjit's message of Fri Oct 15 23:37:42 +0200 2010: > Downgrading an activity is now made possible. [...] You've told git send-email to mark your patch as a reply to some message that I've not only never received, but that's also the same as the one referenced by a totally differen

[Sugar-devel] [PATCH sugar-base 10/17] style cleanup: prefer ' for strings

Tomeu prefers ' for strings, so let's use it wherever we don't have a good reason to use ". Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/saferef.py b/src/sugar/dispatch/saferef.py index 709d292..1632b34 100644 --- a/src/sugar/dispatch/saferef.py +++

[Sugar-devel] [PATCH sugar-base 05/17] PEP8 cleanup: fix spaces around operators and parentheses

Signed-off-by: Sascha Silbe diff --git a/maint-helper.py b/maint-helper.py index 8496f06..b963e7f 100755 --- a/maint-helper.py +++ b/maint-helper.py @@ -22,7 +22,7 @@ import re import datetime import subprocess -source_exts = [ '.py', '.c', '.h', '.cpp&

[Sugar-devel] [PATCH sugar-base 01/17] fix EOL spaces

Signed-off-by: Sascha Silbe diff --git a/maint-helper.py b/maint-helper.py index 50f7d07..fea9b3c 100755 --- a/maint-helper.py +++ b/maint-helper.py @@ -16,7 +16,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA

[Sugar-devel] [PATCH sugar-base 04/17] sugar.dispatch.saferef: don't use assert for critical code paths

ill cause assert statements not to be evaluated. Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/saferef.py b/src/sugar/dispatch/saferef.py index b0ceef9..655f9a1 100644 --- a/src/sugar/dispatch/saferef.py +++ b/src/sugar/dispatch/saferef.py @@ -23,11 +23,12 @@ def safeRef(target,

[Sugar-devel] [PATCH sugar-base 03/17] PEP8 cleanup: fix number of blank lines

Signed-off-by: Sascha Silbe diff --git a/maint-helper.py b/maint-helper.py index d7c5d5b..8496f06 100755 --- a/maint-helper.py +++ b/maint-helper.py @@ -23,12 +23,15 @@ import datetime import subprocess source_exts = [ '.py', '.c', '.h', '.cpp'

[Sugar-devel] [PATCH sugar-base 11/17] pylint cleanup: replace disable-msg with disable

Adapt to upstream format change. Signed-off-by: Sascha Silbe diff --git a/src/sugar/logger.py b/src/sugar/logger.py index ebb766d..b4cba6c 100644 --- a/src/sugar/logger.py +++ b/src/sugar/logger.py @@ -65,7 +65,7 @@ def set_level(level): logging.warning('Invalid log level: %r&#x

[Sugar-devel] [PATCH sugar-base 09/17] PEP8 cleanup: import only one module per import statement

Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/saferef.py b/src/sugar/dispatch/saferef.py index 6eb0d9e..709d292 100644 --- a/src/sugar/dispatch/saferef.py +++ b/src/sugar/dispatch/saferef.py @@ -5,7 +5,8 @@ Provides a way to safely weakref any function, including bound methods

[Sugar-devel] [PATCH sugar-base 16/17] pylint cleanup: Signal._live_receivers: mark receiverkey as unused

Follow the convention of marking known-unused (but required for de-marshalling purposes) variables by postfixing them with an underscore. Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/dispatcher.py b/src/sugar/dispatch/dispatcher.py index eb2dd7e..dd6230b 100644 --- a/src/sugar

[Sugar-devel] [PATCH sugar-base 07/17] PEP8 cleanup: ensure lines are shorter than 80 characters

This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/__init__.py b/src/sugar/dispatch/__init__.py index 776b1bc

[Sugar-devel] Patch review: adding the module name to the subject (was: Re: [PATCH] Change the logic used to determine the format used to save files.)

Excerpts from Sascha Silbe's message of Fri Oct 15 23:46:25 +0200 2010: > Check out the --subject-prefix option of git format-patch. git send-email > delegates the actual patch preparation to git format-patch (unless you > pass it a pre-formatted patch as a file). Forgot to mention: Because it's

[Sugar-devel] [PATCH sugar-base 13/17] maint-helper: rename parameter to avoid name clash with built-in function

Renaming license to license_name even makes the code slightly easier to understand. Signed-off-by: Sascha Silbe diff --git a/maint-helper.py b/maint-helper.py index 4f8a0be..8bd35ce 100755 --- a/maint-helper.py +++ b/maint-helper.py @@ -129,21 +129,21 @@ def cmd_build_snapshot(): print

[Sugar-devel] [PATCH sugar-base 06/17] sugar.dispatch.dispatcher: remove fallback for Python 2.3

Other pieces of the piece rely on Python 2.5, so there's no point in keeping this. pep8 complained about lack of spacing in front of the inline comment, so it needed touching anyway. Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/dispatcher.py b/src/sugar/dispatch/dispatch

[Sugar-devel] [PATCH sugar-base 14/17] sugar.dispatch.saferef: ignore incorrect pylint warning

pylint isn't smart enough to figure out our class magic, so squelch the warning. Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/saferef.py b/src/sugar/dispatch/saferef.py index 1632b34..56166d9 100644 --- a/src/sugar/dispatch/saferef.py +++ b/src/sugar/dispatch/saferef.py @@ -

[Sugar-devel] [PATCH sugar-base 08/17] PEP8 cleanup: don't use has_key()

has_key() has been deprecated for quite some time now. Signed-off-by: Sascha Silbe diff --git a/maint-helper.py b/maint-helper.py index b963e7f..4f8a0be 100755 --- a/maint-helper.py +++ b/maint-helper.py @@ -79,7 +79,7 @@ def cmd_build_snapshot(): print 'Update NEWS.sugar...'

[Sugar-devel] [PATCH sugar-base 02/17] maint-helper.py: remove outdated URL

The git repository of Sugar should be easy enough to discover these days. If we want to make it easier, a README would be a better place. Signed-off-by: Sascha Silbe diff --git a/maint-helper.py b/maint-helper.py index fea9b3c..d7c5d5b 100755 --- a/maint-helper.py +++ b/maint-helper.py @@ -16,8

[Sugar-devel] [PATCH sugar-base 15/17] pylint cleanup: sugar.dispatch.saferef: remove unused variable

Signed-off-by: Sascha Silbe diff --git a/src/sugar/dispatch/saferef.py b/src/sugar/dispatch/saferef.py index 56166d9..bb73b5d 100644 --- a/src/sugar/dispatch/saferef.py +++ b/src/sugar/dispatch/saferef.py @@ -126,7 +126,7 @@ class BoundMethodWeakref(object): except Exception, e

[Sugar-devel] [PATCH sugar-base 17/17] sugar.mime: ignore incorrect pylint warning

pylint isn't smart enough to analyse the contents of gio, so squelch the warning. Signed-off-by: Sascha Silbe diff --git a/src/sugar/mime.py b/src/sugar/mime.py index 7f3f5ff..c4b847b 100644 --- a/src/sugar/mime.py +++ b/src/sugar/mime.py @@ -134,6 +134,7 @@ def get_mime_description(mime

[Sugar-devel] [PATCH sugar-base 12/17] pylint: sugar.logger: allow overriding module name

"traceback" is the name of a parameter of the function we are wrapping, so we shouldn't change it. Signed-off-by: Sascha Silbe diff --git a/src/sugar/logger.py b/src/sugar/logger.py index b4cba6c..c242194 100644 --- a/src/sugar/logger.py +++ b/src/sugar/logger.py @@ -65,7 +65,7 @

[Sugar-devel] [PATCH sugar-base 00/17] style cleanup series

right after we branched off sucrose-0.90: to ensure it gets enough testing before the next release. After this series sugar-base is pep8 and pylint clean. Sascha Silbe (17): fix EOL spaces maint-helper.py: remove outdated URL PEP8 cleanup: fix number of blank lines sugar.dispatch.saferef: d

Re: [Sugar-devel] [PATCH v4 sugar] Downgrading activities not allowed. (#2164)

Excerpts from anubhav's message of Sat Oct 16 22:25:00 +0200 2010: [src/jarabe/journal/versionalert.py: 147 lines skipped] If we really need that much code just for asking the user for confirmation then we're doing something wrong. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/

Re: [Sugar-devel] [DESIGN] Downgrading activities not allowed. (SL#2164)

Excerpts from Gary Martin's message of Sat Oct 16 17:05:20 +0200 2010: > FWIW, I'd vote for use of the regular Sugar alert strip that appears below > the toolbar. Using floating window dialogues goes against the fullscreen > Sugar design. +1 Dialogs are evil (especially, but not only if they're

Re: [Sugar-devel] ticket 2170 Specify bundle id for read activity

Excerpts from Ishan Bansal's message of Sat Oct 16 21:36:56 +0200 2010: > You can check the patch at > http://lists.sugarlabs.org/archive/sugar-devel/2010-September/026963.html > > Wish if you could review it and provide me feedback on any improvement > required. If you'd like to remind everyone

[Sugar-devel] [PATCH sugar 05/21] PEP8 cleanup: fix inline comment spacing

Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/keyboard/model.py b/extensions/cpsection/keyboard/model.py index b7186e2..82456d3 100644 --- a/extensions/cpsection/keyboard/model.py +++ b/extensions/cpsection/keyboard/model.py @@ -20,7 +20,7 @@ import xklavier import gconf

[Sugar-devel] [PATCH sugar 00/21] style cleanup series

ter we branched off sucrose-0.90: to ensure it gets enough testing before the next release. There are a couple of pylint complaints remaining. Some of them are pylint bugs, but a fair number are things that should be looked at more closely. One even shows the cause of SL#1748. Sascha Silbe (21):

[Sugar-devel] [PATCH sugar 14/21] pylint cleanup: pass format parameters to log functions instead of using %

This avoids the overhead from the string formatting on production systems. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/favoritesview.py b/src/jarabe/desktop/favoritesview.py index b06f672..e6c2c44 100644 --- a/src/jarabe/desktop/favoritesview.py +++ b/src/jarabe/desktop

[Sugar-devel] [PATCH sugar 02/21] style cleanup: move globals before class and method definitions

This only touches the globals that were flagged by pep8 due to white space issues. I've also left the sunflower layout variables alone. AFAICT this layout is currently unused and should be removed instead (or factored out like the snow flake layout and reenabled). Signed-off-by: Sascha

[Sugar-devel] [PATCH sugar 01/21] fix EOL spaces

Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/aboutcomputer/model.py b/extensions/cpsection/aboutcomputer/model.py index 898d79c..77d3b86 100644 --- a/extensions/cpsection/aboutcomputer/model.py +++ b/extensions/cpsection/aboutcomputer/model.py @@ -40,7 +40,7 @@ def

[Sugar-devel] [PATCH sugar 20/21] pylint cleanup: don't override variables from outer scope

If two different entities have the same name, things get messy. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/schoolserver.py b/src/jarabe/desktop/schoolserver.py index 720fc40..aea2357 100644 --- a/src/jarabe/desktop/schoolserver.py +++ b/src/jarabe/desktop/schoolserver.py

[Sugar-devel] [PATCH sugar 21/21] pylint cleanup: disable warnings for reasonable catch-all exception handlers

Signed-off-by: Sascha Silbe diff --git a/src/jarabe/model/bundleregistry.py b/src/jarabe/model/bundleregistry.py index 1edee8f..931c59b 100644 --- a/src/jarabe/model/bundleregistry.py +++ b/src/jarabe/model/bundleregistry.py @@ -216,6 +216,7 @@ class BundleRegistry(gobject.GObject

[Sugar-devel] [PATCH sugar 06/21] PEP8 cleanup: ensure lines are shorter than 80 characters

This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/datetime/view.py b/extensions/cpsection/datetime/view.py

[Sugar-devel] [PATCH sugar 18/21] pylint cleanup: fix indentation

Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/activitieslist.py b/src/jarabe/desktop/activitieslist.py index e97d5b0..6c9c764 100644 --- a/src/jarabe/desktop/activitieslist.py +++ b/src/jarabe/desktop/activitieslist.py @@ -420,8 +420,8 @@ class ActivityListPalette(ActivityPalette

[Sugar-devel] [PATCH sugar 12/21] use logging.exception() instead of logging.error(traceback.format_exc())

logging.exception() handles exceptions nicely for us, no need to explicitly use traceback. Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/updater/backends/aslo.py b/extensions/cpsection/updater/backends/aslo.py index 016e5e8..eec54b0 100644 --- a/extensions/cpsection/updater

[Sugar-devel] [PATCH sugar 19/21] jarabe.desktop.schoolserver: mark helper functions and classes as private

Only register_laptop and RegisterError are meant to be public API. Proper marking of private / public makes it easier to see which code changes break API (or not). Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/schoolserver.py b/src/jarabe/desktop/schoolserver.py index 1a10b16

[Sugar-devel] [PATCH sugar 07/21] PEP8 cleanup: don't use has_key()

has_key() has been deprecated for quite some time now. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py index 99734a2..1b3ccda 100644 --- a/src/jarabe/desktop/meshbox.py +++ b/src/jarabe/desktop/meshbox.py @@ -119,7 +119,7 @@ class

[Sugar-devel] [PATCH sugar 10/21] pylint cleanup: replace disable-msg with disable

Adapt to upstream format change. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/config.py.in b/src/jarabe/config.py.in index 6c418e9..d22ee9a 100644 --- a/src/jarabe/config.py.in +++ b/src/jarabe/config.py.in @@ -14,7 +14,7 @@ # along with this program; if not, write to the Free Software

[Sugar-devel] [PATCH sugar 17/21] pylint cleanup: don't override built-in objects

Signed-off-by: Sascha Silbe diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index a3a003f..ffec677 100644 --- a/extensions/deviceicon/network.py +++ b/extensions/deviceicon/network.py @@ -697,8 +697,8 @@ class OlpcMeshDeviceView(ToolButton): try

[Sugar-devel] [PATCH sugar 15/21] CurrentActivityPalette: remove dead code

__active_window_changed_cb() is not referenced anywhere and contains broken code. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/view/palettes.py b/src/jarabe/view/palettes.py index cb30ed8..d9c1f6b 100644 --- a/src/jarabe/view/palettes.py +++ b/src/jarabe/view/palettes.py @@ -108,10

[Sugar-devel] [PATCH sugar 11/21] pylint cleanup: remove unused imports

Signed-off-by: Sascha Silbe diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index 8c86fca..a3a003f 100644 --- a/extensions/deviceicon/network.py +++ b/extensions/deviceicon/network.py @@ -23,7 +23,6 @@ import logging import hashlib import socket import struct

[Sugar-devel] [PATCH sugar 16/21] ignore incorrect pylint error E1101

pylint isn't smart enough to figure out the contents of ParseResult and gtk.Invisible, so squelch the warning. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/frame/clipboard.py b/src/jarabe/frame/clipboard.py index 65872ef..be2b902 100644 --- a/src/jarabe/frame/clipboard.py +++

[Sugar-devel] [PATCH sugar 08/21] style cleanup: use """ everywhere

Most of the code uses """, so adjust the few deviations. Signed-off-by: Sascha Silbe diff --git a/docs/release_howto.txt b/docs/release_howto.txt index db877e0..841809a 100644 --- a/docs/release_howto.txt +++ b/docs/release_howto.txt @@ -1,7 +1,7 @@ -''' This is th

[Sugar-devel] [PATCH sugar 13/21] pylint cleanup: mark some variables as unused

Follow the convention of marking known-unused (but required for de-marshalling purposes) variables by postfixing them with an underscore. Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/favoriteslayout.py b/src/jarabe/desktop/favoriteslayout.py index 8f15861..a0323bb 100644 --- a

[Sugar-devel] Making people aware of the topic filter for sugar-devel

Hi! With the traffic rising on sugar-devel due to patch reviews, we should make sure people are aware they can use easy filtering on the mailing list side. A good first step would be to mention this possibility a) on the Mailing Lists wiki page [1] and b) in the welcome mail that is sent out to n

[Sugar-devel] [PATCH sugar] Journal list view: don't choke on invalid or incomplete metadata (SL#1408)

Metadata can get corrupted by crashes or malformed by buggy activities. We should do our best to display the parts that are usable and certainly never mess up the entire Journal. Signed-off-by: Sascha Silbe --- src/jarabe/journal/listmodel.py | 49 -- 1

[Sugar-devel] [PATCH sugar] Journal details view: don't choke on invalid timestamp (SL#1590, SL#2208)

Metadata can get corrupted by crashes or malformed by buggy activities. We should do our best to display the parts that are usable. Signed-off-by: Sascha Silbe --- src/jarabe/journal/expandedentry.py | 12 src/jarabe/journal/misc.py | 16 2 files

[Sugar-devel] [PATCH sugar-toolkit] XoColor: don't choke if passed the wrong type (SL#1408)

Color data is stored in the Journal as a JSON dump, so we can get back arbitrary types. XoColor already checks the color string for validity and handles invalid strings gracefully, so it makes sense to enhance this to invalid types as well. Signed-off-by: Sascha Silbe --- src/sugar/graphics

Re: [Sugar-devel] How to copy something from the Journal to a pendrive? FotoToon export?

Excerpts from tom.staub...@fhtw-berlin.de's message of Sun Oct 17 09:02:42 +0200 2010: > I've been trying for while now to copy journal entries to a usb stick. > This works fine as long as files are concerned, e.g. Pics or Audio recordings > taken with Record. > It does not work if I try to copy

[Sugar-devel] [PATCH sugar] don't delete bundles on storage media (SL #2456)

after misc.get_bundle() finished. Signed-off-by: Sascha Silbe --- src/jarabe/journal/misc.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/jarabe/journal/misc.py b/src/jarabe/journal/misc.py index 4fcfc60..1817df3 100644 --- a/src/jarabe/journal/misc.py +++ b

Re: [Sugar-devel] How to copy something from the Journal to a pendrive? FotoToon export?

Excerpts from tom.staub...@fhtw-berlin.de's message of Sun Oct 17 09:02:42 +0200 2010: > Imagine two or more children. Half of them are in country1, the others are in > country2. > They would like to collaborate on an activity, e.g. FotoToon. > One of the groups starts and adds a picture and som

Re: [Sugar-devel] [ANNOUCE] Patches topic category was: [Systems] http[s]://lists.sugarlabs.org down

Excerpts from Frederick Grose's message of Sun Oct 17 16:25:49 +0200 2010: > P.S.: The regular expression for ANNOUNCE has a misspelling. Thanks for the reminder. I fixed it now. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature __

Re: [Sugar-devel] [PATCH] Scale TA font proportional to Sugar font-settings. (SL#1858)

Excerpts from Ishan Bansal's message of Sat Sep 25 22:19:48 +0200 2010: > This patch scales the font in TA by using function zoom set in > sugar.graphics.style (SL#1858) [...] Your patch looks very similar to the ones Kandarp Kaushik has submitted before [1,2]. Are you two cooperating on this bug

Re: [Sugar-devel] [PATCH] Scale TA font proportional to Sugar font-settings. (SL#1858)

Excerpts from Sascha Silbe's message of Wed Oct 20 21:51:05 +0200 2010: > Your patch looks very similar to the ones Kandarp Kaushik has submitted > before [1,2]. Sorry, forgot to add the links: [1] https://patchwork.sugarlabs.org/patch/263/ [2] https://patchwork.sugarlabs.org/patch/238/ Sascha

Re: [Sugar-devel] [Dextrose] Request to review documentation required for SL #2372

Excerpts from Bernie Innocenti's message of Thu Oct 21 02:08:12 +0200 2010: [Taking screen shots] > One trick would be running xwd from the command line, with by a fixed > delay to give you enough time to get to the screen you want to capture. > Something like this: > > sleep 10 && xwd | conver

Re: [Sugar-devel] [PATCH v2] Reduction in the time taken for loading of the menu (SL#1169)

Excerpts from shanjit's message of Thu Oct 21 17:36:18 +0200 2010: > Reduction in the lead time for loading the drop down menus. Changes made in > the time delay for rendering of the secondary palette to improve human > computer interaction and experience. Please wrap lines at 79 characters. >

Re: [Sugar-devel] [Dextrose] Pending patchs for Paint

Excerpts from James Cameron's message of Wed Oct 20 22:56:04 +0200 2010: > While it would be nice if every release of every activity has a matching > tag and sources in the respective repository, we've had situations where > that has not been desirable, such as when a version of Record was > relea

Re: [Sugar-devel] [Dextrose] Pending patchs for Paint

Excerpts from Martin Langhoff's message of Fri Oct 22 20:58:22 +0200 2010: > > I certainly hope that each bundle released by Sugar Labs or associated > > Sure. Not everything's perfect. Let's make sure we drag things back to > normality. Re-reading my sentence and reading your reply makes me won

Re: [Sugar-devel] [PATCH sugar 09/21] style cleanup: prefer ' for strings

Excerpts from James Cameron's message of Mon Oct 18 06:29:45 +0200 2010: [src/jarabe/util/emulator.py] > > -os.environ['DISPLAY'] = ":%d" % (display) > > +os.environ['DISPLAY'] = ':%d' % (display, ) > > /me raises eyebrow > > ... wasn't done in extensions/deviceicon/network.py > GsmPalet

Re: [Sugar-devel] [PATCH sugar 00/21] style cleanup series

Excerpts from Aleksey Lim's message of Thu Oct 21 00:58:33 +0200 2010: > Whats the satatus of pylint patches? I'm waiting for an OK from Simon and you. James was already kind enough to review both pending patch series. > I'm planing to propose another set of patches that are scatered among > glu

[Sugar-devel] Mailing list digest mode (was: RE: [PATCH sugar 03/21] pep8 cleanup: fix number of blank lines)

Excerpts from John Tierney's message of Sun Oct 17 00:37:42 +0200 2010: > jt4sugar or JT here. I'm signed up on Sugar-Devel but only digest. I just > got about 20 emails with > [Sugar-devel] [Patch...] since I'm only signed up as digest I believe > something is out of kilter. Sorry for the

Re: [Sugar-devel] How to copy something from the Journal to a pendrive? FotoToon export?

Excerpts from tom.staub...@fhtw-berlin.de's message of Sun Oct 17 16:44:40 +0200 2010: > So what would be the right medium to interchange data between Sugar systems? That's a good question I'm afraid. Even file transfer (sending entries from the Journal to a friend) doesn't preserve most of the

Re: [Sugar-devel] [IAEP] stepping down as maintainer

Excerpts from David Farning's message of Sun Oct 24 06:42:24 +0200 2010: > Sugar Labs lost its lead developer. It is unfortunate that no-one has > done a public review of the reasons and implications of Tomeu quiting. > Tomeu's leaving is significant enough that Sugar Labs should take a > hard l

Re: [Sugar-devel] [IAEP] stepping down as maintainer

Excerpts from Bastien's message of Sun Oct 24 14:55:30 +0200 2010: > There is something I miss in the list of "teams/projects" for "people > persons": community management. This is very different from marketing > and outreach. Maybe this project/role could be advertized somewhere > on the wiki.

Re: [Sugar-devel] [IAEP] stepping down as maintainer

Excerpts from David Farning's message of Sun Oct 24 19:55:39 +0200 2010: > On Sun, Oct 24, 2010 at 11:21 AM, Sascha Silbe > wrote: > > Excerpts from David Farning's message of Sun Oct 24 06:42:24 +0200 2010: > > > >> There is the lack of accountability to st

Re: [Sugar-devel] [IAEP] stepping down as maintainer

Excerpts from Bastien's message of Sun Oct 24 19:51:08 +0200 2010: > If that can help, I just posted a call for help in this area on the > french mailing list. Don't expect miracles though, as we are a small > busy team as well :/ But making such a call public is a first step. Great, thanks! F

Re: [Sugar-devel] Development Meetings

Excerpts from Aleksey Lim's message of Mon Oct 25 15:45:21 +0200 2010: > For me, default time is ok > > Wednesday > 2010-10-27, 14:00 UTC > irc://irc.freenode.net#sugar-meeting > > How about other possible attenders? Mon-Wed is fine with me in general. Thu evening (CET ~= UTC) and F

Re: [Sugar-devel] Development Meetings

Excerpts from Tim McNamara's message of Mon Oct 25 21:39:48 +0200 2010: > 14:00 UTC is 2am for me.. If I have anything to contribute on the agenda > items, should I send an email to sugar-devel or the meeting chair? Would you like to participate regularly and/or this time? For a specific topic or

Re: [Sugar-devel] Development Meetings

Excerpts from James Cameron's message of Tue Oct 26 05:40:27 +0200 2010: > On Tue, Oct 26, 2010 at 08:39:48AM +1300, Tim McNamara wrote: > > 14:00 UTC is 2am for me.. > > It is 1am for me. I won't be attending because /dev/brain will have > shut down for the day. Same question as for Tim: What t

Re: [Sugar-devel] [Dextrose] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080

Excerpts from Anurag Chowdhury's message of Mon Oct 25 19:22:09 +0200 2010: > In my logs I noted an average processing time of 0.85 sec for running the > first run of the update () function (i.e. while rendering of the first frame > ) and since a XO-1.5 is nearly 2.5 times faster than a XO-1 so t

Re: [Sugar-devel] Development Meetings

Excerpts from Aleksey Lim's message of Tue Oct 26 17:22:28 +0200 2010: > I hope interested in people will manage to bear > one meeting on Saturday, 2010-10-30, 22:00 UTC :). I don't think I'll be able to participate this Saturday, I'm afraid. :( The next one (06.11.) should be fine. Sascha -- h

[Sugar-devel] Heads up: dbus upstream planning to break sugar-jhbuild and sugar-emulator

Hi! This is just an early warning that the dbus folks are currently planning on introducing and making the default a "user" bus instead of the current "session" bus. The following mail has just arrived on the dbus mailing list; I haven't replied to it yet (if anyone would like to join the discussi

Re: [Sugar-devel] ObjectChooser() Issue?

Excerpts from James Simmons's message of Tue Nov 09 19:37:01 +0100 2010: > > One thing I noted when I tried to read paths from Journal entries is > > that they don't stay valid forever.  I think they are symbolic links > > to the actual file. Almost right: we are using hard links. In general, act

[Sugar-devel] Coding style: line continuations

Excerpts from Sugar Labs Bugs's message of Wed Oct 27 11:11:49 UTC 2010: > {{{ > 249 self._shared_activity.connect('buddy-joined', > 250 self._buddy_joined_cb) > }}} > In emacs I just use tab for that, the next line then gets aligned under > the buddy join

[Sugar-devel] Coding style: line continuations

Excerpts from Sugar Labs Bugs's message of Wed Oct 27 11:11:49 UTC 2010: > {{{ > 249 self._shared_activity.connect('buddy-joined', > 250 self._buddy_joined_cb) > }}} > In emacs I just use tab for that, the next line then gets aligned under > the buddy join

Re: [Sugar-devel] [PATCH V2] Copying files multiple times results in bogus names. (SL#2060)

e if you could tweak the description a bit: - please wrap lines at 79 characters - the template is filename_copynumber.extension You can do that right before pushing the patch, no need to send it to the list again (but you may do so if you like, of course). Reviewed-By: Sascha Silbe S

Re: [Sugar-devel] ObjectChooser() Issue?

Excerpts from Art Hunkins's message of Sun Nov 14 23:20:49 +0100 2010: > #Declarations >self.file = [0, 0, 0, 0] >self.fileflag = ["0", "0", "0", "0"] FWIW, this looks rather strange. You might want to choose a different approach once you got the Object Chooser part working. > def choos

Re: [Sugar-devel] Browse fail to access maps.google.com

Excerpts from James Cameron's message of Wed Nov 17 01:36:05 +0100 2010: > The activity is failing while executing the javascript on the web page. > > I've attached the log to a new ticket > http://bugs.sugarlabs.org/ticket/2492 As explained on the ticket, the bug is in some other component (pro

[Sugar-devel] [PATCH 03/21 v2 sugar-toolkit] PEP8 cleanup: ensure lines are shorter than 80 characters

Caught by PEP8. This is important for Sugar because the XO has a small screen where long lines would make the code hard to understand (because you need to constantly scroll horizontally). Signed-off-by: Sascha Silbe --- v1->v2: Use line continuation style from example in PEP-8 src/su

[Sugar-devel] [PATCH 05/21 v2 sugar-toolkit] PEP8 cleanup: fix whitespace around operator

Signed-off-by: Sascha Silbe --- v1->v2: add whitespace around powers (a**b), too src/sugar/activity/bundlebuilder.py |3 ++- src/sugar/bundle/activitybundle.py |2 +- src/sugar/graphics/alert.py |2 +- src/sugar/graphics/palettewindow.py |4 ++-- src/sugar/network

Re: [Sugar-devel] [PATCH 05/21 sugar-toolkit] PEP8 cleanup: fix whitespace around operator

Excerpts from Simon Schampijer's message of Fri Oct 29 12:46:54 +0200 2010: > > I've left the powers as-is because IMO they should directly follow the base, > > unlike other operators. > > Hmmm, I see your argument, however I think it is not worth to make an > exception here. I want to get this

Re: [Sugar-devel] [PATCH 06/21 sugar-toolkit] PEP8 cleanup: fix inline comment spacing

Excerpts from Simon Schampijer's message of Fri Oct 29 12:50:30 +0200 2010: [reordered quotes to make the context clear] [src/sugar/presence/activity.py] > > @@ -683,11 +683,16 @@ class _JoinCommand(_BaseCommand): > > # since only the owner can change invite-only, that would break > >

[Sugar-devel] [PATCH 13/21 v2 sugar-toolkit] pylint cleanup: remove unused imports

Signed-off-by: Sascha Silbe --- v1->v2: fix oversight in src/sugar/graphics/palette.py (another unused module among a few false-positives) src/sugar/graphics/palette.py |2 -- src/sugar/presence/connectionmanager.py |3 +-- 2 files changed, 1 insertions(+), 4 deleti

[Sugar-devel] [PATCH sugar v2 00/21] style cleanup series

in PEP-8 - removed extra change in src/jarabe/util/emulator.py Sascha Silbe (21): fix EOL spaces style cleanup: move globals before class and method definitions pep8 cleanup: fix number of blank lines PEP8 cleanup: fix spaces around operators and parentheses PEP8 cleanup: fix inline comm

[Sugar-devel] [PATCH sugar v2 19/21] jarabe.desktop.schoolserver: mark helper functions and classes as private

Only register_laptop and RegisterError are meant to be public API. Proper marking of private / public makes it easier to see which code changes break API (or not). Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/schoolserver.py b/src

[Sugar-devel] [PATCH sugar v2 10/21] pylint cleanup: replace disable-msg with disable

Adapt to upstream format change. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/config.py.in b/src/jarabe/config.py.in index 6c418e9..d22ee9a 100644 --- a/src/jarabe/config.py.in +++ b/src/jarabe/config.py.in @@ -14,7 +14,7 @@ # along with this

[Sugar-devel] [PATCH sugar v2 01/21] fix EOL spaces

Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/aboutcomputer/model.py b/extensions/cpsection/aboutcomputer/model.py index 898d79c..77d3b86 100644 --- a/extensions/cpsection/aboutcomputer/model.py +++ b/extensions/cpsection

[Sugar-devel] [PATCH sugar v2 15/21] CurrentActivityPalette: remove dead code

__active_window_changed_cb() is not referenced anywhere and contains broken code. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/view/palettes.py b/src/jarabe/view/palettes.py index cb30ed8..d9c1f6b 100644 --- a/src/jarabe/view/palettes.py +++ b

[Sugar-devel] [PATCH sugar v2 07/21] PEP8 cleanup: don't use has_key()

has_key() has been deprecated for quite some time now. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py index 6d35f46..50b8a3f 100644 --- a/src/jarabe/desktop/meshbox.py +++ b/src/jarabe/desktop

[Sugar-devel] [PATCH sugar v2 05/21] PEP8 cleanup: fix inline comment spacing

Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/extensions/cpsection/keyboard/model.py b/extensions/cpsection/keyboard/model.py index b7186e2..82456d3 100644 --- a/extensions/cpsection/keyboard/model.py +++ b/extensions/cpsection/keyboard/model.py @@ -20,7

[Sugar-devel] [PATCH sugar v2 02/21] style cleanup: move globals before class and method definitions

the snow flake layout and reenabled). Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/favoritesview.py b/src/jarabe/desktop/favoritesview.py index ada55e0..d582433 100644 --- a/src/jarabe/desktop/favoritesview.py +++ b/src

[Sugar-devel] [PATCH sugar v2 14/21] pylint cleanup: pass format parameters to log functions instead of using %

This avoids the overhead from the string formatting on production systems. Reviewed-by: James Cameron CC: Aleksey Lim Signed-off-by: Sascha Silbe diff --git a/src/jarabe/desktop/favoritesview.py b/src/jarabe/desktop/favoritesview.py index 64baa15..fb865e2 100644 --- a/src/jarabe/desktop

<    3   4   5   6   7   8   9   10   11   12   >