Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-04 Thread Lucian Branescu
I recently looked over sugar-port source, and I found this http://people.sugarlabs.org/~alsroot/sugar-port/ It's equivalent to my patch, but is slightly less readable. 2009/7/1 Tomeu Vizoso to...@sugarlabs.org: On Wed, Jul 1, 2009 at 15:18, Lucian Branesculucian.brane...@gmail.com wrote:

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-04 Thread Lucian Branescu
I didn't realise the docs didn't use a get url. Look for ActivityToolbox.get_bars in the activity module. 2009/7/4 Lucian Branescu lucian.brane...@gmail.com: I recently looked over sugar-port source, and I found this http://people.sugarlabs.org/~alsroot/sugar-port/ It's equivalent to my

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-01 Thread Tomeu Vizoso
On Tue, Jun 30, 2009 at 04:55, Lucian Branesculucian.brane...@gmail.com wrote: While adding the bookmarklet functionality to Browse, I realised that the toolbox API is hard to work with if your toolbars change. For example, set_current_toolbar() takes the index of the toolbar as a parameter,

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-01 Thread Aleksey Lim
On Wed, Jul 01, 2009 at 11:11:30AM +0200, Tomeu Vizoso wrote: On Tue, Jun 30, 2009 at 04:55, Lucian Branesculucian.brane...@gmail.com wrote: While adding the bookmarklet functionality to Browse, I realised that the toolbox API is hard to work with if your toolbars change. For example,

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-01 Thread Aleksey Lim
On Wed, Jul 01, 2009 at 11:38:51AM +0200, Tomeu Vizoso wrote: On Wed, Jul 1, 2009 at 11:31, Aleksey Limalsr...@member.fsf.org wrote: On Wed, Jul 01, 2009 at 11:11:30AM +0200, Tomeu Vizoso wrote: On Tue, Jun 30, 2009 at 04:55, Lucian Branesculucian.brane...@gmail.com wrote: While adding

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-01 Thread Tomeu Vizoso
On Wed, Jul 1, 2009 at 11:44, Aleksey Limalsr...@member.fsf.org wrote: On Wed, Jul 01, 2009 at 11:38:51AM +0200, Tomeu Vizoso wrote: On Wed, Jul 1, 2009 at 11:31, Aleksey Limalsr...@member.fsf.org wrote: On Wed, Jul 01, 2009 at 11:11:30AM +0200, Tomeu Vizoso wrote: On Tue, Jun 30, 2009 at

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-07-01 Thread Tomeu Vizoso
On Wed, Jul 1, 2009 at 15:18, Lucian Branesculucian.brane...@gmail.com wrote: Sorry about that. I've attached another patch which follows the guidelines. I'm not sure I should be opening a ticket about this, though. I've had a chat with Walter last night and he said that since the toolbar will

[Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-06-29 Thread Lucian Branescu
While adding the bookmarklet functionality to Browse, I realised that the toolbox API is hard to work with if your toolbars change. For example, set_current_toolbar() takes the index of the toolbar as a parameter, something which you can't really know if your toolbars move around. Tomeu suggested

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-06-29 Thread Lucian Branescu
I have some workarounds in my Browse, it works fine without that patch on 0.84 I haven't tried it on 0.82 yet, but AFAIK Browse 108 doesn't work in 0.82. None of my changes should prevent it from running on 0.82 though, so I should be able to backport them. It's just not something I've tackled

Re: [Sugar-devel] [API proposal] toolbox.get_toolbars()

2009-06-29 Thread Lucian Branescu
I have some workarounds in my Browse, it works fine without that patch on 0.84 I haven't tried it on 0.82 yet, but AFAIK Browse 108 doesn't work in 0.82. None of my changes should prevent it from running on 0.82 though, so I should be able to backport them. It's just not something I've tackled