Re: [Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-08-19 Thread Martin Abente
Thank you everyone for your comments,

Judging by all the comments, I believe we have some kind of democratic
consensus already.

So, I think the patch behavior could be like this: 

1. Every time a user deletes an activity from the list view, will also
delete activity's profile data.

2. Any other scenario, like upgrading using the CP updater or a bundle
will behave like before (without deleting profile data).

Saludos,
Tincho


___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-08-18 Thread Martin Abente
On Fri, 30 Jul 2010 15:41:29 -0400, Frederick Grose fgr...@gmail.com
wrote:
 This ticket has some important discussion that was proposed for airing
on
 the mailing list.
 http://bugs.sugarlabs.org/ticket/2074
 
 There are patches under review that would delete learner data, perhaps
 unwittingly.
 
 An Activity bundle is deleted from the Home list view bundle pallet by
 invoking the 'Erase' menu action.
 

I have submitted a solution for that scenario already, because it was a
corner case for 2074.

 A 'Confirm erase' alert dialog appears that asks if you want to
permanently
 erase the Activity (bundle). It provides a negative 'Keep' and positive
 'Erase' button.
 

This is not necessary anymore. Because now it does not delete the
installed activity anymore.

 For the proposed patch, to prevent the unwitting loss of Activity
profile
 data or other content that may be stored in the Activity directory, an
 option checkbox should be added, such as, (check) erase all associated
 data,
 which could default to yes (checked).
 

My last patches include your comments :)

 Without this, Learners may unexpectedly delete content that they
downloaded
 at some expense, or be forced to reset profile preferences.
 
 If there isn't time to implement this data protection feature for the
 upcoming Dextrose release, we should not forget to provide this feature
for
 all future learners (who may not have the same storage and usability
 constraints that prompted this patch).
 
 --Fred

I would appreciate if someone could review my patches.

Saludos,
tincho
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-08-18 Thread Daniel Drake
On 30 July 2010 13:41, Frederick Grose fgr...@gmail.com wrote:
 A 'Confirm erase' alert dialog appears that asks if you want to permanently
 erase the Activity (bundle). It provides a negative 'Keep' and positive
 'Erase' button.
 For the proposed patch, to prevent the unwitting loss of Activity profile
 data or other content that may be stored in the Activity directory, an
 option checkbox should be added, such as, (check) erase all associated data,
 which could default to yes (checked).

I disagree with the addition of a checkbox - in my experience, this
kind of complexity will result in a random response from the user.

I agree with the idea of deleting profile data when an activity is
uninstalled. (if they want the profile data, why uninstall the
activity?)

Daniel
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-08-18 Thread Walter Bender
On Wed, Aug 18, 2010 at 4:52 PM, Daniel Drake d...@laptop.org wrote:
 On 30 July 2010 13:41, Frederick Grose fgr...@gmail.com wrote:
 A 'Confirm erase' alert dialog appears that asks if you want to permanently
 erase the Activity (bundle). It provides a negative 'Keep' and positive
 'Erase' button.
 For the proposed patch, to prevent the unwitting loss of Activity profile
 data or other content that may be stored in the Activity directory, an
 option checkbox should be added, such as, (check) erase all associated data,
 which could default to yes (checked).

 I disagree with the addition of a checkbox - in my experience, this
 kind of complexity will result in a random response from the user.

+1

 I agree with the idea of deleting profile data when an activity is
 uninstalled. (if they want the profile data, why uninstall the
 activity?)

+1

(I presume the concern was over whether or not an update would remove
the profile data.)

 Daniel
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel




-- 
Walter Bender
Sugar Labs
http://www.sugarlabs.org
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-08-18 Thread Thomas Gilliard



Walter Bender wrote:

On Wed, Aug 18, 2010 at 4:52 PM, Daniel Drake d...@laptop.org wrote:
  

On 30 July 2010 13:41, Frederick Grose fgr...@gmail.com wrote:


A 'Confirm erase' alert dialog appears that asks if you want to permanently
erase the Activity (bundle). It provides a negative 'Keep' and positive
'Erase' button.
For the proposed patch, to prevent the unwitting loss of Activity profile
data or other content that may be stored in the Activity directory, an
option checkbox should be added, such as, (check) erase all associated data,
which could default to yes (checked).
  

I disagree with the addition of a checkbox - in my experience, this
kind of complexity will result in a random response from the user.



+1

  

I agree with the idea of deleting profile data when an activity is
uninstalled. (if they want the profile data, why uninstall the
activity?)



+1

(I presume the concern was over whether or not an update would remove
the profile data.)
  
A related problem for Soas is that an .xo stores it's activities in a 
different location (/home/liveuser/Activities) than those installed with 
the .iso (/user/share/sugar/activities


My experience is that one had to use rmdir -R 
/user/share/sugar/activities/().Activity to make a similar version 
of an .xo activity start.


Would the Confirm erase checkbox check and delete both locations?


Tom Gilliard
satellit

Daniel

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel






  
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-08-18 Thread Gary Martin
On 19 Aug 2010, at 00:38, Thomas Gilliard wrote:

 Walter Bender wrote:
 On Wed, Aug 18, 2010 at 4:52 PM, Daniel Drake d...@laptop.org
  wrote:
   
 
 On 30 July 2010 13:41, Frederick Grose fgr...@gmail.com
  wrote:
 
 A 'Confirm erase' alert dialog appears that asks if you want to permanently
 erase the Activity (bundle). It provides a negative 'Keep' and positive
 'Erase' button.
 For the proposed patch, to prevent the unwitting loss of Activity profile
 data or other content that may be stored in the Activity directory, an
 option checkbox should be added, such as, (check) erase all associated 
 data,
 which could default to yes (checked).
   
 
 I disagree with the addition of a checkbox - in my experience, this
 kind of complexity will result in a random response from the user.
 
 
 +1

+1

 
 I agree with the idea of deleting profile data when an activity is
 uninstalled. (if they want the profile data, why uninstall the
 activity?)
 
 
 +1

+1

Deleting such data may actually be what is required in the case of something 
that has saved broken 'profile' data. Erase and re-install is a common user 
meme (often sabotaged by broken/unexpected preference files living in unknown 
places). If an activity is storing user activity information in it's data 
directory (e.g. more than just preference information or data for caching 
purposes that can be regenerated), I'd assume it to be a design flaw and worthy 
of a bug ticket in trac. That user state belongs in the Journal.

 
 (I presume the concern was over whether or not an update would remove
 the profile data.)
   
 
 A related problem for Soas is that an .xo stores it's activities in a 
 different location (/home/liveuser/Activities) than those installed with the 
 .iso (/user/share/sugar/activities
 
 My experience is that one had to use rmdir -R 
 /user/share/sugar/activities/().Activity to make a similar version of an 
 .xo activity start.
 
 Would the Confirm erase checkbox check and delete both locations?

If an activity is unbundled in /user/share/sugar/activities/ the list view does 
not give the user an Erase option. If an activity is in ~/Activities but has 
permissions that prevent the user from deleting, the Erase option is shown but 
disabled/dimmed out.

--Gary

 
 Tom Gilliard
 satellit
 
 Daniel
 ___
 Sugar-devel mailing list
 
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel
 
 
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


[Sugar-devel] [Design] Deleting Activity directory when deleting Activity bundle

2010-07-30 Thread Frederick Grose
This ticket has some important discussion that was proposed for airing on
the mailing list.
http://bugs.sugarlabs.org/ticket/2074

There are patches under review that would delete learner data, perhaps
unwittingly.

An Activity bundle is deleted from the Home list view bundle pallet by
invoking the 'Erase' menu action.

A 'Confirm erase' alert dialog appears that asks if you want to permanently
erase the Activity (bundle). It provides a negative 'Keep' and positive
'Erase' button.

For the proposed patch, to prevent the unwitting loss of Activity profile
data or other content that may be stored in the Activity directory, an
option checkbox should be added, such as, (check) erase all associated data,
which could default to yes (checked).

Without this, Learners may unexpectedly delete content that they downloaded
at some expense, or be forced to reset profile preferences.

If there isn't time to implement this data protection feature for the
upcoming Dextrose release, we should not forget to provide this feature for
all future learners (who may not have the same storage and usability
constraints that prompted this patch).

--Fred
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel