Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-24 Thread Martin Langhoff
On Sat, Jan 24, 2009 at 10:42 AM, Bernie Innocenti wrote: > Well, it's customary to introduce an additional state where the bug is > fixed in the developer's intentions, but not yet QA'd: > > NEW -> ASSIGNED -> FIXED -> CLOSED Bernie, 99% of my commits are "working on it, mate" ;-) It's not ab

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-24 Thread Bernie Innocenti
Martin Langhoff wrote: > On Sat, Jan 24, 2009 at 6:39 AM, Bernie Innocenti wrote: >> I meant it should have been optional, but if we switch to using the >> "Closes: header in the body, where we have no size constraints, then >> we could has well use the prefix consistently. > > One important note

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Martin Langhoff
On Sat, Jan 24, 2009 at 6:39 AM, Bernie Innocenti wrote: > I meant it should have been optional, but if we switch to using the > "Closes: header in the body, where we have no size constraints, then > we could has well use the prefix consistently. One important note WRT 'Closes'... Code hits git

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Bernie Innocenti
Jonas Smedegaard wrote: >> - Given the above, the word "Closes: " steals precious characters, >> and is rather easy to deduce, therefore I'd opt it out. > > It really makes better sense to me to not squeeze bug hints into that > first line at all, but instead include them in a later line of the

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Jonas Smedegaard
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, Jan 23, 2009 at 10:45:15AM +0100, Bernie Innocenti wrote: >Jonas Smedegaard wrote: >> Use the recommended style as mentioned in Git documentation >> somewhere: First line a summary of at most 40 chars, then empty line, >> then optional detail

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Tomeu Vizoso
On Fri, Jan 23, 2009 at 13:22, Simon Schampijer wrote: > Marco Pesenti Gritti wrote: >> On Fri, Jan 23, 2009 at 10:45 AM, Bernie Innocenti >> wrote: >>> Some thoughts: >>> >>> - Because the commit message summary appears in the shortlog, >>> it should be kept below 74 characters to avoid ugly

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Simon Schampijer
Marco Pesenti Gritti wrote: > On Fri, Jan 23, 2009 at 10:45 AM, Bernie Innocenti wrote: >> Some thoughts: >> >> - Because the commit message summary appears in the shortlog, >> it should be kept below 74 characters to avoid ugly wrapping. >> >> - Given the above, the word "Closes: " steals pre

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Marco Pesenti Gritti
On Fri, Jan 23, 2009 at 10:45 AM, Bernie Innocenti wrote: > Some thoughts: > > - Because the commit message summary appears in the shortlog, > it should be kept below 74 characters to avoid ugly wrapping. > > - Given the above, the word "Closes: " steals precious characters, > and is rather

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-23 Thread Bernie Innocenti
Jonas Smedegaard wrote: > Use the recommended style as mentioned in Git documentation somewhere: > First line a summary of at most 40 chars, then empty line, then optional > detailed commit message (which is stripped by git-shortlog). > > Also, I'd suggest mentioning ticket numbers at end instea

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-22 Thread Jonas Smedegaard
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, Jan 22, 2009 at 09:54:36AM +0100, Simon Schampijer wrote: >So the command for sugar for this release would be [...]: > >git log v0.83.4..v0.83.5 --no-merges | git-shortlog > >That will encourage people to write nice commit messages :) I would

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-22 Thread Simon Schampijer
Bernie Innocenti wrote: > Walter Bender wrote: >> Wow!! > > We have great release notes lately. > > To credit authors, I'd also append the patch summary by author, > Linus-style. It can quickly be obtained this way: > > git log v0.83.3..HEAD | git-shortlog Excellent, will do that for the nex

Re: [Sugar-devel] [IAEP] [ANNOUNCE] Sucrose 0.83.4 Development Release

2009-01-22 Thread Bernie Innocenti
Walter Bender wrote: > Wow!! We have great release notes lately. To credit authors, I'd also append the patch summary by author, Linus-style. It can quickly be obtained this way: git log v0.83.3..HEAD | git-shortlog -- // Bernie Innocenti - http://www.codewiz.org/ \X/ Sugar Labs