[Sugar-devel] [PATCH] G_MIN/MAX constants have been moved into GObject overrides

2013-04-25 Thread Simon Schampijer
From: Simon Schampijer si...@laptop.org See pygobject c2aa6f0d0ed4c4e60f081b106dc7a65513963fce --- extensions/deviceicon/battery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/deviceicon/battery.py b/extensions/deviceicon/battery.py index 21dc5f3..6bf27ef

Re: [Sugar-devel] [PATCH] G_MIN/MAX constants have been moved into GObject overrides

2013-04-25 Thread Simon Schampijer
The patch works with the latest Pygobject 3.8.x but as well in the 3.4.x series. Actually, using GLib.MAXINT32 would work as well. I will ask on #python what the correct/better one is. Regards, Simon On 04/25/2013 12:45 PM, Simon Schampijer wrote: From: Simon Schampijer si...@laptop.org

Re: [Sugar-devel] [PATCH] G_MIN/MAX constants have been moved into GObject overrides

2013-04-25 Thread Simon Schampijer
On 04/25/2013 12:53 PM, Simon Schampijer wrote: The patch works with the latest Pygobject 3.8.x but as well in the 3.4.x series. Actually, using GLib.MAXINT32 would work as well. I will ask on #python what the correct/better one is. Regards, Simon Confirmed on #python, we should use

Re: [Sugar-devel] [PATCH] G_MIN/MAX constants have been moved into GObject overrides

2013-04-25 Thread Manuel Quiñones
+1 let's push this. 2013/4/25 Simon Schampijer si...@schampijer.de: On 04/25/2013 12:53 PM, Simon Schampijer wrote: The patch works with the latest Pygobject 3.8.x but as well in the 3.4.x series. Actually, using GLib.MAXINT32 would work as well. I will ask on #python what the

Re: [Sugar-devel] [PATCH] G_MIN/MAX constants have been moved into GObject overrides

2013-04-25 Thread Simon Schampijer
Thanks, pushed to master and 0.98 (as F19 will package 0.98 and we need that fix there). Simon On 04/25/2013 02:38 PM, Manuel Quiñones wrote: +1 let's push this. 2013/4/25 Simon Schampijer si...@schampijer.de: On 04/25/2013 12:53 PM, Simon Schampijer wrote: The patch works with the latest