Re: [Sugar-devel] [PATCH] Hardcode env variable TERM to xterm #2394
On 10/06/2010 09:24 PM, Sascha Silbe wrote: Excerpts from simon's message of Wed Oct 06 14:11:04 +0200 2010: Patch needed in 0.90 AFAICT it's needed on Fedora 14, not Sugar 0.90. Are we sure yet this was an intentional change by libvte and not just a mistake? In the latter case we should probably make the setting depend on specific libvte versions so we don't break if they decide to use a different set of control codes (= different $TERM) in the future. Hi Sascha, thanks for your thoughts. I have overseen the fact that we actually do set it to xterm [1]. I am just experimenting a bit to see what is going on. Regards, Simon [1] http://git.sugarlabs.org/projects/terminal/repos/mainline/blobs/master/terminal.py#line449 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Hardcode env variable TERM to xterm #2394
On 10/07/2010 10:31 AM, Tomeu Vizoso wrote: On Wed, Oct 6, 2010 at 21:24, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from simon's message of Wed Oct 06 14:11:04 +0200 2010: Patch needed in 0.90 AFAICT it's needed on Fedora 14, not Sugar 0.90. Are we sure yet this was an intentional change by libvte and not just a mistake? In the latter case we should probably make the setting depend on specific libvte versions so we don't break if they decide to use a different set of control codes (= different $TERM) in the future. Agreed, I think we should understand well what's going on before accepting a hack upstream. If we confirm that we need that hack, then we should put that information in a ticket and reference it from the code. Regards, Tomeu Agreed, I first thought it was another issue when reading other comments about it. I have nailed it down as the following so far: https://bugzilla.gnome.org/show_bug.cgi?id=631589 Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] Hardcode env variable TERM to xterm #2394
From: Simon Schampijer si...@schampijer.de Patch needed in 0.90 --- terminal.py |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/terminal.py b/terminal.py index a0f97ba..4f05ed3 100644 --- a/terminal.py +++ b/terminal.py @@ -51,6 +51,9 @@ class TerminalActivity(activity.Activity): self.max_participants = 1 +# Hardcode to xterm due to a change in vte #2394 +os.environ['TERM'] = 'xterm' + toolbar_box = ToolbarBox() activity_button = ActivityToolbarButton(self) -- 1.7.2.2 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Hardcode env variable TERM to xterm #2394
Excerpts from simon's message of Wed Oct 06 14:11:04 +0200 2010: Patch needed in 0.90 AFAICT it's needed on Fedora 14, not Sugar 0.90. Are we sure yet this was an intentional change by libvte and not just a mistake? In the latter case we should probably make the setting depend on specific libvte versions so we don't break if they decide to use a different set of control codes (= different $TERM) in the future. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
