Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-21 Thread Simon Schampijer
On 09/21/2010 05:32 PM, Tomeu Vizoso wrote: > On Tue, Sep 21, 2010 at 17:23, Sascha Silbe > wrote: >> Excerpts from Tomeu Vizoso's message of Tue Sep 21 15:44:05 +0200 2010: >> >>> I'm proposing this patch for inclusion in master during the hard code >>> freeze period as per >>> http://wiki.sugar

Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-21 Thread Tomeu Vizoso
On Tue, Sep 21, 2010 at 17:23, Sascha Silbe wrote: > Excerpts from Tomeu Vizoso's message of Tue Sep 21 15:44:05 +0200 2010: > >> I'm proposing this patch for inclusion in master during the hard code >> freeze period as per >> http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule >> >> The benefit is

Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-21 Thread Sascha Silbe
Excerpts from Tomeu Vizoso's message of Tue Sep 21 15:44:05 +0200 2010: > I'm proposing this patch for inclusion in master during the hard code > freeze period as per > http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule > > The benefit is a more consistent neighborhood view and the risk is very l

Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-21 Thread Tomeu Vizoso
Hi, I'm proposing this patch for inclusion in master during the hard code freeze period as per http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule The benefit is a more consistent neighborhood view and the risk is very low. Thanks, Tomeu On Mon, Sep 20, 2010 at 14:56, Tomeu Vizoso wrote: > ---

Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-21 Thread Sascha Silbe
Excerpts from Tomeu Vizoso's message of Tue Sep 21 09:54:49 +0200 2010: > Seems like this bug has been there since the signal was added, but > indeed I can make explicit that I'm not changing the signal signature > but passing the expected argument. That would be nice. Sascha -- http://sascha.s

Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-21 Thread Tomeu Vizoso
On Mon, Sep 20, 2010 at 22:39, Sascha Silbe wrote: > Excerpts from Tomeu Vizoso's message of Mon Sep 20 14:56:04 +0200 2010: > >> --- > > Would have been nice to note that this is a regression and callers > expect the contact_id instead of the handle. At first I was worried that > this might break

Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-20 Thread Sascha Silbe
Excerpts from Tomeu Vizoso's message of Mon Sep 20 14:56:04 +0200 2010: > --- Would have been nice to note that this is a regression and callers expect the contact_id instead of the handle. At first I was worried that this might break other code, but the patch actually makes the listeners work ag

[Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

2010-09-20 Thread Tomeu Vizoso
--- src/jarabe/model/neighborhood.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/jarabe/model/neighborhood.py b/src/jarabe/model/neighborhood.py index 76a0a7d..9d82db3 100644 --- a/src/jarabe/model/neighborhood.py +++ b/src/jarabe/model/neighborhood.py @@ -387,8