Re: [Sugar-devel] [PATCH] Setting logging level of message Gsm connection not set... to warning from exception (SL #2247)

2011-02-11 Thread Sascha Silbe 
Excerpts from Dipankar Patro's message of Sat Sep 18 19:03:15 +0200 2010:

 Currently the message appears as an error whereas it is just
 a warning message. Developer should not get this message an error,
 so I have set the logging level to warning from exception.

Pushed (with a new patch description) as 7231d7c [1], thanks!

Sascha

[1] 
http://git.sugarlabs.org/sugar/mainline/commit/7231d7c967e650b671d0be3052f7fd2f94830038
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Setting logging level of message Gsm connection not set... to warning from exception (SL #2247)

2010-11-30 Thread Sascha Silbe 
Excerpts from Dipankar Patro's message of Sat Sep 18 19:03:15 +0200 2010:

 Currently the message appears as an error whereas it is just
 a warning message. Developer should not get this message an error,
 so I have set the logging level to warning from exception.

Please shorten the summary (subject line) to less than 80 characters.

Reviewed-By: Sascha Silbe sascha-...@silbe.org

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Setting logging level of message Gsm connection not set... to warning from exception (SL #2247)

2010-09-19 Thread James Cameron 
Reviewed-by: James Cameron qu...@laptop.org

-- 
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH] Setting logging level of message Gsm connection not set... to warning from exception (SL #2247)

2010-09-18 Thread Dipankar Patro 
Currently the message appears as an error whereas it is just
a warning message. Developer should not get this message an error,
so I have set the logging level to warning from exception.
---
 src/jarabe/model/network.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/jarabe/model/network.py b/src/jarabe/model/network.py
index 79e4360..72fa00a 100644
--- a/src/jarabe/model/network.py
+++ b/src/jarabe/model/network.py
@@ -891,7 +891,7 @@ def load_gsm_connection():
 except Exception:
 logging.exception('Error adding gsm connection to NMSettings.')
 else:
-logging.exception(No gsm connection was set in GConf.)
+logging.warning(No gsm connection was set in GConf.)
 
 def load_connections():
 load_wifi_connections()
-- 
1.7.0.4

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel