Re: [Sugar-devel] [PATCH 1/7] Add ds_clean flag to trigger index rebuilds #2095, #2317

2012-10-01 Thread Martin Langhoff
On Sun, Sep 30, 2012 at 12:24 PM, Manuel Kaufmann wrote: > On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff wrote: >> This gives us more complete coverage of cases where ENOSPC or >> other errors are hit when creating/updating datastore entries. > > I reviewed this patch and I think it's OK. I d

Re: [Sugar-devel] [PATCH 1/7] Add ds_clean flag to trigger index rebuilds #2095, #2317

2012-09-30 Thread Manuel Kaufmann
On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff wrote: > This gives us more complete coverage of cases where ENOSPC or > other errors are hit when creating/updating datastore entries. I reviewed this patch and I think it's OK. I didn't test it because I'm not sure how to simulate that scenario.

[Sugar-devel] [PATCH 1/7] Add ds_clean flag to trigger index rebuilds #2095, #2317

2012-09-20 Thread Martin Langhoff
This gives us more complete coverage of cases where ENOSPC or other errors are hit when creating/updating datastore entries. Without this patch, using the Journal on ENOSPC sometimes leads to an "empty" Journal after restart. Datastore entries exist on disk but are not in the index (Xapian DB). W