Re: [Sugar-devel] [PATCH 4/7] metadatareader: ignore .hidden files

2012-10-01 Thread Manuel Kaufmann
On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote: Ignore any file with a filename starting with a '.' -- metadatastore writes its tempfiles prefixed with a '.' . This patch is OK for me. Just a comment: this patch removes the possibility to have a property named

Re: [Sugar-devel] [PATCH 4/7] metadatareader: ignore .hidden files

2012-10-01 Thread Gonzalo Odiard
Just a comment: this patch removes the possibility to have a property named ..property, right? is this OK? Is any activity setting a property that its name starts with .? We should check that and change its name. I think is better document this issue. Gonzalo -- Kaufmann Manuel

Re: [Sugar-devel] [PATCH 4/7] metadatareader: ignore .hidden files

2012-10-01 Thread Martin Langhoff
On Mon, Oct 1, 2012 at 7:06 AM, Manuel Kaufmann humi...@gmail.com wrote: Just a comment: this patch removes the possibility to have a property named ..property, right? is this OK? I hope it is. I don't know, I'm not an experienced Sugar hacker :-) What I can tell you is that I have never seen

[Sugar-devel] [PATCH 4/7] metadatareader: ignore .hidden files

2012-09-20 Thread Martin Langhoff
Ignore any file with a filename starting with a '.' -- metadatastore writes its tempfiles prefixed with a '.' . Signed-off-by: Martin Langhoff mar...@laptop.org --- Note: this one needs a bit of testing. --- src/carquinyol/metadatareader.c |7 ++- 1 file changed, 2 insertions(+), 5