Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-04-04 Thread Simon Schampijer
On 03/31/2011 05:36 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Thu Mar 31 21:28:17 +0200 2011: Good catch, done, anything else? The code looks good. My spell checker nags about immediatly in the subject and I'd prefer to have an OLPC prefix for the bug number since

[Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Simon Schampijer
As there are no other options to left click the palette should be popped up immediately. See 4c2d26ccaeb502037484ced70b5944e3e20aa3f6 for a similar case. Signed-off-by: Simon Schampijer si...@laptop.org --- src/jarabe/frame/activitiestray.py |5 + 1 files changed, 5 insertions(+), 0

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 19:01:23 +0200 2011: +def __button_clicked_cb(self, button): +self.palette.popup(immediate=True, state=1) I guess this should use the Palette.SECONDARY constant instead of hard coding an integer value. FWIW, the way I did this

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Simon Schampijer
Thanks for the quick feedback. On 03/31/2011 03:05 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Thu Mar 31 19:01:23 +0200 2011: +def __button_clicked_cb(self, button): +self.palette.popup(immediate=True, state=1) I guess this should use the

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 21:28:17 +0200 2011: Good catch, done, anything else? The code looks good. My spell checker nags about immediatly in the subject and I'd prefer to have an OLPC prefix for the bug number since it's not an upstream ticket. Acked-by: Sascha