Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-27 Thread Simon Schampijer
Daniel, thanks for the patch. It is good to add some more details about the requested change in the description. [1] states for example: GtkHBox has been deprecated. You can use GtkBox instead, which is a very quick and easy change. If you have derived your own classes from GtkHBox, you can

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-27 Thread S. Daniel Francis
[1] states for example: GtkHBox has been deprecated. You can use GtkBox instead, which is a very quick and easy change. If you have derived your own classes from GtkHBox, you can simply change the inheritance to derive directly from GtkBox. No further changes are needed, since the default

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-27 Thread Gonzalo Odiard
Why not? Lets migrate all our gtk3 components to GtkGrid! We should check if the move to GtkGrid is really free of charge. There are a lot to change right now, and if changing the boxes break (or change visuals) in subtle ways, will be a headache. Then, should be good test it, before doing a

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-27 Thread Agustin Zubiaga Sanchez
+1 for the Daniel's idea. El 27/06/2012 09:52, S. Daniel Francis fran...@sugarlabs.org escribió: 2012/6/27 Gonzalo Odiard gonz...@laptop.org: Why not? Lets migrate all our gtk3 components to GtkGrid! We should check if the move to GtkGrid is really free of charge. There are a lot to

[Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-26 Thread Daniel Francis
--- src/sugar3/activity/widgets.py |3 ++- src/sugar3/graphics/alert.py|9 ++--- src/sugar3/graphics/notebook.py |6 -- src/sugar3/graphics/palette.py | 27 +++ src/sugar3/graphics/panel.py|3 ++-

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-26 Thread James Cameron
Reviewed-by: James Cameron qu...@laptop.org I note other people have accepted the default orientation in their patches. I'm not sure which method is best. I think it is fine either way. (Also, I blame upstream for causing this extra work. I can see no good reason for deprecating these

Re: [Sugar-devel] [PATCH sugar-toolkit-gtk3] Fixing deprecations: Using Gtk.Orientation

2012-06-26 Thread Gonzalo Odiard
(Also, I blame upstream for causing this extra work. I can see no good reason for deprecating these classes.) +1 Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel