Re: [Sugar-devel] [PATCH sugar 0/2] Move EventIcon to sugar

2012-08-03 Thread Simon Schampijer 

On 07/25/2012 12:23 AM, Sascha Silbe wrote:

As agreed on during the Development Team meeting [1], the EventIcon
needed for the hippo-canvas removal project should be merged into
sugar, rather than sugar-toolkit. This patch series adds the icon to
sugar and modifies the code from the current working branch [2] of the
hippo-canvas removal project to make use of this private copy so that
it works with mainline sugar-toolkit.


Finally, I did not put the new EventIcon into the shell as I did not 
like code accessing private classes as _IconBuffer. But as an 
intermediate step I don't care to much.


I will wrap up now the other patches so we can land them.

Regards,
   Simon

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH sugar 0/2] Move EventIcon to sugar

2012-07-24 Thread Sascha Silbe 
As agreed on during the Development Team meeting [1], the EventIcon
needed for the hippo-canvas removal project should be merged into
sugar, rather than sugar-toolkit. This patch series adds the icon to
sugar and modifies the code from the current working branch [2] of the
hippo-canvas removal project to make use of this private copy so that
it works with mainline sugar-toolkit.

The second patch (switching to the private implementation) should be
squashed into the other patches presented for review on sugar-devel,
rather than as a separate patch. It's a modification of the approach
taken by the hippo-canvas removal project, not a change to sugar.


Sascha Silbe (1):
  Switch to private implementation of EventIcon

Simon Schampijer (1):
  SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

 extensions/cpsection/aboutme/view.py |3 +-
 src/jarabe/desktop/favoritesview.py  |2 +-
 src/jarabe/desktop/friendview.py |2 +-
 src/jarabe/desktop/groupbox.py   |2 +-
 src/jarabe/desktop/meshbox.py|2 +-
 src/jarabe/journal/expandedentry.py  |2 +-
 src/jarabe/journal/listview.py   |3 +-
 src/jarabe/view/Makefile.am  |1 +
 src/jarabe/view/buddyicon.py |3 +-
 src/jarabe/view/eventicon.py |  277 ++
 src/jarabe/view/pulsingicon.py   |5 +-
 11 files changed, 293 insertions(+), 9 deletions(-)
 create mode 100644 src/jarabe/view/eventicon.py

[1] http://meeting.sugarlabs.org/sugar-meeting/meetings/2012-06-26
[2] http://git.sugarlabs.org/~erikos/sugar/erikos-shell-port
-- 
1.7.10

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel