Re: [Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-07 Thread Simon Schampijer
On 08/06/2012 03:53 PM, Benjamin Berg wrote: On Mon, 2012-08-06 at 15:49 +0200, Sascha Silbe wrote: Benjamin Berg writes: +# HACK to supress the grey background around the icon +# won't be needed in GTK3 +self.modify_bg(gtk.STATE_NORMAL, style.COLOR_WHITE.get_gdk_color(

Re: [Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-06 Thread Benjamin Berg
On Mon, 2012-08-06 at 15:49 +0200, Sascha Silbe wrote: > Benjamin Berg writes: > >> +# HACK to supress the grey background around the icon > >> +# won't be needed in GTK3 > >> +self.modify_bg(gtk.STATE_NORMAL, > >> style.COLOR_WHITE.get_gdk_color()) > > > > Not really too

Re: [Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-06 Thread Sascha Silbe
Benjamin Berg writes: > Reviewed-by: Benjamin Berg Thanks! >> +# HACK to supress the grey background around the icon >> +# won't be needed in GTK3 >> +self.modify_bg(gtk.STATE_NORMAL, style.COLOR_WHITE.get_gdk_color()) > > Not really too bad, but I am pretty sure that

Re: [Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-06 Thread Simon Schampijer
On 08/06/2012 02:02 PM, Benjamin Berg wrote: Hi, On Mon, 2012-08-06 at 12:04 +0200, Simon Schampijer wrote: Signed-off-by: Simon Schampijer [moved from sugar-toolkit to sugar] Signed-off-by: Sascha Silbe Reviewed-by: Benjamin Berg +def __init__(self, **kwargs): +self._buffer =

Re: [Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-06 Thread Benjamin Berg
Hi, On Mon, 2012-08-06 at 12:04 +0200, Simon Schampijer wrote: > Signed-off-by: Simon Schampijer > [moved from sugar-toolkit to sugar] > Signed-off-by: Sascha Silbe Reviewed-by: Benjamin Berg > +def __init__(self, **kwargs): > +self._buffer = _IconBuffer() > +self._alpha =

Re: [Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-06 Thread Sascha Silbe
Simon Schampijer writes: > The icon consists of an GtkEventBox and an IconBuffer. The > GtkEventBox is a subclass of GtkBin which has its own window > and therefor is used to catch events for our IconBuffer > which does not have it's own window. [...] This is fine from my side, but as discussed

[Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

2012-08-06 Thread Simon Schampijer
The icon consists of an GtkEventBox and an IconBuffer. The GtkEventBox is a subclass of GtkBin which has its own window and therefor is used to catch events for our IconBuffer which does not have it's own window. The EventIcon uses the CursorInvoker that has been introduced in the GTK+ 3 toolkit t