Re: [Sugar-devel] [PATCH v3 sugar] Run Sugar-Emulator in fullscreen by default if the screen is <=800x600 (SL #2180)
Excerpts from Dipankar Patro's message of Mon Sep 27 20:35:35 +0200 2010: > Previously some bottom part of sugar emulator window was pushed out of > viewing area at 800x600 system resolution. > The patch opens Sugar-emulator in fullscreen mode by default for resolutions > <= 800x600 to avoid the above mentioned situation. Pushed as 1d069eb (master) / 1cce2c7 (sucrose-0.90). Thanks for the patch! Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v3 sugar] Run Sugar-Emulator in fullscreen by default if the screen is <=800x600 (SL #2180)
Thanks Tomeu for the acceptance. On Tue, Oct 5, 2010 at 3:02 PM, Tomeu Vizoso wrote: > On Mon, Sep 27, 2010 at 20:35, Dipankar Patro wrote: > > Previously some bottom part of sugar emulator window was pushed out of > viewing area at 800x600 system resolution. > > The patch opens Sugar-emulator in fullscreen mode by default for > resolutions <= 800x600 to avoid the above mentioned situation. > > Thanks, > > will push once we branch, please ping if I forget about it. > > Regards, > > Tomeu > > > --- > > src/jarabe/util/emulator.py |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > v2 was Reviewed-By Tomeu Vizoso > > v2->v3 : Changed commit message for proper description of patch. > > > > diff --git a/src/jarabe/util/emulator.py b/src/jarabe/util/emulator.py > > index 6a43044..cc112c9 100644 > > --- a/src/jarabe/util/emulator.py > > +++ b/src/jarabe/util/emulator.py > > @@ -42,7 +42,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen): > > screen_size = (gtk.gdk.screen_width(), gtk.gdk.screen_height()) > > > > if (not dimensions) and (fullscreen is None) and \ > > - (screen_size < default_dimensions) : > > + (screen_size <= default_dimensions) : > > # no forced settings, screen too small => fit screen > > fullscreen = True > > elif (not dimensions) : > > -- > > 1.7.0.4 > > > > ___ > > Sugar-devel mailing list > > Sugar-devel@lists.sugarlabs.org > > http://lists.sugarlabs.org/listinfo/sugar-devel > > > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v3 sugar] Run Sugar-Emulator in fullscreen by default if the screen is <=800x600 (SL #2180)
On Mon, Sep 27, 2010 at 20:35, Dipankar Patro wrote: > Previously some bottom part of sugar emulator window was pushed out of > viewing area at 800x600 system resolution. > The patch opens Sugar-emulator in fullscreen mode by default for resolutions > <= 800x600 to avoid the above mentioned situation. Thanks, will push once we branch, please ping if I forget about it. Regards, Tomeu > --- > src/jarabe/util/emulator.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > v2 was Reviewed-By Tomeu Vizoso > v2->v3 : Changed commit message for proper description of patch. > > diff --git a/src/jarabe/util/emulator.py b/src/jarabe/util/emulator.py > index 6a43044..cc112c9 100644 > --- a/src/jarabe/util/emulator.py > +++ b/src/jarabe/util/emulator.py > @@ -42,7 +42,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen): > screen_size = (gtk.gdk.screen_width(), gtk.gdk.screen_height()) > > if (not dimensions) and (fullscreen is None) and \ > - (screen_size < default_dimensions) : > + (screen_size <= default_dimensions) : > # no forced settings, screen too small => fit screen > fullscreen = True > elif (not dimensions) : > -- > 1.7.0.4 > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH v3 sugar] Run Sugar-Emulator in fullscreen by default if the screen is <=800x600 (SL #2180)
Previously some bottom part of sugar emulator window was pushed out of viewing area at 800x600 system resolution. The patch opens Sugar-emulator in fullscreen mode by default for resolutions <= 800x600 to avoid the above mentioned situation. --- src/jarabe/util/emulator.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) v2 was Reviewed-By Tomeu Vizoso v2->v3 : Changed commit message for proper description of patch. diff --git a/src/jarabe/util/emulator.py b/src/jarabe/util/emulator.py index 6a43044..cc112c9 100644 --- a/src/jarabe/util/emulator.py +++ b/src/jarabe/util/emulator.py @@ -42,7 +42,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen): screen_size = (gtk.gdk.screen_width(), gtk.gdk.screen_height()) if (not dimensions) and (fullscreen is None) and \ - (screen_size < default_dimensions) : + (screen_size <= default_dimensions) : # no forced settings, screen too small => fit screen fullscreen = True elif (not dimensions) : -- 1.7.0.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
