Re: [Sugar-devel] [sugar-toolkit-gtk3] Make icon_name api consistent between the different toolbuttons

2012-09-20 Thread Simon Schampijer
Thanks for the patch. I did change the method name to set_icon_name to clearly overwrite that. Otherwise you would have been still able to do button.set_icon and button.set_icon_name. Pushed with these changes, Simon On 09/19/2012 10:25 PM, godi...@sugarlabs.org wrote: From: Gonzalo

[Sugar-devel] [sugar-toolkit-gtk3] Make icon_name api consistent between the different toolbuttons

2012-09-19 Thread godiard
From: Gonzalo Odiard godi...@gmail.com As discused in the mailing list [1] the api to set the icon in sugar ToolButton, RadioToolButton and ToggleToolButton is inconsistent, and with the port to gtk3 differences are visible as a wrong size (SL #3849) Signed-off-by: Gonzalo Odiard