Re: [Sugar-devel] Alt-tab key does not work in F14 and sugar-emulator #2300

2010-10-08 Thread Bernie Innocenti
On Thu, 2010-10-07 at 09:52 +0200, Simon Schampijer wrote:
 Hi Sascha,
 
 thanks for your comments.
 
 On 10/06/2010 03:38 PM, Sascha Silbe wrote:
  Excerpts from Simon Schampijer's message of Wed Oct 06 15:21:29 +0200 2010:
 
  I have been bumping into [1] [...]
 
  Just to avoid confusion: This has nothing to do with how you run Sugar
  (i.e. it will occur both with sugar-emulator and running Sugar as a
  regular desktop session). It is (according to Bernie - I didn't quite
  grok the code) a bug in some versions of Xorg and will appear on some
  distro versions, independent of how you installed Sugar (native distro
  packages or sugar-jhbuild).
 
  It's supposed to be fixed (haven't checked myself yet) in recent Xorg
  versions. Bernie has also written a patch that lets metacity work around
  the bug. With that patch applied, metacity-message disable-keybindings
  works fine again.
 
 Bernie can you give some light on the issue in Xorg and where it has 
 been fixed, if?

For those tuning in just now, the testcase we're trying to fix is
getting Metacity to effectively release keys such as Alt-TAB when
someone executes metacity-message disable-keybindings from the
command-line.

This Metacity patch fixed the problem for me on Fedora 11:

  
http://people.sugarlabs.org/bernie/patches/gnome/metacity/pending/ungrab-x-keybindings-when-they-are-disabled.patch

It works by making Metacity ungrab each key individually rather than
trying to ungrab them all at once with XUngrabKey(AnyKey, AnyModifier),
which does not seem to work as advertised in the manpage.


 Right, best would be of course to get the Xorg fix in distros. Bernie 
 might have made the metacity workaround with a good reason, though. 
 Let's see, I hope Bernie can point us to the Xorg issue.

I thought the problem had been fixed in the X server by recent commits
to dix/grabs.c:DeletePassiveGrabFromList(), but apparently it's still
there. Now I'm a little confused, because ungrabbing seems to work on at
least some systems. I'm not sure which particular combinations of X
server and Metacity can trigger it.

These are the suspected functions, we still have no incriminating
evidence to declare one them them definitely guilty:

  http://cgit.freedesktop.org/xorg/xserver/tree/dix/grabs.c#n417
  http://git.gnome.org/browse/metacity/tree/src/core/keybindings.c#n737

Perhaps Peter or Owen can shred some light?

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs   - http://sugarlabs.org/


___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] Alt-tab key does not work in F14 and sugar-emulator #2300

2010-10-07 Thread Simon Schampijer

Hi Sascha,

thanks for your comments.

On 10/06/2010 03:38 PM, Sascha Silbe wrote:

Excerpts from Simon Schampijer's message of Wed Oct 06 15:21:29 +0200 2010:


I have been bumping into [1] [...]


Just to avoid confusion: This has nothing to do with how you run Sugar
(i.e. it will occur both with sugar-emulator and running Sugar as a
regular desktop session). It is (according to Bernie - I didn't quite
grok the code) a bug in some versions of Xorg and will appear on some
distro versions, independent of how you installed Sugar (native distro
packages or sugar-jhbuild).

It's supposed to be fixed (haven't checked myself yet) in recent Xorg
versions. Bernie has also written a patch that lets metacity work around
the bug. With that patch applied, metacity-message disable-keybindings
works fine again.


Bernie can you give some light on the issue in Xorg and where it has 
been fixed, if?



ISTR somebody got in touch with the metacity maintainers to land the
workaround, but don't know what got of it.
To get the workaround (or an Xorg fix) into distros we will also need to
report this bug to them. For Debian nobody did this so far and for Ubuntu
there has been no follow-up from the reporter so the ticket is marked as
Incomplete. [1]


Right, best would be of course to get the Xorg fix in distros. Bernie 
might have made the metacity workaround with a good reason, though. 
Let's see, I hope Bernie can point us to the Xorg issue.


Regards,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] Alt-tab key does not work in F14 and sugar-emulator #2300

2010-10-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Oct 07 09:52:19 +0200 2010:

 Bernie can you give some light on the issue in Xorg and where it has 
 been fixed, if?

See [1] for a start.

 Right, best would be of course to get the Xorg fix in distros.

That would require someone to isolate the commit that fixed it and
backport it to the Xorg versions the distros are shipping. I have no
idea how much effort that would be.

Sascha

[1] https://lists.sugarlabs.org/private/sugar-devel/2010-September/027099.html
--
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


[Sugar-devel] Alt-tab key does not work in F14 and sugar-emulator #2300

2010-10-06 Thread Simon Schampijer
Hi,

I have been bumping into [1] and Sascha pointed out that this is likely 
the same issue that we see in [2]. What is the status of this? Has this 
been taken upstream already?

Regards,
Simon

[1] http://bugs.sugarlabs.org/ticket/2404
[2] http://bugs.sugarlabs.org/ticket/2300
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] Alt-tab key does not work in F14 and sugar-emulator #2300

2010-10-06 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Oct 06 15:21:29 +0200 2010:

 I have been bumping into [1] [...]

Just to avoid confusion: This has nothing to do with how you run Sugar
(i.e. it will occur both with sugar-emulator and running Sugar as a
regular desktop session). It is (according to Bernie - I didn't quite
grok the code) a bug in some versions of Xorg and will appear on some
distro versions, independent of how you installed Sugar (native distro
packages or sugar-jhbuild).

It's supposed to be fixed (haven't checked myself yet) in recent Xorg
versions. Bernie has also written a patch that lets metacity work around
the bug. With that patch applied, metacity-message disable-keybindings
works fine again.

ISTR somebody got in touch with the metacity maintainers to land the
workaround, but don't know what got of it.
To get the workaround (or an Xorg fix) into distros we will also need to
report this bug to them. For Debian nobody did this so far and for Ubuntu
there has been no follow-up from the reporter so the ticket is marked as
Incomplete. [1]

Sascha

[1] https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/634415
--
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel