Re: [Sugar-devel] Please review two important bug fixes (was: Re: [PATCH sugar] Journal detail view: don't choke on invalid 'keep' property, [PATCH sugar-datastore] Ensure we return valid internal / c
On 03/06/2012 10:24 PM, Sascha Silbe wrote: Excerpts from Sascha Silbe's message of 2012-01-09 12:02:12 +0100: Excerpts from Sascha Silbe's message of 2011-11-02 23:28:28 +0100: [sugar patch] Properties of data store entries can get corrupted, e.g. due to low level crashes or running out of battery (see OLPC#11372 [1] for a real-life example). In addition any activity can - accidentally or on purpose - write data store entries with arbitrary metadata. [...] [sugar-datastore patch] The copy in the metadata storage can get corrupted, e.g. due to low level crashes or running out of battery (see OLPC#11372 [1] for a real-life example). [...] Ping. These two patches [1,2] are important bug fixes. Without them, Sugar can be left crippled after a system crash. Can somebody review the patches so we can finally land these important bug fixes, please? Sascha [1] https://patchwork.sugarlabs.org/patch/1032/ [2] https://patchwork.sugarlabs.org/patch/1136/ Both are fine to push with the amended description. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Please review two important bug fixes (was: Re: [PATCH sugar] Journal detail view: don't choke on invalid 'keep' property, [PATCH sugar-datastore] Ensure we return valid internal / c
Excerpts from Simon Schampijer's message of 2012-03-13 13:57:00 +0100: On 03/06/2012 10:24 PM, Sascha Silbe wrote: [1] https://patchwork.sugarlabs.org/patch/1032/ [2] https://patchwork.sugarlabs.org/patch/1136/ Both are fine to push with the amended description. Pushed as 9fd345f [1] (sugar-datastore) and 55a4df2 [2] (sugar). Thanks for the review! Sascha [1] https://git.sugarlabs.org/sugar-datastore/mainline/commit/9fd345f4b87c074cf50e82376020b7585eac [2] https://git.sugarlabs.org/sugar/mainline/commit/55a4df2fb8476d295f90767d42f54eca81b37cd9 -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
