Re: [Sugar-devel] review process changes

2010-06-14 Thread Tomeu Vizoso
On Sat, Jun 12, 2010 at 14:17, Bernie Innocenti ber...@codewiz.org wrote: El Thu, 03-06-2010 a las 12:19 +0200, Tomeu Vizoso escribió: Thanks, this is really useful. A few observations: - how to link tickets and patches? One way is to always end the commit message with a link to the bug:

Re: [Sugar-devel] review process changes

2010-06-12 Thread Bernie Innocenti
El Thu, 03-06-2010 a las 12:19 +0200, Tomeu Vizoso escribió: Thanks, this is really useful. A few observations: - how to link tickets and patches? One way is to always end the commit message with a link to the bug: http://bugs.sugarlabs.org/ticket/1622 This is what git-bz does automatically.

Re: [Sugar-devel] review process changes

2010-06-03 Thread Bernie Innocenti
El Thu, 03-06-2010 a las 11:55 +1000, James Cameron escribió: I don't see a way to make each module a project. The Patchwork project sugar would have to encompass all Sugar modules and activities. Patchwork prevents me from adding another project paint that shares the same mailing list.

Re: [Sugar-devel] review process changes

2010-06-03 Thread Tomeu Vizoso
On Thu, Jun 3, 2010 at 09:07, Bernie Innocenti ber...@codewiz.org wrote: El Thu, 03-06-2010 a las 11:55 +1000, James Cameron escribió: I don't see a way to make each module a project.  The Patchwork project sugar would have to encompass all Sugar modules and activities. Patchwork prevents me

Re: [Sugar-devel] review process changes

2010-06-02 Thread Tomeu Vizoso
On Thu, May 27, 2010 at 08:44, James Cameron qu...@laptop.org wrote: On Wed, May 26, 2010 at 01:48:17PM +0200, Tomeu Vizoso wrote: == Changes I would like to see == * Having _all_ reviews in the mailing list. The process already allows patches to be sent and discussed in the mailing list, but

Re: [Sugar-devel] review process changes

2010-06-02 Thread James Cameron
On Wed, Jun 02, 2010 at 11:45:57AM +0200, Tomeu Vizoso wrote: On Thu, May 27, 2010 at 08:44, James Cameron qu...@laptop.org wrote: On Wed, May 26, 2010 at 01:48:17PM +0200, Tomeu Vizoso wrote: == Issues I need help with == * How can a maintainer keep track of his queue with something like

Re: [Sugar-devel] review process changes

2010-05-27 Thread Tomeu Vizoso
On Wed, May 26, 2010 at 13:48, Tomeu Vizoso to...@tomeuvizoso.net wrote: Hi, would be good to reach some consensus and finally change the review process as defined in http://wiki.sugarlabs.org/go/Development_Team/Code_Review Alternatively, we can stay with the same process and discuss

Re: [Sugar-devel] review process changes

2010-05-27 Thread James Cameron
On Wed, May 26, 2010 at 01:48:17PM +0200, Tomeu Vizoso wrote: == Changes I would like to see == * Having _all_ reviews in the mailing list. The process already allows patches to be sent and discussed in the mailing list, but restricts it to new feature[s] and reasonably big. It also says

[Sugar-devel] review process changes

2010-05-26 Thread Tomeu Vizoso
Hi, would be good to reach some consensus and finally change the review process as defined in http://wiki.sugarlabs.org/go/Development_Team/Code_Review == Changes I would like to see == * Having _all_ reviews in the mailing list. The process already allows patches to be sent and discussed in