Re: [Sugar-devel] [PATCH] Patch to display 'Sugar inside Xephyr' instead of 'Xephyr on' in the title bar. Ticket #2285

2010-09-07 Thread Tomeu Vizoso 
On Sun, Sep 5, 2010 at 18:12, Ishan Bansal is...@seeta.in wrote:
 This patch is to display 'Sugar inside Xephyr' instead of 'Xephyr on' in the 
 title bar of the sugar windows.
 ---
  sugar-0.88-0.88.1/src/jarabe/util/emulator.py |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

 diff --git a/sugar-0.88-0.88.1/src/jarabe/util/emulator.py 
 b/sugar-0.88-0.88.1/src/jarabe/util/emulator.py
 index 5a99dbe..32ab982 100644
 --- a/sugar-0.88-0.88.1/src/jarabe/util/emulator.py
 +++ b/sugar-0.88-0.88.1/src/jarabe/util/emulator.py
 @@ -36,6 +36,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen):
     cmd = [ 'Xephyr' ]
     cmd.append(':%d' % display)
     cmd.append('-ac')
 +    cmd += ['-title', 'Sugar inside Xephyr']

     screen_size = (gtk.gdk.screen_width(), gtk.gdk.screen_height())

 --
 1.7.0.4

For reference: http://bugs.sugarlabs.org/ticket/2285#comment:2

Regards,

Tomeu

 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Patch to display 'Sugar inside Xephyr' instead of 'Xephyr on' in the title bar. Ticket #2285

2010-09-06 Thread Marco Pesenti Gritti 
On Sun, Sep 5, 2010 at 5:12 PM, Ishan Bansal is...@seeta.in wrote:
 This patch is to display 'Sugar inside Xephyr' instead of 'Xephyr on' in the 
 title bar of the sugar windows.
 ---
  sugar-0.88-0.88.1/src/jarabe/util/emulator.py |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

 diff --git a/sugar-0.88-0.88.1/src/jarabe/util/emulator.py 
 b/sugar-0.88-0.88.1/src/jarabe/util/emulator.py
 index 5a99dbe..32ab982 100644
 --- a/sugar-0.88-0.88.1/src/jarabe/util/emulator.py
 +++ b/sugar-0.88-0.88.1/src/jarabe/util/emulator.py
 @@ -36,6 +36,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen):
     cmd = [ 'Xephyr' ]
     cmd.append(':%d' % display)
     cmd.append('-ac')
 +    cmd += ['-title', 'Sugar inside Xephyr']

Looks fine to me. I would change the appends to use += too for consistency.

(Ideally we would translate this but it's probably too much trouble)

Marco
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel