Re: [Sugar-devel] [PATCH Log 1/2] pep8-ized logcollect.py

2012-05-10 Thread James Cameron
On Thu, May 10, 2012 at 06:46:00PM -0300, Manuel Kaufmann wrote:
 Passed pep8.py script to remove a lot of trailling whitespaces and
 things related.

Reviewed-by: James Cameron qu...@laptop.org

On Thu, May 10, 2012 at 06:46:01PM -0300, Manuel Kaufmann wrote:
 When the user creates a zipfile with the log collector utility, all
 his installed activities are listed in info.txt (inside the zipfile)
 and all the sugar logs of the session are attached.

Reviewed-by: James Cameron qu...@laptop.org

 -for path in glob.glob('/home/olpc/Activities/*'):
 +home = os.path.expanduser('~')
 +for path in glob.glob(os.path.join(home, 'Activities', '*')):
  s += '~' + os.path.basename(path) + '\n'

This didn't look right, because of how it apparently corrupts the
name, changing /home/olpc/Activities/Terminal.activity
into ~Terminal.activity but it is how the code was before your patch.
It remains acceptable.

-- 
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH Log 1/2] pep8-ized logcollect.py

2012-05-10 Thread Manuel Kaufmann
On Thu, May 10, 2012 at 7:24 PM, James Cameron qu...@laptop.org wrote:
 This didn't look right, because of how it apparently corrupts the
 name, changing /home/olpc/Activities/Terminal.activity
 into ~Terminal.activity but it is how the code was before your patch.
 It remains acceptable.

Yes. I don't like the way it was implemented but I don't know if those
file are parsed with some script (for example), so I decided not to
change the original text.


-- 
Kaufmann Manuel
Blog: http://humitos.wordpress.com/
Porfolio: http://fotos.mkaufmann.com.ar/
PyAr: http://www.python.com.ar/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel