Re: [Sugar-devel] [RFA] Feature freeze break: ImageViewer
On 09/07/2009 11:14 PM, Simon Schampijer wrote: On 09/07/2009 10:23 PM, Sayamindu Dasgupta wrote: On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasguptasayami...@gmail.com wrote: Hello, The attached diff makes ImageViewer work with the newer toolbar system. I have tested it in a sugar-jhbuild environment, and have found no regressions. Based on Simon's inputs on IRC, I have updated the patch. New one is attached. Thanks, Sayamindu Hmm, I think we said in a design meeting that all the buttons should be left aligned (expect the stop button). So maybe you want to put the fullscreen button the the left as well. Please, mind the 80 colums and the two '_' for callbacks ;D I tested all the buttons as working fine! Thanks, Simon Did you handle those comments? Rest looks good, Simon PS: here as well, better to wait with the push after the exception is handled ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [RFA] Feature freeze break: ImageViewer
On Wed, Sep 9, 2009 at 3:26 PM, Simon Schampijersi...@schampijer.de wrote: On 09/07/2009 11:14 PM, Simon Schampijer wrote: On 09/07/2009 10:23 PM, Sayamindu Dasgupta wrote: On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasguptasayami...@gmail.com wrote: Hello, The attached diff makes ImageViewer work with the newer toolbar system. I have tested it in a sugar-jhbuild environment, and have found no regressions. Based on Simon's inputs on IRC, I have updated the patch. New one is attached. Thanks, Sayamindu Hmm, I think we said in a design meeting that all the buttons should be left aligned (expect the stop button). So maybe you want to put the fullscreen button the the left as well. Please, mind the 80 colums and the two '_' for callbacks ;D I tested all the buttons as working fine! Thanks, Simon Did you handle those comments? two __ has been done. I'll do the 80 columns thingy and a general pylint check with the next release. Thanks, Sayamindu -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [RFA] Feature freeze break: ImageViewer
On 09/09/2009 12:17 PM, Sayamindu Dasgupta wrote: On Wed, Sep 9, 2009 at 3:26 PM, Simon Schampijersi...@schampijer.de wrote: On 09/07/2009 11:14 PM, Simon Schampijer wrote: On 09/07/2009 10:23 PM, Sayamindu Dasgupta wrote: On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasguptasayami...@gmail.com wrote: Hello, The attached diff makes ImageViewer work with the newer toolbar system. I have tested it in a sugar-jhbuild environment, and have found no regressions. Based on Simon's inputs on IRC, I have updated the patch. New one is attached. Thanks, Sayamindu Hmm, I think we said in a design meeting that all the buttons should be left aligned (expect the stop button). So maybe you want to put the fullscreen button the the left as well. Please, mind the 80 colums and the two '_' for callbacks ;D I tested all the buttons as working fine! Thanks, Simon Did you handle those comments? two __ has been done. I'll do the 80 columns thingy and a general pylint check with the next release. Thanks, Sayamindu Awesome! No doubtly +1 After 0.86 I would like to make a session a general pylint and pep8 session, and looking for other items like two '_' etc in all fructose. We have view source now, would be nice to show consistent code. Anyhow, will make another announcement, just a heads up. Thanks, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [RFA] Feature freeze break: ImageViewer
On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasguptasayami...@gmail.com wrote: Hello, The attached diff makes ImageViewer work with the newer toolbar system. I have tested it in a sugar-jhbuild environment, and have found no regressions. Based on Simon's inputs on IRC, I have updated the patch. New one is attached. Thanks, Sayamindu -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] imageviewer_toolbar.patch Description: Binary data ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [RFA] Feature freeze break: ImageViewer
On 09/07/2009 10:23 PM, Sayamindu Dasgupta wrote: On Mon, Sep 7, 2009 at 11:54 PM, Sayamindu Dasguptasayami...@gmail.com wrote: Hello, The attached diff makes ImageViewer work with the newer toolbar system. I have tested it in a sugar-jhbuild environment, and have found no regressions. Based on Simon's inputs on IRC, I have updated the patch. New one is attached. Thanks, Sayamindu Hmm, I think we said in a design meeting that all the buttons should be left aligned (expect the stop button). So maybe you want to put the fullscreen button the the left as well. Please, mind the 80 colums and the two '_' for callbacks ;D I tested all the buttons as working fine! Thanks, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
