Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Alvaro Herrera
Excerpts from Edward Z. Yang's message of lun sep 03 02:00:59 -0300 2012: > The locking is a downright crime (where's the STM when you need it), > and it's still racy, but it should work OK. Hm. I tried this but ran into trouble: I currently run branch "next", and your patch doesn't apply there;

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of lun sep 03 13:02:26 -0300 2012: > Excerpts from Edward Z. Yang's message of lun sep 03 02:00:59 -0300 2012: > > The locking is a downright crime (where's the STM when you need it), > > and it's still racy, but it should work OK. > > Hm. I tried this but r

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread ezyang
Quoting Alvaro Herrera : Excerpts from Alvaro Herrera's message of lun sep 03 13:02:26 -0300 2012: Excerpts from Edward Z. Yang's message of lun sep 03 02:00:59 -0300 2012: > The locking is a downright crime (where's the STM when you need it), > and it's still racy, but it should work OK. Hm.

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Edward Z. Yang
OK, cracked a fix; you need this extra patch: commit f9ea07f3c4982ab46d8171fdba8eabc3af00c840 Author: Edward Z. Yang Date: Mon Sep 3 14:09:34 2012 -0400 sync_back after writing to index, not before. Signed-off-by: Edward Z. Yang diff --git a/lib/sup/index.rb b/lib/sup/index.rb i

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Edward Z. Yang
I think I may have seen Sup peg IO R/W in the way you saw, but when I restarted Sup with debugging, it went away. Do let me know if you see it again; I think there's an infinite loop somewhere. Edward Excerpts from Edward Z. Yang's message of Mon Sep 03 14:09:57 -0400 2012: > OK, cracked a fix;

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Alvaro Herrera
Excerpts from Edward Z. Yang's message of lun sep 03 15:29:43 -0300 2012: > I think I may have seen Sup peg IO R/W in the way you saw, but when I > restarted Sup with debugging, it went away. Do let me know if you see it > again; I think there's an infinite loop somewhere. Sure. For the record,

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Edward Z. Yang
Excerpts from Alvaro Herrera's message of Mon Sep 03 14:42:55 -0400 2012: > Message at 0 has changed its source location. Updating labels from > draft,personal => draft,personal > Message at 1 has changed its source location. Updating labels from > draft,inbox,personal => draft,inbox,personal > M

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Edward Z. Yang
Excerpts from Alvaro Herrera's message of Mon Sep 03 14:42:55 -0400 2012: > For the record, I let it run for a while and after that the poll log had > a couple thousand lines saying "Deleting ". > After that, so far it behaves normally. I don't know what prompted > those particular messages to be

Re: [sup-devel] [PATCH] Inotify support for Maildirs. (FIRST DRAFT)

2012-09-03 Thread Edward Z. Yang
Extra note: the ruby-inotify plugin appears to be braindead on at least Ruby 1.8.7 for Ubuntu Precise, and will spin-loop. If sup is chomping 15% CPU on idle, try this patch on ruby-inotify Reported here: https://github.com/ruby-building-blocks/ruby-inotify/issues/8 diff --git a/lib/inotify/inot