Re: logpipe error handling patch

2014-07-29 Thread Gerrit Pape
On Sat, Jul 26, 2014 at 10:44:18AM +0200, c...@webprojekty.cz wrote: Hello, I wrote a patch for how broken filedescriptors when creating child are handled. Currently only the child dies, leaving non-working instance of runsv in place. My patch makes it kill the parent so the runsv process can

Re: Rare runsv logging problem

2014-07-29 Thread Caleb Spare
Thanks Gerrit! You've exactly pinpointed the issue. I can reproduce it reliably: 1. Create service/ and service/run, and let it get picked up by runsvdir 2. Create service/log/ and service/log/run Now this is in the bad state I originally described. I suppose a workaround for us is pretty

Re: Rare runsv logging problem

2014-07-29 Thread Caleb Spare
On Tue, Jul 29, 2014 at 11:43 AM, Gerrit Pape p...@smarden.org wrote: On Tue, Jul 29, 2014 at 11:17:15AM -0700, Caleb Spare wrote: I suppose a workaround for us is pretty simple: if the service directory does not exist (initial deploy), do the rsync to a temp directory and mv it into place.

[PATCH] Implement stage 4 (execve handoff)

2014-07-29 Thread Ryan Finnie
This patch adds stage 4, an optional stage which is run after stage 3. If /etc/runit/4 is found and executable, runit will execve() into it, giving it control of PID 1. Finnix (http://www.finnix.org/) uses runit as its init system, and uses this patch as a way to pivot root back into a ramdisk

Re: logpipe error handling patch

2014-07-29 Thread Jan Pobrislo
On Tue, 29 Jul 2014 15:22:36 + Gerrit Pape p...@smarden.org wrote: Thanks for the patch, but it works around the bug and doesn't fix its root cause. There are two possible resolutions - either make runsv create new pipe when asked to start up again or make it die since it's unable to

RE: logpipe error handling patch

2014-07-29 Thread James Powell
Yeah its a workaround but I've implemented it anyway in my LFS hint to be sure it works right. If you don't mind me asking Jan, can I host it on the runit-for-LFS project on GoogleCode? Sent from my Windows Phone From: Jan Pobrislomailto:c...@webprojekty.cz