Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 16:51, Luca Tettamanti wrote: > On 9/25/06, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Monday, 25 September 2006 10:40, Pavel Machek wrote: > > > So let's do: > > > > > > before suspend, swap header says "this is swapspace" > > > suspend image is written, heade

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Luca Tettamanti
On 9/25/06, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Monday, 25 September 2006 10:40, Pavel Machek wrote: > > So let's do: > > > > before suspend, swap header says "this is swapspace" > > suspend image is written, header says "this is image, suspend time was > > 5 seconds" > > then comes p

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 10:40, Pavel Machek wrote: > Hi! > > > > > > If you want to do it _right_, write timing info onto disk, then read > > > > > it from there. That will not slow the user down, while still telling > > > > > them nice statistics when resume is done. Hmmm? > > > > > > > > w

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Pavel Machek
Hi! > > > > If you want to do it _right_, write timing info onto disk, then read > > > > it from there. That will not slow the user down, while still telling > > > > them nice statistics when resume is done. Hmmm? > > > > > > where? there's no fs mounted. Is there a place to put it in the swap >

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 00:18, Pavel Machek wrote: > Hi! > > > > If you want to do it _right_, write timing info onto disk, then read > > > it from there. That will not slow the user down, while still telling > > > them nice statistics when resume is done. Hmmm? > > > > where? there's no fs

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Pavel Machek
Hi! > > If you want to do it _right_, write timing info onto disk, then read > > it from there. That will not slow the user down, while still telling > > them nice statistics when resume is done. Hmmm? > > where? there's no fs mounted. Is there a place to put it in the swap > that won't interfere

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Jason Lunz
On Sun, Sep 24, 2006 at 08:28:21PM +0200, Pavel Machek wrote: > If you want to do it _right_, write timing info onto disk, then read > it from there. That will not slow the user down, while still telling > them nice statistics when resume is done. Hmmm? where? there's no fs mounted. Is there a pla

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Rafael J. Wysocki
On Sunday, 24 September 2006 20:23, Jason Lunz wrote: > On Sun, Sep 24, 2006 at 07:17:46PM +0200, Rafael J. Wysocki wrote: > > But then you probably won't be using this switch any more. ;-) > > I will when the async i/o support comes in 2.6.19. That will only affect the in-kernel swsusp. > > I t

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Pavel Machek
Hi! > > But then you probably won't be using this switch any more. ;-) > > I will when the async i/o support comes in 2.6.19. > > > I think it would be better to make it possible to compile out the > > benchmarking code. > > Maybe eventually. Right now, the impact of various combinations of ima

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Jason Lunz
On Sun, Sep 24, 2006 at 07:17:46PM +0200, Rafael J. Wysocki wrote: > But then you probably won't be using this switch any more. ;-) I will when the async i/o support comes in 2.6.19. > I think it would be better to make it possible to compile out the > benchmarking code. Maybe eventually. Right

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Rafael J. Wysocki
On Sunday, 24 September 2006 16:12, Jason Lunz wrote: > On Sun, Sep 24, 2006 at 10:11:17AM +0200, Pavel Machek wrote: > > I'm not sure I like this one. It is little too specialized... > > without this, I can't see the i/o timings at all. Is there another way > to do it? > > I guess it could be a

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Jason Lunz
On Sun, Sep 24, 2006 at 10:11:17AM +0200, Pavel Machek wrote: > I'm not sure I like this one. It is little too specialized... without this, I can't see the i/o timings at all. Is there another way to do it? I guess it could be a command-line option, or an #ifdef used only by someone benchmarking.

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-24 Thread Pavel Machek
Hi! > Add an option to allow the user to wait for keypress during the resume > process so that image i/o stats may be read. I'm not sure I like this one. It is little too specialized... Pavel -- (english) http://www.livejournal.co

[Suspend-devel] [PATCH] add optional pause during resume

2006-09-23 Thread Jason Lunz
Add an option to allow the user to wait for keypress during the resume process so that image i/o stats may be read. Jason --- HOWTO |4 resume.c | 13 + suspend.c |5 + swsusp.h |2 +- 4 files changed, 23 insertions(+), 1 deletion(-) Index: suspend/resu