Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-07 Thread Stefan Seyfried
On Tue, Feb 06, 2007 at 07:00:00PM +0100, Rafael J. Wysocki wrote: > On Monday, 5 February 2007 16:58, Rafael J. Wysocki wrote: > > Okay, I'll try to figure out what I need to change (if anything ;-)). > > Well, that was hard. :-( Bad. I tried to document it as good as possible on the opensuse wi

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-06 Thread Rafael J. Wysocki
On Tuesday, 6 February 2007 22:46, Pavel Machek wrote: > Hi! > > > > > I think I can prepare the -mm patch. > > > > > > Thanks, i owe you one :-) > > > > Ah, no big deal, that was easy. ;-) Patch appended. > > Can you add my ACK and send it to akpm? Or do you want me to do it? I'll send. Gre

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-06 Thread Pavel Machek
Hi! > > > I think I can prepare the -mm patch. > > > > Thanks, i owe you one :-) > > Ah, no big deal, that was easy. ;-) Patch appended. Can you add my ACK and send it to akpm? Or do you want me to do it? Pavel > Rafael >

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-06 Thread Rafael J. Wysocki
On Monday, 5 February 2007 16:58, Rafael J. Wysocki wrote: > On Monday, 5 February 2007 06:46, Stefan Seyfried wrote: > > On Mon, Feb 05, 2007 at 02:05:18AM +0100, Rafael J. Wysocki wrote: > > > On Saturday, 3 February 2007 22:02, Stefan Seyfried wrote: > > > > On Fri, Feb 02, 2007 at 07:39:30PM +0

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-05 Thread Rafael J. Wysocki
On Monday, 5 February 2007 06:46, Stefan Seyfried wrote: > On Mon, Feb 05, 2007 at 02:05:18AM +0100, Rafael J. Wysocki wrote: > > On Saturday, 3 February 2007 22:02, Stefan Seyfried wrote: > > > On Fri, Feb 02, 2007 at 07:39:30PM +0100, Rafael J. Wysocki wrote: > > > > > > > I think I can prepare

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-05 Thread Stefan Seyfried
On Mon, Feb 05, 2007 at 02:05:18AM +0100, Rafael J. Wysocki wrote: > On Saturday, 3 February 2007 22:02, Stefan Seyfried wrote: > > On Fri, Feb 02, 2007 at 07:39:30PM +0100, Rafael J. Wysocki wrote: > > > > > I think I can prepare the -mm patch. > > > > Thanks, i owe you one :-) > > Ah, no big d

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-04 Thread Rafael J. Wysocki
On Saturday, 3 February 2007 22:02, Stefan Seyfried wrote: > On Fri, Feb 02, 2007 at 07:39:30PM +0100, Rafael J. Wysocki wrote: > > > I think I can prepare the -mm patch. > > Thanks, i owe you one :-) Ah, no big deal, that was easy. ;-) Patch appended. An unrelated question: what do I need to

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-03 Thread Stefan Seyfried
On Fri, Feb 02, 2007 at 07:39:30PM +0100, Rafael J. Wysocki wrote: > I think I can prepare the -mm patch. Thanks, i owe you one :-) > > Unfortunately i can not get it to -suse, since i don't have any access, so > > it will probably still be up to you to do that. But i will attach the > > patch

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-02 Thread Pavel Machek
Hi! > > > for a copy) and get it to the -suse, and I'll get it to the -mm. Ok? > > I think I can prepare the -mm patch. Ok, thanks! Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-02 Thread Rafael J. Wysocki
On Friday, 2 February 2007 16:08, Stefan Seyfried wrote: > On Fri, Feb 02, 2007 at 03:05:43PM +0100, Pavel Machek wrote: > > > Lets make a deal. You retransmit a patch (so I don't have to search > > Signed-off-by: Stefan Seyfried <[EMAIL PROTECTED]> > > diff -rup linux-2.6.20-rc6.orig/kernel/pow

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-02 Thread Stefan Seyfried
On Fri, Feb 02, 2007 at 03:05:43PM +0100, Pavel Machek wrote: > Lets make a deal. You retransmit a patch (so I don't have to search Signed-off-by: Stefan Seyfried <[EMAIL PROTECTED]> diff -rup linux-2.6.20-rc6.orig/kernel/power/main.c linux-2.6.20-rc6/kernel/power/main.c --- linux-2.6.20-rc6.or

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-02 Thread Pavel Machek
Hi! > > Not exactly, but one of them removes most of the code in user.c that Seife's > > patch fixes and the other changes code ordering in main.c in an incompatible > > way. > > > > I'd really prefer to get a fix on top of -mm right now and this bug has been > > there for _ages_. > > Rafael, ca

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-02 Thread Stefan Seyfried
On Fri, Feb 02, 2007 at 01:05:27AM +0100, Rafael J. Wysocki wrote: > Not exactly, but one of them removes most of the code in user.c that Seife's > patch fixes and the other changes code ordering in main.c in an incompatible > way. > > I'd really prefer to get a fix on top of -mm right now and th

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-01 Thread Pavel Machek
Hi! > > (Sorry, forgot ccs at the first try). > > > > > > in the light of https://bugzilla.novell.com/show_bug.cgi?id=230470 we > > > > found out that the SNAPSHOT_PMOPS syscall does not handle non-ACPI > > > > systems gracefully. > > > > > > > > Pavel did the first oops-preventing patch, i hack

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-01 Thread Rafael J. Wysocki
On Friday, 2 February 2007 00:55, Pavel Machek wrote: > Hi! > > (Sorry, forgot ccs at the first try). > > > > in the light of https://bugzilla.novell.com/show_bug.cgi?id=230470 we > > > found out that the SNAPSHOT_PMOPS syscall does not handle non-ACPI > > > systems gracefully. > > > > > > Pavel

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-01 Thread Pavel Machek
Hi! (Sorry, forgot ccs at the first try). > > in the light of https://bugzilla.novell.com/show_bug.cgi?id=230470 we > > found out that the SNAPSHOT_PMOPS syscall does not handle non-ACPI > > systems gracefully. > > > > Pavel did the first oops-preventing patch, i hacked it up a bit. > > > > Any

Re: [Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-01 Thread Rafael J. Wysocki
On Thursday, 1 February 2007 22:51, Stefan Seyfried wrote: > Hi, > > in the light of https://bugzilla.novell.com/show_bug.cgi?id=230470 we > found out that the SNAPSHOT_PMOPS syscall does not handle non-ACPI > systems gracefully. > > Pavel did the first oops-preventing patch, i hacked it up a bit

[Suspend-devel] [kernel patch] fix SNAPSHOT_PMOPS for non-ACPI systems

2007-02-01 Thread Stefan Seyfried
Hi, in the light of https://bugzilla.novell.com/show_bug.cgi?id=230470 we found out that the SNAPSHOT_PMOPS syscall does not handle non-ACPI systems gracefully. Pavel did the first oops-preventing patch, i hacked it up a bit. Any comments before i send it to lkml? Better return values? diff -ru