Re: [Suspend-devel] Splashy features

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 15:03, Tim Dijkstra wrote: > On Thu, 10 May 2007 22:17:29 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > - } else if (!splashy_open()) { > > > + } else if (!(error = splashy_open(mode))) { > > > > I'd prefer > > > > error = error = splashy_open(mode);

Re: [Suspend-devel] Splashy features

2007-05-11 Thread Tim Dijkstra
On Thu, 10 May 2007 22:17:29 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > - } else if (!splashy_open()) { > > + } else if (!(error = splashy_open(mode))) { > > I'd prefer > > error = error = splashy_open(mode); > if (error) { > > and analogously below. huh? Why i

Re: [Suspend-devel] Splashy features

2007-05-10 Thread Rafael J. Wysocki
Hi, One small remark below. Apart from this looks OK. On Thursday, 10 May 2007 22:05, Tim Dijkstra wrote: > Hi, > > libsplashy changed the ABI a bit, needed to change something. It also > would want to know if we're suspend of resuming, it can then show a > penguin going to bed or waking up. >

[Suspend-devel] Splashy features

2007-05-10 Thread Tim Dijkstra
Hi, libsplashy changed the ABI a bit, needed to change something. It also would want to know if we're suspend of resuming, it can then show a penguin going to bed or waking up. Index: resume.c === RCS file: /cvsroot/suspend/suspend/