svn commit: r326819 - head/sys/cam/ata

Author: imp Date: Wed Dec 13 07:07:27 2017 New Revision: 326819 URL: https://svnweb.freebsd.org/changeset/base/326819 Log: Use ataio ccb instead of general ccb to avoid excessice stack usage. Modified: head/sys/cam/ata/ata_da.c Modified: head/sys/cam/ata/ata_da.c

Re: svn commit: r326809 - head/sys/dev/cardbus

On Wed, Dec 13, 2017 at 6:54 AM, Alexey Dokuchaev wrote: > On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > > New Revision: 326809 > > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > > > Log: > > > 1k objects on the stack are a bad idea.

Re: svn commit: r326809 - head/sys/dev/cardbus

On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > New Revision: 326809 > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > Log: > > 1k objects on the stack are a bad idea. While it's likely safe in this > > context, it's also safe to allocate the memory and

svn commit: r326818 - stable/10/usr.bin/ipcs

Author: delphij Date: Wed Dec 13 06:20:18 2017 New Revision: 326818 URL: https://svnweb.freebsd.org/changeset/base/326818 Log: MFC r326361: Remove unused include. Modified: stable/10/usr.bin/ipcs/ipc.c Directory Properties: stable/10/ (props changed) Modified:

svn commit: r326817 - stable/11/usr.bin/ipcs

Author: delphij Date: Wed Dec 13 06:17:20 2017 New Revision: 326817 URL: https://svnweb.freebsd.org/changeset/base/326817 Log: MFC r326361: Remove unused include. Modified: stable/11/usr.bin/ipcs/ipc.c Directory Properties: stable/11/ (props changed) Modified:

svn commit: r326816 - head/usr.bin/find

Author: eadler Date: Wed Dec 13 03:36:33 2017 New Revision: 326816 URL: https://svnweb.freebsd.org/changeset/base/326816 Log: find(1): remove unused variable Modified: head/usr.bin/find/extern.h head/usr.bin/find/main.c Modified: head/usr.bin/find/extern.h

Re: svn commit: r326758 - in head/sys/i386: conf include

> On 13.12.2017 00:32, Rodney W. Grimes wrote: > > >> I am not sure if there are tools that can analyze stack requirements for > >> possible call chains rather than individual functions. > > > > Call graphs can be used to find deep chains. Combine the above > > with a call graph and we should

Re: svn commit: r326758 - in head/sys/i386: conf include

[ Charset UTF-8 unsupported, converting... ] > On 12/12/2017 19:01, Rodney W. Grimes wrote: > > We should probably start looking for those, something someone who is > > offerring help but doesnt know what they might be good at, but can > > read C code. They could be utililized t simply scan

svn commit: r326815 - head/etc/mtree

Author: dim Date: Tue Dec 12 22:21:20 2017 New Revision: 326815 URL: https://svnweb.freebsd.org/changeset/base/326815 Log: Follow-up to r325967, which removed /etc/casper, by also removing it from BSD.root.dist, so it does not get created again on installworld. Modified:

svn commit: r326814 - in stable/10/sys: amd64/linux amd64/linux32 i386/linux

Author: pfg Date: Tue Dec 12 22:10:12 2017 New Revision: 326814 URL: https://svnweb.freebsd.org/changeset/base/326814 Log: MFC r326282: (by fsu) Remap ENOATTR to ENODATA in the linuxulator. In the linux ENOADATA is frequently #defined as ENOATTR. The change is required for an xattrs

svn commit: r326813 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace

Author: markj Date: Tue Dec 12 22:08:34 2017 New Revision: 326813 URL: https://svnweb.freebsd.org/changeset/base/326813 Log: MFV r326785: 8880 improve DTrace error checking illumos/illumos-gate@2cf374268f3e1c9e9be6367466b183d27632583a

svn commit: r326812 - in head/stand: . common efi/loader i386/loader mips/beri/loader ofw/common powerpc/kboot powerpc/ps3 sparc64/loader uboot/common userboot/userboot

Author: imp Date: Tue Dec 12 22:06:22 2017 New Revision: 326812 URL: https://svnweb.freebsd.org/changeset/base/326812 Log: Revert r326792, r326784, r326772, r326712 Something subtle is creating problems for disk access on ubldr. Back it out unti that can be sorted out. Sponsored by:

Re: svn commit: r326758 - in head/sys/i386: conf include

On 12/12/17 3:09 PM, Eugene Grosbein wrote: > On 13.12.2017 02:32, John Baldwin wrote: > >> Certainly for MIPS I have found that compiling with clang >> instead of gcc for mips64 gives a kernel that panics for stack overflow for >> any >> use of NFS. It might be that this is due to something

Re: svn commit: r326758 - in head/sys/i386: conf include

> On 13.12.2017 00:01, Rodney W. Grimes wrote: > > >> But many other parts of kernel think it's OK to allocate big arrays or > >> structures on stack. > > > > We should probably start looking for those, something someone who is > > offerring help but doesnt know what they might be good at, but

Re: svn commit: r326809 - head/sys/dev/cardbus

> Author: imp > Date: Tue Dec 12 20:22:09 2017 > New Revision: 326809 > URL: https://svnweb.freebsd.org/changeset/base/326809 > > Log: > 1k objects on the stack are a bad idea. While it's likely safe in this > context, it's also safe to allocate the memory and free it instead. > >

svn commit: r326811 - head/sys/cddl/contrib/opensolaris/uts/powerpc/dtrace

Author: markj Date: Tue Dec 12 20:41:11 2017 New Revision: 326811 URL: https://svnweb.freebsd.org/changeset/base/326811 Log: Correct initialization of pc on powerpc. PR: 224293 Submitted by: Breno Leitao X-MFC with: r326774 Pointy hat: markj

svn commit: r326810 - in stable/11: lib/libsysdecode sys/amd64/linux sys/amd64/linux32 sys/i386/linux

Author: fsu Date: Tue Dec 12 20:28:54 2017 New Revision: 326810 URL: https://svnweb.freebsd.org/changeset/base/326810 Log: MFC r326282, r326317: Remap ENOATTR to ENODATA in the linuxulator. In the linux ENOADATA is frequently #defined as ENOATTR. The change is required for an xattrs

Re: svn commit: r326792 - head/stand/uboot/common

On 12/12/17 20:27, Cy Schubert wrote: PR 224080??? Yes please. Regards -- Niclas ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r326809 - head/sys/dev/cardbus

Author: imp Date: Tue Dec 12 20:22:09 2017 New Revision: 326809 URL: https://svnweb.freebsd.org/changeset/base/326809 Log: 1k objects on the stack are a bad idea. While it's likely safe in this context, it's also safe to allocate the memory and free it instead. Noticed by: Eugene

svn commit: r326808 - head/sys/kern

Author: fsu Date: Tue Dec 12 20:15:57 2017 New Revision: 326808 URL: https://svnweb.freebsd.org/changeset/base/326808 Log: Move buffer size checks outside of the vnode locks. Reviewed by:kib, cem, pfg (mentor) Approved by:pfg (mentor) MFC after: 1 weeks Differential

Re: svn commit: r326758 - in head/sys/i386: conf include

On 13.12.2017 02:32, John Baldwin wrote: > Certainly for MIPS I have found that compiling with clang > instead of gcc for mips64 gives a kernel that panics for stack overflow for > any > use of NFS. It might be that this is due to something MIPS-specific, but it > might be worthwhile retesting

svn commit: r326807 - head/sys/fs/ext2fs

Author: fsu Date: Tue Dec 12 20:02:48 2017 New Revision: 326807 URL: https://svnweb.freebsd.org/changeset/base/326807 Log: Fix extattr getters in case of neither uio nor buffer was not passed to VOP_*. Approved by:pfg (mentor) MFC after: 2 weeks Differential Revision:

svn commit: r326806 - head/usr.sbin/efibootmgr

Author: imp Date: Tue Dec 12 19:45:24 2017 New Revision: 326806 URL: https://svnweb.freebsd.org/changeset/base/326806 Log: Actually insert the free(d) call missed in r326802. Noticed by: rpokala@ Modified: head/usr.sbin/efibootmgr/efibootmgr.c Modified:

Re: svn commit: r326758 - in head/sys/i386: conf include

On 12/11/17 5:26 AM, Eugene Grosbein wrote: > On 11.12.2017 16:19, Konstantin Belousov wrote: >> On Mon, Dec 11, 2017 at 04:32:37AM +, Conrad Meyer wrote: >>> Author: cem >>> Date: Mon Dec 11 04:32:37 2017 >>> New Revision: 326758 >>> URL: https://svnweb.freebsd.org/changeset/base/326758 >>>

Re: svn commit: r326758 - in head/sys/i386: conf include

On 13.12.2017 00:32, Rodney W. Grimes wrote: >> I am not sure if there are tools that can analyze stack requirements for >> possible call chains rather than individual functions. > > Call graphs can be used to find deep chains. Combine the above > with a call graph and we should be able to come

RE: svn commit: r326792 - head/stand/uboot/common

PR 224080??? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -Original Message-

svn commit: r326805 - head/usr.sbin/efivar

Author: imp Date: Tue Dec 12 19:26:28 2017 New Revision: 326805 URL: https://svnweb.freebsd.org/changeset/base/326805 Log: Iniailize str so ucs2_to_utf8 won't free stack garbage. CID: 1381037 Sponsored by: Netflix Modified: head/usr.sbin/efivar/efiutil.c Modified:

svn commit: r326803 - head/usr.sbin/efibootmgr

Author: imp Date: Tue Dec 12 19:26:19 2017 New Revision: 326803 URL: https://svnweb.freebsd.org/changeset/base/326803 Log: Free load_opt_buf after we're done with it. CID: 1383607 Sponsored by: Netflix Modified: head/usr.sbin/efibootmgr/efibootmgr.c Modified:

svn commit: r326801 - head/usr.sbin/efibootmgr

Author: imp Date: Tue Dec 12 19:26:10 2017 New Revision: 326801 URL: https://svnweb.freebsd.org/changeset/base/326801 Log: Don't leak new_data. CID: 1383605 Sponsored by: Netflix Modified: head/usr.sbin/efibootmgr/efibootmgr.c Modified: head/usr.sbin/efibootmgr/efibootmgr.c

svn commit: r326804 - head/usr.sbin/efibootmgr

Author: imp Date: Tue Dec 12 19:26:24 2017 New Revision: 326804 URL: https://svnweb.freebsd.org/changeset/base/326804 Log: Add sanity testing against maximum sane lengths for device paths for loader and kernel. CID: 1383608 Sponsored by: Netflix Modified:

svn commit: r326802 - head/usr.sbin/efibootmgr

Author: imp Date: Tue Dec 12 19:26:15 2017 New Revision: 326802 URL: https://svnweb.freebsd.org/changeset/base/326802 Log: Fix resource leak. Free converted description after printing it. Also minor style sort of local vars. CID: 1383606 Sponsored by: Netflix Modified:

svn commit: r326800 - head/usr.sbin/efibootmgr

Author: imp Date: Tue Dec 12 19:25:54 2017 New Revision: 326800 URL: https://svnweb.freebsd.org/changeset/base/326800 Log: Check return value for set_bootvar and give a good error message. CID: 1383601 Sponsored by: Netflix Modified: head/usr.sbin/efibootmgr/efibootmgr.c Modified:

Re: svn commit: r326792 - head/stand/uboot/common

On Tue, Dec 12, 2017 at 12:13 PM, Mateusz Guzik wrote: > How about you both close one PR as a punishment and we pretend this did > not happen. > I'll fix 6 CIDs as punishment. Warner > The thing to do was to reply to the offending commit or contact the > committer > on

Re: svn commit: r326758 - in head/sys/i386: conf include

On 13.12.2017 00:01, Rodney W. Grimes wrote: >> But many other parts of kernel think it's OK to allocate big arrays or >> structures on stack. > > We should probably start looking for those, something someone who is > offerring help but doesnt know what they might be good at, but can > read C

Re: svn commit: r326792 - head/stand/uboot/common

How about you both close one PR as a punishment and we pretend this did not happen. The thing to do was to reply to the offending commit or contact the committer on irc. Only in case of no timely response fixing on your own is the right thing to do. On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh

Re: svn commit: r326792 - head/stand/uboot/common

The email I wrote here also sucks. It was unduly harsh. While the commit message should have been better, I was too harsh in trying to express this and giving a better example. Warner On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh wrote: > This commit message sucks. Please use a

svn commit: r326799 - head/contrib/less

Author: asomers Date: Tue Dec 12 17:34:35 2017 New Revision: 326799 URL: https://svnweb.freebsd.org/changeset/base/326799 Log: less(1): diff reduction vs upstream No functional change. MFC after:3 weeks Sponsored by: Spectra Logic Corp Modified: head/contrib/less/main.c

svn commit: r326798 - head/sys/geom/mirror

Author: markj Date: Tue Dec 12 17:29:34 2017 New Revision: 326798 URL: https://svnweb.freebsd.org/changeset/base/326798 Log: Address a possible lost wakeup for gmirror events. g_mirror_event_send() acquires the I/O queue lock to deliver a wakeup to the worker thread, and this is done

Re: svn commit: r326758 - in head/sys/i386: conf include

On 12/12/2017 19:01, Rodney W. Grimes wrote: > We should probably start looking for those, something someone who is > offerring help but doesnt know what they might be good at, but can > read C code. They could be utililized t simply scan through the > code looking for this type of thing and

svn commit: r326797 - head/sys/geom/mirror

Author: markj Date: Tue Dec 12 17:25:25 2017 New Revision: 326797 URL: https://svnweb.freebsd.org/changeset/base/326797 Log: Give g_mirror_event_get() a more accurate name. MFC after:1 week Sponsored by: Dell EMC Isilon Modified: head/sys/geom/mirror/g_mirror.c Modified:

svn commit: r326796 - head/sys/geom/mirror

Author: markj Date: Tue Dec 12 17:24:30 2017 New Revision: 326796 URL: https://svnweb.freebsd.org/changeset/base/326796 Log: Decrement sc_writes when BIO_DELETE requests complete. Otherwise a gmirror that has received a BIO_DELETE request will never be marked clean (unless sc_writes

Re: svn commit: r324686 - stable/11/sys/netinet

On Sun, Dec 03, 2017 at 03:39:46PM +0200, Konstantin Belousov wrote: > On Tue, Oct 17, 2017 at 12:42:17PM +, Michael Tuexen wrote: > > Author: tuexen > > Date: Tue Oct 17 12:42:17 2017 > > New Revision: 324686 > > URL: https://svnweb.freebsd.org/changeset/base/324686 > > > > Log: > > MFC

Re: svn commit: r326773 - in head/sys: conf dev/syscon

On Tue, Dec 12, 2017 at 10:05 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > Please stop dismissing concerns, especially if raised by more > than one person, as whining, that is not helpful. > Except in this case it was totally useless. Totally. It was an emotional reaction

Re: svn commit: r326773 - in head/sys: conf dev/syscon

> On Tue, 12 Dec 2017 07:40:21 -0800 (PST) > "Rodney W. Grimes" wrote: > > > > On Tue, 12 Dec 2017 06:18:36 + > > > Alexey Dokuchaev wrote: > > > > > > > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > > > > > I think

Re: svn commit: r326758 - in head/sys/i386: conf include

[ Charset windows-1252 unsupported, converting... ] > 12.12.2017 22:30, Rodney W. Grimes: > > >>> Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent > >>> client, and I run several virtualized routers with IPSEC tunnels, > >>> jabber and mail server, squid and ZFS for

Re: svn commit: r326773 - in head/sys: conf dev/syscon

On Tue, 2017-12-12 at 07:40 -0800, Rodney W. Grimes wrote: > > > > On Tue, 12 Dec 2017 06:18:36 + > > Alexey Dokuchaev wrote: > > > > > > > > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > > > > > > > > I think this name might confuse people looking

Re: svn commit: r326758 - in head/sys/i386: conf include

12.12.2017 22:30, Rodney W. Grimes: >>> Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent >>> client, and I run several virtualized routers with IPSEC tunnels, >>> jabber and mail server, squid and ZFS for src/obj/ports compression >>> and they all easily crash unless

Re: svn commit: r326773 - in head/sys: conf dev/syscon

On Tue, Dec 12, 2017 at 8:58 AM, Emmanuel Vadot wrote: > Again, we will move it to sys/dev/extres, now can we stop whining > about small details like that and do some actual work please ? while true; do echo +1 ; done You have no idea how demotivating chicken !$!%

Re: svn commit: r326773 - in head/sys: conf dev/syscon

On Tue, 12 Dec 2017 07:40:21 -0800 (PST) "Rodney W. Grimes" wrote: > > On Tue, 12 Dec 2017 06:18:36 + > > Alexey Dokuchaev wrote: > > > > > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > > > > I think this name might

Re: svn commit: r326773 - in head/sys: conf dev/syscon

> On Tue, 12 Dec 2017 06:18:36 + > Alexey Dokuchaev wrote: > > > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > > > I think this name might confuse people looking for "syscons". Can it be > > > renamed? Also, if it is ARM-specific, maybe it belongs in

Re: svn commit: r326758 - in head/sys/i386: conf include

> On 12 Dec, Eugene Grosbein wrote: > > > Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent > > client, and I run several virtualized routers with IPSEC tunnels, > > jabber and mail server, squid and ZFS for src/obj/ports compression > > and they all easily crash unless

svn commit: r326795 - in stable/8/contrib/gcclibs: include libiberty

Author: danfe (ports committer) Date: Tue Dec 12 12:59:04 2017 New Revision: 326795 URL: https://svnweb.freebsd.org/changeset/base/326795 Log: MFC r301291: libiberty: prevent integer overflow. Take care of very old bug leading to heap-buffer overflow by processing certain file

Re: svn commit: r326792 - head/stand/uboot/common

This commit message sucks. Please use a more descriptive one in the future like "catch up to change rX that remove the argument from interact." If you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. Your message is utterly useless. It doesn't even say what arch is broken.

svn commit: r326794 - head/lib/libc/gen

Author: mmel Date: Tue Dec 12 11:25:30 2017 New Revision: 326794 URL: https://svnweb.freebsd.org/changeset/base/326794 Log: Rework alignment handling in __libc_allocate_tls() for Variant I of TLS layout. There are two versions of variant I of TLS - ARM and aarch64 uses original version

svn commit: r326793 - stable/11/sys/amd64/amd64

Author: kib Date: Tue Dec 12 11:09:46 2017 New Revision: 326793 URL: https://svnweb.freebsd.org/changeset/base/326793 Log: MFC r326311: Fix index calculation for the page table pages for efirt 1:1 map. Modified: stable/11/sys/amd64/amd64/efirt.c Directory Properties: stable/11/ (props

svn commit: r326792 - head/stand/uboot/common

Author: antoine Date: Tue Dec 12 09:46:53 2017 New Revision: 326792 URL: https://svnweb.freebsd.org/changeset/base/326792 Log: Attempt to unbreak buildworld Modified: head/stand/uboot/common/main.c Modified: head/stand/uboot/common/main.c

Re: svn commit: r326773 - in head/sys: conf dev/syscon

On Tue, 12 Dec 2017 06:18:36 + Alexey Dokuchaev wrote: > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > > I think this name might confuse people looking for "syscons". Can it be > > renamed? Also, if it is ARM-specific, maybe it belongs in sys/arm? >

Re: svn commit: r326773 - in head/sys: conf dev/syscon

Bezüglich Alexey Dokuchaev's Nachricht vom 12.12.2017 07:18 (localtime): > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: >> I think this name might confuse people looking for "syscons". Can it be >> renamed? Also, if it is ARM-specific, maybe it belongs in sys/arm? > +1 for

Re: svn commit: r291722 - in stable/9: crypto/openssl crypto/openssl/apps crypto/openssl/crypto crypto/openssl/crypto/asn1 crypto/openssl/crypto/des/t crypto/openssl/crypto/evp crypto/openssl/doc cryp

On Thu, Dec 03, 2015 at 09:24:41PM +, Jung-uk Kim wrote: > New Revision: 291722 > URL: https://svnweb.freebsd.org/changeset/base/291722 > > Log: > Merge OpenSSL 0.9.8zh. > > Added: > stable/9/crypto/openssl/doc/dir-locals.example.el > - copied unchanged from r291711, >

Re: svn commit: r326758 - in head/sys/i386: conf include

On 12.12.2017 06:00, Don Lewis wrote: > On 12 Dec, Eugene Grosbein wrote: > >> Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent >> client, and I run several virtualized routers with IPSEC tunnels, >> jabber and mail server, squid and ZFS for src/obj/ports compression >> and they