Re: svn commit: r328430 - head/sbin/devd

2018-01-26 5:52 GMT+01:00 Warner Losh : > Everything needs a virtual destructor... Please back that part of this > out... If you're concerned about inheritance, what about adding the 'final' keyword to the class? http://en.cppreference.com/w/cpp/language/final Eitan: static

svn commit: r328432 - head/sys/modules/geom/geom_label

Author: lwhsu (ports committer) Date: Fri Jan 26 06:21:24 2018 New Revision: 328432 URL: https://svnweb.freebsd.org/changeset/base/328432 Log: Fix LINT build. Approved by: delphij Modified: head/sys/modules/geom/geom_label/Makefile Modified: head/sys/modules/geom/geom_label/Makefile

Re: svn commit: r328430 - head/sbin/devd

On Thu, Jan 25, 2018 at 10:04 PM, Eitan Adler wrote: > On 25 January 2018 at 21:02, Matt Joras wrote: > > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: > >> > >> > >> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler

Re: svn commit: r328430 - head/sbin/devd

On Thu, Jan 25, 2018 at 10:02 PM, Matt Joras wrote: > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: > > > > > > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: > >> > >> Author: eadler > >> Date: Fri Jan 26 04:40:41 2018 > >>

Re: svn commit: r328430 - head/sbin/devd

On 25 January 2018 at 21:02, Matt Joras wrote: > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: >> >> >> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: >>> >>> Author: eadler >>> Date: Fri Jan 26 04:40:41 2018 >>> New

svn commit: r328431 - head/sbin/devd

Author: eadler Date: Fri Jan 26 05:03:37 2018 New Revision: 328431 URL: https://svnweb.freebsd.org/changeset/base/328431 Log: devd: readd virtual - my C++ knowledge is old and rusty. re-add virtual Modified: head/sbin/devd/devd.hh Modified: head/sbin/devd/devd.hh

Re: svn commit: r328430 - head/sbin/devd

On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: > > > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: >> >> Author: eadler >> Date: Fri Jan 26 04:40:41 2018 >> New Revision: 328430 >> URL: https://svnweb.freebsd.org/changeset/base/328430 >> >> Log: >>

Re: svn commit: r328430 - head/sbin/devd

On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: > Author: eadler > Date: Fri Jan 26 04:40:41 2018 > New Revision: 328430 > URL: https://svnweb.freebsd.org/changeset/base/328430 > > Log: > devd: minor nits > > - mark usage as noreturn > - config does not need a

svn commit: r328430 - head/sbin/devd

Author: eadler Date: Fri Jan 26 04:40:41 2018 New Revision: 328430 URL: https://svnweb.freebsd.org/changeset/base/328430 Log: devd: minor nits - mark usage as noreturn - config does not need a virtual destructor Modified: head/sbin/devd/devd.cc head/sbin/devd/devd.hh Modified:

svn commit: r328429 - in stable: 10/release 11/release

Author: gjb Date: Fri Jan 26 04:32:31 2018 New Revision: 328429 URL: https://svnweb.freebsd.org/changeset/base/328429 Log: MFC r328283, r328284: r328283: When CHROOTBUILD_SKIP is set, evaluate the existence of /bin/sh within the CHROOTDIR. If it does not exist, unset

svn commit: r328429 - in stable: 10/release 11/release

Author: gjb Date: Fri Jan 26 04:32:31 2018 New Revision: 328429 URL: https://svnweb.freebsd.org/changeset/base/328429 Log: MFC r328283, r328284: r328283: When CHROOTBUILD_SKIP is set, evaluate the existence of /bin/sh within the CHROOTDIR. If it does not exist, unset

svn commit: r328428 - head/share/examples/kld/cdev/module

Author: eadler Date: Fri Jan 26 04:24:39 2018 New Revision: 328428 URL: https://svnweb.freebsd.org/changeset/base/328428 Log: example cdev: use make_dev_s Make use of make_dev_s in the example cdev. While here, fix warnings. Reviewed by: rpokala Modified:

svn commit: r328427 - head/bin/dd

Author: eadler Date: Fri Jan 26 03:30:05 2018 New Revision: 328427 URL: https://svnweb.freebsd.org/changeset/base/328427 Log: dd(1): Use a local swapbytes() function. swab(3) has restrict qualifiers for src and dst. Avoid relying on undefined overlapping swab behavior. Obtained

svn commit: r328426 - in head: lib/libufs sbin/clri sbin/dump sbin/fsck_ffs sbin/fsirand sbin/growfs sbin/newfs sbin/quotacheck stand/libsa sys/geom sys/geom/journal sys/geom/label sys/ufs/ffs usr....

Author: mckusick Date: Fri Jan 26 00:58:32 2018 New Revision: 328426 URL: https://svnweb.freebsd.org/changeset/base/328426 Log: Refactoring of reading and writing of the UFS/FFS superblock. Specifically reading is done if ffs_sbget() and writing is done in ffs_sbput(). These functions are

svn commit: r328425 - head/sys/cam/ctl

Author: jhibbits Date: Fri Jan 26 00:58:02 2018 New Revision: 328425 URL: https://svnweb.freebsd.org/changeset/base/328425 Log: Minimum changes for ctl to build on architectures with non-matching physical and virtual address sizes Summary: Some architectures use physical addresses

svn commit: r328424 - head/sys/compat/linuxkpi/common/src

Author: jhibbits Date: Fri Jan 26 00:56:09 2018 New Revision: 328424 URL: https://svnweb.freebsd.org/changeset/base/328424 Log: Minimal change to build linuxkpi on architectures with physical addresses larger than virtual Summary: Some architectures have physical/bus addresses that

svn commit: r328423 - head/sys/dev/cxgbe

Author: np Date: Fri Jan 26 00:45:40 2018 New Revision: 328423 URL: https://svnweb.freebsd.org/changeset/base/328423 Log: cxgbe(4): Accept old names of a couple of tunables. Modified: head/sys/dev/cxgbe/t4_main.c Modified: head/sys/dev/cxgbe/t4_main.c

svn commit: r328422 - stable/10/usr.bin/procstat

Author: brooks Date: Fri Jan 26 00:35:33 2018 New Revision: 328422 URL: https://svnweb.freebsd.org/changeset/base/328422 Log: MFC r328297: Don't escape '?'s in protocol output. This isn't required by mandoc and is nonfunctional in groff. PR: 224632 Reported by:

svn commit: r328421 - stable/11/usr.bin/procstat

Author: brooks Date: Fri Jan 26 00:34:33 2018 New Revision: 328421 URL: https://svnweb.freebsd.org/changeset/base/328421 Log: MFC r328297: Don't escape '?'s in protocol output. This isn't required by mandoc and is nonfunctional in groff. PR: 224632 Reported by:

svn commit: r328420 - head/sys/dev/cxgbe/common

Author: np Date: Fri Jan 26 00:03:14 2018 New Revision: 328420 URL: https://svnweb.freebsd.org/changeset/base/328420 Log: cxgbe(4): Do not display harmless warning in non-debug builds. MFC after:3 days Sponsored by: Chelsio Communications Modified:

svn commit: r328419 - head/crypto/openssl/ssl

Author: jkim Date: Thu Jan 25 23:38:05 2018 New Revision: 328419 URL: https://svnweb.freebsd.org/changeset/base/328419 Log: Add declaration of SSL_get_selected_srtp_profile() for OpenSSL. Because there was an extra declaration in the vendor version, we locally removed the second one in

Re: svn commit: r328313 - head/sys/netpfil/pf

On Thu, Jan 25, 2018 at 02:46:14PM +1100, Kristof Provost wrote: K> On 25 Jan 2018, at 12:08, Kristof Provost wrote: K> > On 25 Jan 2018, at 11:34, Ian Lepore wrote: K> >> On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: K> >>> (r328313) K> >>> K> @@ -1613,6 +1613,7 @@ int K> >>> K>  

svn commit: r328418 - in head/sys/fs: nfs nfsserver

Author: cem Date: Thu Jan 25 22:38:39 2018 New Revision: 328418 URL: https://svnweb.freebsd.org/changeset/base/328418 Log: nfs: Remove NFSSOCKADDRALLOC, NFSSOCKADDRFREE macros They were just thin wrappers over malloc(9) w/ M_ZERO and free(9). Discussed with: rmacklem, markj

svn commit: r328417 - in head/sys: contrib/ipfilter/netinet fs/nfs fs/nfsclient fs/nfsserver netinet nfsclient sys

Author: cem Date: Thu Jan 25 22:25:13 2018 New Revision: 328417 URL: https://svnweb.freebsd.org/changeset/base/328417 Log: style: Remove remaining deprecated MALLOC/FREE macros Mechanically replace uses of MALLOC/FREE with appropriate invocations of malloc(9) / free(9) (a series of sed

svn commit: r328416 - head/sys/modules/cam

Author: imp Date: Thu Jan 25 21:48:07 2018 New Revision: 328416 URL: https://svnweb.freebsd.org/changeset/base/328416 Log: Add new opt_da.h for stand-alone build. Sponsored by: Netflix Modified: head/sys/modules/cam/Makefile Modified: head/sys/modules/cam/Makefile

svn commit: r328415 - in head/sys: cam/scsi conf

Author: imp Date: Thu Jan 25 21:38:30 2018 New Revision: 328415 URL: https://svnweb.freebsd.org/changeset/base/328415 Log: Track Ref / DeRef and Hold / Unhold that da is doing to track down leaks. We assume each source can be taken / dropped only once and don't recurse. These are only

svn commit: r328414 - head/sys/cam

Author: imp Date: Thu Jan 25 21:38:09 2018 New Revision: 328414 URL: https://svnweb.freebsd.org/changeset/base/328414 Log: When devices are invalidated, there's some cases where ccbs for that device still wind up in xpt_done after the path has been invalidated. Since we don't always need

svn commit: r328413 - head

Author: wosch Date: Thu Jan 25 21:36:26 2018 New Revision: 328413 URL: https://svnweb.freebsd.org/changeset/base/328413 Log: `make installkernel' should display a completed message if done PR: 225159 Reviewed by: bdrewery Approved by: cem (mentor) Differential Revision:

svn commit: r328412 - head/share/vt/keymaps

Author: emaste Date: Thu Jan 25 21:13:42 2018 New Revision: 328412 URL: https://svnweb.freebsd.org/changeset/base/328412 Log: vt: add Ctrl+/ key mapping This matches Xorg's handling of Ctrl+/ and may be useful as a tmux escape. PR: 212197 Submitted by: martin at

svn commit: r328411 - in head/stand/efi: include loader

Author: emaste Date: Thu Jan 25 20:09:51 2018 New Revision: 328411 URL: https://svnweb.freebsd.org/changeset/base/328411 Log: loader.efi: add missing EFI GUIDs These were found during bring-up on a new arm64 platform and in an amd64 VM. Submitted by: Arshan Khanifar Reviewed by:

Re: svn commit: r328388 - head/share/man/man8

On Thu, Jan 25, 2018 at 12:16 PM, Andrew Turner wrote: > > On 25 Jan 2018, at 17:43, Warner Losh wrote: > > > > On Thu, Jan 25, 2018 at 9:51 AM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > >> [ Charset UTF-8 unsupported, converting... ]

Re: svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

On 25/01/2018 14:24, Bruce Evans wrote: On Thu, 25 Jan 2018, Pedro Giffuni wrote: This is almost unreadable due to hard-coded UTF-8 (mostly for tabs corrupted to spaces) even in previously-literally quoted C code. Mailer agents ... they all suck :( On 01/25/18 11:28, Bruce Evans wrote:

svn commit: r328410 - head/usr.sbin/bsdinstall/partedit

Author: emaste Date: Thu Jan 25 19:57:21 2018 New Revision: 328410 URL: https://svnweb.freebsd.org/changeset/base/328410 Log: bsdinstall: enable SUJ by default (revert r327890) fsck should be fixed as of r328092. PR: 225110 Tested by:dumbbell, Arshan Khanifar

Re: svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

On Thu, 25 Jan 2018, Pedro Giffuni wrote: This is almost unreadable due to hard-coded UTF-8 (mostly for tabs corrupted to spaces) even in previously-literally quoted C code. On 01/25/18 11:28, Bruce Evans wrote: On Wed, 24 Jan 2018, Pedro F. Giffuni wrote: [... Most unreadable lines

Re: svn commit: r328388 - head/share/man/man8

> On 25 Jan 2018, at 17:43, Warner Losh wrote: > > > > On Thu, Jan 25, 2018 at 9:51 AM, Rodney W. Grimes > > > wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: lwhsu (ports committer) >

Re: svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

On 01/25/18 11:28, Bruce Evans wrote: On Wed, 24 Jan 2018, Pedro F. Giffuni wrote: Log:  ext2fs|ufs:Unsign some values related to allocation.  When allocating memory through malloc(9), we always expect the amount of  memory requested to be unsigned as a negative value would either stand

svn commit: r328409 - head/sys/powerpc/powerpc

Author: nwhitehorn Date: Thu Jan 25 18:10:33 2018 New Revision: 328409 URL: https://svnweb.freebsd.org/changeset/base/328409 Log: Avoid all SLB operations in trap handling if the process is not using a software-managed SLB. Modified: head/sys/powerpc/powerpc/trap.c Modified:

svn commit: r328408 - head/sys/powerpc/powerpc

Author: nwhitehorn Date: Thu Jan 25 18:09:26 2018 New Revision: 328408 URL: https://svnweb.freebsd.org/changeset/base/328408 Log: Treat DSE exceptions like DSI exceptions when generating signinfo. Both can generate SIGSEGV, but DSEs would have put the wrong address into the siginfo

svn commit: r328407 - head/sys/arm/freescale/imx

Author: ian Date: Thu Jan 25 18:08:56 2018 New Revision: 328407 URL: https://svnweb.freebsd.org/changeset/base/328407 Log: Fix return style in RD2. Remove bogus return value from a void function in WR2 (I have no idea why that didn't result in a compile error). Modified:

Re: svn commit: r328388 - head/share/man/man8

[ Charset UTF-8 unsupported, converting... ] > On Thu, Jan 25, 2018 at 9:51 AM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > Author: lwhsu (ports committer) > > > Date: Thu Jan 25 05:15:44 2018 > > > New Revision: 328388 > >

svn commit: r328406 - head/sys/fs/ext2fs

Author: pfg Date: Thu Jan 25 18:01:46 2018 New Revision: 328406 URL: https://svnweb.freebsd.org/changeset/base/328406 Log: Minor style issue introduced in r328346. Pointed by: bde Modified: head/sys/fs/ext2fs/ext2_lookup.c Modified: head/sys/fs/ext2fs/ext2_lookup.c

svn commit: r328405 - head/sys/arm/freescale/imx

Author: ian Date: Thu Jan 25 17:53:33 2018 New Revision: 328405 URL: https://svnweb.freebsd.org/changeset/base/328405 Log: Minor cleanups... Move DRIVER_MODULE() and other boilerplate stuff to the bottom of the file, where it is in most imx5/6 drivers. Switch from an RD2 macro using

Re: svn commit: r328388 - head/share/man/man8

On Thu, Jan 25, 2018 at 9:51 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: lwhsu (ports committer) > > Date: Thu Jan 25 05:15:44 2018 > > New Revision: 328388 > > URL: https://svnweb.freebsd.org/changeset/base/328388 > > >

Re: svn commit: r328402 - head/sys/dev/usb/controller

On Thu, Jan 25, 2018 at 06:12:04PM +0100, Emmanuel Vadot wrote: > > Log: > > Add basic driver for Qualcomm USB 2.0 EHCI controller. > > This driver relies on system initialization in u-boot. > > > > Tested on DragonBoard 410c. > > > > Sponsored by: DARPA, AFRL > > > > Added: > >

svn commit: r328404 - in head/sys: arm/mv/armada38x arm/xilinx conf

Author: br Date: Thu Jan 25 17:16:29 2018 New Revision: 328404 URL: https://svnweb.freebsd.org/changeset/base/328404 Log: o Move sdhci_fdt to the generic files list. o Include Qualcomm EHCI and UART drivers to the build. Sponsored by: DARPA, AFRL Modified:

Re: svn commit: r328402 - head/sys/dev/usb/controller

Hi Ruslan, On Thu, 25 Jan 2018 16:58:23 + (UTC) Ruslan Bukin wrote: > Author: br > Date: Thu Jan 25 16:58:23 2018 > New Revision: 328402 > URL: https://svnweb.freebsd.org/changeset/base/328402 > > Log: > Add basic driver for Qualcomm USB 2.0 EHCI controller. > This

svn commit: r328403 - head/sys/dev/sdhci

Author: br Date: Thu Jan 25 17:00:35 2018 New Revision: 328403 URL: https://svnweb.freebsd.org/changeset/base/328403 Log: Add support for SDHCI controller found in Qualcomm Snapdragon 410e. Tested on DragonBoard 410c. Sponsored by: DARPA, AFRL Modified:

svn commit: r328402 - head/sys/dev/usb/controller

Author: br Date: Thu Jan 25 16:58:23 2018 New Revision: 328402 URL: https://svnweb.freebsd.org/changeset/base/328402 Log: Add basic driver for Qualcomm USB 2.0 EHCI controller. This driver relies on system initialization in u-boot. Tested on DragonBoard 410c. Sponsored by: DARPA,

Re: svn commit: r328388 - head/share/man/man8

[ Charset UTF-8 unsupported, converting... ] > Author: lwhsu (ports committer) > Date: Thu Jan 25 05:15:44 2018 > New Revision: 328388 > URL: https://svnweb.freebsd.org/changeset/base/328388 > > Log: > Fix manual page install on non-amd64 > > Reviewed by:emaste, imp >

Re: svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

On Wed, 24 Jan 2018, Pedro F. Giffuni wrote: Log: ext2fs|ufs:Unsign some values related to allocation. When allocating memory through malloc(9), we always expect the amount of memory requested to be unsigned as a negative value would either stand for an error or an overflow. Unsign some

svn commit: r328401 - head/share/man/man9

Author: imp Date: Thu Jan 25 15:55:58 2018 New Revision: 328401 URL: https://svnweb.freebsd.org/changeset/base/328401 Log: Bump .Dd date for c99 change Modified: head/share/man/man9/style.9 Modified: head/share/man/man9/style.9

svn commit: r328400 - head/share/man/man9

Author: imp Date: Thu Jan 25 15:42:21 2018 New Revision: 328400 URL: https://svnweb.freebsd.org/changeset/base/328400 Log: Add info about c99 designationed initializers. Differential Revision: https://reviews.freebsd.org/D13975 Modified: head/share/man/man9/style.9 Modified:

svn commit: r328399 - head/sys/netinet

Author: markj Date: Thu Jan 25 15:35:34 2018 New Revision: 328399 URL: https://svnweb.freebsd.org/changeset/base/328399 Log: Use tcpinfoh_t for TCP headers in the tcp:::debug-{drop,input} probes. The header passed to these probes has some fields converted to host order by

svn commit: r328398 - head/cddl/lib/libdtrace

Author: markj Date: Thu Jan 25 15:31:56 2018 New Revision: 328398 URL: https://svnweb.freebsd.org/changeset/base/328398 Log: Remove uneeded parentheses. MFC after:1 week Modified: head/cddl/lib/libdtrace/tcp.d Modified: head/cddl/lib/libdtrace/tcp.d

svn commit: r328397 - in stable/11/sys: amd64/amd64 i386/i386

Author: kib Date: Thu Jan 25 15:28:43 2018 New Revision: 328397 URL: https://svnweb.freebsd.org/changeset/base/328397 Log: MFC r327820: Remove redundand CLD instructions. Modified: stable/11/sys/amd64/amd64/support.S stable/11/sys/i386/i386/support.s Directory Properties: stable/11/

Re: svn commit: r328340 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

On 25/01/2018 09:42, Bruce Evans wrote: On Wed, 24 Jan 2018, Pedro F. Giffuni wrote: Log:  Revert r327781,  r328093, r328056:  ufs|ext2fs: Revert uses of mallocarray(9).  These aren't really useful: drop them.  Variable unsigning will be brought again later. Variable "unsigning" (that is,

Re: svn commit: r328340 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

On Wed, 24 Jan 2018, Pedro F. Giffuni wrote: Log: Revert r327781, r328093, r328056: ufs|ext2fs: Revert uses of mallocarray(9). These aren't really useful: drop them. Variable unsigning will be brought again later. Variable "unsigning" (that is, adding unsign extension bugs) is even more

svn commit: r328396 - head/share/man/man8

Author: emaste Date: Thu Jan 25 14:36:47 2018 New Revision: 328396 URL: https://svnweb.freebsd.org/changeset/base/328396 Log: uefi.8: describe architecture-specific default path Sponsored by: The FreeBSD Foundation Modified: head/share/man/man8/uefi.8 Modified:

svn commit: r328395 - head/share/man/man8

Author: emaste Date: Thu Jan 25 13:51:20 2018 New Revision: 328395 URL: https://svnweb.freebsd.org/changeset/base/328395 Log: Install uefi.8 also on arm64 Our standard boot method for arm64 is via UEFI, so install the man page that describes the boot process. MFC after:1 week

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

On Wed, 24 Jan 2018, Conrad Meyer wrote: On Wed, Jan 24, 2018 at 10:05 AM, Warner Losh wrote: ... Let's start with his point about u_long vs size_t causing problems: void*malloc(unsigned long size, struct malloc_type *type, int flags) vs void*mallocarray(size_t

svn commit: r328394 - head/sys/net

Author: wma Date: Thu Jan 25 12:13:41 2018 New Revision: 328394 URL: https://svnweb.freebsd.org/changeset/base/328394 Log: BPF: Switch to 32 bit compatible mode only when thread is 32 bit Sometimes 32 bit and 64 bit ioctls are represented by the same number. It causes unnecessary switch

svn commit: r328393 - head/sbin/fsck_ffs

Author: lwhsu (ports committer) Date: Thu Jan 25 08:36:19 2018 New Revision: 328393 URL: https://svnweb.freebsd.org/changeset/base/328393 Log: Fix architectures where pointer and u_int have different sizes Reviewed by: imp Differential Revision:https://reviews.freebsd.org/D14049