svn commit: r351450 - in head/tests/sys/netpfil: common pf

2019-08-23 Thread Li-Wen Hsu
Author: lwhsu Date: Sat Aug 24 01:28:39 2019 New Revision: 351450 URL: https://svnweb.freebsd.org/changeset/base/351450 Log: Fix failure test cases after r351423 due to ping6(8) options changed Failure test cases: sys.netpfil.common.pass_block.pf_v6

svn commit: r351449 - in stable: 11/sys/amd64/amd64 11/sys/i386/i386 12/sys/amd64/amd64 12/sys/i386/i386

2019-08-23 Thread John Baldwin
Author: jhb Date: Sat Aug 24 00:35:59 2019 New Revision: 351449 URL: https://svnweb.freebsd.org/changeset/base/351449 Log: MFC 350551: Don't reset memory attributes when mapping physical addresses for ACPI. Previously, AcpiOsMemory was using pmap_mapbios which would always map the

svn commit: r351449 - in stable: 11/sys/amd64/amd64 11/sys/i386/i386 12/sys/amd64/amd64 12/sys/i386/i386

2019-08-23 Thread John Baldwin
Author: jhb Date: Sat Aug 24 00:35:59 2019 New Revision: 351449 URL: https://svnweb.freebsd.org/changeset/base/351449 Log: MFC 350551: Don't reset memory attributes when mapping physical addresses for ACPI. Previously, AcpiOsMemory was using pmap_mapbios which would always map the

svn commit: r351448 - in head/sys: kern vm

2019-08-23 Thread Mateusz Guzik
Author: mjg Date: Sat Aug 24 00:01:19 2019 New Revision: 351448 URL: https://svnweb.freebsd.org/changeset/base/351448 Log: Remove the obsolete pcpu_zone_ptr zone. It was only used by flowtable (removed in r321618). Sponsored by: The FreeBSD Foundation Modified:

svn commit: r351447 - head/sys/dev/nvme

2019-08-23 Thread Warner Losh
Author: imp Date: Fri Aug 23 22:52:58 2019 New Revision: 351447 URL: https://svnweb.freebsd.org/changeset/base/351447 Log: It turns out the duplication is only mostly harmless. While it worked with the kenrel, it wasn't working with the loader. It failed to handle dependencies correctly.

svn commit: r351446 - head/sys/dev/cxgbe/tom

2019-08-23 Thread Navdeep Parhar
Author: np Date: Fri Aug 23 22:41:16 2019 New Revision: 351446 URL: https://svnweb.freebsd.org/changeset/base/351446 Log: cxgbe/t4_tom: Any invalid scaling factor in the hardware's wsf field implies that window scaling is not in use. MFC after:3 days Sponsored by: Chelsio

svn commit: r351445 - head/sys/dev/cxgbe/tom

2019-08-23 Thread Navdeep Parhar
Author: np Date: Fri Aug 23 22:34:14 2019 New Revision: 351445 URL: https://svnweb.freebsd.org/changeset/base/351445 Log: whitespace nit. Modified: head/sys/dev/cxgbe/tom/t4_listen.c Modified: head/sys/dev/cxgbe/tom/t4_listen.c

svn commit: r351444 - head/sys/dev/cxgbe

2019-08-23 Thread Navdeep Parhar
Author: np Date: Fri Aug 23 22:22:34 2019 New Revision: 351444 URL: https://svnweb.freebsd.org/changeset/base/351444 Log: cxgbe(4): Use the same buffer size for TOE rx queues as the NIC rx queues. This is a minor simplification. MFC after:1 week Sponsored by: Chelsio

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Warner Losh
On Fri, Aug 23, 2019 at 12:26 PM Conrad Meyer wrote: > At expected peril of wading into a thread >4 emails deep, > > @Warner, modern GCC reports a similar warning; it just doesn't become > an error (at least in CI?). I'm not sure of the mechanism. Maybe > CI-specific? Old GCC didn't have a

svn commit: r351440 - head/sbin/ping

2019-08-23 Thread Alan Somers
Author: asomers Date: Fri Aug 23 22:04:26 2019 New Revision: 351440 URL: https://svnweb.freebsd.org/changeset/base/351440 Log: ping: Fix alignment errors This fixes -Wcast-align errors when compiled with WARNS=6. Submitted by: Ján Sučan MFC after:2 weeks Sponsored by: Google

svn commit: r351439 - in stable/11/sys/amd64: amd64 include pci

2019-08-23 Thread John Baldwin
Author: jhb Date: Fri Aug 23 22:03:50 2019 New Revision: 351439 URL: https://svnweb.freebsd.org/changeset/base/351439 Log: MFC 339432: Do not flush cache for PCIe config window. Apparently AMD machines cannot tolerate this. This was uncovered by r339386, where cache flush started really

svn commit: r351438 - head/sys/sys

2019-08-23 Thread Mateusz Guzik
Author: mjg Date: Fri Aug 23 21:05:37 2019 New Revision: 351438 URL: https://svnweb.freebsd.org/changeset/base/351438 Log: vfs: assert the lock held in MNT_REF/MNT_REL Sponsored by: The FreeBSD Foundation Modified: head/sys/sys/mount.h Modified: head/sys/sys/mount.h

svn commit: r351437 - head/sys/vm

2019-08-23 Thread Mark Johnston
Author: markj Date: Fri Aug 23 19:53:11 2019 New Revision: 351437 URL: https://svnweb.freebsd.org/changeset/base/351437 Log: Stop clearing page flags in vm_page_pqbatch_submit(). All existing callers guarantee that the page does not have a pre-existing dequeue pending. Thus, if the page

svn commit: r351436 - head/sys/vm

2019-08-23 Thread Mark Johnston
Author: markj Date: Fri Aug 23 19:49:29 2019 New Revision: 351436 URL: https://svnweb.freebsd.org/changeset/base/351436 Log: Make vm_pqbatch_submit_page() externally visible. It will become useful for the page daemon to be able to directly create a batch queue entry for a page, and

svn commit: r351435 - in head/sys: kern sys ufs/ffs

2019-08-23 Thread Konstantin Belousov
Author: kib Date: Fri Aug 23 19:40:10 2019 New Revision: 351435 URL: https://svnweb.freebsd.org/changeset/base/351435 Log: De-commision the MNTK_NOINSMNTQ kernel mount flag. After all the changes, its dynamic scope is same as for MNTK_UNMOUNT, but to allow the syncer vnode to be

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Conrad Meyer
At expected peril of wading into a thread >4 emails deep, @Warner, modern GCC reports a similar warning; it just doesn't become an error (at least in CI?). I'm not sure of the mechanism. Maybe CI-specific? Old GCC didn't have a -Wno-error for -Wcast-qual, so -Wcast-qual + -Werror there

svn commit: r351434 - head/sys/conf

2019-08-23 Thread John Baldwin
Author: jhb Date: Fri Aug 23 18:26:34 2019 New Revision: 351434 URL: https://svnweb.freebsd.org/changeset/base/351434 Log: Fix universe to include arm LINT kernel configs. Strip comments from the NOTES.armv[57] files as is done for other NOTES files when building the corresponding LINT

svn commit: r351433 - stable/11/contrib/telnet/telnetd

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 17:43:41 2019 New Revision: 351433 URL: https://svnweb.freebsd.org/changeset/base/351433 Log: MFC r331074 (cem): telnetd(8): Fix dereference of uninitialized value 'IF' Reported by: Coverity Modified: stable/11/contrib/telnet/telnetd/telnetd.c Directory

svn commit: r351432 - in stable/11/contrib/telnet: arpa libtelnet telnet telnetd

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 17:40:47 2019 New Revision: 351432 URL: https://svnweb.freebsd.org/changeset/base/351432 Log: MFC r351070: telnet: remove 3rd clause from Berkeley copyrights Per the July 22, 1999 letter (in /COPYRIGHT) from William Hoskins Director, Office of Technology

svn commit: r351431 - in stable/12/contrib/telnet: arpa libtelnet telnet telnetd

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 17:39:59 2019 New Revision: 351431 URL: https://svnweb.freebsd.org/changeset/base/351431 Log: MFC r351070: telnet: remove 3rd clause from Berkeley copyrights Per the July 22, 1999 letter (in /COPYRIGHT) from William Hoskins Director, Office of Technology

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Bjoern A. Zeeb
On 23 Aug 2019, at 16:48, Warner Losh wrote: On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb wrote: On 23 Aug 2019, at 15:53, Warner Losh wrote: Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Warner Losh
On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb wrote: > On 23 Aug 2019, at 15:53, Warner Losh wrote: > > > Sorry for top posting... > > > > I had planned this for next week, but I think give this insanity of > > this > > patch, we should do it now: turn off -Werror for gcc 4.2.1 > > > >

Re: svn commit: r351429 - head/sys/conf

2019-08-23 Thread Enji Cooper
> On Aug 23, 2019, at 09:45, Enji Cooper wrote: > > >> On Aug 23, 2019, at 09:42, Warner Losh wrote: >> >> Author: imp >> Date: Fri Aug 23 16:42:04 2019 >> New Revision: 351429 >> URL: https://svnweb.freebsd.org/changeset/base/351429 >> >> Log: >> Turn off -Werror for gcc 4.2.1 >> >> As

Re: svn commit: r351429 - head/sys/conf

2019-08-23 Thread Enji Cooper
> On Aug 23, 2019, at 09:42, Warner Losh wrote: > > Author: imp > Date: Fri Aug 23 16:42:04 2019 > New Revision: 351429 > URL: https://svnweb.freebsd.org/changeset/base/351429 > > Log: > Turn off -Werror for gcc 4.2.1 > > As part of marching gcc 4.2.1 out of the tree, turn off -Werror on

svn commit: r351430 - head/share/mk

2019-08-23 Thread Warner Losh
Author: imp Date: Fri Aug 23 16:42:39 2019 New Revision: 351430 URL: https://svnweb.freebsd.org/changeset/base/351430 Log: Turn off -Werror for gcc 4.2.1 for userland As discussed on arch@, gcc 4.2.1 is on its way out. Turn off Werror on gcc versions < 5.0 permantly. This will allow

svn commit: r351429 - head/sys/conf

2019-08-23 Thread Warner Losh
Author: imp Date: Fri Aug 23 16:42:04 2019 New Revision: 351429 URL: https://svnweb.freebsd.org/changeset/base/351429 Log: Turn off -Werror for gcc 4.2.1 As part of marching gcc 4.2.1 out of the tree, turn off -Werror on gcc 4.2.1 compiles by default. It generates too many false

svn commit: r351428 - stable/11/usr.bin/vtfontcvt

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 16:26:06 2019 New Revision: 351428 URL: https://svnweb.freebsd.org/changeset/base/351428 Log: vtfontcvt: improve BDF and hex font parsing MFC r348661: vtfontcvt: rework height/width setting Introduce VFNT_MAXDIMENSION to replace bare 128, add

svn commit: r351427 - stable/11/usr.bin/vtfontcvt

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 16:19:58 2019 New Revision: 351427 URL: https://svnweb.freebsd.org/changeset/base/351427 Log: MFC r305815: vtfontcvt: remove superfluous newlines in errx messages Modified: stable/11/usr.bin/vtfontcvt/vtfontcvt.c Directory Properties: stable/11/ (props

svn commit: r351426 - stable/12/usr.bin/vtfontcvt

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 16:18:25 2019 New Revision: 351426 URL: https://svnweb.freebsd.org/changeset/base/351426 Log: vtfontcvt: improve BDF and hex font parsing MFC r348661: vtfontcvt: rework height/width setting Introduce VFNT_MAXDIMENSION to replace bare 128, add

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Bjoern A. Zeeb
On 23 Aug 2019, at 15:53, Warner Losh wrote: Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror for gcc 4.2.1 https://reviews.freebsd.org/D21378 has the review. There's no benefit to these

Re: svn commit: r351391 - head/tests/sys/netpfil/pf

2019-08-23 Thread Kristof Provost
On 22 Aug 2019, at 14:08, Li-Wen Hsu wrote: Author: lwhsu Date: Thu Aug 22 12:08:35 2019 New Revision: 351391 URL: https://svnweb.freebsd.org/changeset/base/351391 Log: Fix path issues after r351212 This fixes sys.netpfil.pf.forward.v4 and sys.netpfil.pf.icmp.cve_2019_5598 failures in

svn commit: r351425 - head/usr.bin/vtfontcvt

2019-08-23 Thread Ed Maste
Author: emaste Date: Fri Aug 23 16:03:23 2019 New Revision: 351425 URL: https://svnweb.freebsd.org/changeset/base/351425 Log: vtfontcvt: simplify rshift_row We don't need to specify the buffer size in both bytes and bits. MFC after:1 week Sponsored by: The FreeBSD Foundation

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Warner Losh
Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror for gcc 4.2.1 https://reviews.freebsd.org/D21378 has the review. There's no benefit to these head-scratcher changes when we can get the same benefit by

svn commit: r351424 - head/sbin/ping

2019-08-23 Thread Alan Somers
Author: asomers Date: Fri Aug 23 15:24:18 2019 New Revision: 351424 URL: https://svnweb.freebsd.org/changeset/base/351424 Log: ping: fix include guard symbol name to reflect the header file name Submitted by: Ján Sučan MFC after:2 weeks MFC-With: 351171 Sponsored by: Google

svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests

2019-08-23 Thread Alan Somers
functionality run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) +20190823: + Several of ping6's options have been renamed for better consistency + with ping. If you use any of -ARWXaghmrtwx, you must update your + scripts. See ping6(8) for details. +

svn commit: r351422 - head/usr.sbin/pciconf

2019-08-23 Thread Alexander Motin
Author: mav Date: Fri Aug 23 15:17:04 2019 New Revision: 351422 URL: https://svnweb.freebsd.org/changeset/base/351422 Log: Report Clock Power Management support and status. Since we already report ASPM, why not to go further. MFC after:2 weeks Sponsored by: iXsystems, Inc.

svn commit: r351421 - head/tests/sys/netpfil/common

2019-08-23 Thread Kristof Provost
Author: kp Date: Fri Aug 23 12:11:46 2019 New Revision: 351421 URL: https://svnweb.freebsd.org/changeset/base/351421 Log: netpfil tests: Add forward test for the three firewalls Submitted by: Ahsan Barkati Reviewed by: kp Sponsored by: Google, Inc. (GSoC 2019) Differential Revision:

Re: svn commit: r351413 - head/usr.bin/last

2019-08-23 Thread Eugene Grosbein
23.08.2019 17:38, Eugene Grosbein wrote: >> Should this be done more generally? Last time I looked it seemed like >> libxo was completely locale-unaware and just assumed all input was >> UTF-8. It might make more sense to have libxo take locale into >> account when formatting %s strings. > >

Re: svn commit: r351413 - head/usr.bin/last

2019-08-23 Thread Eugene Grosbein
23.08.2019 10:01, Conrad Meyer wrote: > Should this be done more generally? Last time I looked it seemed like > libxo was completely locale-unaware and just assumed all input was > UTF-8. It might make more sense to have libxo take locale into > account when formatting %s strings. libxo is

svn commit: r351420 - stable/11/sys/netinet

2019-08-23 Thread Andrey V. Elsukov
Author: ae Date: Fri Aug 23 10:12:42 2019 New Revision: 351420 URL: https://svnweb.freebsd.org/changeset/base/351420 Log: MFC r350974: Save ip_ttl value and restore it after checksum calculation. Since ipvoly is used for checksum calculation, part of original IP header is zeroed.

svn commit: r351419 - stable/12/sys/netinet

2019-08-23 Thread Andrey V. Elsukov
Author: ae Date: Fri Aug 23 10:11:10 2019 New Revision: 351419 URL: https://svnweb.freebsd.org/changeset/base/351419 Log: MFC r350974: Since ipvoly is used for checksum calculation, part of original IP header is zeroed. This part includes ip_ttl field, that can be used later in

svn commit: r351418 - head/sys/netgraph

2019-08-23 Thread Xin LI
Author: delphij Date: Fri Aug 23 07:24:36 2019 New Revision: 351418 URL: https://svnweb.freebsd.org/changeset/base/351418 Log: Convert ng_deflate to use new zlib. This removes the last consumer of the modified zlib originally bundled with Paul's PPP implementation, which will be removed

svn commit: r351417 - head/sys/kern

2019-08-23 Thread Xin LI
Author: delphij Date: Fri Aug 23 06:39:40 2019 New Revision: 351417 URL: https://svnweb.freebsd.org/changeset/base/351417 Log: INVARIANTS: treat LA_LOCKED as the same of LA_XLOCKED in mtx_assert. The Linux lockdep API assumes LA_LOCKED semantic in lockdep_assert_held(), meaning that