Re: svn commit: r352658 - head/sys/kern

2019-09-24 Thread Peter Holm
On Tue, Sep 24, 2019 at 08:01:20PM +, Alexander Motin wrote: > Author: mav > Date: Tue Sep 24 20:01:20 2019 > New Revision: 352658 > URL: https://svnweb.freebsd.org/changeset/base/352658 > > Log: > Fix/improve interrupt threads scheduling. > > Doing some tests with very high interrupt

svn commit: r352668 - in head/usr.sbin/cron: cron crontab lib

2019-09-24 Thread Kyle Evans
Author: kevans Date: Wed Sep 25 02:37:40 2019 New Revision: 352668 URL: https://svnweb.freebsd.org/changeset/base/352668 Log: cron: add log suppression and mail suppression for successful runs This commit adds two new extensions to crontab, ported from OpenBSD: - -n: suppress mail on

svn commit: r352667 - head/sys/powerpc/include

2019-09-24 Thread Justin Hibbits
Author: jhibbits Date: Wed Sep 25 01:39:58 2019 New Revision: 352667 URL: https://svnweb.freebsd.org/changeset/base/352667 Log: powerpc/atomic: Follow recommendations on atomic primitive comparisons Both IBM and Freescale programming examples presume the cmpset operands will favor equal,

Re: svn commit: r352662 - head/usr.sbin/freebsd-update

2019-09-24 Thread Kubilay Kocak
On 25/09/2019 6:49 am, Michael Gmelin wrote: Author: grembo (ports committer) Date: Tue Sep 24 20:49:33 2019 New Revision: 352662 URL: https://svnweb.freebsd.org/changeset/base/352662 Log: freebsd-update: Add `updatesready' and `showconfig' commands `freebsd-update updatesready' can

svn commit: r352666 - head/sys/powerpc/powerpc

2019-09-24 Thread Justin Hibbits
Author: jhibbits Date: Wed Sep 25 01:23:08 2019 New Revision: 352666 URL: https://svnweb.freebsd.org/changeset/base/352666 Log: powerpc: Allocate DPCPU block from domain-local memory This should improve NUMA scalability a little, by binding to the CPU's NUMA domain. This matches what's

svn commit: r352665 - head/sbin/nvmecontrol

2019-09-24 Thread Warner Losh
Author: imp Date: Wed Sep 25 00:24:57 2019 New Revision: 352665 URL: https://svnweb.freebsd.org/changeset/base/352665 Log: After my comnd changes, the number of threads and size weren't set. In addition, the flags are optional, but were made to be mandatory. Set these things, as well as

svn commit: r352664 - in head/sys/fs: nfs nfsclient

2019-09-24 Thread Rick Macklem
Author: rmacklem Date: Tue Sep 24 23:38:10 2019 New Revision: 352664 URL: https://svnweb.freebsd.org/changeset/base/352664 Log: Replace all mtx_lock()/mtx_unlock() on the iod lock with macros. Since the NFS node mutex needs to change to an sx lock so it can be held when

svn commit: r352663 - head/sys/conf

2019-09-24 Thread Jung-uk Kim
Author: jkim Date: Tue Sep 24 21:41:19 2019 New Revision: 352663 URL: https://svnweb.freebsd.org/changeset/base/352663 Log: Fix white spaces. Modified: head/sys/conf/files Modified: head/sys/conf/files == ---

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Bruce Evans
On Tue, 24 Sep 2019, Randall Stewart wrote: Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. You mean "Don't use K declarations. clang is too broken to warn about K declarations even

svn commit: r352662 - head/usr.sbin/freebsd-update

2019-09-24 Thread Michael Gmelin
Author: grembo (ports committer) Date: Tue Sep 24 20:49:33 2019 New Revision: 352662 URL: https://svnweb.freebsd.org/changeset/base/352662 Log: freebsd-update: Add `updatesready' and `showconfig' commands `freebsd-update updatesready' can be used to check if there are any pending fetched

svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Randall Stewart
Author: rrs Date: Tue Sep 24 20:36:43 2019 New Revision: 352661 URL: https://svnweb.freebsd.org/changeset/base/352661 Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. Obtained from:

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Randall Stewart via svn-src-all
Hmm It looks like BBR needs an update too since it calls the inpcb detach of the ratelimit function too… I may need to reassess this since it should use only the tcp_ratelimit interfaces… but for now an simple ifdef will work make sure to pick up r352660 (and actually it might be best to

svn commit: r352660 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Randall Stewart
Author: rrs Date: Tue Sep 24 20:11:55 2019 New Revision: 352660 URL: https://svnweb.freebsd.org/changeset/base/352660 Log: don't call in_ratelmit detach when RATELIMIT is not compiled in the kernel. Modified: head/sys/netinet/tcp_stacks/bbr.c Modified: head/sys/netinet/tcp_stacks/bbr.c

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Randall Stewart via svn-src-all
Right Thats because GENERIC does not add the optional TCP stacks. Ok the problem is fixed with r352659 The tcp_ratelimit.h had a mixed up ifdef i.e. #ifdef RATELIMIT #ifdef _KERNEL definitions #else macro definitions that return error #endif #endif Which should have been the opposite

svn commit: r352659 - head/sys/netinet

2019-09-24 Thread Randall Stewart
Author: rrs Date: Tue Sep 24 20:04:31 2019 New Revision: 352659 URL: https://svnweb.freebsd.org/changeset/base/352659 Log: Fix the ifdefs in tcp_ratelimit.h. They were reversed so that instead of functions only being inside the _KERNEL and the absence of RATELIMIT causing us to have

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Randall Stewart via svn-src-all
Ok I have found it Its a reversal in an ifdef in tcp_ratelimit.h .. it supposed to be that if its not define (RATELIMIT) the main interfaces return errors.. and the ifdef kernel/ratelimit is reversed of what it should be. Let me fix that :) R > On Sep 24, 2019, at 12:55 PM, Randall Stewart

svn commit: r352658 - head/sys/kern

2019-09-24 Thread Alexander Motin
Author: mav Date: Tue Sep 24 20:01:20 2019 New Revision: 352658 URL: https://svnweb.freebsd.org/changeset/base/352658 Log: Fix/improve interrupt threads scheduling. Doing some tests with very high interrupt rates I've noticed that one of conditions I added in r232207 to make interrupt

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Li-Wen Hsu
I mean the head (r352657) world and GENERIC kernel can be built successfully on 12.0-R, which is we guaranteed. Also the LINT kernel build is fine on CI: https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/13781/ So I was curious about the build environment of that build failure. Best, Li-Wen On

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Randall Stewart via svn-src-all
12.0R would not have BBR .. its only in head… hmm it could be a issue with TCP_RATELIMIT not defined though I did compile GENERIC without the extra stacks (and without rate limit and hpts) and that compiled ok.. R > On Sep 24, 2019, at 12:49 PM, Li-Wen Hsu wrote: > > On Tue, Sep 24, 2019 at

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Randall Stewart via svn-src-all
This is strange I built this and have it running on my machine with the standard make buildkern KERNCONF=myconf and make installkern KERNCONF=myconf Why can I build and it blow up.. last time I saw this I was building in amd64/compile and was getting a warning that somehow is an error.. but

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Li-Wen Hsu
On Tue, Sep 24, 2019 at 9:29 PM O. Hartmann wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Am Tue, 24 Sep 2019 18:18:11 + (UTC) > Randall Stewart schrieb: > > > Author: rrs > > Date: Tue Sep 24 18:18:11 2019 > > New Revision: 352657 > > URL:

Re: svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread O. Hartmann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Am Tue, 24 Sep 2019 18:18:11 + (UTC) Randall Stewart schrieb: > Author: rrs > Date: Tue Sep 24 18:18:11 2019 > New Revision: 352657 > URL: https://svnweb.freebsd.org/changeset/base/352657 > > Log: > This commit adds BBR (Bottleneck

svn commit: r352657 - in head/sys: conf kern modules/tcp modules/tcp/bbr netinet netinet/tcp_stacks sys

2019-09-24 Thread Randall Stewart
Author: rrs Date: Tue Sep 24 18:18:11 2019 New Revision: 352657 URL: https://svnweb.freebsd.org/changeset/base/352657 Log: This commit adds BBR (Bottleneck Bandwidth and RTT) congestion control. This is a completely separate TCP stack (tcp_bbr.ko) that will be built only if you add the make

svn commit: r352656 - head/sys/dev/ixgbe

2019-09-24 Thread Eric Joyner
Author: erj Date: Tue Sep 24 17:06:32 2019 New Revision: 352656 URL: https://svnweb.freebsd.org/changeset/base/352656 Log: ix, ixv: Read msix_bar from device configuration Instead of predicting the MSI-X bar index based on the device's MAC type, read it from the device's PCI

svn commit: r352655 - head/sys/net

2019-09-24 Thread Eric Joyner
Author: erj Date: Tue Sep 24 17:03:31 2019 New Revision: 352655 URL: https://svnweb.freebsd.org/changeset/base/352655 Log: iflib: Remove redundant VLAN events deregistration From Piotr: r351152 introduced iflib_deregister() function calling EVENTHANDLER_DEREGISTER() to unregister VLAN

svn commit: r352654 - head/sys/dev/pccard

2019-09-24 Thread Olivier Cochard
Author: olivier (ports committer) Date: Tue Sep 24 16:49:42 2019 New Revision: 352654 URL: https://svnweb.freebsd.org/changeset/base/352654 Log: Fix a minor typo Approved by: lwhsu MFC after:1 month Sponsored by: Netflix Differential Revision:

svn commit: r352653 - head/tests/sys/kern

2019-09-24 Thread Olivier Cochard
Author: olivier (ports committer) Date: Tue Sep 24 16:45:34 2019 New Revision: 352653 URL: https://svnweb.freebsd.org/changeset/base/352653 Log: Fix coredump_phnum_test in case of kern.compress_user_cores=1 PR: 240783 Approved by: ngie, lwhsu MFC after:1 month

svn commit: r352652 - head/sys/netinet

2019-09-24 Thread Michael Tuexen
Author: tuexen Date: Tue Sep 24 13:15:24 2019 New Revision: 352652 URL: https://svnweb.freebsd.org/changeset/base/352652 Log: Plumb a memory leak. Thnanks to Felix Weinrank for finding this issue using fuzz testing and reporting it for the userland stack:

svn commit: r352651 - head/lib/libc/regex

2019-09-24 Thread Yuri Pankov
Author: yuripv Date: Tue Sep 24 12:21:01 2019 New Revision: 352651 URL: https://svnweb.freebsd.org/changeset/base/352651 Log: lib/libc/regex: fix build with REDEBUG defined Reviewed by: kevans Differential Revision:https://reviews.freebsd.org/D21760 Modified:

svn commit: r352650 - stable/11/sbin/ifconfig

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:37:01 2019 New Revision: 352650 URL: https://svnweb.freebsd.org/changeset/base/352650 Log: MFC r352459: ifconfig: add report of the string from SIOCGIFDOWNREASON. Sponsored by: Mellanox Technologies Modified: stable/11/sbin/ifconfig/ifmedia.c Directory

svn commit: r352649 - in stable/11/sys: net sys

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:36:25 2019 New Revision: 352649 URL: https://svnweb.freebsd.org/changeset/base/352649 Log: MFC r352458: Add SIOCGIFDOWNREASON. Sponsored by: Mellanox Technologies Modified: stable/11/sys/net/if.c stable/11/sys/net/if.h stable/11/sys/sys/sockio.h

svn commit: r352648 - stable/12/sbin/ifconfig

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:31:56 2019 New Revision: 352648 URL: https://svnweb.freebsd.org/changeset/base/352648 Log: MFC r352459: ifconfig: add report of the string from SIOCGIFDOWNREASON. Sponsored by: Mellanox Technologies Modified: stable/12/sbin/ifconfig/ifmedia.c Directory

svn commit: r352647 - in stable/12/sys: net sys

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:30:34 2019 New Revision: 352647 URL: https://svnweb.freebsd.org/changeset/base/352647 Log: MFC r352458: Add SIOCGIFDOWNREASON. Sponsored by: Mellanox Technologies Modified: stable/12/sys/net/if.c stable/12/sys/net/if.h stable/12/sys/sys/sockio.h

svn commit: r352646 - stable/11/contrib/jemalloc/src

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:23:38 2019 New Revision: 352646 URL: https://svnweb.freebsd.org/changeset/base/352646 Log: MFC r352456: realloc(x, 0) should not return NULL. PR: 240456 Modified: stable/11/contrib/jemalloc/src/jemalloc.c Directory Properties: stable/11/ (props

svn commit: r352645 - in stable/11: lib/libc/sys sys/kern

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:21:48 2019 New Revision: 352645 URL: https://svnweb.freebsd.org/changeset/base/352645 Log: MFC r352455: Return EISDIR when directory is opened with O_CREAT without O_DIRECTORY. PR: 240452 Modified: stable/11/lib/libc/sys/open.2

svn commit: r352644 - stable/12/contrib/jemalloc/src

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:19:41 2019 New Revision: 352644 URL: https://svnweb.freebsd.org/changeset/base/352644 Log: MFC r352456: realloc(x, 0) should not return NULL. PR: 240456 Modified: stable/12/contrib/jemalloc/src/jemalloc.c Directory Properties: stable/12/ (props

svn commit: r352643 - in stable/12: lib/libc/sys sys/kern

2019-09-24 Thread Konstantin Belousov
Author: kib Date: Tue Sep 24 06:18:48 2019 New Revision: 352643 URL: https://svnweb.freebsd.org/changeset/base/352643 Log: MFC r352455: Return EISDIR when directory is opened with O_CREAT without O_DIRECTORY. PR: 240452 Modified: stable/12/lib/libc/sys/open.2