Author: tsoome
Date: Mon Nov 4 06:35:48 2019
New Revision: 354330
URL: https://svnweb.freebsd.org/changeset/base/354330
Log:
MFC r354237:
loader: asprinf does crash arm64 due to missing NULL pointer check
PCHAR macro needs to check if d is NULL.
Modified:
> On 4. Nov 2019, at 03:42, Alexander Motin wrote:
>
> On 03.11.2019 20:19, Xin Li wrote:
>> On 2019-11-03 15:30, Ravi Pokala wrote:
>>> Uh
>>>
>>> I've had a log device in my boot-pool for months, and have booted without
>>> issue:
>>>
>>>[threepio:~] rpokala% zpool status zroot
Author: kevans
Date: Mon Nov 4 03:07:01 2019
New Revision: 354328
URL: https://svnweb.freebsd.org/changeset/base/354328
Log:
patch(1): give /dev/null patches special treatment
We have a bad habit of duplicating contents of files that are sourced from
/dev/null and applied more than
Author: wulf
Date: Mon Nov 4 02:29:58 2019
New Revision: 354327
URL: https://svnweb.freebsd.org/changeset/base/354327
Log:
[ig4] Try to workaround MIPS namespace pollution issue
Modified:
head/sys/dev/ichiic/ig4_iic.c
Modified: head/sys/dev/ichiic/ig4_iic.c
On 03.11.2019 20:19, Xin Li wrote:
> On 2019-11-03 15:30, Ravi Pokala wrote:
>> Uh
>>
>> I've had a log device in my boot-pool for months, and have booted without
>> issue:
>>
>> [threepio:~] rpokala% zpool status zroot
>> pool: zroot
>> state: ONLINE
>> scan: scrub
On 2019-11-03 13:32, Toomas Soome wrote:
>
>
>> On 3. Nov 2019, at 22:39, Kevin Bowling wrote:
>>
>> I believe this is/was a common configuration, at least the few
>> spinning disk based systems I have left have a slog.
>>
>
> On boot pool? um. well, I’ll kick out that return then.
I think
(chosen a random message)
On 2019-11-03 15:30, Ravi Pokala wrote:
> Uh
>
> I've had a log device in my boot-pool for months, and have booted without
> issue:
>
> [threepio:~] rpokala% zpool status zroot
> pool: zroot
> state: ONLINE
> scan: scrub repaired 0 in 0 days
Author: jhibbits
Date: Mon Nov 4 00:35:40 2019
New Revision: 354326
URL: https://svnweb.freebsd.org/changeset/base/354326
Log:
powerpc/pmap: Make use of tlb1_mapin_region in pmap_mapdev_attr()
tlb1_mapin_region() and pmap_mapdev_attr() do roughly the same thing -- map
a chunk of
Uh
I've had a log device in my boot-pool for months, and have booted without issue:
[threepio:~] rpokala% zpool status zroot
pool: zroot
state: ONLINE
scan: scrub repaired 0 in 0 days 00:04:36 with 0 errors on Mon Oct 28
03:10:59 2019
config:
NAME
Pretty sure we had at least two systems using root with log just fine, so
would be interested to know why this isn’t supported anymore?
On Sun, 3 Nov 2019 at 13:26, Toomas Soome wrote:
> Author: tsoome
> Date: Sun Nov 3 13:25:47 2019
> New Revision: 354283
> URL:
On Mon, Nov 04, 2019 at 01:46:14AM +0300, Vladimir Kondratyev wrote:
> On 04.11.2019 01:02, Konstantin Belousov wrote:
> > On Sun, Nov 03, 2019 at 09:17:51PM +, Vladimir Kondratyev wrote:
> >> Author: wulf
> >> Date: Sun Nov 3 21:17:50 2019
> >> New Revision: 354322
> >> URL:
On Sun, 2019-11-03 at 21:17 +, Vladimir Kondratyev wrote:
> Author: wulf
> Date: Sun Nov 3 21:17:50 2019
> New Revision: 354322
> URL: https://svnweb.freebsd.org/changeset/base/354322
>
> Log:
> [ig4] Convert ithread interrupt handler to filter based one.
>
This doesn't seem like a very
On 04.11.2019 01:02, Konstantin Belousov wrote:
> On Sun, Nov 03, 2019 at 09:17:51PM +, Vladimir Kondratyev wrote:
>> Author: wulf
>> Date: Sun Nov 3 21:17:50 2019
>> New Revision: 354322
>> URL: https://svnweb.freebsd.org/changeset/base/354322
>>
>> Log:
>> [ig4] Convert ithread interrupt
Author: andrew
Date: Sun Nov 3 22:17:49 2019
New Revision: 354325
URL: https://svnweb.freebsd.org/changeset/base/354325
Log:
Move the struct debug_monitor_state out of _KERNEL.
Some userland libraries incude machine/pcb.h and this needs the full
definition of struct debug_monitor_state.
On Sun, Nov 03, 2019 at 09:17:51PM +, Vladimir Kondratyev wrote:
> Author: wulf
> Date: Sun Nov 3 21:17:50 2019
> New Revision: 354322
> URL: https://svnweb.freebsd.org/changeset/base/354322
>
> Log:
> [ig4] Convert ithread interrupt handler to filter based one.
And why ?
You need some
On 03/11/2019 23:36, Toomas Soome wrote:
> Author: tsoome
> Date: Sun Nov 3 21:36:29 2019
> New Revision: 354324
> URL: https://svnweb.freebsd.org/changeset/base/354324
>
> Log:
> loader: allow booting from pool with log device
>
> Apparently people are using log with boot pool, so we can
Author: tsoome
Date: Sun Nov 3 21:36:29 2019
New Revision: 354324
URL: https://svnweb.freebsd.org/changeset/base/354324
Log:
loader: allow booting from pool with log device
Apparently people are using log with boot pool, so we can not just
error out there. Still we will need to
Yes, some systems with two disks in a mirror and an ssd as slog.
What are you trying to guard against? I have never seen an issue but would
like to be aware of potential problems with that system.
On Sun, Nov 3, 2019 at 2:32 PM Toomas Soome wrote:
>
>
> > On 3. Nov 2019, at 22:39, Kevin
Author: wulf
Date: Sun Nov 3 21:17:01 2019
New Revision: 354321
URL: https://svnweb.freebsd.org/changeset/base/354321
Log:
[ig4] Enable additional registers support on Appolo Lake controllers
To be inline with intel-lpss Linux driver
Modified:
head/sys/dev/ichiic/ig4_var.h
Modified:
Author: alc
Date: Sun Nov 3 17:45:30 2019
New Revision: 354286
URL: https://svnweb.freebsd.org/changeset/base/354286
Log:
Utilize ASIDs to reduce both the direct and indirect costs of context
switching. The indirect costs being unnecessary TLB misses that are
incurred when ASIDs are not
Author: wulf
Date: Sun Nov 3 20:59:04 2019
New Revision: 354307
URL: https://svnweb.freebsd.org/changeset/base/354307
Log:
[ig4] Implement burst mode for data reads
In this mode DATA_CMD register reads and writes are performed in
TX/RX FIFO-sized bursts to increase I2C bus utilization.
Author: vmaffione
Date: Sun Nov 3 19:02:32 2019
New Revision: 354288
URL: https://svnweb.freebsd.org/changeset/base/354288
Log:
bhyve: add backend rx backpressure to virtio-net
If a VM is flooded with more ingress packets than the guest OS
can handle, the current virtio-net code will
Author: wulf
Date: Sun Nov 3 21:03:55 2019
New Revision: 354311
URL: https://svnweb.freebsd.org/changeset/base/354311
Log:
[ig4] Convert last remaining usage of TX_NOTFULL status to TX_EMPTY
in ig4iic_read routine. It makes possible interrupt utilization while
waiting for empty space in
Author: wulf
Date: Sun Nov 3 20:40:55 2019
New Revision: 354292
URL: https://svnweb.freebsd.org/changeset/base/354292
Log:
[ig4] Handle controller startup errors
Fail the attach on controller startup errors. For some reason the
dell xps 13 says there's I2C controller, but the
Author: wulf
Date: Sun Nov 3 21:10:47 2019
New Revision: 354316
URL: https://svnweb.freebsd.org/changeset/base/354316
Log:
[ig4] On SkyLake controllers issue reset on attach unconditionally.
It is very helpful during debugging of I2C issues.
It is done only for SkyLakes due to lack of
Author: wulf
Date: Sun Nov 3 21:16:06 2019
New Revision: 354320
URL: https://svnweb.freebsd.org/changeset/base/354320
Log:
[ig4] Add support for CannonLake controllers
They are clocked at 216MHz rate, much higher than previous models.
PR: 240485
Submitted by: Neel Chauhan
Author: wulf
Date: Sun Nov 3 20:56:53 2019
New Revision: 354305
URL: https://svnweb.freebsd.org/changeset/base/354305
Log:
[ig4] dump IG4_REG_COMP_PARAM1 and IG4_REG_COMP_VER registers unconditionally
They appeared to be supported (although undocumented) on SkyLakes+ too.
Modified:
Author: cem
Date: Sun Nov 3 19:36:34 2019
New Revision: 354290
URL: https://svnweb.freebsd.org/changeset/base/354290
Log:
Take arm.arm (armv5) out of universe
It's on the chopping block in two months, the CI tinderbox doesn't bother with
it anymore either, and buildworld fails today due
Author: wulf
Date: Sun Nov 3 20:53:13 2019
New Revision: 354302
URL: https://svnweb.freebsd.org/changeset/base/354302
Log:
[ig4] Allow enabling of polled mode from iicbus allocation callback
If controller is allocated with IIC_NOWAIT option ig4 enables polled mode
for a period of
Author: tsoome
Date: Sun Nov 3 21:19:52 2019
New Revision: 354323
URL: https://svnweb.freebsd.org/changeset/base/354323
Log:
loader: factor out label and uberblock load from vdev_probe, add MMP checks
Clean up the label read.
Modified:
head/stand/libsa/zfs/zfsimpl.c
Author: wulf
Date: Sun Nov 3 20:39:46 2019
New Revision: 354291
URL: https://svnweb.freebsd.org/changeset/base/354291
Log:
[ig4] Give common name to PCI and ACPI device drivers
They share common device driver code with different bus attachments
This commit starts a bunch of changes
Author: wulf
Date: Sun Nov 3 21:01:53 2019
New Revision: 354309
URL: https://svnweb.freebsd.org/changeset/base/354309
Log:
[ig4] Remove dead code inherited from DragonflyBSD
Modified:
head/sys/dev/ichiic/ig4_iic.c
head/sys/dev/ichiic/ig4_var.h
Modified: head/sys/dev/ichiic/ig4_iic.c
Author: wulf
Date: Sun Nov 3 20:57:59 2019
New Revision: 354306
URL: https://svnweb.freebsd.org/changeset/base/354306
Log:
[ig4] Set clock registers based on controller model
IC clock rates are varied between different controller models so we have
to adjust timing registers in each case
> On 3. Nov 2019, at 19:42, Andriy Gapon wrote:
>
> On 03/11/2019 15:25, Toomas Soome wrote:
>> Author: tsoome
>> Date: Sun Nov 3 13:25:47 2019
>> New Revision: 354283
>> URL: https://svnweb.freebsd.org/changeset/base/354283
>>
>> Log:
>> loader: we do not support booting from pool with log
Author: wulf
Date: Sun Nov 3 21:04:51 2019
New Revision: 354312
URL: https://svnweb.freebsd.org/changeset/base/354312
Log:
[ig4] Use interrupts for waiting for empty TX FIFO
Modified:
head/sys/dev/ichiic/ig4_iic.c
Modified: head/sys/dev/ichiic/ig4_iic.c
Author: wulf
Date: Sun Nov 3 20:45:25 2019
New Revision: 354296
URL: https://svnweb.freebsd.org/changeset/base/354296
Log:
[ig4] Reduce scope of io_lock
Now io_lock is used as condition variable to synchronize active process with
the interrupt handler. It is not used for tasks other
Author: wulf
Date: Sun Nov 3 20:55:28 2019
New Revision: 354304
URL: https://svnweb.freebsd.org/changeset/base/354304
Log:
[cyapa] Postpone start of the polling thread until sleep is available
After recent ig4 changes cyapa driver can be attached before timers
initialization is
Author: cem
Date: Sun Nov 3 19:33:49 2019
New Revision: 354289
URL: https://svnweb.freebsd.org/changeset/base/354289
Log:
armv6: Switch to LLD by default
This could just be ${__TT} == "arm", except armv5 isn't slated for death until
EOY.
arm tinderbox builds. Let's see what else
Author: wulf
Date: Sun Nov 3 21:12:59 2019
New Revision: 354317
URL: https://svnweb.freebsd.org/changeset/base/354317
Log:
[ig4] wait for bus stop condition after stop command issued
It gives better error detection and ig4 driver's lock coverage
in a pipelined write case
Modified:
Author: wulf
Date: Sun Nov 3 20:46:20 2019
New Revision: 354297
URL: https://svnweb.freebsd.org/changeset/base/354297
Log:
[ig4] Ignore stray interrupts
Modified:
head/sys/dev/ichiic/ig4_iic.c
Modified: head/sys/dev/ichiic/ig4_iic.c
> On 3. Nov 2019, at 22:39, Kevin Bowling wrote:
>
> I believe this is/was a common configuration, at least the few
> spinning disk based systems I have left have a slog.
>
On boot pool? um. well, I’ll kick out that return then.
rgds,
toomas
> On Sun, Nov 3, 2019 at 10:55 AM Andriy Gapon
Author: wulf
Date: Sun Nov 3 21:17:50 2019
New Revision: 354322
URL: https://svnweb.freebsd.org/changeset/base/354322
Log:
[ig4] Convert ithread interrupt handler to filter based one.
Modified:
head/sys/dev/ichiic/ig4_iic.c
Modified: head/sys/dev/ichiic/ig4_iic.c
Author: wulf
Date: Sun Nov 3 21:00:55 2019
New Revision: 354308
URL: https://svnweb.freebsd.org/changeset/base/354308
Log:
[ig4] Add suspend/resume support
That is done with re-execution of controller initialization procedure
from resume handler.
PR: 238037
Modified:
Author: wulf
Date: Sun Nov 3 21:15:01 2019
New Revision: 354319
URL: https://svnweb.freebsd.org/changeset/base/354319
Log:
[ig4] Add generic resource methods to bus interface
That allows ig4 children to allocate IRQs
Modified:
head/sys/dev/ichiic/ig4_acpi.c
Author: wulf
Date: Sun Nov 3 21:08:26 2019
New Revision: 354315
URL: https://svnweb.freebsd.org/changeset/base/354315
Log:
[ig4] Set STOP condition and flush TX/RX FIFOs on error
if controller has not it done for us yet.
Reset controller when transfer abort is failed.
Modified:
Author: wulf
Date: Sun Nov 3 20:44:16 2019
New Revision: 354295
URL: https://svnweb.freebsd.org/changeset/base/354295
Log:
[ig4] Do not wait for interrupts in set_controller() routine
Specs shows no dedicated interrupt firing on disable of the controller.
Remove io lock acquisitions
Author: vmaffione
Date: Sun Nov 3 18:53:42 2019
New Revision: 354287
URL: https://svnweb.freebsd.org/changeset/base/354287
Log:
bhyve: fix mistake introduced by r352841
MFC after:1 week
Differential Revision:https://reviews.freebsd.org/D20973
Modified:
Author: wulf
Date: Sun Nov 3 21:14:08 2019
New Revision: 354318
URL: https://svnweb.freebsd.org/changeset/base/354318
Log:
[ig4] Minor improvement of write pipelining
With leaving some data queued in the TX FIFO at the end of write cycle.
Modified:
head/sys/dev/ichiic/ig4_iic.c
Author: wulf
Date: Sun Nov 3 20:50:06 2019
New Revision: 354300
URL: https://svnweb.freebsd.org/changeset/base/354300
Log:
[ig4] disable controller before initialization of clock counters
It is required by controller specifications.
Modified:
head/sys/dev/ichiic/ig4_iic.c
Modified:
Author: wulf
Date: Sun Nov 3 20:51:22 2019
New Revision: 354301
URL: https://svnweb.freebsd.org/changeset/base/354301
Log:
[ig4] Add support for polled mode
Currently ig4 internally depends on it's own interrupts and uses mtx_sleep()
to wait for them. That means it can not be used from
Author: wulf
Date: Sun Nov 3 21:06:06 2019
New Revision: 354313
URL: https://svnweb.freebsd.org/changeset/base/354313
Log:
[ig4] Convert polling loop from status-based to interrupt-based
INTR_STAT register exposes more useful informaton then STA register does
e.g. it exposes error and
Author: wulf
Date: Sun Nov 3 20:42:04 2019
New Revision: 354293
URL: https://svnweb.freebsd.org/changeset/base/354293
Log:
[ig4] Only enable interrupts when we want them. Otherwise keep mask at 0.
This avoids possible interrupt storms, depending on the state of the I2C
controller before
Author: wulf
Date: Sun Nov 3 20:49:04 2019
New Revision: 354299
URL: https://svnweb.freebsd.org/changeset/base/354299
Log:
[ig4] Stop I2C controller after checking that it's kind of functional.
Obtained from:DragonfliBSD (0b3eedb)
Modified:
head/sys/dev/ichiic/ig4_iic.c
Author: wulf
Date: Sun Nov 3 21:03:07 2019
New Revision: 354310
URL: https://svnweb.freebsd.org/changeset/base/354310
Log:
[ig4] Rewrite ig4iic_write routine to use TX_EMPTY status flag
rather than TX_NOTFULL. It makes possible interrupt utilization while
waiting for empty space in TX
I believe this is/was a common configuration, at least the few
spinning disk based systems I have left have a slog.
On Sun, Nov 3, 2019 at 10:55 AM Andriy Gapon wrote:
>
> On 03/11/2019 15:25, Toomas Soome wrote:
> > Author: tsoome
> > Date: Sun Nov 3 13:25:47 2019
> > New Revision: 354283
> >
Author: wulf
Date: Sun Nov 3 21:07:12 2019
New Revision: 354314
URL: https://svnweb.freebsd.org/changeset/base/354314
Log:
[ig4] Improve error detection
Handle error bits of INTR_STAT and TX_ABORT registers.
Move interrupt clearing from interrupt handler to polling loop to get
Author: wulf
Date: Sun Nov 3 20:54:17 2019
New Revision: 354303
URL: https://svnweb.freebsd.org/changeset/base/354303
Log:
[ig4] Do not wait until interrupts are enabled at attach stage
as the driver is fully functional on a cold boot through utilization of
polled mode.
As a side
Author: wulf
Date: Sun Nov 3 20:43:02 2019
New Revision: 354294
URL: https://svnweb.freebsd.org/changeset/base/354294
Log:
[ig4] Drop driver's internal RX FIFO
There is no need to read all controller's RX FIFO data to clear RX_FULL
bit in interrupt handler as interrupts are masked
Author: wulf
Date: Sun Nov 3 20:47:49 2019
New Revision: 354298
URL: https://svnweb.freebsd.org/changeset/base/354298
Log:
[ig4] We actually need to set the Rx threshold register one smaller.
Setting the IG4_REG_RX_TL register to 1 was actually generating an
interrupt after 2 bytes were
On 03/11/2019 15:25, Toomas Soome wrote:
> Author: tsoome
> Date: Sun Nov 3 13:25:47 2019
> New Revision: 354283
> URL: https://svnweb.freebsd.org/changeset/base/354283
>
> Log:
> loader: we do not support booting from pool with log device
>
> If pool has log device, stop there and tell
Author: andrew
Date: Sun Nov 3 15:42:08 2019
New Revision: 354285
URL: https://svnweb.freebsd.org/changeset/base/354285
Log:
Add support for setting hardware breakpoints from ptrace on arm64.
Implement get/fill_dbregs on arm64. This is used by ptrace with the
PT_GETDBREGS and
Author: tsoome
Date: Sun Nov 3 14:36:16 2019
New Revision: 354284
URL: https://svnweb.freebsd.org/changeset/base/354284
Log:
loader: zfs.c is missing malloc checks, fix it
malloc() can return NULL, we need to check the return value.
Modified:
head/stand/libsa/zfs/zfs.c
Modified:
Author: tsoome
Date: Sun Nov 3 13:25:47 2019
New Revision: 354283
URL: https://svnweb.freebsd.org/changeset/base/354283
Log:
loader: we do not support booting from pool with log device
If pool has log device, stop there and tell about it.
Modified:
head/stand/libsa/zfs/zfs.c
Author: tsoome
Date: Sun Nov 3 13:03:47 2019
New Revision: 354282
URL: https://svnweb.freebsd.org/changeset/base/354282
Log:
loader: should check malloc in zfs_dev_open
malloc can return NULL.
Modified:
head/stand/libsa/zfs/zfs.c
Modified: head/stand/libsa/zfs/zfs.c
Author: kib
Date: Sun Nov 3 11:51:53 2019
New Revision: 354280
URL: https://svnweb.freebsd.org/changeset/base/354280
Log:
amd64 ddb: Add printing of kernel/user and saved user %cr3 values from pcpu.
Tested by:pho
Sponsored by: The FreeBSD Foundation
MFC after:1 week
Modified:
Author: kib
Date: Sun Nov 3 11:52:50 2019
New Revision: 354281
URL: https://svnweb.freebsd.org/changeset/base/354281
Log:
amd64: Store %cr3 into pcpu saved_ucr3 on double fault.
Tested by:pho
Sponsored by: The FreeBSD Foundation
MFC after:1 week
Modified:
Author: tsoome
Date: Sun Nov 3 11:09:06 2019
New Revision: 354279
URL: https://svnweb.freebsd.org/changeset/base/354279
Log:
loader: calculate physical vdev psize from asize
Since physical device asize is calculated from psize and the asize is stored
in pool label, we can use asize to
Author: tsoome
Date: Sun Nov 3 09:14:29 2019
New Revision: 354278
URL: https://svnweb.freebsd.org/changeset/base/354278
Log:
loader: userboot/test should accept more than one disk
allow to specify multiple -d options, test -d disk1 -d disk2 ..
Modified:
head/stand/userboot/test/test.c
Author: tsoome
Date: Sun Nov 3 07:11:09 2019
New Revision: 354277
URL: https://svnweb.freebsd.org/changeset/base/354277
Log:
MFC: r354127
loader: zio_checksum_verify should check byteswap
We do have both native and byteswap checksum callbacks in place but the
selection is not
69 matches
Mail list logo
