svn commit: r367702 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-14 Thread Scott Long
Author: scottl Date: Sun Nov 15 07:50:29 2020 New Revision: 367702 URL: https://svnweb.freebsd.org/changeset/base/367702 Log: Fix the previous revision, it suffered from an incomplete change to the getlocalbase API. Also don't erroneously subtract the lenth from the buffer a second time.

svn commit: r367701 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sun Nov 15 07:48:52 2020 New Revision: 367701 URL: https://svnweb.freebsd.org/changeset/base/367701 Log: Because getlocalbase() returns -1 on error, it needs to use a signed type internally. Do that, and make sure that conversations between signed and unsigned don't

svn commit: r367700 - head/sys/kern

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sun Nov 15 01:54:44 2020 New Revision: 367700 URL: https://svnweb.freebsd.org/changeset/base/367700 Log: sched: fix an incorrect comparison in sched_lend_user_prio_cond Compare with sched_lend_user_prio. Modified: head/sys/kern/sched_4bsd.c head/sys/kern/sched_ule.c

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
There are "KBI" breaking changes happening all the time and version bumps only sometimes happen. The build process already has infrastructure to rebuild all port kmods as well -- see PORTS_MODULES in make.conf(5) Perhaps it would be beneficial to add checking that the kernel is older than the

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Warner Losh
true, but a version bump forces that and versions are cheap enough... Warner On Sat, Nov 14, 2020 at 1:58 PM Mateusz Guzik wrote: > you are expected to recompile all your kernel modules every time you > update head > > On 11/14/20, Shawn Webb wrote: > > Are there any kernel modules (in base,

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
Another oversight on my part. I have a fix, it’s trivial, but I’m running a few more tests to be sure this time. Scott > On Nov 14, 2020, at 2:54 PM, Gordon Bergling wrote: > > Hi Scott, > > after r367689 the build was fixed, but on arm64 I get the following error, > when I try to 'pkg

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Gordon Bergling
Hi Scott, after r367689 the build was fixed, but on arm64 I get the following error, when I try to 'pkg upgrade': $ doas pkg upgrade Cannot determine local path $ Is this error somehow related to this change? --Gordon On Sat, Nov 14, 2020 at 11:44:29AM -0700, Scott Long wrote: > Hi, > >

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
you are expected to recompile all your kernel modules every time you update head On 11/14/20, Shawn Webb wrote: > Are there any kernel modules (in base, in ports, or out-of-both-trees) > that access struct ucred? > > On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: >> I don't think

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Shawn Webb
Are there any kernel modules (in base, in ports, or out-of-both-trees) that access struct ucred? On Sat, Nov 14, 2020 at 09:51:47PM +0100, Mateusz Guzik wrote: > I don't think so, it does not change any APIs > > On 11/14/20, Shawn Webb wrote: > > On Sat, Nov 14, 2020 at 07:20:37PM +,

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
I don't think so, it does not change any APIs On 11/14/20, Shawn Webb wrote: > On Sat, Nov 14, 2020 at 07:20:37PM +, Mateusz Guzik wrote: >> Author: mjg >> Date: Sat Nov 14 19:20:37 2020 >> New Revision: 367692 >> URL: https://svnweb.freebsd.org/changeset/base/367692 >> >> Log: >> cred:

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Shawn Webb
On Sat, Nov 14, 2020 at 07:20:37PM +, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 14 19:20:37 2020 > New Revision: 367692 > URL: https://svnweb.freebsd.org/changeset/base/367692 > > Log: > cred: reorder cr_audit to be closer to the lock > > This makes cr_uid avoid sharing. > >

svn commit: r367699 - stable/12/sys/kern

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 20:45:12 2020 New Revision: 367699 URL: https://svnweb.freebsd.org/changeset/base/367699 Log: MFC r366231: Address whitespace nits in subr_rtc.c These were separated out from a nearby patch from Andrew Gierth. Modified: stable/12/sys/kern/subr_rtc.c

svn commit: r367698 - stable/12/release/packages

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 20:44:34 2020 New Revision: 367698 URL: https://svnweb.freebsd.org/changeset/base/367698 Log: MFC r365883: pkgbase: use consistent annotation for object keys Everywhere else we use objects ("scripts", generally) we do specify the optional colon. Be

svn commit: r367697 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:56:11 2020 New Revision: 367697 URL: https://svnweb.freebsd.org/changeset/base/367697 Log: cred: annotate credbatch_process argument as unused Fixes libprocstat compilation as zfs defines _KERNEL. Modified: head/sys/sys/ucred.h Modified:

Re: svn commit: r367689 - head/lib/libutil

2020-11-14 Thread Jessica Clarke
On 14 Nov 2020, at 19:04, Scott Long wrote: > @@ -66,10 +67,16 @@ getlocalbase(char *path, size_t pathlen) > #endif > > tmplen = strlcpy(path, tmppath, pathlen); > - if ((tmplen < 0) || (tmplen >= (ssize_t)pathlen)) { > + if ((tmplen < 0) || (tmplen >= pathlen)) { I'd expect the

svn commit: r367696 - head/sys/contrib/openzfs/module/zfs

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:23:07 2020 New Revision: 367696 URL: https://svnweb.freebsd.org/changeset/base/367696 Log: zfs: disable periodic arc updates They are only there to provide less innacurate statistics for debuggers. However, this is quite heavy-weight and instead it would

svn commit: r367695 - in head/sys: kern sys

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:22:02 2020 New Revision: 367695 URL: https://svnweb.freebsd.org/changeset/base/367695 Log: thread: batch credential freeing Modified: head/sys/kern/kern_prot.c head/sys/kern/kern_thread.c head/sys/sys/ucred.h Modified: head/sys/kern/kern_prot.c

svn commit: r367694 - in head/sys: kern sys

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:21:46 2020 New Revision: 367694 URL: https://svnweb.freebsd.org/changeset/base/367694 Log: thread: batch resource limit free calls Modified: head/sys/kern/kern_resource.c head/sys/kern/kern_thread.c head/sys/sys/resourcevar.h Modified:

svn commit: r367693 - head/sys/kern

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:20:58 2020 New Revision: 367693 URL: https://svnweb.freebsd.org/changeset/base/367693 Log: thread: rework tid batch to use helpers Modified: head/sys/kern/kern_thread.c Modified: head/sys/kern/kern_thread.c

svn commit: r367692 - head/sys/sys

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:20:37 2020 New Revision: 367692 URL: https://svnweb.freebsd.org/changeset/base/367692 Log: cred: reorder cr_audit to be closer to the lock This makes cr_uid avoid sharing. Modified: head/sys/sys/ucred.h Modified: head/sys/sys/ucred.h

svn commit: r367691 - head/sys/kern

2020-11-14 Thread Mateusz Guzik
Author: mjg Date: Sat Nov 14 19:19:27 2020 New Revision: 367691 URL: https://svnweb.freebsd.org/changeset/base/367691 Log: thread: pad tid lock On a kernel with other changes this bumps 104-way thread creation/destruction from 0.96 mln ops/s to 1.1 mln ops/s. Modified:

svn commit: r367690 - head/usr.bin/login

2020-11-14 Thread Baptiste Daroussin
Author: bapt Date: Sat Nov 14 19:16:39 2020 New Revision: 367690 URL: https://svnweb.freebsd.org/changeset/base/367690 Log: Change the default locale to C.UTF-8 The C.UTF-8 locales is the same as the actual C locale except it does support the unicode character set. But the collation etc

svn commit: r367689 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 19:04:36 2020 New Revision: 367689 URL: https://svnweb.freebsd.org/changeset/base/367689 Log: Fix a problem with r367686 related to the use of ssize_t. Not sure how this escaped prior testing, but it should be better now. Reported by: lots Modified:

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
Hi, Yeah, I’m working on a fix, sorry. I made a last minute change that I thought I had tested, but apparently hadn’t. Scott > On Nov 14, 2020, at 11:43 AM, Gordon Bergling wrote: > > Hi Scott, > > this somehow breaks the build. > >

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Gordon Bergling
Hi Scott, this somehow breaks the build. - ===> lib/msun (obj,all,install) /tank/nfs_public/tiny/src/lib/libutil/getlocalbase.c:69:30: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and

svn commit: r367688 - head

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 18:06:35 2020 New Revision: 367688 URL: https://svnweb.freebsd.org/changeset/base/367688 Log: Makefile: re-wordsmith the blurb about xtoolchain ports The new version only includes a specific version once, and uses the one that's currently advised by

svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 18:01:14 2020 New Revision: 367687 URL: https://svnweb.freebsd.org/changeset/base/367687 Log: Replace hardcoded references to _PATH_LOCALBASE with calls to getlocalbase.3 Reviewed by: imp, se Modified: head/sbin/nvmecontrol/comnd.c

svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 17:57:50 2020 New Revision: 367686 URL: https://svnweb.freebsd.org/changeset/base/367686 Log: Add the library function getlocalbase and its manual page. This helps to unify the retrieval of the various ways that the local software base directory, typically

Re: svn commit: r367678 - head/usr.sbin/freebsd-update

2020-11-14 Thread Kyle Evans
On Sat, Nov 14, 2020 at 11:20 AM Mateusz Piotrowski <0...@freebsd.org> wrote: > > Hello Rodney, > > On 11/14/20 4:59 PM, Rodney W. Grimes wrote: > >> Author: 0mp (doc,ports committer) > >> Date: Sat Nov 14 13:07:41 2020 > >> New Revision: 367678 > >> URL:

Re: svn commit: r367678 - head/usr.sbin/freebsd-update

2020-11-14 Thread Mateusz Piotrowski
Hello Rodney, On 11/14/20 4:59 PM, Rodney W. Grimes wrote: Author: 0mp (doc,ports committer) Date: Sat Nov 14 13:07:41 2020 New Revision: 367678 URL: https://svnweb.freebsd.org/changeset/base/367678 Log: Document the PAGER environment variable Sometimes users want to use

Re: svn commit: r367678 - head/usr.sbin/freebsd-update

2020-11-14 Thread Rodney W. Grimes
> Author: 0mp (doc,ports committer) > Date: Sat Nov 14 13:07:41 2020 > New Revision: 367678 > URL: https://svnweb.freebsd.org/changeset/base/367678 > > Log: > Document the PAGER environment variable > > Sometimes users want to use freebsd-update(8) in a non-interactive way and > what

svn commit: r367685 - head/tests/sys/netinet

2020-11-14 Thread Jonathan T. Looney
Author: jtl Date: Sat Nov 14 15:44:28 2020 New Revision: 367685 URL: https://svnweb.freebsd.org/changeset/base/367685 Log: Add a regression test for the port-selection behavior fixed in r367680. Reviewed by: markj, olivier, tuexen Sponsored by: Netflix Differential Revision:

svn commit: r367684 - stable/12/sys/kern

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 15:33:39 2020 New Revision: 367684 URL: https://svnweb.freebsd.org/changeset/base/367684 Log: MFC r367604: umtx: drop incorrect timespec32 definition This works for amd64, but none others -- drop it, because we already have a proper definition in

svn commit: r367683 - stable/12/lib/libbe

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 15:26:18 2020 New Revision: 367683 URL: https://svnweb.freebsd.org/changeset/base/367683 Log: MFC r366819: libbe(3): const'ify a couple arguments libbe will never need to mutate these as we either process them into a local buffer or we just don't touch

svn commit: r367682 - in stable/12: lib/libbe tools/build/mk

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 15:21:20 2020 New Revision: 367682 URL: https://svnweb.freebsd.org/changeset/base/367682 Log: MFC r366820-r366821: libbe(3) documentation improvements r366820: libbe(3): document be_snapshot() While toying around with lua bindings for libbe(3), I

svn commit: r367681 - in stable/12/contrib/lua: . doc src

2020-11-14 Thread Kyle Evans
Author: kevans Date: Sat Nov 14 15:19:36 2020 New Revision: 367681 URL: https://svnweb.freebsd.org/changeset/base/367681 Log: MFC r366769: MFC r366760: lua: update to 5.3.6 This release contains some minor bugfixes; notably: - 2x minor Makefile fixes (not used in base) - Long brackets

svn commit: r367680 - head/sys/netinet6

2020-11-14 Thread Jonathan T. Looney
Author: jtl Date: Sat Nov 14 14:50:34 2020 New Revision: 367680 URL: https://svnweb.freebsd.org/changeset/base/367680 Log: Fix implicit automatic local port selection for IPv6 during connect calls. When a user creates a TCP socket and tries to connect to the socket without explicitly

svn commit: r367679 - stable/12/share/man/man4

2020-11-14 Thread Gordon Bergling
Author: gbe (doc committer) Date: Sat Nov 14 14:15:49 2020 New Revision: 367679 URL: https://svnweb.freebsd.org/changeset/base/367679 Log: MFC r366580: bpf(4): Update the man page to reflect reality PR: 131918 Submitted by: guy at alum dot mit dot edu Reviewed by: gnn, gbe

Re: svn commit: r367359 - stable/12/sys/dev/pci

2020-11-14 Thread Alexander Motin
Martin, I've never seen such issues. Could you send me verbose `dmesg`, `devinfo -v` and `lspci -vv` outputs with and without the tunable set? I guess your BIOS sets some things differently from all I've tested. On 13.11.2020 11:38, mar...@vx.sk wrote: > I am encountering a problem with

svn commit: r367678 - head/usr.sbin/freebsd-update

2020-11-14 Thread Mateusz Piotrowski
Author: 0mp (doc,ports committer) Date: Sat Nov 14 13:07:41 2020 New Revision: 367678 URL: https://svnweb.freebsd.org/changeset/base/367678 Log: Document the PAGER environment variable Sometimes users want to use freebsd-update(8) in a non-interactive way and what they often miss is that

svn commit: r367677 - in stable/12/sys/dev: acpi_support acpica iicbus

2020-11-14 Thread Vladimir Kondratyev
Author: wulf Date: Sat Nov 14 12:02:50 2020 New Revision: 367677 URL: https://svnweb.freebsd.org/changeset/base/367677 Log: MFC r367239-367241: r367239: Add plug and play information macroses for ACPI and I2C buses. Matching table format is compatible with ACPI_ID_PROBE bus method.

svn commit: r367676 - stable/12/sbin/devmatch

2020-11-14 Thread Vladimir Kondratyev
Author: wulf Date: Sat Nov 14 11:51:37 2020 New Revision: 367676 URL: https://svnweb.freebsd.org/changeset/base/367676 Log: MFC r367237: devmatch(8): Respect mask field when matching strings of Z type. While here, add debug output for this action. Reviewed by: imp Differential

svn commit: r367675 - stable/12/sys/dev/ichiic

2020-11-14 Thread Vladimir Kondratyev
Author: wulf Date: Sat Nov 14 11:48:28 2020 New Revision: 367675 URL: https://svnweb.freebsd.org/changeset/base/367675 Log: MFC r367230: ig4(4): Add PCI IDs for Intel Comet Lake I2C controllers. Modified: stable/12/sys/dev/ichiic/ig4_pci.c Directory Properties: stable/12/ (props

svn commit: r367674 - head/stand/common

2020-11-14 Thread Toomas Soome
Author: tsoome Date: Sat Nov 14 10:56:40 2020 New Revision: 367674 URL: https://svnweb.freebsd.org/changeset/base/367674 Log: loader: cstyle cleanup of console.c cstyle cleanup only, no functional changes intended. Modified: head/stand/common/console.c Modified:

svn commit: r367673 - head/sys/compat/linuxkpi/common/include/linux

2020-11-14 Thread Vladimir Kondratyev
Author: wulf Date: Sat Nov 14 10:34:18 2020 New Revision: 367673 URL: https://svnweb.freebsd.org/changeset/base/367673 Log: LinuxKPI: Exclude linux/acpi.h content on non-ACPI archs. LinuxKPI ACPI support is based on FreeBSD import of ACPICA which can be compiled only on aarch64, amd64