Re: svn commit: r286170 - head/share/man/man9

2015-08-04 Thread Bruce Evans
On Tue, 4 Aug 2015, Ed Schouten wrote: Hi Bruce, 2015-08-02 7:35 GMT+02:00 Bruce Evans b...@optusnet.com.au: This function shouldn't be deprecated. It is a kernel wrapper with a good name for hiding the implementation detail or not-yet standard interface _Static_assert(). _Static_assert

Re: svn commit: r286103 - head/share/man/man9

2015-08-04 Thread Bruce Evans
On Tue, 4 Aug 2015, Ed Schouten wrote: 2015-08-04 20:23 GMT+02:00 Warner Losh i...@bsdimp.com: There???s at least one compiler in common use that warns about extern int fred[1]; extern int fred[1]; being a repeated declaration (despite being legal C). Would you happen to know which one

Re: svn commit: r286267 - head/usr.bin/ypcat

2015-08-03 Thread Bruce Evans
On Tue, 4 Aug 2015, Marcelo Araujo wrote: Log: Remove the 3rd clause of BSD LICENSE. Sync the code with the OpenBSD version. Small style(9) fix up. This has many style(9) fix downs. Differential Revision: D3212 Reviewed by: rodrigc, bapt Obtained from: OpenBSD

Re: svn commit: r286265 - head/sys/x86/include

2015-08-03 Thread Bruce Evans
On Tue, 4 Aug 2015, Konstantin Belousov wrote: On Tue, Aug 04, 2015 at 12:11:40AM +, Jung-uk Kim wrote: Log: Always define __va_list for amd64 and restore pre-r232261 behavior for i386. Note it allows exotic compilers, e.g., TCC, to build with our stdio.h, etc. Thanks. PR:

Re: svn commit: r286102 - head/usr.bin/wall

2015-08-01 Thread Bruce Evans
On Fri, 31 Jul 2015, Pedro Giffuni wrote: On 07/31/15 02:12, Bruce Evans wrote: On Fri, 31 Jul 2015, Pedro F. Giffuni wrote: ... static char errbuf[1024]; Another static buffer. The function is obviously not reentrant. This large static buffer mainly wastes space all the time

Re: svn commit: r285985 - in head/usr.sbin/pw: . tests

2015-08-01 Thread Bruce Evans
On Sat, 1 Aug 2015, Jilles Tjoelker wrote: On Wed, Jul 29, 2015 at 08:52:52AM +1000, Bruce Evans wrote: On Tue, 28 Jul 2015, Baptiste Daroussin wrote: Added: head/usr.sbin/pw/tests/pw_groupadd.sh == --- /dev/null 00

Re: svn commit: r286168 - head/sys/net

2015-08-01 Thread Bruce Evans
On Sun, 2 Aug 2015, John-Mark Gurney wrote: Log: convert to C11's _Static_assert, and pull in sys/cdefs.h for compatibility w/ older non-C11 compilers... This include is bogus. net/pfkeyv2.h already depends on the includer including other headers that include sys/cdefs.h. Mainly

Re: svn commit: r285985 - in head/usr.sbin/pw: . tests

2015-08-01 Thread Bruce Evans
On Sat, 1 Aug 2015, Jilles Tjoelker wrote: On Sun, Aug 02, 2015 at 02:59:00AM +1000, Bruce Evans wrote: On Sat, 1 Aug 2015, Jilles Tjoelker wrote: These values are easily written using arithmetic expansion, for example largeid=$((0x1)). Not really. Shells are also very buggy

Re: svn commit: r286170 - head/share/man/man9

2015-08-01 Thread Bruce Evans
On Sun, 2 Aug 2015, John-Mark Gurney wrote: Log: mark this function as deprecated, and put the warning first, since I doubt most people will read to the end... Note the use of sys/cdefs.h for pre-C11 compilers... This function shouldn't be deprecated. It is a kernel wrapper with a good

Re: svn commit: r286148 - head/usr.sbin/chkgrp

2015-08-01 Thread Bruce Evans
On Sat, 1 Aug 2015, Baptiste Daroussin wrote: Log: Use strtoumax instead of strtoul This does nothing good, and breaks 32-bit arches. Modified: head/usr.sbin/chkgrp/chkgrp.c == --- head/usr.sbin/chkgrp/chkgrp.c

Re: svn commit: r286103 - head/share/man/man9

2015-07-31 Thread Bruce Evans
On Fri, 31 Jul 2015, John-Mark Gurney wrote: Log: The implementation note isn't true anymore.. Not that anyone reads it, but those that do, remind them that this isn't usable in userland... I can't wait till this doc is wrong.. It goes without saying that an API documented in a section 9

Re: svn commit: r286102 - head/usr.bin/wall

2015-07-31 Thread Bruce Evans
On Fri, 31 Jul 2015, Pedro F. Giffuni wrote: Log: Buffer overflow in wall(1). This affected syslogd, wall and talkd. Detected by FORTIFY_SOURCE GSoC (with clang). Old versions got this wrong by using strcpy() instead of strlcpy(). The fix using strlcpy() got this wrong by using a wrong

Re: svn commit: r286103 - head/share/man/man9

2015-07-31 Thread Bruce Evans
On Fri, 31 Jul 2015, John-Mark Gurney wrote: Bruce Evans wrote this message on Fri, Jul 31, 2015 at 16:21 +1000: On Fri, 31 Jul 2015, John-Mark Gurney wrote: Log: The implementation note isn't true anymore.. Not that anyone reads it, but those that do, remind them that this isn't usable

Re: svn commit: r285068 - in head/sys: conf modules/agp modules/geom/geom_part/geom_part_apm modules/geom/geom_part/geom_part_bsd modules/geom/geom_part/geom_part_bsd64 modules/geom/geom_part/geom_par

2015-07-30 Thread Bruce Evans
On Wed, 29 Jul 2015, Warner Losh wrote: On Jul 29, 2015, at 9:46 AM, Hans Petter Selasky h...@selasky.org wrote: In this particular case one find of /sys takes 11-16 seconds over NFS, so building a single KMOD takes 16 seconds too. It's not possible to eliminate the find entirely during

Re: svn commit: r285997 - head/usr.sbin/pw

2015-07-29 Thread Bruce Evans
On Wed, 29 Jul 2015, Baptiste Daroussin wrote: Log: Actually add the new code I shouldn't have asked for this. It gives more to clean up. It has 1 large bug and many style bugs. Added: head/usr.sbin/pw/strtounum.c

Re: svn commit: r285985 - in head/usr.sbin/pw: . tests

2015-07-28 Thread Bruce Evans
On Wed, 29 Jul 2015, Baptiste Daroussin wrote: On Wed, Jul 29, 2015 at 08:52:52AM +1000, Bruce Evans wrote: On Tue, 28 Jul 2015, Baptiste Daroussin wrote: Log: Check uid/gid used when creating a user/group are not larger than UID_MAX/GID_MAX PR:173977 Reported by: nv

Re: svn commit: r285985 - in head/usr.sbin/pw: . tests

2015-07-28 Thread Bruce Evans
On Tue, 28 Jul 2015, Baptiste Daroussin wrote: Log: Check uid/gid used when creating a user/group are not larger than UID_MAX/GID_MAX PR:173977 Reported by: nv...@gmx.com This is broken in a different way than before. Modified: head/usr.sbin/pw/pw.c

Re: svn commit: r285854 - head/sys/amd64/include

2015-07-25 Thread Bruce Evans
On Sat, 25 Jul 2015, Alan Cox wrote: On 07/24/2015 16:15, John-Mark Gurney wrote: Alan Cox wrote this message on Fri, Jul 24, 2015 at 19:43 +: ... Log: Add a comment discussing the appropriate use of the atomic_*() functions with acquire and release semantics versus the *mb()

Re: svn commit: r285664 - in head/sys: kern sys

2015-07-19 Thread Bruce Evans
On Sat, 18 Jul 2015, Mark Johnston wrote: On Sat, Jul 18, 2015 at 08:55:07PM +1000, Bruce Evans wrote: On Sat, 18 Jul 2015, Mark Johnston wrote: Log: Pass the lock object to lockstat_nsecs() and return immediately if LO_NOPROFILE is set. Some timecounter handlers acquire a spin mutex

Re: svn commit: r285644 - head/contrib/sqlite3

2015-07-18 Thread Bruce Evans
On Fri, 17 Jul 2015, Pedro Giffuni wrote: On 07/17/15 17:26, Peter Jeremy wrote: On 2015-Jul-16 22:07:14 +, Pedro F. Giffuni p...@freebsd.org wrote: Log: ... sqlite: clean a couple of invocations of memcpy(3) Found almost accidentally by our native gcc when enhanced with

Re: svn commit: r285664 - in head/sys: kern sys

2015-07-18 Thread Bruce Evans
On Sat, 18 Jul 2015, Mark Johnston wrote: Log: Pass the lock object to lockstat_nsecs() and return immediately if LO_NOPROFILE is set. Some timecounter handlers acquire a spin mutex, and we don't want to recurse if lockstat probes are enabled. It is an error to call timecounter code from a

Re: svn commit: r285644 - head/contrib/sqlite3

2015-07-17 Thread Bruce Evans
On Thu, 16 Jul 2015, Pedro Giffuni wrote: On 07/16/15 17:22, Ian Lepore wrote: On Thu, 2015-07-16 at 22:07 +, Pedro F. Giffuni wrote: Author: pfg Date: Thu Jul 16 22:07:13 2015 New Revision: 285644 URL: https://svnweb.freebsd.org/changeset/base/285644 Log: sqlite: clean a couple of

Re: svn commit: r285639 - head/sys/dev/e1000

2015-07-16 Thread Bruce Evans
On Thu, 16 Jul 2015, Sean Bruno wrote: Log: Add an adapter CORE lock in the DDB hook em_dump_queue to avoid WITNESS panic in em_init_locked() while debugging. It is a bug to lock anything from within ddb. Witness or something should panic when such a lock is attempted. Modified:

Re: svn commit: r285552 - head/usr.bin/xargs

2015-07-15 Thread Bruce Evans
On Tue, 14 Jul 2015, Ian Lepore wrote: On Tue, 2015-07-14 at 13:44 -0700, Xin Li wrote: On 07/14/15 13:29, Garrett Cooper wrote: On Jul 14, 2015, at 12:16, Baptiste Daroussin b...@freebsd.org wrote: Author: bapt Date: Tue Jul 14 19:16:14 2015 New Revision: 285552 URL:

Re: svn commit: r285217 - head/usr.sbin/bhyve

2015-07-07 Thread Bruce Evans
On Mon, 6 Jul 2015, Ian Lepore wrote: On Mon, 2015-07-06 at 19:33 +, Neel Natu wrote: Author: neel Date: Mon Jul 6 19:33:29 2015 New Revision: 285217 URL: https://svnweb.freebsd.org/changeset/base/285217 Log: Always assert DCD and DSR in bhyve's uart emulation. The /etc/ttys entry

Re: svn commit: r285227 - head/sys/powerpc/powerpc

2015-07-07 Thread Bruce Evans
On Tue, 7 Jul 2015, Justin Hibbits wrote: Log: style(9) cleanups. Don't use PRIxPTR, these registers are 32-bits, cast to u_long instead. Pointed out by:bde Thanks. This could actually cast to u_int if values are really 32 bits even when the arch is 64 bits. I don't know if

Re: svn commit: r285217 - head/usr.sbin/bhyve

2015-07-07 Thread Bruce Evans
On Tue, 7 Jul 2015, John-Mark Gurney wrote: Bruce Evans wrote this message on Tue, Jul 07, 2015 at 16:11 +1000: - tty_init_console() doesn't set CLOCAL in the lock state device. So without fixation, bugs like the one in reset(1) break serial consoles. Here's a patch to fix that: Index

Re: svn commit: r285168 - head/sys/powerpc/powerpc

2015-07-05 Thread Bruce Evans
On Sun, 5 Jul 2015, Justin Hibbits wrote: On Jul 5, 2015 08:30, Bjoern A. Zeeb b...@freebsd.org wrote: Author: bz Date: Sun Jul 5 15:30:16 2015 New Revision: 285168 URL: https://svnweb.freebsd.org/changeset/base/285168 Log: Fix GENERIC64 and LINT64 powerpc builds after r285144. Modified:

Re: svn commit: r284163 - head/bin/cp

2015-06-25 Thread Bruce Evans
On Wed, 24 Jun 2015, Bryan Drewery wrote: On 6/9/2015 1:28 AM, Bruce Evans wrote: On Mon, 8 Jun 2015, Bryan Drewery wrote: Log: Cleanup some style(9) issues. - Whitespace. - Comments. - Wrap long lines. cp's style had a remarlable amount of bitrot. This change unimproves it in some

Re: svn commit: r284711 - head/sys/netinet

2015-06-23 Thread Bruce Evans
On Mon, 22 Jun 2015, Ian Lepore wrote: On Mon, 2015-06-22 at 22:16 +, Hiren Panchasara wrote: Author: hiren Date: Mon Jun 22 22:16:06 2015 New Revision: 284711 URL: https://svnweb.freebsd.org/changeset/base/284711 Log: Reverting r284710. Today I learned: iff == if and only if.

Re: svn commit: r268137 - head/sys/sys

2015-06-21 Thread Bruce Evans
On Sun, 21 Jun 2015, Pedro Giffuni wrote: On 06/21/15 10:41, Bruce Evans wrote: On Sun, 21 Jun 2015, Pedro Giffuni wrote: On 06/21/15 01:09, Bruce Evans wrote: On Sat, 20 Jun 2015, Pedro Giffuni wrote: * ... With the patch we would use: __Noreturn void foo(void) _dead2; Which is still

Re: svn commit: r268137 - head/sys/sys

2015-06-21 Thread Bruce Evans
On Sun, 21 Jun 2015, Pedro Giffuni wrote: On 06/21/15 01:09, Bruce Evans wrote: On Sat, 20 Jun 2015, Pedro Giffuni wrote: * ... With the patch we would use: __Noreturn void foo(void) _dead2; Which is still ugly but C11-ish. That asks for the same problems as defining __weak. Why

Re: svn commit: r268137 - head/sys/sys

2015-06-21 Thread Bruce Evans
On Sun, 21 Jun 2015, Pedro Giffuni wrote: On 06/21/15 11:48, Bruce Evans wrote: On Sun, 21 Jun 2015, Pedro Giffuni wrote: ... Well, the fact this we just do this in the tree and no one has bothered to clean the situation for older compilers just indicates that no one *cares* about older

Re: svn commit: r268137 - head/sys/sys

2015-06-21 Thread Bruce Evans
On Sat, 20 Jun 2015, Pedro Giffuni wrote: On 06/19/15 12:23, Bruce Evans wrote: On Fri, 19 Jun 2015, Dimitry Andric wrote: On 19 Jun 2015, at 17:02, Pedro Giffuni p...@freebsd.org wrote: On 19/06/2015 05:16 a.m., David Chisnall wrote: I only just caught this (having seen the fallout from

Re: svn commit: r268137 - head/sys/sys

2015-06-19 Thread Bruce Evans
On Fri, 19 Jun 2015, Dimitry Andric wrote: On 19 Jun 2015, at 17:02, Pedro Giffuni p...@freebsd.org wrote: On 19/06/2015 05:16 a.m., David Chisnall wrote: I only just caught this (having seen the fallout from NetBSD doing the same thing in a shipping release and the pain that it???s

Re: svn commit: r284163 - head/bin/cp

2015-06-09 Thread Bruce Evans
On Mon, 8 Jun 2015, Bryan Drewery wrote: Log: Cleanup some style(9) issues. - Whitespace. - Comments. - Wrap long lines. cp's style had a remarlable amount of bitrot. This change unimproves it in some places. Clean up is 2 words. Modified: head/bin/cp/cp.c

Re: svn commit: r284167 - head/sys/i386/i386

2015-06-09 Thread Bruce Evans
On Mon, 8 Jun 2015, Dimitry Andric wrote: Log: Merge r283870 from amd64: Remove unneeded NULL checks in trap_fatal(). Since td_name is an array member of struct thread, it can never be NULL, so the check can be removed. In addition, curproc can never be NULL, so remove the if statement,

Re: svn commit: r284178 - head/sys/kern

2015-06-09 Thread Bruce Evans
On Tue, 9 Jun 2015, Konstantin Belousov wrote: Log: When updating/accessing the timehands, barriers are needed to ensure that: - th_generation update is visible after the parameters update is visible; - the read of parameters is not reordered before initial read of th_generation.

Re: svn commit: r284157 - head/sys/kern

2015-06-08 Thread Bruce Evans
On Mon, 8 Jun 2015, Ed Maste wrote: Log: Add user facing errors for exceeding process memory limits Previously the process terminating with SIGABRT at startup was the only notification. I don't like this. Errrors in syscalls should be reported by returning an error code, not by spamming

Re: svn commit: r283842 - head/usr.sbin/pw

2015-06-03 Thread Bruce Evans
On Mon, 1 Jun 2015, Baptiste Daroussin wrote: On Mon, Jun 01, 2015 at 03:36:58PM +1000, Bruce Evans wrote: On Sun, 31 May 2015, Baptiste Daroussin wrote: Log: Remove useless cast in printf and printf-like functions: use %u for uid_t and gid_t The cast was not useless. It was to avoid

Re: svn commit: r283842 - head/usr.sbin/pw

2015-06-01 Thread Bruce Evans
On Sun, 31 May 2015, Baptiste Daroussin wrote: Log: Remove useless cast in printf and printf-like functions: use %u for uid_t and gid_t The cast was not useless. It was to avoid the assumption that the default promotion of uid_t and gid_t is anything in particular. Now it is assumed that

Re: svn commit: r283869 - head/contrib/diff/src

2015-06-01 Thread Bruce Evans
On Mon, 1 Jun 2015, Marcelo Araujo wrote: Log: Fix the wrong format, format specifies type 'int' but the argument has type 'long', it was spotted by clang. ... Modified: head/contrib/diff/src/context.c == ---

Re: svn commit: r283870 - head/sys/amd64/amd64

2015-06-01 Thread Bruce Evans
On Mon, 1 Jun 2015, Dimitry Andric wrote: Log: Remove unneeded NULL checks in amd64's trap_fatal(). Since td_name is an array member of struct thread, it can never be NULL, so the check can be removed. In addition, curproc can never be NULL, so remove the if statement, and splice the two

Re: svn commit: r283671 - head/sys/sys

2015-05-29 Thread Bruce Evans
On Thu, 28 May 2015, Brooks Davis wrote: Log: Revert r102953 The bitfile padding was always unallocated on real-world FreeBSD systems and depended on the assumption that (abs(sizeof(long) - sizeof(char*)) = 32). Actually, it was bit-field padding that depended on the assumption that

Re: svn commit: r283693 - head/lib/libc/gen

2015-05-29 Thread Bruce Evans
On Fri, 29 May 2015, Andrew Turner wrote: Log: Fix __isinfl on architectures where double == long double. This is the case on at least ARM and PowerPC. Urk. I rarely look at the parts of libm misplaced outside of libc. Modified: head/lib/libc/gen/isinf.c

Re: svn commit: r283694 - head/lib/libc/gen

2015-05-29 Thread Bruce Evans
On Fri, 29 May 2015, Andrew Turner wrote: Log: Fix __fpclassifyl when double == long double. As with r283693 this is needed on ARM and PowerPC. MFC after: 1 Week Modified: head/lib/libc/gen/fpclassify.c Modified: head/lib/libc/gen/fpclassify.c

Re: svn commit: r283671 - head/sys/sys

2015-05-29 Thread Bruce Evans
On Fri, 29 May 2015, Brooks Davis wrote: On Fri, May 29, 2015 at 05:40:16PM +1000, Bruce Evans wrote: On Thu, 28 May 2015, Brooks Davis wrote: Log: Revert r102953 The bitfile padding was always unallocated on real-world FreeBSD systems and depended on the assumption that (abs(sizeof(long

Re: svn commit: r281103 - head/sys/amd64/amd64

2015-05-27 Thread Bruce Evans
On Wed, 27 May 2015, Kurt Lidl wrote: On 4/6/15 1:42 AM, Bruce Evans wrote: On Mon, 6 Apr 2015, Eitan Adler wrote: + a few people interested in the diff On 5 April 2015 at 02:55, Bruce Evans b...@optusnet.com.au wrote: On Sun, 5 Apr 2015, Eitan Adler wrote: I did not confirm

Re: svn commit: r283547 - head/sys/arm/conf

2015-05-26 Thread Bruce Evans
On Mon, 25 May 2015, John-Mark Gurney wrote: Ian Lepore wrote this message on Mon, May 25, 2015 at 23:27 +: Author: ian Date: Mon May 25 23:27:13 2015 New Revision: 283547 URL: https://svnweb.freebsd.org/changeset/base/283547 Log: Ensure that all arm kernel configs contain

Re: svn commit: r283197 - head/usr.bin/soelim

2015-05-21 Thread Bruce Evans
On Thu, 21 May 2015, Baptiste Daroussin wrote: Log: add an include on sys/types.h because we do explicitly use size_t remove unused stdbool.h sys/types.h may be needed for some other typedef, but not for size_t. size_t is already declared in at least 3 other of the included headers: -

Re: svn commit: r283105 - head/share/man/man9

2015-05-19 Thread Bruce Evans
On Tue, 19 May 2015, Julian Elischer wrote: Author: julian Log: Only several years late, catch the psignal man page up to the fact that psignal has been renamed to kern_psignal since 9.0. MFC after: 1 week It would be better to fix the function to match its documented name. Many

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Bruce Evans
On Mon, 18 May 2015, Pedro Giffuni wrote: Il giorno 18/mag/2015, alle ore 20:48, Bruce Evans b...@optusnet.com.au ha scritto: On Mon, 18 May 2015, Pedro F. Giffuni wrote: Log: ddb: stop boolean screaming. TRUE -- true FALSE-- false Hinted by: NetBSD This is not just churn

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Bruce Evans
On Mon, 18 May 2015, Pedro F. Giffuni wrote: Log: ddb: stop boolean screaming. TRUE -- true FALSE-- false Hinted by: NetBSD This is not just churn to a style regression, but a type mismatch. Modified: head/sys/ddb/db_break.c

Re: svn commit: r281966 - head/contrib/netbsd-tests/lib/libpthread

2015-04-25 Thread Bruce Evans
On Sat, 25 Apr 2015, Garrett Cooper wrote: Log: Add #include sys/types.h for register_t for mips Why not fix mips? Modified: head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c == ---

Re: svn commit: r281787 - head/sbin/dmesg

2015-04-21 Thread Bruce Evans
On Mon, 20 Apr 2015, Eric van Gyzen wrote: Log: dmesg: accommodate message buffer growth between the sysctl calls Allocate 12.5% extra space to avoid ENOMEM when the message buffer is growing steadily. This is bogus allocation. The message buffer has a small fixed size so that it fits in

Re: svn commit: r281721 - head/sys/sys

2015-04-21 Thread Bruce Evans
On Tue, 21 Apr 2015, David Chisnall wrote: On 20 Apr 2015, at 17:19, Bruce Evans b...@optusnet.com.au wrote: Enums should never be used in ABIs, since their size can be anything large enough. The rules for the size of enums also differ between C and C++, though clang (and, I think, gcc

Re: svn commit: r281721 - head/sys/sys

2015-04-21 Thread Bruce Evans
On Tue, 21 Apr 2015, Konstantin Belousov wrote: On Tue, Apr 21, 2015 at 07:32:30PM +1000, Bruce Evans wrote: On Tue, 21 Apr 2015, David Chisnall wrote: On 20 Apr 2015, at 17:19, Bruce Evans b...@optusnet.com.au wrote: Enums should never be used in ABIs, since their size can be anything

Re: svn commit: r281758 - head/bin/ed

2015-04-20 Thread Bruce Evans
On Mon, 20 Apr 2015, Eitan Adler wrote: On 19 April 2015 at 21:23, Bruce Evans b...@optusnet.com.au wrote: On Mon, 20 Apr 2015, Eitan Adler wrote: ... --- head/bin/ed/glbl.c Mon Apr 20 00:24:32 2015(r281757) +++ head/bin/ed/glbl.c Mon Apr 20 02:07:57 2015(r281758) @@ -60,7

Re: svn commit: r280279 - head/sys/sys

2015-04-20 Thread Bruce Evans
On Mon, 20 Apr 2015, Konstantin Belousov wrote: On Mon, Apr 13, 2015 at 04:04:45PM -0400, Jung-uk Kim wrote: Please try the attached patch. Index: sys/amd64/amd64/pmap.c === --- sys/amd64/amd64/pmap.c (revision 281496) +++

Re: svn commit: r281721 - head/sys/sys

2015-04-20 Thread Bruce Evans
On Mon, 20 Apr 2015, John Baldwin wrote: On Sunday, April 19, 2015 12:33:22 AM Justin Hibbits wrote: Log: Fix the build. Commit the last part of e500 PMC. ... @@ -136,6 +138,7 @@ enum pmc_cputype { __PMC_CLASS(MIPS74K)/* MIPS 74K */ \

Re: svn commit: r281724 - head/usr.bin/rpcgen

2015-04-19 Thread Bruce Evans
On Sun, 19 Apr 2015, Eitan Adler wrote: Log: rpcgen: fix use use of strcmp strcmp only guarantee that it will return at least 1 if the string B is greater than that of string A. Modified: head/usr.bin/rpcgen/rpc_sample.c Modified: head/usr.bin/rpcgen/rpc_sample.c

Re: svn commit: r281758 - head/bin/ed

2015-04-19 Thread Bruce Evans
On Mon, 20 Apr 2015, Eitan Adler wrote: Log: ed(1): Fix [-Werror=logical-not-parentheses] /usr/src/bin/ed/glbl.c:64:36: error: logical not is only applied to theleft hand side of comparison [-Werror=logical-not-parentheses] Obtained from: Dragonfly

Re: svn commit: r281517 - head/usr.bin/ipcs

2015-04-14 Thread Bruce Evans
On Tue, 14 Apr 2015, Eitan Adler wrote: Log: ipcs: fix builds that use gcc gcc gets annoyed by duplicate declarations You mean Fix builds that use a working compiler. Working compilers report redundant declarations when requested to do so by the -Wredundant-decls flag which I

Re: svn commit: r281307 - head/sys/boot/efi/boot1

2015-04-13 Thread Bruce Evans
On Mon, 13 Apr 2015, Andrew Turner wrote: On Thu, 9 Apr 2015 21:38:02 +1000 (EST) Bruce Evans b...@optusnet.com.au wrote: On Thu, 9 Apr 2015, Andrew Turner wrote: Log: Print error values with hex to make it easier to find the EFI error type. Modified: head/sys/boot/efi/boot1/boot1.c

Re: svn commit: r281307 - head/sys/boot/efi/boot1

2015-04-09 Thread Bruce Evans
On Thu, 9 Apr 2015, Andrew Turner wrote: Log: Print error values with hex to make it easier to find the EFI error type. Modified: head/sys/boot/efi/boot1/boot1.c Modified: head/sys/boot/efi/boot1/boot1.c == ---

Re: svn commit: r281281 - head/sys/dev/nvme

2015-04-08 Thread Bruce Evans
On Wed, 8 Apr 2015, Bjoern A. Zeeb wrote: Please trim quotes. On 08 Apr 2015, at 21:49 , Jim Harris jimhar...@freebsd.org wrote: [... quotes trimmed] Log: nvme: create separate DMA tag for non-payload DMA buffers I think this one break i386 PAE and XEN kernels at least:

Re: svn commit: r281103 - head/sys/amd64/amd64

2015-04-06 Thread Bruce Evans
On Mon, 6 Apr 2015, Adrian Chadd wrote: Hi Bruce, There's been a bunch of research into that field lately. Eg: http://daim.idi.ntnu.no/masteroppgaver/009/9231/masteroppgave.pdf The best part (imho)- the length of your USER environment string influencing code runtime costs. :) I fix the

Re: svn commit: r281103 - head/sys/amd64/amd64

2015-04-05 Thread Bruce Evans
On Mon, 6 Apr 2015, Eitan Adler wrote: + a few people interested in the diff On 5 April 2015 at 02:55, Bruce Evans b...@optusnet.com.au wrote: On Sun, 5 Apr 2015, Eitan Adler wrote: I did not confirm the performance impact, but the submitter and others indicated they saw a difference. Do

Re: svn commit: r281103 - head/sys/amd64/amd64

2015-04-05 Thread Bruce Evans
On Sun, 5 Apr 2015, Eitan Adler wrote: Log: adrian asked me to revert and get more testing Modified: head/sys/amd64/amd64/support.S Modified: head/sys/amd64/amd64/support.S == --- head/sys/amd64/amd64/support.S

Re: svn commit: r281059 - head/sys/boot/efi/boot1

2015-04-04 Thread Bruce Evans
On Sat, 4 Apr 2015, Rui Paulo wrote: Log: boot1 EFI: reset the screen and select the best mode. It's necessary to reset the screen to make sure any vendor pixels are gone when we start boot1. In the Lenovo X1 (3rd gen), this is the only way to clear the screen. Previously, the Lenovo

Re: svn commit: r281004 - in head/lib/libc: arm/sys mips/sys powerpc powerpc/sys powerpc64 powerpc64/sys sparc64 sparc64/sys sys

2015-04-02 Thread Bruce Evans
On Thu, 2 Apr 2015, Ed Maste wrote: Log: libc: Eliminate duplicate copies of __vdso_gettc.c ... Modified: head/lib/libc/arm/sys/Makefile.inc == --- head/lib/libc/arm/sys/Makefile.inc Thu Apr 2 20:14:51 2015

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-31 Thread Bruce Evans
On Mon, 30 Mar 2015, Konstantin Belousov wrote: On Mon, Mar 30, 2015 at 03:14:10PM +1100, Bruce Evans wrote: File timestamps use CLOCK_REALTIME, so they are supposed to go backwards sometimes. More importantly, if the time is set to a future time (by utimes(), etc., not due to a clock step

Re: svn commit: r280279 - head/sys/sys

2015-03-30 Thread Bruce Evans
On Mon, 30 Mar 2015, Konstantin Belousov wrote: On Mon, Mar 30, 2015 at 11:57:08AM -0400, John Baldwin wrote: On Sunday, March 22, 2015 11:32:51 AM Konstantin Belousov wrote: ... So anybody has to compile his own kernel to get popcnt optimization ? We do care about trivial things that improve

Re: svn commit: r280759 - head/sys/netinet

2015-03-29 Thread Bruce Evans
On Sun, 29 Mar 2015, Ian Lepore wrote: On Mon, 2015-03-30 at 00:07 +0300, Gleb Smirnoff wrote: On Sun, Mar 29, 2015 at 08:16:46AM -0700, Adrian Chadd wrote: A On 29 March 2015 at 01:13, Hans Petter Selasky h...@selasky.org wrote: A On 03/28/15 20:16, Gleb Smirnoff wrote: A A +uint16_t A

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-29 Thread Bruce Evans
On Sun, 29 Mar 2015, Jilles Tjoelker wrote: On Sun, Mar 22, 2015 at 11:25:07AM -0700, Don Lewis wrote: It's not totally worthless. I think the mtime on tty devices is used to calculate the idle time that is printed by the w command. We just don't need nanosecond accuracy for that. Hmm. The

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-29 Thread Bruce Evans
On Sun, 29 Mar 2015, Konstantin Belousov wrote: Interesting complication with the devfs timestamp update is that devfs_read_f() and devfs_write_f() do not lock the vnode. So whatever update method is used, stat(2) on devfs might return inconsistent value, since tv_src/tv_nsec cannot be updated

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-29 Thread Bruce Evans
On Mon, 30 Mar 2015, Bruce Evans wrote: On Sun, 29 Mar 2015, Konstantin Belousov wrote: Interesting complication with the devfs timestamp update is that devfs_read_f() and devfs_write_f() do not lock the vnode. So whatever update method is used, stat(2) on devfs might return inconsistent

Re: svn commit: r280636 - head/include

2015-03-27 Thread Bruce Evans
On Thu, 26 Mar 2015, Tijl Coosemans wrote: On Thu, 26 Mar 2015 17:37:53 +1100 (EST) Bruce Evans b...@optusnet.com.au wrote: On Wed, 25 Mar 2015, Pedro Giffuni wrote: On 03/25/15 21:14, Bruce Evans wrote: On Wed, 25 Mar 2015, Pedro F. Giffuni wrote: Log: Temporarily revert 280458. GCC

Re: svn commit: r280700 - head/sys/sys

2015-03-26 Thread Bruce Evans
On Thu, 26 Mar 2015, Pedro F. Giffuni wrote: Log: Introduce some allocation function attributes. Bring support for two gcc function attributes that are likely to be used in our system headers: ... The __alloc_size attribute required some workarounds for lint(1). Both attributes are

Re: svn commit: r280636 - head/include

2015-03-26 Thread Bruce Evans
On Wed, 25 Mar 2015, Pedro Giffuni wrote: On 03/25/15 21:14, Bruce Evans wrote: On Wed, 25 Mar 2015, Pedro F. Giffuni wrote: Log: Temporarily revert 280458. GCC is still carries an old version of cdefs.h which doesn't accept multiple parameters for the nonnull attribute. Since

Re: svn commit: r280407 - head/sys/kern

2015-03-25 Thread Bruce Evans
On Wed, 25 Mar 2015, Mateusz Guzik wrote: On Tue, Mar 24, 2015 at 03:58:14PM +1100, Bruce Evans wrote: On Tue, 24 Mar 2015, Mateusz Guzik wrote: Log: filedesc: microoptimize fget_unlocked by getting rid of fd 0 branch This has no effect. Compilers optimize to the equivalent

Re: svn commit: r280636 - head/include

2015-03-25 Thread Bruce Evans
On Wed, 25 Mar 2015, Pedro F. Giffuni wrote: Log: Temporarily revert 280458. GCC is still carries an old version of cdefs.h which doesn't accept multiple parameters for the nonnull attribute. Since this issue probably affects many ports in the tree we will revert it for now until gcc

Re: svn commit: r280407 - head/sys/kern

2015-03-23 Thread Bruce Evans
On Tue, 24 Mar 2015, Mateusz Guzik wrote: Log: filedesc: microoptimize fget_unlocked by getting rid of fd 0 branch This has no effect. Compilers optimize to the equivalent of the the unsigned cast hack if this is good. On x86, it is good since no instructions are needed for the

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-22 Thread Bruce Evans
On Sun, 22 Mar 2015, Jilles Tjoelker wrote: On Sat, Mar 21, 2015 at 08:49:00PM +1100, Bruce Evans wrote: On Sat, 21 Mar 2015, Xin LI wrote: Log: Disable timestamping on devfs read/write operations by default. I don't like this. It defaults to non-POSIX-conformant behaviour

Re: svn commit: r280346 - head/sys/sys

2015-03-22 Thread Bruce Evans
On Sun, 22 Mar 2015, Pedro F. Giffuni wrote: Log: Small style(9) cleanup. #define should always be followed by a tab not space. Thanks, but not in comments. Modified: head/sys/sys/cdefs.h == ---

Re: svn commit: r280357 - head/bin/expr

2015-03-22 Thread Bruce Evans
On Sun, 22 Mar 2015, Dimitry Andric wrote: Log: Build expr with -fwrapv, since it relies on signed integer wrapping having defined behavior. This was supposed to be fixed using a volatile hack, but I see that was only for multiplication. Wrapping is not undefined behaviour. You mean

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-22 Thread Bruce Evans
On Sun, 22 Mar 2015, Konstantin Belousov wrote: On Sun, Mar 22, 2015 at 02:37:09PM +0100, Jilles Tjoelker wrote: On Sat, Mar 21, 2015 at 08:49:00PM +1100, Bruce Evans wrote: On Sat, 21 Mar 2015, Xin LI wrote: Log: Disable timestamping on devfs read/write operations by default. ... I

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-21 Thread Bruce Evans
On Sat, 21 Mar 2015, Xin LI wrote: Log: Disable timestamping on devfs read/write operations by default. Currently we update timestamps unconditionally when doing read or write operations. This may slow things down on hardware where reading timestamps is expensive (e.g. HPET, because of

Re: svn commit: r280279 - head/sys/sys

2015-03-21 Thread Bruce Evans
On Sat, 21 Mar 2015, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 09:42:51AM +1100, Bruce Evans wrote: On Fri, 20 Mar 2015, Konstantin Belousov wrote: On Fri, Mar 20, 2015 at 10:27:06AM +, John Baldwin wrote: Author: jhb Date: Fri Mar 20 10:27:06 2015 New Revision: 280279 URL

Re: svn commit: r280279 - head/sys/sys

2015-03-21 Thread Bruce Evans
On Sat, 21 Mar 2015, John Baldwin wrote: On 3/21/15 12:35 PM, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 12:04:41PM -0400, John Baldwin wrote: On 3/20/15 9:02 AM, Konstantin Belousov wrote: On Fri, Mar 20, 2015 at 10:27:06AM +, John Baldwin wrote: Author: jhb Date: Fri Mar 20

Re: svn commit: r280279 - head/sys/sys

2015-03-20 Thread Bruce Evans
On Fri, 20 Mar 2015, Konstantin Belousov wrote: On Fri, Mar 20, 2015 at 10:27:06AM +, John Baldwin wrote: Author: jhb Date: Fri Mar 20 10:27:06 2015 New Revision: 280279 URL: https://svnweb.freebsd.org/changeset/base/280279 Log: Expand the bitcount* API to support 64-bit integers, plain

Re: svn commit: r279981 - in head: contrib/compiler-rt/lib/builtins lib/libcompiler_rt

2015-03-14 Thread Bruce Evans
On Sat, 14 Mar 2015, Dimitry Andric wrote: Log: ???Pull in r231965 from upstream compiler-rt trunk (by J??rg Sonnenberger): Refactor float to integer conversion to share the same code. 80bit Intel/PPC long double is excluded due to lacking support for the abstraction. Consistently

Re: svn commit: r279937 - in head/sys/powerpc: include powerpc

2015-03-13 Thread Bruce Evans
On Fri, 13 Mar 2015, Konstantin Belousov wrote: On Fri, Mar 13, 2015 at 10:45:46AM -0700, Nathan Whitehorn wrote: We'll need to hack the compiler in this case, since it assumes setjmp() saves and restores the vector registers. I'm really not sure which option is worse. Changing the compiler

Re: svn commit: r279905 - head

2015-03-12 Thread Bruce Evans
On Thu, 12 Mar 2015, Warner Losh wrote: Log: It appears that xlint isn't used in the build process, so it certainly doesn't need to be a build tool. It does appear to be used for lint.7 and lint libraries, just like in 2002 when it was added to cross-tools. It never was a build-tool.

Re: svn commit: r279764 - head/sys/vm

2015-03-12 Thread Bruce Evans
On Tue, 10 Mar 2015, Gleb Smirnoff wrote: On Tue, Mar 10, 2015 at 12:18:13PM +0200, Konstantin Belousov wrote: K On Tue, Mar 10, 2015 at 01:01:41PM +0300, Gleb Smirnoff wrote: K On Sun, Mar 08, 2015 at 02:13:47AM +, Konstantin Belousov wrote: K K Author: kib K K Date: Sun Mar 8 02:13:46

Re: svn commit: r279856 - in head/lib/msun: man src

2015-03-10 Thread Bruce Evans
On Tue, 10 Mar 2015, Steve Kargl wrote: Log: According to POSIX.1-2008, the Bessel functions of second kind should raise a divide-by-zero floating point exception for x = +-0 and an invalid floating point exception for x 0 including x = -Inf. Update the code to raise the exception and

Re: svn commit: r279338 - head/sys/arm/include

2015-02-27 Thread Bruce Evans
On Fri, 27 Feb 2015, Ian Lepore wrote: On Fri, 2015-02-27 at 13:35 +1100, Bruce Evans wrote: On Thu, 26 Feb 2015, Ian Lepore wrote: Log: Add casting to make atomic ops work for pointers. (Apparently nobody has ever done atomic ops on pointers before now on arm). Apparently, arm code

Re: svn commit: r279349 - head/sys/kern

2015-02-27 Thread Bruce Evans
On Fri, 27 Feb 2015, Andrew Turner wrote: On Fri, 27 Feb 2015 02:56:59 + (UTC) Warner Losh i...@freebsd.org wrote: ... /* + * We need some randomness. Implement the classic Linear Congruential + * generator X_{n+1}=(aX_n+c) mod m. These values are optimized for + * m = 2^32, a = 69069 and

Re: svn commit: r279338 - head/sys/arm/include

2015-02-26 Thread Bruce Evans
On Thu, 26 Feb 2015, Ian Lepore wrote: Log: Add casting to make atomic ops work for pointers. (Apparently nobody has ever done atomic ops on pointers before now on arm). Apparently, arm code handled pointers correctly before. des broke i386 in the same way and didn't back out the changes

Re: svn commit: r278889 - head/lib/libc/include

2015-02-19 Thread Bruce Evans
On Thu, 19 Feb 2015, Konstantin Belousov wrote: On Thu, Feb 19, 2015 at 11:58:48AM +1100, Bruce Evans wrote: BTW, the reason for existence of __cleanup() has been broken by malloc() and other bloatware. It is to avoid linking anything in stdio when only exit() is used. But crtso now links

<    6   7   8   9   10   11   12   13   14   15   >