Re: svn commit: r341338 - head/share/man/man4

On Fri, 30 Nov 2018, Edward Tomasz Napierala wrote: Log: Say in plain text what the 'debug' keymap action usually is. MFC after: 2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head/share/man/man4/ddb.4

Re: svn commit: r341103 - head/sys/powerpc/include

On Wed, 28 Nov 2018, Justin Hibbits wrote: Log: powerpc: Fix the powerpc64 build post-r341102 VM_MIN_KERNEL_ADDRESS is now used in locore.S, but the UL suffix isn't permitted in .S files. The UL suffix is arguably a style bug in .c files too. It was not even wrong (it had no effect) this

Re: svn commit: r341006 - head/sys/netgraph

On Tue, 27 Nov 2018, Eugene Grosbein wrote: Log: ng_source(4): correction after the change r340617 tv_usec has "long" type for all architecture in FreeBSD and follows __LP64__. However, this is not true for tv_sec that has "time_t" type. tv_usec actually has type suseconds_t.

Re: svn commit: r340450 - head/sys/sys

On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 9:05 AM Bruce Evans wrote: On Tue, 20 Nov 2018, Bruce Evans wrote: On Tue, 20 Nov 2018, Bruce Evans wrote: On Mon, 19 Nov 2018, Warner Losh wrote: ... I found my test program. But I think I understand the problem now

Re: svn commit: r340450 - head/sys/sys

On Tue, 20 Nov 2018, Bruce Evans wrote: On Tue, 20 Nov 2018, Bruce Evans wrote: On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: ... I found my test program. But I think I understand the problem now. mstosbt(1000) is overflowing with my

Re: svn commit: r340450 - head/sys/sys

On Tue, 20 Nov 2018, Bruce Evans wrote: On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: As a side note, I wonder if those functions are ever used on negative values, given the type of the argument, and if anyone checked their correctness

Re: svn commit: r340450 - head/sys/sys

On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: On 19/11/2018 03:38, Warner Losh wrote: I'll talk to Allan to see if he can test that. the bare 1 should be handled properly because of C's promotion rules. 1ull << 32 is an unsigned long long.

Re: svn commit: r340472 - in head: lib/libc/amd64/string sys/amd64/amd64

On Fri, 16 Nov 2018, Mateusz Guzik wrote: Log: amd64: handle small memset buffers with overlapping stores Instead of jumping to locations which store the exact number of bytes, use displacement to move the destination. In particular the following clears an area between 8-16 (inclusive)

Re: svn commit: r339481 - head/sys/dev/random

On Sat, 20 Oct 2018, Conrad Meyer wrote: ... Log: Fortuna: trivial static variable cleanup Remove unnecessary use of function-local static variable. 32 bytes is small enough to live on the stack. ... Modified: head/sys/dev/random/fortuna.c

Re: svn commit: r339448 - head/usr.sbin/vidcontrol

On Sat, 20 Oct 2018, Tobias Kortkamp wrote: ... Log: vidcontrol(1): Fix a typo in the description of -f While here: - Fix markup in -c This was supposed to be consistent with nearby style, but I changed the main .Cm to .Ar so it was inconsistent with itself. There are many other misuses

Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src

On Thu, 20 Sep 2018, John Baldwin wrote: On 9/20/18 2:43 PM, Li-Wen Hsu wrote: ... I suspect this. Each build is in a fresh created jail with the latest branch of packages from pkg.freebsd.org. At the beginning of (warning: 56MB file)

Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src

On Thu, 20 Sep 2018, John Baldwin wrote: On 9/20/18 8:54 AM, Mark Johnston wrote: On Sun, Jul 15, 2018 at 12:23:11AM +, Matt Macy wrote: Author: mmacy Date: Sun Jul 15 00:23:10 2018 New Revision: 336299 URL: https://svnweb.freebsd.org/changeset/base/336299 Log: msun: add ld80/ld128

Re: svn commit: r338751 - head/include

On Tue, 18 Sep 2018, Brooks Davis wrote: Log: Fix C11 and POSIX 1003.1b-1993 compliance in time.h Only expose timespec_get in C11, C++17, or BSD code. Always define struct timespect if defining timespec_get. PR:231425 Reviewed by: kib Approved by: re (gjb) Differential

Re: svn commit: r338128 - in head: cddl/lib/libzpool cddl/usr.bin/ztest cddl/usr.sbin/zdb sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys sys/conf sys/modules/zfs

On Tue, 21 Aug 2018, John Baldwin wrote: On 8/21/18 4:45 AM, Matt Macy wrote: ... Log: Make dnode definition uniform on !x86 gcc4 requires -fms-extensions to accept anonymous union members It does not. Anonymous unions have been a standard gcc extension since ~1989, but these are

Re: svn commit: r337674 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

On Wed, 15 Aug 2018, John Baldwin wrote: On 8/12/18 3:09 AM, Matt Macy wrote: Log: Restore legacy dnode_phys layout on tier 2 arches Evidently gcc4 doesn't support anonymous union members Even gcc3 supports anonomous union members. Maybe even gcc1. They are a standard gcc feature

Re: svn commit: r337750 - head/share/man/man4

On Tue, 14 Aug 2018, Warner Losh wrote: Log: Add good description of init and lock devices from sio to uart. I thought at first that this was for the callin and callout devices. These have been completely broken since FreeBSD-8. (A few hundred bugs collateral bugs in the tty driver are

Re: svn commit: r337518 - in head/sys: kern sys

On Fri, 10 Aug 2018, Bruce Evans wrote: On Thu, 9 Aug 2018, Kyle Evans wrote: ... When you say you call msgbufinit() earlier-- before the static environment is even setup, or at least after that? The above is with a simplified version that first calls msgbufinit() after the static env is set

Re: svn commit: r337518 - in head/sys: kern sys

On Thu, 9 Aug 2018, Kyle Evans wrote: On Thu, Aug 9, 2018 at 6:22 PM, Bruce Evans wrote: ... The only obvious bug in (a later version of) the output is a missing newline for the tag. My dmesg output on amd64: X ---<>--<>---Test of early printf to msgbuf X GDB: debug port

Re: svn commit: r337426 - head/sbin/ifconfig

On Tue, 7 Aug 2018, Mark Johnston wrote: Log: ifconfig: Fix use of _Noreturn. The _Noreturn is a function-specifier (like inline) which must preceed the declarator. Submitted by: Sebastian Huber MFC after: 1 week _Noreturn is even more broken than I knew. It should never be

Re: svn commit: r337518 - in head/sys: kern sys

On Thu, 9 Aug 2018, Kyle Evans wrote: Log: kern: Add a BOOT_TAG marker at the beginning of boot dmesg From the "newly licensed to drive" PR department, add a BOOT_TAG marker (by default, --<>--, to the beginning of each boot's dmesg. This makes it easier to do textproc magic to locate the

Re: svn commit: r337334 - head/lib/libc/sys

On Mon, 6 Aug 2018, Bruce Evans wrote: ... I forgot about FAT times, and only remembered that utc_offset() was used for RTC drivers. I thought that utc_offset() is 0 unless something sets the timezone to nonzero or the RTC is on local time (wall_cmos_clock case). However, since the kernel

Re: svn commit: r337334 - head/lib/libc/sys

On Sun, 5 Aug 2018, Ian Lepore wrote: On Sat, 2018-08-04 at 16:39 -0600, Warner Losh wrote: [Context lost to corruption of spaces} Specifically, for compatibility, we store minutes west of UTC on settimeofday and we retrieve it for settimeofday. Otherwise it's 100% unused by anything else at

Re: svn commit: r337334 - head/lib/libc/sys

On Sat, 4 Aug 2018, Conrad Meyer wrote: Log: settimeofday(2): Remove stale note about timezone Contrary to the removed comment, the kernel does appear to use the timezone argument of settimeofday. The comment dates to the BSD4.4 import; I assume it is just stale. The kernel not only

svn commit: r336665 - head/lib/msun/src

Author: bde Date: Tue Jul 24 11:50:05 2018 New Revision: 336665 URL: https://svnweb.freebsd.org/changeset/base/336665 Log: In C remquol() and thus also in C remainderl(), don't clobber the sign bit of NaNs before possible returning a NaN. The remquo*() and remainder*() functions should

svn commit: r336663 - head/lib/msun/src

Author: bde Date: Tue Jul 24 10:10:16 2018 New Revision: 336663 URL: https://svnweb.freebsd.org/changeset/base/336663 Log: Fix the conversion to use nan_mix() in r336362. fmod*(x, y), remainder*(x, y) and remquo*(x, y, quo) were broken for y = 0 by changing multiplication by y to addition

svn commit: r336545 - in head/lib/msun: ld128 ld80 src

Author: bde Date: Fri Jul 20 12:42:24 2018 New Revision: 336545 URL: https://svnweb.freebsd.org/changeset/base/336545 Log: Centralize the complications for special efficient rounding to integers. This was open-coded in range reduction for trig and exp functions. Now there are 3 static

Re: svn commit: r336517 - head/sys/powerpc/include

On Thu, 19 Jul 2018, Justin Hibbits wrote: Log: Revert r336509. Fails buildworld. I had naively assumed that building kernel would be sufficient to test that the header is sane. However, it turns out this now needs -fms-extensions to build. Rather than sprinkling -fms-extensions all

svn commit: r336488 - head/lib/msun/src

Author: bde Date: Thu Jul 19 15:04:10 2018 New Revision: 336488 URL: https://svnweb.freebsd.org/changeset/base/336488 Log: Fix spurious and extra underflows and resulting inaccuracies for some cases with 1 huge component and 1 tiny (but nowhere near denormal) component. Rescale earlier so

svn commit: r336484 - head/lib/msun/src

Author: bde Date: Thu Jul 19 14:24:48 2018 New Revision: 336484 URL: https://svnweb.freebsd.org/changeset/base/336484 Log: Oops, r336412 undid the fix of the overflow threshold in r323003. Restore the previous overflow threshold and adjust comments. Modified: head/lib/msun/src/s_csqrtl.c

svn commit: r336412 - head/lib/msun/src

Author: bde Date: Tue Jul 17 12:01:59 2018 New Revision: 336412 URL: https://svnweb.freebsd.org/changeset/base/336412 Log: Minor cleanups to csqrt*(), mostly in comments. Remove the STDC CX_LIMITED_RANGE pragma and its verbose comment. We still don't have any C99 compilers (that support

svn commit: r336400 - head/lib/msun/src

Author: bde Date: Tue Jul 17 10:44:16 2018 New Revision: 336400 URL: https://svnweb.freebsd.org/changeset/base/336400 Log: Fix scaling bugs which gave innaccuracies and spurious underflows in csqrt() and csqrtl(). When one component is huge and the other is tiny, scaling down the tiny

svn commit: r336362 - in head/lib/msun: ld128 ld80 src

Author: bde Date: Tue Jul 17 07:42:14 2018 New Revision: 336362 URL: https://svnweb.freebsd.org/changeset/base/336362 Log: Add a macro nan_mix() and use it to get NaN results that are (bitwise) independent of the precision in most cases. This is mainly to simplify checking for errors.

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

On Fri, 6 Jul 2018, John Baldwin wrote: On 7/6/18 8:52 AM, Rodney W. Grimes wrote: ... Trivial to fix this with +#if defined(SMP) || !defined(_KERNEL) || defined(KLD_MODULE) || !defined(KLD_UP_MODULES) This is not worth it. Note that we already use LOCK always in userland which is probably

Re: svn commit: r336002 - in head: usr.bin/netstat usr.sbin/tcpdrop

On Fri, 6 Jul 2018, Bruce Evans wrote: On Thu, 5 Jul 2018, Brooks Davis wrote: Log: Work around lame warnings in ancient gcc on 32-bit platforms. Fixes r335979. These are correct warnings. Why not fix the bug instead of rorking around it? Modified: head/usr.bin/netstat/inet.c

Re: svn commit: r336002 - in head: usr.bin/netstat usr.sbin/tcpdrop

On Thu, 5 Jul 2018, Brooks Davis wrote: Log: Work around lame warnings in ancient gcc on 32-bit platforms. Fixes r335979. These are correct warnings. Why not fix the bug instead of rorking around it? Modified: head/usr.bin/netstat/inet.c

Re: svn commit: r335765 - head/sys/sys

On Thu, 28 Jun 2018, David Bright wrote: Log: Remove potential identifier conflict in the EV_SET macro. PR43905 pointed out a problem with the EV_SET macro if the passed struct kevent pointer were specified with an expression with side effects (e.g., "kevp++"). This was fixed in rS110241,

Re: svn commit: r335746 - head/bin/sh

On Wed, 27 Jun 2018, Bryan Drewery wrote: Log: Stop building intermediate .o files. These are not used to link the final tool anymore. At some point in the past the suffix rules changed to not link these in. The original reason for this in r19176 is unclear but seems to be related to

Re: svn commit: r335278 - head/bin/pwd

On Sun, 17 Jun 2018, Eitan Adler wrote: Log: pwd: mark usage as dead Modified: head/bin/pwd/pwd.c Modified: head/bin/pwd/pwd.c == --- head/bin/pwd/pwd.c Sun Jun 17 03:33:29 2018(r335277) +++

Re: svn commit: r335041 - head/lib/libc/stdlib

On Wed, 13 Jun 2018, Jilles Tjoelker wrote: On Wed, Jun 13, 2018 at 08:03:13PM +1000, Bruce Evans wrote: On Wed, 13 Jun 2018, Eitan Adler wrote: Log: libc: remove explicit cast NULL in atoi There isn't any reason to cast NULL so just remove it. Noticed when cleaning up top

Re: svn commit: r334947 - head/sys/modules

On Sat, 16 Jun 2018, Kurt Lidl wrote: On 6/11/18 4:42 AM, Dimitry Andric wrote: /// Log: Disable building aesni with base gcc Because base gcc does not support the required intrinsics, do not attempt to compile the aesni module with it. ... Modified: head/sys/modules/Makefile

Re: svn commit: r335242 - head/sys/kern

On Fri, 15 Jun 2018, Gleb Smirnoff wrote: Log: Since 'ticks' is an int, it may wrap around and cr_ticks at a certain counter_rate will be greater than ticks, resulting in counter_ratecheck() failure. To fix this take an absolute value of the difference between ticks and cr_ticks. This

Re: svn commit: r335177 - in head/sys: compat/freebsd32 compat/linux i386/ibcs2 kern vm

On Thu, 14 Jun 2018, Brooks Davis wrote: ... Log: Name the implementation of brk and sbrk sys_break(). This API was actually named brk(2). Now brk(2) doesn't actually give this API. brk(2) doesn't exist in libc. Only brk(3) exists. It calls the actual brk(2) and adds complications. brk(3)

Re: svn commit: r333945 - head/usr.bin/top

On Thu, 14 Jun 2018, Eitan Adler wrote: On 10 June 2018 at 09:26, Alexey Dokuchaev wrote: On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: On 10 June 2018 at 05:28, Alexey Dokuchaev wrote: I've just tried the latest top(1). Now it's even worse: ... Also, it is COMMA now. Can

Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core

On Thu, 14 Jun 2018, Hans Petter Selasky wrote: On 06/14/18 10:46, Bruce Evans wrote: Are these macros for conversion of host (FreeBSD) dev_t's or target (Linux) ones??? If for the host, then I don't see any reason not to use the host APIs. If for the target, then they shouldn't be used

Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core

On Thu, 14 Jun 2018, Hans Petter Selasky wrote: On 06/14/18 02:03, Matthew Macy wrote: On Wed, Jun 13, 2018 at 4:47 PM, Ryan Libby wrote: On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy wrote: Author: mmacy Date: Wed Jun 13 23:30:54 2018 New Revision: 335094 URL:

Re: svn commit: r335053 - in head/sys: compat/freebsd32 compat/linux fs/nfsclient kern sys

On Thu, 14 Jun 2018, Hans Petter Selasky wrote: On 06/13/18 14:22, Bruce Evans wrote: [... inlines for makedev(), etc.] Can you use all macros here? This breaks OFED, because __makedev() is used to initialize variables. See another reply. I will change them to macros and fear breaking

Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core

On Wed, 13 Jun 2018, Matthew Macy wrote: On Wed, Jun 13, 2018 at 4:47 PM, Ryan Libby wrote: On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy wrote: Author: mmacy Date: Wed Jun 13 23:30:54 2018 New Revision: 335094 URL: https://svnweb.freebsd.org/changeset/base/335094 Log: fix OFED build after

svn commit: r335057 - head/sys/compat/linux

Author: bde Date: Wed Jun 13 12:44:45 2018 New Revision: 335057 URL: https://svnweb.freebsd.org/changeset/base/335057 Log: Oops, r335053 had an old version of the comment about 16-bit linux dev_t translation. Modified: head/sys/compat/linux/linux_stats.c Modified:

svn commit: r335053 - in head/sys: compat/freebsd32 compat/linux fs/nfsclient kern sys

Author: bde Date: Wed Jun 13 12:22:00 2018 New Revision: 335053 URL: https://svnweb.freebsd.org/changeset/base/335053 Log: Fix the encoding of major and minor numbers in 64-bit dev_t by restoring the old encodings for the lower 16 and 32 bits and only using the higher 32 bits for unusually

Re: svn commit: r335041 - head/lib/libc/stdlib

On Wed, 13 Jun 2018, Eitan Adler wrote: Log: libc: remove explicit cast NULL in atoi There isn't any reason to cast NULL so just remove it. Noticed when cleaning up top. There are many reasons to cast NULL for all members of the ato*() family: - it is required if no prototype is in scope

svn commit: r335035 - in head/sys: compat/freebsd32 compat/linux kern

Author: bde Date: Wed Jun 13 08:50:43 2018 New Revision: 335035 URL: https://svnweb.freebsd.org/changeset/base/335035 Log: Fix some bugs found while fixing the representation and translation of 64-bit dev_t's (but not ones involving dev_t's). st_size was supposed to be clamped in

Re: svn commit: r334928 - head/lib/libc/stdlib

On Mon, 11 Jun 2018, Konstantin Belousov wrote: On Mon, Jun 11, 2018 at 03:48:52PM +1000, Bruce Evans wrote: Change TYPE to unsigned char[sizeof(old TYPE)] and use memcpy() to assign the variables to fix this with small churn and without the pessimizations in this commit. This gives portable

Re: svn commit: r334928 - head/lib/libc/stdlib

On Sun, 10 Jun 2018, Konstantin Belousov wrote: Log: libc qsort(3): stop aliasing. Qsort swap code aliases the sorted array elements to ints and longs in order to do swap by machine words. Unfortunately this breaks with the full code optimization, e.g. LTO. See

svn commit: r334925 - in head/sys: amd64/amd64 x86/x86

Author: bde Date: Sun Jun 10 14:49:13 2018 New Revision: 334925 URL: https://svnweb.freebsd.org/changeset/base/334925 Log: Untangle configuration ifdefs a little. On x86, msi is optional on pci, and also on apic in common and i386 files (except for xen it is optional only on xenhvm), but

svn commit: r334924 - head/sys/i386/i386

Author: bde Date: Sun Jun 10 14:21:01 2018 New Revision: 334924 URL: https://svnweb.freebsd.org/changeset/base/334924 Log: Fix panics in potentially all x86bios calls on i386 since r332489. A call to npxsave() in the exception trampolines was not relocated. This call to a garbage address

Re: svn commit: r334702 - head/sys/sys

On Wed, 6 Jun 2018, Benjamin Kaduk wrote: On Wed, Jun 6, 2018 at 6:35 AM, Ravi Pokala wrote: Hi Mateusz, ... ... #ifdef _KERNEL #define malloc(size, type, flags) ({ \ Now that I'm taking another look at this, I'm confused as to why the entire macro expansion is inside

Re: svn commit: r334669 - head/sys/sys

On Tue, 5 Jun 2018, Eric van Gyzen wrote: On 06/05/2018 15:53, Ian Lepore wrote: On Tue, 2018-06-05 at 20:34 +, Eric van Gyzen wrote: Author: vangyzen Date: Tue Jun\xc2\xa0\xc2\xa05 20:34:11 2018 New Revision: 334669 URL: https://svnweb.freebsd.org/changeset/base/334669 Log: \xc2\xa0

Re: svn commit: r334604 - head/usr.bin/top

On Mon, 4 Jun 2018, Ian Lepore wrote: On Mon, 2018-06-04 at 05:27 +, Eitan Adler wrote: ... Log: \xa0 top(1): some nitpicks \xa0\xa0 \xa0 - prefer fully spelled names to "u_long" Why? I though we preferred the u_char, u_int, u_long spellings in BSD code? (I certainly prefer them, and I

svn commit: r334530 - in head: share/man/man4 sys/conf sys/dev/syscons

Author: bde Date: Sat Jun 2 14:07:27 2018 New Revision: 334530 URL: https://svnweb.freebsd.org/changeset/base/334530 Log: Improve defaults for per-CPU kernel console colors, especially with 2 or 4 CPUs. Add a compile-time option SC_KERNEL_CONS_ATTRS to control the defaults. Default

svn commit: r334529 - head/sys/dev/syscons

Author: bde Date: Sat Jun 2 10:36:30 2018 New Revision: 334529 URL: https://svnweb.freebsd.org/changeset/base/334529 Log: Use per-CPU attributes earlier. The per-CPU ts is not initialized early, so the global kernel ts is used early, but it ony has 1 (normal) attribute. Switch this to

svn commit: r334528 - head/sys/i386/include

Author: bde Date: Sat Jun 2 09:59:27 2018 New Revision: 334528 URL: https://svnweb.freebsd.org/changeset/base/334528 Log: Oops, the last minute reduction in the clobber list for i386 MCOUNT_OVERHEAD() in r334522 was too agressive. Only mcount exit preserves %eax and %edx. Modified:

svn commit: r334526 - head/sys/dev/syscons

Author: bde Date: Sat Jun 2 08:38:59 2018 New Revision: 334526 URL: https://svnweb.freebsd.org/changeset/base/334526 Log: Fix low-level locking during panics. The SCHEDULER_STOPPED() hack breaks locking generally, and mtx_trylock_*() especially. When mtx_trylock_*() returns nonzero,

svn commit: r334523 - in head/sys: amd64/conf conf i386/conf

Author: bde Date: Sat Jun 2 06:40:15 2018 New Revision: 334523 URL: https://svnweb.freebsd.org/changeset/base/334523 Log: Finish COMPAT_AOUT support for amd64. It wasn't in any amd64 or MI file in /sys/conf, so was unavailable in configurations that don't use modules, and was not testable

svn commit: r334522 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include

Author: bde Date: Sat Jun 2 05:48:44 2018 New Revision: 334522 URL: https://svnweb.freebsd.org/changeset/base/334522 Log: Fix high resolution kernel profiling just enough to not crash at boot time, especially for SMP. If configured, it turns itself on at boot time for calibration, so is

svn commit: r334520 - in head/sys: amd64/amd64 i386/i386 i386/include libkern

Author: bde Date: Sat Jun 2 04:25:09 2018 New Revision: 334520 URL: https://svnweb.freebsd.org/changeset/base/334520 Log: Fix recent breakages of kernel profiling, mostly on i386 (high resolution kernel profiling remains broken). memmove() was broken using ALTENTRY(). ALTENTRY() is

Re: svn commit: r334419 - head/sys/amd64/amd64

On Thu, 31 May 2018, Mateusz Guzik wrote: On Thu, May 31, 2018 at 09:19:58PM +1000, Bruce Evans wrote: On Thu, 31 May 2018, Mateusz Guzik wrote: Log: amd64: switch pagecopy from non-temporal stores to rep movsq As for pagezero, this pessimizes for machines with slow movsq and/or caches

Re: svn commit: r334419 - head/sys/amd64/amd64

On Thu, 31 May 2018, Mateusz Guzik wrote: Log: amd64: switch pagecopy from non-temporal stores to rep movsq As for pagezero, this pessimizes for machines with slow movsq and/or caches (mostly older machines). The copied data is accessed in part soon after and it results with additional

Re: svn commit: r334306 - in head: lib/libc/stdlib share/man/man3

On Tue, 29 May 2018, Eric van Gyzen wrote: Log: Cross-reference abort2(2) from a few man pages I didn't know abort2 existed until it was mentioned on a mailing list. Mention it in related pages so others can find it easily. MFC after: 3 days Sponsored by: Dell EMC Modified:

Re: svn commit: r334302 - head/sys/teken

On Mon, 28 May 2018, [UTF-8] Jean-S??bastien P??dron wrote: Log: teken: Sort DECSCUSR alphabetically While here, align columns again. Reported by: bde This unimproves the formatting of 73 lines to improve it for 1. The number of lines with msialigned columns remains unchanged at 1,

Re: svn commit: r334291 - head/lib/libc/string

On Mon, 28 May 2018, Ed Maste wrote: Log: strsep.3: don't silently ignore errors Reported by: bde MFC with: r334275 Thanks. Modified: head/lib/libc/string/strsep.3 == --- head/lib/libc/string/strsep.3

Re: svn commit: r334275 - head/lib/libc/string

On Mon, 28 May 2018, Marcelo Araujo wrote: Log: Update strsep(3) EXAMPLE section regards the usage of assert(3). As many people has pointed out, using assert(3) shall be not the best approach to verify if strdup(3) has allocated memory to string. Reviewed by: imp Modified:

Re: svn commit: r333945 - head/usr.bin/top

On Fri, 25 May 2018, Eitan Adler wrote: On 20 May 2018 at 23:39, Alexey Dokuchaev <da...@freebsd.org> wrote: On Mon, May 21, 2018 at 10:32:30AM +1000, Bruce Evans wrote: ... if (smpmode && namelength > SMPUNAMELEN) namelength = SMPUNAMELEN; el

Re: svn commit: r334171 - head

On Thu, 24 May 2018, Ed Maste wrote: Log: UPDATING: remove EOL whitespace in 20180523 entry This file has many other formatting errors. There are 2 more on just the line changed by this commit, and 1 of these is another implementation of EOL whitespace. Modified: head/UPDATING

Re: svn commit: r333995 - head/sys/teken

On Mon, 21 May 2018, [UTF-8] Jean-S??bastien P??dron wrote: Log: teken: Rename the "Set Cursor Style" sequence to match vt100.net docs This fixes inconsistencies with the rest of the `sequences` file. No functional changes. Requested by: ed Modified: head/sys/teken/sequences

Re: svn commit: r333945 - head/usr.bin/top

On Sun, 20 May 2018, Eitan Adler wrote: Log: top(1): set max username length based on system constant This changes previous behavior of calculating it at startup based on the current max username length. This is done because: - it is in theory possible for the max length to change at

Re: svn commit: r333669 - in head/sys: dev/vt kern sys teken

On Wed, 16 May 2018, Bruce Evans wrote: On Wed, 16 May 2018, [UTF-8] Jean-S??bastien P??dron wrote: Author: dumbbell Date: Wed May 16 09:01:02 2018 New Revision: 333669 URL: https://svnweb.freebsd.org/changeset/base/333669 Log: teken, vt(4): New callbacks to lock the terminal once

Re: svn commit: r333669 - in head/sys: dev/vt kern sys teken

On Wed, 16 May 2018, [UTF-8] Jean-S??bastien P??dron wrote: Author: dumbbell Date: Wed May 16 09:01:02 2018 New Revision: 333669 URL: https://svnweb.freebsd.org/changeset/base/333669 Log: teken, vt(4): New callbacks to lock the terminal once ... to process input, instead of inside each

Re: svn commit: r333503 - stable/11/sys/net

On Fri, 11 May 2018, Ian Lepore wrote: On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd wrote: Author: shurd Date: Fri May 11 20:40:26 2018 New Revision: 333503 URL:

Re: svn commit: r333482 - head/usr.bin/expand

On Fri, 11 May 2018, Eitan Adler wrote: Log: [expand] add __dead2 annotation to usage Declaring static functions as __dead2 has no good effect, but reduces portability and is a style bug. Compilers have always been able to see inside static functions and determine if they return. Primitive

Re: svn commit: r333461 - head/sys/amd64/amd64

On Thu, 10 May 2018, Konstantin Belousov wrote: On Fri, May 11, 2018 at 03:31:46AM +1000, Bruce Evans wrote: On Thu, 10 May 2018, Konstantin Belousov wrote: Log: Make fpusave() and fpurestore() on amd64 ifuncs. From now on, linking amd64 kernel requires either lld or newer ld.bfd

Re: svn commit: r333461 - head/sys/amd64/amd64

On Thu, 10 May 2018, Konstantin Belousov wrote: Log: Make fpusave() and fpurestore() on amd64 ifuncs. From now on, linking amd64 kernel requires either lld or newer ld.bfd. This breaks building with gcc: XX cc1: warnings being treated as errors XX ../../../amd64/amd64/fpu.c:195: warning:

Re: svn commit: r333344 - in head/sys: kern sys

On Mon, 7 May 2018, Mateusz Guzik wrote: Log: Inlined sched_userret. The tested condition is rarely true and it induces a function call on each return to userspace. Bumps getuid rate by about 1% on Broadwell. ... Modified: head/sys/kern/sched_4bsd.c

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

On Tue, 8 May 2018, Bruce Evans wrote: On Mon, 7 May 2018, Mateusz Guzik wrote: Log: amd64: replace libkern's memset and memmove with assembly variants ... memset is repurposed memcpy. The librkern variant is doing fishy stuff, including branching on 0 and calling bzero. You mean the old

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

On Mon, 7 May 2018, Mateusz Guzik wrote: Log: amd64: replace libkern's memset and memmove with assembly variants memmove is repurposed bcopy (arguments swapped, return value added) The libkern variant is a wrapper around bcopy, so this is a big improvement. This is a tiny improvement,

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

On Sat, 5 May 2018, Mateusz Guzik wrote: On Sat, May 5, 2018 at 2:38 AM, Bruce Evans <b...@optusnet.com.au> wrote: I don't believe the claimed speeding of using the optimized bcopy() in cpu_fetch_sycall_args() on amd64 (r333241). This changes the copy size from a variable to 6*8

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

On Sat, 5 May 2018, Mateusz Guzik wrote: On Sat, May 5, 2018 at 2:00 PM, Alexey Dokuchaev <da...@freebsd.org> wrote: On Sat, May 05, 2018 at 10:38:29AM +1000, Bruce Evans wrote: ... Summary: this change wouldn't have passed my review. I have used similar changes for 15-20 years but

Re: svn commit: r333265 - head/sys/sys

On Fri, 4 May 2018, Mateusz Guzik wrote: Log: Allow the compiler to use __builtin_memcpy In particular this allows the compiler to avoid heavy-handed machinery if the to be copied buffer is small. Reviewed by: jhb Bugs in this: Modified: head/sys/sys/systm.h

Re: svn commit: r333266 - head/sys/amd64/amd64

On Fri, 4 May 2018, Warner Losh wrote: On Fri, May 4, 2018 at 5:12 PM, Mateusz Guzik wrote: On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: Can we get the why in commit messages please? This sort of message doesnt provide

Re: svn commit: r333266 - head/sys/amd64/amd64

On Fri, 4 May 2018, Warner Losh wrote: While i wholeheartedly agree, an earlier commit explained why in this case. It allows the compiler to inline for small copies. [This should have been killfiled due to top-posting.] No, it has nothing to do with that. The compiler can inline either

Re: svn commit: r333242 - head/sys/kern

On Fri, 4 May 2018, John Baldwin wrote: On Friday, May 04, 2018 06:51:02 AM Matt Macy wrote: Author: mmacy Date: Fri May 4 06:51:01 2018 New Revision: 333242 URL: https://svnweb.freebsd.org/changeset/base/333242 Log: `dup1_processes -t 96 -s 5` on a dual 8160 x dup_before + dup_after

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

On Sat, 5 May 2018, Mateusz Guzik wrote: On Fri, May 4, 2018 at 5:53 PM, Brooks Davis wrote: On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL:

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

On Fri, 4 May 2018, Conrad Meyer wrote: On Fri, May 4, 2018 at 8:53 AM, Brooks Davis wrote: On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: Author: mjg Date: Fri May 4 04:00:48 2018 New Revision: 333240 URL: https://svnweb.freebsd.org/changeset/base/333240

Re: svn commit: r333010 - head/sys/mips/mips

On Fri, 27 Apr 2018, John Baldwin wrote: On Thursday, April 26, 2018 09:29:30 AM Ian Lepore wrote: On Thu, 2018-04-26 at 19:01 +0800, Li-Wen Hsu wrote: On Thu, Apr 26, 2018 at 7:59 AM, Ian Lepore wrote: On Wed, 2018-04-25 at 19:46 +, Li-Wen Hsu wrote: Author: lwhsu

Re: svn commit: r332860 - head/sys/kern

On Sat, 21 Apr 2018, Jonathan T. Looney wrote: Log: When running with INVARIANTS, the kernel contains extra checks. However, these assumptions may not hold true once we've panic'd. Therefore, the checks hold less value after a panic. Additionally, if one of the checks fails while we are

Re: svn commit: r332395 - head/sys/kern

On Tue, 10 Apr 2018, Ian Lepore wrote: URL: https://svnweb.freebsd.org/changeset/base/332395 Log: Use explicit_bzero() when cleaning values out of the kernel environment. Sometimes the values contain geli passphrases being communicated from loader(8) to the kernel, and some day the

Re: svn commit: r331369 - head/sys/vm

On Sat, 7 Apr 2018, Cy Schubert wrote: In message <201803230615.w2n6ftmj040...@slippy.cwsent.com>, Cy Schubert writes: In message <20180323150709.h...@besplex.bde.org>, Bruce Evans writes: On Thu, 22 Mar 2018, Jeff Roberson wrote: On Thu, 22 Mar 2018, Cy Schubert wrote: It br

Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86

On Fri, 6 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: remove GiB/MiB macros from param.h And instead define them in the files where they are used. Requested by: bde Thanks, but these files have a negative need for the macros. Modified: head/sys/amd64/amd64/mp_machdep.c

Re: svn commit: r332072 - head/sys/sys

On Thu, 5 Apr 2018, Warner Losh wrote: On Thu, Apr 5, 2018 at 9:46 AM, Roger Pau Monn?? wrote: On Thu, Apr 05, 2018 at 09:32:57AM -0600, Ian Lepore wrote: On Thu, 2018-04-05 at 14:31 +, Roger Pau Monn?? wrote: Log: introduce GiB and MiB macros ... +/* Unit

Re: svn commit: r332072 - head/sys/sys

On Thu, 5 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: introduce GiB and MiB macros This macros convert from GiB or MiB into bytes. This is undocumented namspace pollution with bad names and worse types. The better names GB and MB would be more likely to conflicted with code not written

Re: svn commit: r332073 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include x86/include x86/x86

On Thu, 5 Apr 2018, [UTF-8] Roger Pau Monn?? wrote: Log: x86: improve reservation of AP trampoline memory This has lots of style bugs. Mainly changing the KNF spelling of 'unsigned' as u_int to the verbose 'unsigned int' in code that used to be careful to use the KNF spelling.

<    1   2   3   4   5   6   7   8   9   10   >