On Tue, Apr 16, 2019 at 2:32 PM John Baldwin wrote:
> There are definitely places arc4random is used where sleeping is not allowed.
Sure.
> ipsec generating nonces for AES-CBC is one example I can think of off the
> top of my head.
IVs for AES-CBC are also a great example of a case we should be
Author: cem
Date: Tue Apr 16 17:12:17 2019
New Revision: 346282
URL: https://svnweb.freebsd.org/changeset/base/346282
Log:
random(4): Add is_random_seeded(9) KPI
The imagined use is for early boot consumers of random to be able to make
decisions based on whether random is available yet or
Hi Warner,
On Tue, Apr 16, 2019 at 8:47 AM Warner Losh wrote:
> On Tue, Apr 16, 2019 at 9:16 AM Ian Lepore wrote:
>> Isn't a file full of data which is distributed in identical form to
>> everyone the exact opposite of entropy?
Ian has the right idea.
> It's just to bootstrap entropy for insta
Hi Ruslan,
On Tue, Apr 16, 2019 at 8:38 AM Ruslan Bukin wrote:
>
> Hi I just got this:
>
> ...
> _sleep() at random_harvest_deregister_source+0x132
> random_harvest_deregister_source() at read_random+0xc4
> read_random() at vn_fsync_buf+0x594
> vn_fsync_buf() at arc4rand+0xd4
> arc4rand() at sche
Author: cem
Date: Mon Apr 15 18:49:04 2019
New Revision: 346251
URL: https://svnweb.freebsd.org/changeset/base/346251
Log:
random.3: Clarify confusing summary
random.3 is only "better" in contrast to rand.3. Both are non-cryptographic
pseudo-random number generators. The opening blurbs
Author: cem
Date: Mon Apr 15 18:40:36 2019
New Revision: 346250
URL: https://svnweb.freebsd.org/changeset/base/346250
Log:
random(4): Block read_random(9) on initial seeding
read_random() is/was used, mostly without error checking, in a lot of
very sensitive places in the kernel -- includ
Author: cem
Date: Sat Apr 13 04:42:17 2019
New Revision: 346175
URL: https://svnweb.freebsd.org/changeset/base/346175
Log:
sort(1): Memoize MD5 computation to reduce repeated computation
Experimentally, reduces sort -R time of a 148160 line corpus from about
3.15s to about 0.93s on this p
Author: cem
Date: Sat Apr 13 16:51:48 2019
New Revision: 346187
URL: https://svnweb.freebsd.org/changeset/base/346187
Log:
hexdump(1): Exit gracefully on format strings missing conversion
PR: 237263
Submitted by: Bojan Petrovic
Modified:
head/usr.bin/hexdump/hexdump.h
head
Author: cem
Date: Thu Apr 11 05:08:49 2019
New Revision: 346116
URL: https://svnweb.freebsd.org/changeset/base/346116
Log:
sort(1): Simplify and bound random seeding
Bound input file processing length to avoid the issue reported in [1]. For
simplicity, only allow regular file and charact
Author: cem
Date: Thu Apr 11 00:39:06 2019
New Revision: 346110
URL: https://svnweb.freebsd.org/changeset/base/346110
Log:
sort(1): Whitespace and style cleanup
No functional change.
Sponsored by: Dell EMC Isilon
Modified:
head/usr.bin/sort/sort.c
Modified: head/usr.bin/sort/sort.c
Hi Edward,
I have a question about this change below.
On Thu, Apr 11, 2019 at 4:22 AM Edward Tomasz Napierala
wrote:
>
> Author: trasz
> Date: Thu Apr 11 11:21:45 2019
> New Revision: 346120
> URL: https://svnweb.freebsd.org/changeset/base/346120
>
> Log:
> Use shared vnode locks for the ELF i
Author: cem
Date: Sat Apr 6 21:56:24 2019
New Revision: 345993
URL: https://svnweb.freebsd.org/changeset/base/345993
Log:
kern/subr_pctrie: Fix mismatched signedness in assertion comparison
'tos' is an index into an array and never holds a negative value. Correct
its signedness to match
Author: cem
Date: Sat Apr 6 20:38:44 2019
New Revision: 345991
URL: https://svnweb.freebsd.org/changeset/base/345991
Log:
kern/subr_pctrie: Convert old-style boolean_t to plain "bool"
No functional change.
Modified:
head/sys/kern/subr_pctrie.c
head/sys/sys/pctrie.h
Modified: head/sys
On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote:
>
> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes
> wrote:
> >
>
> > > +static const u_char dot_name[] = {
> > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > +static const u_char dotdot_name[] = {
> > > + '.', '.',' ',' ',' ',' ',
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote:
>
> On 4/5/19 9:51 PM, Conrad Meyer wrote:
> > static const u_char dot_name[11] = ". ";
> > static const u_char dotdot_name[11] = ".. ";
> >
> > Seems more clear to me
Author: cem
Date: Thu Apr 4 20:27:13 2019
New Revision: 345891
URL: https://svnweb.freebsd.org/changeset/base/345891
Log:
sort(1): randomcoll: Don't sort on ENOMEM
PR: 230792 (1/many)
Sponsored by: Dell EMC Isilon
Modified:
head/usr.bin/sort/coll.c
Modified: head/usr.bin/so
Author: cem
Date: Thu Apr 4 01:02:50 2019
New Revision: 345865
URL: https://svnweb.freebsd.org/changeset/base/345865
Log:
Replace read_random(9) with more appropriate arc4rand(9) KPIs
Reviewed by: ae, delphij
Sponsored by: Dell EMC Isilon
Differential Revision:https://reviews.
Author: cem
Date: Thu Apr 4 23:32:27 2019
New Revision: 345896
URL: https://svnweb.freebsd.org/changeset/base/345896
Log:
sort(1): randomcoll: Skip the memory allocation entirely
There's no reason to order based on strcmp of ASCII digests instead of
memcmp of the raw digests.
While
Author: cem
Date: Sun Mar 31 04:57:50 2019
New Revision: 345744
URL: https://svnweb.freebsd.org/changeset/base/345744
Log:
random(4): Attempt to persist entropy promptly
The goal of saving entropy in Fortuna is two-fold: (1) to provide early
availability of the random device (unblocking)
Hi Cy,
On Sun, Sep 1, 2019 at 3:23 PM Cy Schubert wrote:
>
> In message om>
> , Conrad Meyer writes:
>
> > Short version: no, we shouldn't [recommend the use of gets_s]. :-)
> >
> > Longer version: Annex K functions like gets_s have zero real adoption
>
On Sun, Sep 1, 2019 at 12:32 PM Cy Schubert wrote:
> In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes:
> > Author: emaste
> > Date: Sun Sep 1 16:12:05 2019
> > New Revision: 351659
> > URL: https://svnweb.freebsd.org/changeset/base/351659
> >
> > Log:
> > libc: remove
Sorry. Accidentally hit send instead of clicking in the edit box.
On Sun, Sep 1, 2019 at 2:12 PM Conrad Meyer wrote:
>
> On Sun, Sep 1, 2019 at 12:32 PM Cy Schubert wrote:
> >
> > In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes:
> > &g
On Sun, Sep 1, 2019 at 12:32 PM Cy Schubert wrote:
>
> In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes:
> > Author: emaste
> > Date: Sun Sep 1 16:12:05 2019
> > New Revision: 351659
> > URL: https://svnweb.freebsd.org/changeset/base/351659
> >
> > Log:
> > libc: remov
On Sun, Sep 1, 2019 at 9:12 AM Ed Maste wrote:
>
> Author: emaste
> Date: Sun Sep 1 16:12:05 2019
> New Revision: 351659
> URL: https://svnweb.freebsd.org/changeset/base/351659
>
> Log:
> libc: remove gets
>
> gets is unsafe and shouldn't be used (for many years now). Leave it in
> the exi
Thanks Li-Wen! Might it be less fragile to have the test fixture
create a file, if the test(s) will expect one to be present to read?
On Sat, Aug 31, 2019 at 7:42 AM Li-Wen Hsu wrote:
>
> Author: lwhsu
> Date: Sat Aug 31 14:41:58 2019
> New Revision: 351643
> URL: https://svnweb.freebsd.org/chan
Hi Alexander,
On Mon, Aug 26, 2019 at 10:27 AM Alexander Motin wrote:
>
> Author: mav
> Date: Mon Aug 26 17:27:36 2019
> New Revision: 351514
> ...
> - device_printf(dev,
> - "HotPlug Command Timed Out - forcing detach\n");
> - sc->flags &= ~(PCIB_HOT
n 8/24/19 1:43 PM, Konstantin Belousov wrote:
> > On Sat, Aug 24, 2019 at 11:47:52AM -0700, Conrad Meyer wrote:
> >> On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov
> >> wrote:
> >>>
> >>> On Sat, Aug 24, 2019 at 08:49:42AM -0700, Conrad Meyer
On Sun, Aug 25, 2019 at 6:47 PM Shawn Webb wrote:
> I wonder if something like this could be done:
Something like it could be; I suggested so two hours ago.
> Somewhere in ping(8):
> bool ping6_compat;
> if (strcmp(argv[0], "ping6")) {
> ping6_compat = true;
You've gotten the sense of t
Hi Alan, Hiroki,
It would be pretty easy to install a `ping6` link to the `ping(8)`
binary with different option parsing (conditional on argv[0]). That
removes most of the issues of code and space duplication, I think?
And the goal would be for the 'ping6' name to retain option
compatibility with
Hi Eugene,
This change introduced some style(9) violations.
On Sat, Aug 24, 2019 at 8:50 AM Eugene Grosbein wrote:
>
> Author: eugen
> Date: Sat Aug 24 15:50:13 2019
> New Revision: 351459
> URL: https://svnweb.freebsd.org/changeset/base/351459
> ...
> --- head/usr.bin/last/last.cSat Aug 24
On Sat, Aug 24, 2019 at 9:15 AM Konstantin Belousov wrote:
>
> On Sat, Aug 24, 2019 at 08:49:42AM -0700, Conrad Meyer wrote:
> > Hi Konstantin,
> >
> > What is the motivation for this change? The commit message doesn't
> > really describe why it was done.
>
Hi Konstantin,
What is the motivation for this change? The commit message doesn't
really describe why it was done.
Thanks,
Conrad
On Sat, Aug 24, 2019 at 8:28 AM Konstantin Belousov wrote:
>
> Author: kib
> Date: Sat Aug 24 15:28:40 2019
> New Revision: 351456
> URL: https://svnweb.freebsd.org
At expected peril of wading into a thread >4 emails deep,
@Warner, modern GCC reports a similar warning; it just doesn't become
an error (at least in CI?). I'm not sure of the mechanism. Maybe
CI-specific? Old GCC didn't have a -Wno-error for -Wcast-qual, so
-Wcast-qual + -Werror there produced
Hi Eugene,
Should this be done more generally? Last time I looked it seemed like
libxo was completely locale-unaware and just assumed all input was
UTF-8. It might make more sense to have libxo take locale into
account when formatting %s strings.
Best,
Conrad
On Thu, Aug 22, 2019 at 6:25 PM Eu
Author: cem
Date: Thu Aug 22 04:31:07 2019
New Revision: 351381
URL: https://svnweb.freebsd.org/changeset/base/351381
Log:
Fix i386 build after r351368
Reported by: cy
Submitted by: cy
Modified:
head/sys/gdb/gdb_main.c
Modified: head/sys/gdb/gdb_main.c
===
Author: cem
Date: Thu Aug 22 00:36:16 2019
New Revision: 351370
URL: https://svnweb.freebsd.org/changeset/base/351370
Log:
gdb(4): Style
No functional change.
I was surprised to find that no sys/ header already defines the -1 EOF
convention anywhere, so defined one locally.
Modified
Author: cem
Date: Thu Aug 22 00:35:17 2019
New Revision: 351369
URL: https://svnweb.freebsd.org/changeset/base/351369
Log:
gdb(4):amd64: Bump MI GDB_BUFSZ for more efficient transfers
A bigger buffer reduces the RTTs to transfer long messages and is otherwise
relatively harmless, especial
Author: cem
Date: Thu Aug 22 00:34:11 2019
New Revision: 351368
URL: https://svnweb.freebsd.org/changeset/base/351368
Log:
gdb(4): Implement qXfer:threads:read
This streams out an XML document over several GDB packets describing all
threads in the system; their ids, name, and any loosely
Author: cem
Date: Thu Aug 22 00:19:41 2019
New Revision: 351366
URL: https://svnweb.freebsd.org/changeset/base/351366
Log:
gdb(4): Add basic 'qSupported' support
This is where the host GDB tells us what features it supports, and we
respond with the list we support. For now, just report P
Author: cem
Date: Thu Aug 22 00:19:14 2019
New Revision: 351365
URL: https://svnweb.freebsd.org/changeset/base/351365
Log:
gdb(4): Include thread in Target Halt Reason
This saves a round trip of the gdb remote inferior attempting to find
the thread id of the halted thread.
Sponsored
Hi Xin Li,
On Wed, Aug 21, 2019 at 12:45 AM Xin LI wrote:
> URL: https://svnweb.freebsd.org/changeset/base/351324
>
> Log:
> The 'mtx' is on stack and can contain garbages that would cause mtx_init
> (and in turn lock_init) to think that the mutex was already initialized.
>
> --- head/sys/net
Author: cem
Date: Mon Aug 19 23:01:59 2019
New Revision: 351240
URL: https://svnweb.freebsd.org/changeset/base/351240
Log:
Fix stylistic nit in r351239
Meant to fix this before committing, but forgot.
Modified:
head/sys/gdb/gdb_main.c
Modified: head/sys/gdb/gdb_main.c
==
Author: cem
Date: Mon Aug 19 22:58:30 2019
New Revision: 351239
URL: https://svnweb.freebsd.org/changeset/base/351239
Log:
gdb(4): Support "qC" query
Sometimes GDB gets confused about what the current thread is. When it does,
it asks the remote: "Who am I?"
Answer it.
Modified:
h
Author: cem
Date: Mon Aug 19 22:57:03 2019
New Revision: 351238
URL: https://svnweb.freebsd.org/changeset/base/351238
Log:
gdb(4): Pack 'info threads' responses into fewer packets
We suffer at least one round trip ACK latency every command / packet that
GDB has to send and receive, and th
: BSD-2-Clause-FreeBSD
+ *
+ * Copyright (c) 2019 Conrad Meyer
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
Author: cem
Date: Sun Aug 18 16:04:01 2019
New Revision: 351191
URL: https://svnweb.freebsd.org/changeset/base/351191
Log:
random(4): Reorder configuration of random source modules
Move fast entropy source registration to the earlier
SI_SUB_RANDOM:SI_ORDER_FOURTH and move random_harvestq_
Author: cem
Date: Sun Aug 18 04:19:41 2019
New Revision: 351180
URL: https://svnweb.freebsd.org/changeset/base/351180
Log:
OFED: Fix accidental double-copy of rdma_sdp.h in r351176
The mistake came about like this: the first attempt to commit was blocked by
a pre-commit hook due to missin
Author: cem
Date: Sat Aug 17 18:54:07 2019
New Revision: 351176
URL: https://svnweb.freebsd.org/changeset/base/351176
Log:
OFED: Unbreak SDP support in ibcore
This regression was introduced in the r326169 Linux v4.9 Infiniband upgrade.
Restore the functionality.
Reviewed by: hselask
Author: cem
Date: Sat Aug 17 10:11:34 2019
New Revision: 351169
URL: https://svnweb.freebsd.org/changeset/base/351169
Log:
SDP: Fix brain-o from r351162
Lost in translation between different SDP stacks.
Reported by: hselasky
Modified:
head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_cm
Author: cem
Date: Sat Aug 17 03:09:03 2019
New Revision: 351163
URL: https://svnweb.freebsd.org/changeset/base/351163
Log:
OFED: Fix ib_mad.h ib_user_mad.h include to match new uapi path
Sponsored by: Dell EMC Isilon
Modified:
head/sys/ofed/include/rdma/ib_mad.h
Modified: head/sys/ofed/
Author: cem
Date: Sat Aug 17 03:07:41 2019
New Revision: 351162
URL: https://svnweb.freebsd.org/changeset/base/351162
Log:
SDP: Add a dbg() on QP events
Sponsored by: Dell EMC Isilon
Modified:
head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_cma.c
Modified: head/sys/ofed/drivers/infiniband/
Author: cem
Date: Sat Aug 17 03:06:46 2019
New Revision: 351161
URL: https://svnweb.freebsd.org/changeset/base/351161
Log:
SDP: Also log a nice status string in RX WC error dbg()
Sponsored by: Dell EMC Isilon
Modified:
head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_rx.c
Modified: head/sys
Author: cem
Date: Sat Aug 17 03:05:09 2019
New Revision: 351160
URL: https://svnweb.freebsd.org/changeset/base/351160
Log:
SDP: Include nice string names for raw event numbers in a dbg()
Sponsored by: Dell EMC Isilon
Modified:
head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_cma.c
Modified:
Author: cem
Date: Sat Aug 17 03:03:26 2019
New Revision: 351159
URL: https://svnweb.freebsd.org/changeset/base/351159
Log:
SDP: SYSCTL_DECL SDP-wide sysctl node in header
This allows use of the shared _net_inet_sdp in more than one compilation
unit. (Nothing in-tree uses this today, but
Author: cem
Date: Sat Aug 17 03:00:58 2019
New Revision: 351158
URL: https://svnweb.freebsd.org/changeset/base/351158
Log:
Linuxkpi: Prevent easy generated ctor name conflicts with prefix
Sponsored by: Dell EMC Isilon
Modified:
head/sys/compat/linuxkpi/common/include/linux/workqueue.h
M
Author: cem
Date: Thu Aug 15 00:39:53 2019
New Revision: 351062
URL: https://svnweb.freebsd.org/changeset/base/351062
Log:
random(4): Remove "EXPERIMENTAL" verbiage from concurrent operation
No functional change.
Add a verbose comment giving an example side-by-side comparison between t
7;Z'
+#defineCLOOP_COMP_ZSTD_DDP 'z'
#defineCLOOP_MINVER_LZMA CLOOP_MAJVER_3
#defineCLOOP_MINVER_ZLIB CLOOP_MAJVER_2
+#defineCLOOP_MINVER_ZSTD CLOOP_MAJVER_4
+
+#defineCLOOP_MINVER_RELIABLE_LASTBLKSZ CLOOP_MAJVER_4
stru
_mbr_enc.h
======
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/sbin/fdisk/fdisk_mbr_enc.h Tue Aug 13 20:06:55 2019
(r351001)
@@ -0,0 +1,34 @@
+/*-
+ * SPDX-License-Identifier: BSD
Author: cem
Date: Sat Aug 10 18:22:22 2019
New Revision: 350843
URL: https://svnweb.freebsd.org/changeset/base/350843
Log:
.gitignore: Add LINT kernel configurations generated into SRCDIR
Modified:
head/.gitignore
Modified: head/.gitignore
Author: cem
Date: Fri Aug 9 02:11:47 2019
New Revision: 350813
URL: https://svnweb.freebsd.org/changeset/base/350813
Log:
tools/tools/crypto: cryptokeytest: Fix build with newer OpenSSL
Also, drag into this decade.
Modified:
head/tools/tools/crypto/cryptokeytest.c
Modified: head/tools/
Thanks Warner for noticing and fixing this.
I've sent the patch upstream to hopefully be addressed there as well:
https://github.com/facebook/zstd/pull/1713
Best,
Conrad
On Thu, Aug 8, 2019 at 1:09 PM Warner Losh wrote:
>
> Author: imp
> Date: Thu Aug 8 20:09:36 2019
> New Revision: 350778
>
Author: cem
Date: Thu Aug 8 16:54:22 2019
New Revision: 350760
URL: https://svnweb.freebsd.org/changeset/base/350760
Log:
Update to Zstandard 1.4.2
The full release notes for 1.4.1 (skipped) and 1.4.2 can be found on Github:
https://github.com/facebook/zstd/releases/tag/v1.4.1
h
Author: cem
Date: Thu Aug 8 15:38:57 2019
New Revision: 350755
URL: https://svnweb.freebsd.org/changeset/base/350755
Log:
tag zstd 1.4.2
Added:
vendor/zstd/1.4.2/
- copied from r350754, vendor/zstd/dist/
___
svn-src-all@freebsd.org mailing lis
Author: cem
Date: Thu Aug 8 15:37:56 2019
New Revision: 350754
URL: https://svnweb.freebsd.org/changeset/base/350754
Log:
import zstd 1.4.2
Added:
vendor/zstd/dist/contrib/seekable_format/examples/seekable_decompression_mem.c
(contents, props changed)
vendor/zstd/dist/lib/compress/zstd
Author: cem
Date: Thu Aug 8 15:32:53 2019
New Revision: 350753
URL: https://svnweb.freebsd.org/changeset/base/350753
Log:
tag zstd 1.4.1
Added:
vendor/zstd/1.4.1/
- copied from r350752, vendor/zstd/dist/
___
svn-src-all@freebsd.org mailing lis
Author: cem
Date: Thu Aug 8 15:30:49 2019
New Revision: 350752
URL: https://svnweb.freebsd.org/changeset/base/350752
Log:
import zstd 1.4.1
Added:
vendor/zstd/dist/tests/bigdict.c (contents, props changed)
vendor/zstd/dist/tests/fuzz/simple_compress.c (contents, props changed)
vendor
Author: cem
Date: Thu Aug 8 04:29:46 2019
New Revision: 350740
URL: https://svnweb.freebsd.org/changeset/base/350740
Log:
r350739 try #2
For some inexplicable reason, C++ compilers reject the -Wno- flag, and also
(ab)use CWARNFLAGS.
Reported by: imp
Modified:
head/share/mk/bsd.s
Author: cem
Date: Thu Aug 8 03:27:46 2019
New Revision: 350739
URL: https://svnweb.freebsd.org/changeset/base/350739
Log:
Disable useless -Wformat-zero-length
It is part of -Wformat, which is enabled by -Wall. Empty format strings are
well defined and it is perfectly reasonable to expec
Hi Rick,
Coverity reports that the following portion of
vn_generic_copy_file_range() is deadcode (CID 1403974), and it is:
On Wed, Jul 24, 2019 at 10:46 PM Rick Macklem wrote:
>
> Author: rmacklem
> Date: Thu Jul 25 05:46:16 2019
> New Revision: 350315
> URL: https://svnweb.freebsd.org/changeset
Author: cem
Date: Thu Aug 8 01:37:41 2019
New Revision: 350715
URL: https://svnweb.freebsd.org/changeset/base/350715
Log:
Fix !DDB kernel configurations after r350713
KDB is standard and the kdb_active variable is always available. So,
de-conditionalize inclusion of sys/kdb.h in kern_sy
Thanks Li-Wen Hsu!
On Wed, Aug 7, 2019 at 5:51 PM Li-Wen Hsu wrote:
>
> Author: lwhsu
> Date: Thu Aug 8 00:51:17 2019
> New Revision: 350714
> URL: https://svnweb.freebsd.org/changeset/base/350714
>
> Log:
> Follow r350693 to add a link for sbuf_nl_terminate(9)
>
> Sponsored by: The FreeBSD
Author: cem
Date: Thu Aug 8 00:42:29 2019
New Revision: 350713
URL: https://svnweb.freebsd.org/changeset/base/350713
Log:
ddb(4): Add 'sysctl' command
Implement `sysctl` in `ddb` by overriding `SYSCTL_OUT`. When handling the
req, we install custom ddb in/out handlers. The out handler p
4)
@@ -345,7 +345,8 @@ void g_reset_bio(struct bio *);
void * g_read_data(struct g_consumer *cp, off_t offset, off_t length, int
*error);
int g_write_data(struct g_consumer *cp, off_t offset, void *ptr, off_t length);
int g_delete_data(struct g_consumer *cp, off_t offset, off_t length);
-void g
Author: cem
Date: Wed Aug 7 19:27:14 2019
New Revision: 350693
URL: https://svnweb.freebsd.org/changeset/base/350693
Log:
sbuf(9): Add sbuf_nl_terminate() API
The API is used to gracefully terminate text line(s) with a single \n. If
the formatted buffer was empty or already ended in \n,
Author: cem
Date: Wed Aug 7 19:25:56 2019
New Revision: 350692
URL: https://svnweb.freebsd.org/changeset/base/350692
Log:
sbuf(9): Refactor sbuf_newbuf into sbuf_new
Code flow was somewhat difficult to read due to the combination of
multiple return sites and the 4x possible dynamic const
Author: cem
Date: Wed Aug 7 19:23:07 2019
New Revision: 350691
URL: https://svnweb.freebsd.org/changeset/base/350691
Log:
sbuf(9): Add NOWAIT dynamic buffer extension mode
The goal is to avoid some kinds of low-memory deadlock when formatting
heap-allocated buffers.
Reviewed by: va
Author: cem
Date: Tue Aug 6 03:54:27 2019
New Revision: 350624
URL: https://svnweb.freebsd.org/changeset/base/350624
Log:
amdtemp(4), amdsmn(4): Attach to Ryzen 3 (Zen 2) hostbridges
PR: 239607
Reported by: "drclaw"
Modified:
head/sys/dev/amdsmn/amdsmn.c
head/sys/dev/amdtemp/amd
Hi Philip,
Sorry I'm late to the party. Unless I am mistaken, most of these are
*not* overflows or vulnerabilities of any sort.
On Wed, Jul 10, 2019 at 10:42 AM Philip Paeps wrote:
>
> Author: philip
> Date: Wed Jul 10 17:42:04 2019
> New Revision: 349890
> URL: https://svnweb.freebsd.org/chang
On Sun, Jul 21, 2019 at 3:52 AM Dimitry Andric wrote:
> On 20 Jul 2019, at 22:56, Conrad Meyer wrote:
> > Author: cem
> > Date: Sat Jul 20 20:56:31 2019
> > New Revision: 350184
> > URL: https://svnweb.freebsd.org/changeset/base/350184
> >
> > Log:
> &
Author: cem
Date: Sat Jul 20 20:56:31 2019
New Revision: 350184
URL: https://svnweb.freebsd.org/changeset/base/350184
Log:
motd: Generate from template to /var/run
Update login(1), its manual pages, similar utilities, and motd.5 to refer to
the new location.
Suggested by: delphij@ (r
Hi Alan,
This change restores the possible overflow beyond IO_SEQMAX that the
removed conditional prevented.
On Tue, Jun 25, 2019 at 12:44 PM Alan Somers wrote:
>
> Author: asomers
> Date: Tue Jun 25 19:44:22 2019
> New Revision: 349391
> URL: https://svnweb.freebsd.org/changeset/base/349391
>
>
Hi,
Maybe the sense of the flag should be reversed? Ie, add a “trusted” flag
and default to untrusted.
I have two reasons in mind. The first is that a new default-off option is
easy to forget, and a missed security feature may be worse than a missed
mount-time performance enhancement.
The second
To this end, __result_use_check can help ensure no unchecked callers are
missed when panics are downgraded to errors. (In OneFS, the macro has the
imo more memorable name “__must_check”.
Cheers,
Conrad
On Thu, Jun 27, 2019 at 23:48 Scott Long wrote:
>
>
> > On Jun 27, 2019, at 3:09 PM, Konstant
Hi Xin Li,
On Mon, Jun 17, 2019 at 12:49 PM Xin LI wrote:
>
> Author: delphij
> Date: Mon Jun 17 19:49:08 2019
> New Revision: 349151
> URL: https://svnweb.freebsd.org/changeset/base/349151
>
> Log:
> Separate kernel crc32() implementation to its own header (gsb_crc32.h) and
> rename the sour
Author: cem
Date: Fri Jun 21 02:37:54 2019
New Revision: 349256
URL: https://svnweb.freebsd.org/changeset/base/349256
Log:
rc.d/motd: Update motd more robustly
Use appropriate fsyncs to persist the rewritten /etc/motd file, when a
rewrite is performed.
Reported by: Jonathan Walton
Author: cem
Date: Fri Jun 21 00:33:45 2019
New Revision: 349254
URL: https://svnweb.freebsd.org/changeset/base/349254
Log:
Fixup UPDATING text for r349253
Requested by: delphij
Modified:
head/UPDATING
Modified: head/UPDATING
==
Author: cem
Date: Fri Jun 21 00:16:30 2019
New Revision: 349253
URL: https://svnweb.freebsd.org/changeset/base/349253
Log:
sys: Remove DEV_RANDOM device option
Remove 'device random' from kernel configurations that reference it (most).
Replace perhaps mistaken 'nodevice random' in two MIP
Author: cem
Date: Tue Jun 18 18:50:58 2019
New Revision: 349176
URL: https://svnweb.freebsd.org/changeset/base/349176
Log:
random(4): Fix a regression in short AES mode reads
In r349154, random device reads of size < 16 bytes (AES block size) were
accidentally broken to loop forever. Cor
Author: cem
Date: Mon Jun 17 20:29:13 2019
New Revision: 349154
URL: https://svnweb.freebsd.org/changeset/base/349154
Log:
random(4): Fortuna: allow increased concurrency
Add experimental feature to increase concurrency in Fortuna. As this
diverges slightly from canonical Fortuna, and du
Author: cem
Date: Mon Jun 17 15:09:12 2019
New Revision: 349138
URL: https://svnweb.freebsd.org/changeset/base/349138
Log:
random(4): Generalize algorithm-independent APIs
At a basic level, remove assumptions about the underlying algorithm (such as
output block size and reseeding requirem
added)
+++ head/tests/sys/devrandom/uint128_test.c Mon Jun 17 14:59:45 2019
(r349137)
@@ -0,0 +1,225 @@
+/*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
+ * Copyright (c) 2019 Conrad Meyer
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with
On Mon, Jun 10, 2019 at 9:17 AM Bruce Evans wrote:
> Only headers and libraries should support -std=c89. has
> lots of support for compilers and POSIX versions going back to K&R C,
> and only the K&R parts are completely broken.
Is this due to specific policy, or just inertia? (No one has both
Hi Warner,
That doesn't seem responsive to the question.
On Mon, Jun 10, 2019 at 6:49 AM Warner Losh wrote:
>
>
>
> On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote:
>>
>> On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote:
>> > On Mon, 10 Jun 2
On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote:
> On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin
> wrote:
> > ...
> > URL: https://svnweb.freebsd.org/changeset/base/348847
> > Log:
> > Use C11 anonymous unions.
> >
> > Modified: head/sys/sys/ucred.h
> ...
>
> Isn't this a userland
Author: cem
Date: Mon Jun 10 13:34:18 2019
New Revision: 348854
URL: https://svnweb.freebsd.org/changeset/base/348854
Log:
/etc/rc.d/local: Fix typo in description
PR: 238448
Submitted by: Marián Černý
Modified:
head/libexec/rc/rc.d/local
Modified: head/libexec/rc/rc.d/loca
On Tue, Jun 4, 2019 at 6:31 PM Bruce Evans wrote:
> On Tue, 4 Jun 2019, Gleb Smirnoff wrote:
> > Why don't use C99 in 2019 instead of preprocessor define? Should be
> >
> > union {
> > void*_cr_unused1; /* compatibility with old ucred */
> > pid_t cr_pid;
On Tue, Jun 4, 2019 at 7:15 AM Shawn Webb wrote:
>
> On Tue, Jun 04, 2019 at 01:07:10PM +, Ed Maste wrote:
> > Author: emaste
> > Date: Tue Jun 4 13:07:10 2019
> > New Revision: 348611
> > URL: https://svnweb.freebsd.org/changeset/base/348611
> >
> > Log:
> > Expose the kernel's build-ID th
Author: cem
Date: Tue Jun 4 16:07:01 2019
New Revision: 348629
URL: https://svnweb.freebsd.org/changeset/base/348629
Log:
daemon(8): Don't block SIGTERM during restart delay
I believe this was introduced in the original '-r' commit, r231911 (2012).
At the time, the scope was limited to a
Author: cem
Date: Tue Jun 4 02:37:11 2019
New Revision: 348599
URL: https://svnweb.freebsd.org/changeset/base/348599
Log:
virtio(4): Add PNP match metadata for virtio devices
Register MODULE_PNP_INFO for virtio devices using the newbus PNP information
provided by the previous commit. Ma
Author: cem
Date: Tue Jun 4 02:34:59 2019
New Revision: 348598
URL: https://svnweb.freebsd.org/changeset/base/348598
Log:
virtio(4): Expose PNP metadata through newbus
Expose the same fields and widths from both vtio buses, even though they
don't quite line up; several virtio drivers can
401 - 500 of 1507 matches
Mail list logo
