svn commit: r336852 - head/lib/libc/gen

2018-07-28 Thread Conrad Meyer
Author: cem Date: Sat Jul 28 23:55:18 2018 New Revision: 336852 URL: https://svnweb.freebsd.org/changeset/base/336852 Log: exec.3: Add BUGS section and document non-FreeBSD portability Requested by: kib (in part) Modified: head/lib/libc/gen/exec.3 Modified: head/lib/libc/gen/exec.3

Re: svn commit: r336835 - head/lib/libc/gen

2018-07-28 Thread Conrad Meyer
On Sat, Jul 28, 2018 at 1:32 PM, Konstantin Belousov wrote: > Our existing practice is to not provide an advise in the man pages > for the userspace code which would harm the portability or the standard > conformance. Perhaps, but you do not have to look beyond this manual page to find that such

Re: svn commit: r336835 - head/lib/libc/gen

2018-07-28 Thread Conrad Meyer
On Sat, Jul 28, 2018 at 1:06 PM, Konstantin Belousov wrote: > On Sat, Jul 28, 2018 at 07:08:00PM +0000, Conrad Meyer wrote: >> For unclear reasons, POSIX' definition of these routines spells NULL as >> "(char *)0." This is needlessly unclear. One guess might b

svn commit: r336836 - head/release/tools

2018-07-28 Thread Conrad Meyer
Author: cem Date: Sat Jul 28 19:35:49 2018 New Revision: 336836 URL: https://svnweb.freebsd.org/changeset/base/336836 Log: Remove insecure ciphers from GCE sshd configuration They were added for unclear reasons in r277263. The current OpenSSH defaults (7.5+) are reasonable, and do not in

svn commit: r336835 - head/lib/libc/gen

2018-07-28 Thread Conrad Meyer
Author: cem Date: Sat Jul 28 19:08:00 2018 New Revision: 336835 URL: https://svnweb.freebsd.org/changeset/base/336835 Log: Clean up execl*(3) manual page prototype formatting Rendering of execle was missing a comma between the NULL argument and envp. For unclear reasons, POSIX' definit

svn commit: r336801 - head/contrib/libarchive/libarchive

2018-07-27 Thread Conrad Meyer
Author: cem Date: Sat Jul 28 00:59:59 2018 New Revision: 336801 URL: https://svnweb.freebsd.org/changeset/base/336801 Log: MFV r336800: libarchive: Cherry-pick upstream 2c8c83b9 Relevant vendor changes: Fix issue #948: out-of-bounds read in lha_read_data_none() admbugs: 877

svn commit: r336800 - vendor/libarchive/dist/libarchive

2018-07-27 Thread Conrad Meyer
Author: cem Date: Sat Jul 28 00:55:57 2018 New Revision: 336800 URL: https://svnweb.freebsd.org/changeset/base/336800 Log: libarchive: Cherry-pick upstream 2c8c83b9 Relevant vendor changes: Fix issue #948: out-of-bounds read in lha_read_data_none() admbugs: 877 Security:

Re: svn commit: r336757 - in head: share/man/man4 share/man/man7 share/misc sys/dev/firewire sys/dev/hwpmc sys/dev/sk sys/dev/sound/pci sys/dev/sound/pcm sys/fs/nfsclient

2018-07-27 Thread Conrad Meyer
This may intersect badly with our current policy of not shipping any CAs in base. Best, Conrad On Fri, Jul 27, 2018 at 3:40 AM, Eitan Adler wrote: > Author: eadler > Date: Fri Jul 27 10:40:48 2018 > New Revision: 336757 > URL: https://svnweb.freebsd.org/changeset/base/336757 > > Log: > Use htt

svn commit: r336527 - head/tools/tools/crypto

2018-07-19 Thread Conrad Meyer
Author: cem Date: Fri Jul 20 01:51:05 2018 New Revision: 336527 URL: https://svnweb.freebsd.org/changeset/base/336527 Log: cryptocheck: Correct mismatch between OpenSSL use and OCF Blake2 This corrects a mistake introduced to the cryptocheck tool in r331418. Our CRYPTO_BLAKE2B and CRYP

Re: svn commit: r336503 - in head/sys: netinet netinet6

2018-07-19 Thread Conrad Meyer
These changes mostly seem like style regressions, rather than improvements. (Not to mention, largescale churn like this makes it more difficult for future readers to research history (confusing tools like "git/svn blame").) On Thu, Jul 19, 2018 at 12:33 PM, Michael Tuexen wrote: > Author: tuexen

svn commit: r336489 - head/usr.sbin/newsyslog

2018-07-19 Thread Conrad Meyer
Author: cem Date: Thu Jul 19 16:03:20 2018 New Revision: 336489 URL: https://svnweb.freebsd.org/changeset/base/336489 Log: newsyslog.8: Remove cutesy nonsense Sponsored by: Dell EMC Isilon Modified: head/usr.sbin/newsyslog/newsyslog.8 Modified: head/usr.sbin/newsyslog/newsyslog.8 ==

svn commit: r336445 - head/sys/crypto/aesni

2018-07-17 Thread Conrad Meyer
Author: cem Date: Wed Jul 18 04:44:11 2018 New Revision: 336445 URL: https://svnweb.freebsd.org/changeset/base/336445 Log: Remove unused variable Reported by: gcc Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/aesni.c ===

svn commit: r336444 - head/sys/crypto/aesni

2018-07-17 Thread Conrad Meyer
Author: cem Date: Wed Jul 18 04:43:18 2018 New Revision: 336444 URL: https://svnweb.freebsd.org/changeset/base/336444 Log: aesni(4): Add SHA2-224(-HMAC) support as well Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/aesni.c ===

svn commit: r336443 - head/sys/crypto/aesni

2018-07-17 Thread Conrad Meyer
Author: cem Date: Wed Jul 18 04:37:14 2018 New Revision: 336443 URL: https://svnweb.freebsd.org/changeset/base/336443 Log: aesni(4): Add sha256 plain hash support Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/aesni.c =

svn commit: r336442 - head/sys/crypto/aesni

2018-07-17 Thread Conrad Meyer
Author: cem Date: Wed Jul 18 04:29:44 2018 New Revision: 336442 URL: https://svnweb.freebsd.org/changeset/base/336442 Log: aesni(4): Abstract out hash/HMAC support No functional change. Verified with cryptocheck. Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aes

svn commit: r336441 - head/sys/dev/glxsb

2018-07-17 Thread Conrad Meyer
Author: cem Date: Wed Jul 18 03:32:28 2018 New Revision: 336441 URL: https://svnweb.freebsd.org/changeset/base/336441 Log: glxsb: Convert remaining OCF driver to new interface glxsb, an i386 AMD Geode specific driver, was missed in r336439. Correct that mistake and adapt it to the new in

svn commit: r336439 - in head: share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe/crypto sys/dev/hifn sys/dev/safe sys/dev/s...

2018-07-17 Thread Conrad Meyer
Author: cem Date: Wed Jul 18 00:56:25 2018 New Revision: 336439 URL: https://svnweb.freebsd.org/changeset/base/336439 Log: OpenCrypto: Convert sessions to opaque handles instead of integers Track session objects in the framework, and pass handles between the framework (OCF), consumers, an

svn commit: r336352 - in head/sys: geom/eli kgssapi/krb5

2018-07-16 Thread Conrad Meyer
Author: cem Date: Mon Jul 16 19:01:05 2018 New Revision: 336352 URL: https://svnweb.freebsd.org/changeset/base/336352 Log: OCF: Convert consumers to the session id typedef These were missed in the earlier r336269. No functional change. Sponsored by: Dell EMC Isilon Modified: he

Re: svn commit: r336284 - in head/sys: modules/mac_veriexec_rmd160 security/mac_veriexec

2018-07-14 Thread Conrad Meyer
Thanks! On Sat, Jul 14, 2018 at 9:59 AM Stephen J. Kiernan wrote: > Author: stevek > Date: Sat Jul 14 16:59:17 2018 > New Revision: 336284 > URL: https://svnweb.freebsd.org/changeset/base/336284 > > Log: > Remove RIPEMD-160 fingerprint modules for veriexec, since it has very > little practic

svn commit: r336280 - head/sys/ufs/ffs

2018-07-14 Thread Conrad Meyer
Author: cem Date: Sat Jul 14 15:45:11 2018 New Revision: 336280 URL: https://svnweb.freebsd.org/changeset/base/336280 Log: ffs_syncvnode: Remove unhelpful print It can occur during ordinary use of softupdates, or perhaps if writes to the underlying media fail (causing bufs to be redirtied

svn commit: r336269 - in head/sys: netipsec opencrypto

2018-07-13 Thread Conrad Meyer
Author: cem Date: Fri Jul 13 23:46:07 2018 New Revision: 336269 URL: https://svnweb.freebsd.org/changeset/base/336269 Log: OCF: Add a typedef for session identifiers No functional change. This should ease the transition from an integer session identifier model to an opaque pointer mo

svn commit: r336268 - head/sys/dev/smartpqi

2018-07-13 Thread Conrad Meyer
Author: cem Date: Fri Jul 13 22:49:48 2018 New Revision: 336268 URL: https://svnweb.freebsd.org/changeset/base/336268 Log: Re-unbreak smartpqi(4) GCC build Like r333085, remove redundant declarations. Redundant declarations were re-introduced in r336201. Sponsored by: Dell EMC Isi

Re: svn commit: r336127 - head/usr.bin/gzip

2018-07-09 Thread Conrad Meyer
On Mon, Jul 9, 2018 at 1:37 AM, Conrad Meyer wrote: > Author: cem > Date: Mon Jul 9 08:37:55 2018 > New Revision: 336127 > URL: https://svnweb.freebsd.org/changeset/base/336127 > > Log: > gzip(1): Don't shadow global 'err' > > Unbreak work build on

svn commit: r336127 - head/usr.bin/gzip

2018-07-09 Thread Conrad Meyer
Author: cem Date: Mon Jul 9 08:37:55 2018 New Revision: 336127 URL: https://svnweb.freebsd.org/changeset/base/336127 Log: gzip(1): Don't shadow global 'err' Unbreak work build on ppc due to -Werror=shadow. Introduced in r336121. X-MFC-With: r336121 Modified: head/usr.bin

svn commit: r336126 - in head: lib/libcrypt lib/libmd sbin/md5

2018-07-09 Thread Conrad Meyer
Author: cem Date: Mon Jul 9 08:19:04 2018 New Revision: 336126 URL: https://svnweb.freebsd.org/changeset/base/336126 Log: Integrate SHA2-224 with userspace components The double compilation of the kernel sources in libmd and libcrypt is baffling, but add yet another define hack to preven

svn commit: r336125 - in head: sys/opencrypto tools/tools/crypto

2018-07-09 Thread Conrad Meyer
Author: cem Date: Mon Jul 9 07:28:13 2018 New Revision: 336125 URL: https://svnweb.freebsd.org/changeset/base/336125 Log: OCF: Add plain hash modes In part, to support OpenSSL's use of cryptodev, which puts the HMAC pieces in software and only offloads the raw hash primitive. The fo

svn commit: r336124 - in head: sys/opencrypto tools/tools/crypto

2018-07-09 Thread Conrad Meyer
Author: cem Date: Mon Jul 9 07:26:12 2018 New Revision: 336124 URL: https://svnweb.freebsd.org/changeset/base/336124 Log: OCF: Add CRYPTO_SHA2_224_HMAC mode Round out the complete set of basic SHA2 HMAC modes with SHA2-224. Support is added to the cryptocheck test tool. Modified: h

svn commit: r336123 - head/sys/crypto/sha2

2018-07-09 Thread Conrad Meyer
Author: cem Date: Mon Jul 9 07:24:05 2018 New Revision: 336123 URL: https://svnweb.freebsd.org/changeset/base/336123 Log: Implement SHA2-224 submode of SHA2-256 Like SHA2-384:SHA2-512, SHA2-224 is simply a truncated SHA2-256 with a different initial vector. Add to round out the complete

svn commit: r336122 - in head/sys: crypto/aesni crypto/ccp crypto/via dev/cesa dev/safe dev/ubsec opencrypto

2018-07-09 Thread Conrad Meyer
Author: cem Date: Mon Jul 9 07:21:37 2018 New Revision: 336122 URL: https://svnweb.freebsd.org/changeset/base/336122 Log: Remove "HMAC" from _HMAC_BLOCK_LEN macro names The block size is a property of the underlying hash algorithm, and has nothing to do with the HMAC construction. N

Re: svn commit: r336067 - head/sys/dev/ath

2018-07-07 Thread Conrad Meyer
On Sat, Jul 7, 2018 at 8:25 AM, Warner Losh wrote: > Author: imp > Date: Sat Jul 7 15:25:16 2018 > New Revision: 336067 > URL: https://svnweb.freebsd.org/changeset/base/336067 > > Log: > Switch to using new PCI_MATCH stuff. > > Modified: head/sys/dev/ath/if_ath_pci.c > =

svn commit: r336016 - head/sys/dev/ath

2018-07-05 Thread Conrad Meyer
Author: cem Date: Thu Jul 5 21:38:54 2018 New Revision: 336016 URL: https://svnweb.freebsd.org/changeset/base/336016 Log: ath(4): Fix typo in debugging code PR: 229548 Submitted by: David Binderman Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ===

Re: svn commit: r335836 - head/usr.bin/top

2018-07-01 Thread Conrad Meyer
On Sun, Jul 1, 2018 at 10:08 AM, Conrad Meyer wrote: > (Also, the patch in phabricator does not seem to match what was committed.) It seems the right phabricator URL is https://reviews.freebsd.org/D16058 . Best, Conrad ___ svn-src-all@freebsd.

Re: svn commit: r335836 - head/usr.bin/top

2018-07-01 Thread Conrad Meyer
Hi Daichi, On Sat, Jun 30, 2018 at 10:32 PM, Daichi GOTO wrote: > Author: daichi > Date: Sun Jul 1 05:32:03 2018 > New Revision: 335836 > URL: https://svnweb.freebsd.org/changeset/base/335836 > > Log: > top(1) - support UTF-8 display > > ... > ==

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Conrad Meyer
I think the right initializer is something like: *(kevp_) = (struct kevent) { ... .ext = { [0] = 0, [1] = 0, ... }, }; (I.e., use a C99 array static initializer to initialize the array member of struct kevent.) Best, Conrad On Thu, Jun 28, 2018 at 11:45 AM, Justin Hibbits wrote: > Hi David

svn commit: r335768 - head/lib/libc/sys

2018-06-28 Thread Conrad Meyer
Author: cem Date: Thu Jun 28 18:17:20 2018 New Revision: 335768 URL: https://svnweb.freebsd.org/changeset/base/335768 Log: sigaction.2: Minor cleanups Add vertical space between struct definition and function prototype. Use "NULL" to describe zero pointers, instead of "zero." Remo

svn commit: r335671 - head/share/man/man9

2018-06-26 Thread Conrad Meyer
Author: cem Date: Tue Jun 26 16:20:19 2018 New Revision: 335671 URL: https://svnweb.freebsd.org/changeset/base/335671 Log: atomic.9: Add missing MLINK for testandclear, thread_fence routines Missed in r299912, r326982. X-MFC-With: r299912, r326982 Sponsored by: Dell EMC Isilon Mod

svn commit: r335584 - head/sys/crypto/aesni

2018-06-23 Thread Conrad Meyer
Author: cem Date: Sat Jun 23 18:20:17 2018 New Revision: 335584 URL: https://svnweb.freebsd.org/changeset/base/335584 Log: aesni(4): Fix {de,en}crypt operations that allocated a buffer aesni(4) allocates a contiguous buffer for the data it processes if the provided input was not already v

svn commit: r335583 - head/sys/crypto/aesni

2018-06-23 Thread Conrad Meyer
Author: cem Date: Sat Jun 23 17:24:19 2018 New Revision: 335583 URL: https://svnweb.freebsd.org/changeset/base/335583 Log: aesni(4): Support CRD_F_KEY_EXPLICIT OCF mode PR: 227788 Reported by: eadler@ Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/a

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-21 Thread Conrad Meyer
On Thu, Jun 21, 2018 at 9:51 AM, Stephen Kiernan wrote: > On Wed, Jun 20, 2018 at 10:36 PM, Eitan Adler wrote: >> >> On 19 June 2018 at 20:08, Eitan Adler wrote: >> > On 19 June 2018 at 18:08, Stephen J. Kiernan wrote: >> >> Added: head/sbin/veriexecctl/Makefile >> >> >> >>

svn commit: r335498 - head/sys/libkern

2018-06-21 Thread Conrad Meyer
Author: cem Date: Thu Jun 21 17:35:13 2018 New Revision: 335498 URL: https://svnweb.freebsd.org/changeset/base/335498 Log: Sync strlcpy with userland version, again No functional change. Please remember to update libkern copies of libc functions when you update libc. Sponsored b

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
Hi Jon, On Wed, Jun 20, 2018 at 11:58 AM, Jonathan Anderson wrote: > On 20 Jun 2018, at 15:32, Jonathan T. Looney wrote: >> My reasoning >> was fairly simple: when a review has been open for over a year with no >> action, it seems like the submitter should be able to commit it without >> waiting

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
Hi Simon, Jonathan points out some of my comments were more acerbic than necessary. I apologize for that. I'd like to try to rephrase them in a more clear way. On Wed, Jun 20, 2018 at 8:43 AM, Conrad Meyer wrote: > On Tue, Jun 19, 2018 at 11:21 PM, Simon J. Gerraty wrote: >>

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
Ian, On Wed, Jun 20, 2018 at 8:58 AM, Ian Lepore wrote: > And I request exactly the opposite: reject the complaining of people > who think all the world is a 256-core 5ghz server First: no need to be so rude to other committers. The hyperbole doesn't help anyone and doesn't help communicate you

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
curity. On Tue, Jun 19, 2018 at 11:21 PM, Simon J. Gerraty wrote: > Conrad Meyer wrote: >> First and foremost: nothing is actually signed, anywhere. The > > The signing of manifests is external. The veriexecctl tool is I assume > a straight copy of what's in NetBSD (I

Re: svn commit: r335437 - in head: share/man/man4 sys/kern

2018-06-20 Thread Conrad Meyer
On Wed, Jun 20, 2018 at 8:36 AM, Bjoern A. Zeeb wrote: > On 20 Jun 2018, at 15:05, Conrad Meyer wrote: > >> Hi Bjoern, >> >> It might be nice to be explicit that the vnode was not in the >> namecache (in the ddb output) rather than failing silently. The name >>

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-20 Thread Conrad Meyer
You can keep these poor security modes in your downstream product if you want, but don't put them in the tree. On Wed, Jun 20, 2018 at 8:28 AM, Simon J. Gerraty wrote: > Benjamin Kaduk wrote: >> With all due respect, NIST is hardly the sole authority on this topic. > > True, unless of course you

Re: svn commit: r335437 - in head: share/man/man4 sys/kern

2018-06-20 Thread Conrad Meyer
Hi Bjoern, It might be nice to be explicit that the vnode was not in the namecache (in the ddb output) rather than failing silently. The name of the ddb method does not suggest that only entries in the namecache may be found, and users (developers :)) do not always read manual pages thoroughly.

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-19 Thread Conrad Meyer
, Conrad Meyer wrote: > On Tue, Jun 19, 2018 at 6:08 PM, Stephen J. Kiernan > wrote: >> Author: stevek >> Date: Wed Jun 20 01:08:54 2018 >> New Revision: 335402 >> URL: https://svnweb.freebsd.org/changeset/base/335402 >> >> Log: >> This application (

Re: svn commit: r335402 - head/sbin/veriexecctl

2018-06-19 Thread Conrad Meyer
On Tue, Jun 19, 2018 at 6:08 PM, Stephen J. Kiernan wrote: > Author: stevek > Date: Wed Jun 20 01:08:54 2018 > New Revision: 335402 > URL: https://svnweb.freebsd.org/changeset/base/335402 > > Log: > This application (veriexecctl) handles reading a fingerprints file Hi, This patchset needed des

Re: svn commit: r334947 - head/sys/modules

2018-06-16 Thread Conrad Meyer
r255185 added _mm_aesenc(), etc, but not _mm_sha*(). That's probably where the report comes from. (If you feel it is worth your while adding sha intrinsics to a decade-old GCC, go ahead, but I think gcc 4.2 on x86 is pretty dead.) Best, Conrad On Sat, Jun 16, 2018 at 7:57 AM, Kurt Lidl wrote:

Re: svn commit: r335223 - head/sys/dev/cxgbe

2018-06-15 Thread Conrad Meyer
This seems generally useful, and nothing about the code is specific to cxgbe. Could it be adapted to be driver-agnostic? Thanks, Conrad On Fri, Jun 15, 2018 at 11:04 AM, Navdeep Parhar wrote: > Author: np > Date: Fri Jun 15 18:04:44 2018 > New Revision: 335223 > URL: https://svnweb.freebsd.org/

svn commit: r335237 - head/sys/sys

2018-06-15 Thread Conrad Meyer
Author: cem Date: Fri Jun 15 20:57:02 2018 New Revision: 335237 URL: https://svnweb.freebsd.org/changeset/base/335237 Log: Bump __FreeBSD_version after r335227 The kerneldumpheader ABI is used by at least the netdumpd port. Bump __FreeBSD_version to reflect the change. Reported by:

svn commit: r335227 - head/sys/sys

2018-06-15 Thread Conrad Meyer
Author: cem Date: Fri Jun 15 19:02:53 2018 New Revision: 335227 URL: https://svnweb.freebsd.org/changeset/base/335227 Log: Retain offset compatibility with pre-12.0 dumps As a follow-up to r324965, which adds support for compressed kernel dumps, readjust dump header members slightly to mo

Re: svn commit: r335010 - head/usr.sbin/cpucontrol

2018-06-12 Thread Conrad Meyer
On Tue, Jun 12, 2018 at 11:58 AM, Sean Bruno wrote: > Author: sbruno > Date: Tue Jun 12 18:58:56 2018 > New Revision: 335010 > URL: https://svnweb.freebsd.org/changeset/base/335010 > > Log: > cpucontrol: > - fix debugging for family on AMD cpus and add useful debugging for > which file is

svn commit: r334738 - head/lib/libc/string

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 21:32:49 2018 New Revision: 334738 URL: https://svnweb.freebsd.org/changeset/base/334738 Log: strdup.3: Document standardization in POSIX Sponsored by: Dell EMC Isilon Modified: head/lib/libc/string/strdup.3 Modified: head/lib/libc/string/strdup.3 ==

svn commit: r334733 - head/lib/libc/string

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 20:09:21 2018 New Revision: 334733 URL: https://svnweb.freebsd.org/changeset/base/334733 Log: strcpy.3: Improve legibility and clarity In the DESCRIPTION, put the more commonly used functions first in the corresponding sentence, to help catch the eye. Pul

Re: svn commit: r334702 - head/sys/sys

2018-06-06 Thread Conrad Meyer
Hi Ben, Ravi, GCC/Clang are fine with the just curly braces, or just do/while(0). The core benefit of the ({ }) syntax is to allow multiple-statement macros to have expression syntax externally (i.e., yield a value) — which is not possible in standard C due to concession to simplistic parsers. B

svn commit: r334722 - head/sys/dev/puc

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 16:47:33 2018 New Revision: 334722 URL: https://svnweb.freebsd.org/changeset/base/334722 Log: puc(4): Add provisional support for Exar XR17V352 Reportedly, this is sufficient for 4800bps use, but maybe not any better. PR: 228781 Submitted by: pe

svn commit: r334721 - head/lib/msun/man

2018-06-06 Thread Conrad Meyer
Author: cem Date: Wed Jun 6 16:25:00 2018 New Revision: 334721 URL: https://svnweb.freebsd.org/changeset/base/334721 Log: clog.3, complex.3: Fix typos and igor style issues PR: 228783 Reported by: Karsten Modified: head/lib/msun/man/clog.3 head/lib/msun/man/complex.3 Mo

svn commit: r334625 - head/sys/netipsec

2018-06-04 Thread Conrad Meyer
Author: cem Date: Mon Jun 4 18:51:06 2018 New Revision: 334625 URL: https://svnweb.freebsd.org/changeset/base/334625 Log: Correctly handle the padding for IPv6-AH, as specified by RFC4302 The RFC specifies that under IPv6 the complete AH header must be 64 bit aligned, and under IPv4, 32

svn commit: r334624 - head/sys/libkern

2018-06-04 Thread Conrad Meyer
Author: cem Date: Mon Jun 4 18:47:14 2018 New Revision: 334624 URL: https://svnweb.freebsd.org/changeset/base/334624 Log: str(r)chr: Replace union abuse with __DECONST Writing one union member and reading another is technically illegal C, although we do it in many places in the tree. Us

svn commit: r334503 - head/usr.bin/at

2018-06-01 Thread Conrad Meyer
Author: cem Date: Fri Jun 1 22:57:19 2018 New Revision: 334503 URL: https://svnweb.freebsd.org/changeset/base/334503 Log: at.man: Bump .Dd missed in r334502 Sponsored by: Dell EMC Isilon Modified: head/usr.bin/at/at.man Modified: head/usr.bin/at/at.man =

svn commit: r334502 - in head: bin/date usr.bin/at usr.bin/last

2018-06-01 Thread Conrad Meyer
Author: cem Date: Fri Jun 1 22:37:59 2018 New Revision: 334502 URL: https://svnweb.freebsd.org/changeset/base/334502 Log: Update other man pages to match leap second reality Missed these in r334501; see justification there: https://svnweb.freebsd.org/base?view=revision&revision=334501

svn commit: r334501 - head/usr.bin/touch

2018-06-01 Thread Conrad Meyer
Author: cem Date: Fri Jun 1 22:34:59 2018 New Revision: 334501 URL: https://svnweb.freebsd.org/changeset/base/334501 Log: touch.1: Update to conform to POSIX 2004 POSIX borrowed the "double leap second" bug from C89. Double leap seconds can never happen. This mistake was present in at

svn commit: r334443 - head/sbin/dhclient

2018-05-31 Thread Conrad Meyer
Author: cem Date: Thu May 31 19:36:24 2018 New Revision: 334443 URL: https://svnweb.freebsd.org/changeset/base/334443 Log: dhclient(8): allow to supersede interface-mtu option In some cases broken DHCP servers might send invalid MTU value, so allow to use 'supersede' in dhclient.conf to o

Re: svn commit: r334375 - in head/sys: net netpfil/pf

2018-05-30 Thread Conrad Meyer
On Wed, May 30, 2018 at 5:41 AM, Kristof Provost wrote: > Odd. The other reports I got were mips only. I did test amd64. > Are you using gcc to build perhaps? > > r334379 should fix it. Hi Kristof, Oliver uses a non-GENERIC kernel, which often catches some oversights :-). I appreciate the promp

svn commit: r334170 - in head/sys: arm/conf conf dev/asmc kern modules/asmc

2018-05-24 Thread Conrad Meyer
Author: cem Date: Thu May 24 17:06:00 2018 New Revision: 334170 URL: https://svnweb.freebsd.org/changeset/base/334170 Log: Yank crufty INTR_FILTER option It was introduced to the tree in r169320 and r169321 in May 2007. It never got much use and never became a kernel default. The code

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

2018-05-24 Thread Conrad Meyer
On Thu, May 24, 2018 at 5:30 AM, Emeric POUPON wrote: > Actually we just store traffic profiles and the associated security policy > (SP). > A SP is basically just a bunch of traffic selectors, there is no key or other > sensitive information involved. Ok, thanks! Best, Conrad

Re: svn commit: r334120 - head/share/mk

2018-05-23 Thread Conrad Meyer
On Wed, May 23, 2018 at 6:28 PM, Eitan Adler wrote: > On 23 May 2018 at 14:26, Ed Maste wrote: >> Author: emaste >> Date: Wed May 23 21:26:33 2018 >> New Revision: 334120 >> URL: https://svnweb.freebsd.org/changeset/base/334120 >> >> Log: >> Revert r334081 (-Wmain) as it broke the build on gcc

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

2018-05-23 Thread Conrad Meyer
On Wed, May 23, 2018 at 12:23 AM, Emeric POUPON wrote: >> From: "Conrad Meyer" > >> Can users control arbitrary key_allocsp() calls? If so, it seems >> concerning to expose hit/miss stats on cached security keys. > > I am not sure to understand, could you

Re: svn commit: r334054 - in head: sys/kern sys/netipsec tools/tools/crypto usr.bin/netstat

2018-05-22 Thread Conrad Meyer
Can users control arbitrary key_allocsp() calls? If so, it seems concerning to expose hit/miss stats on cached security keys. On Tue, May 22, 2018 at 8:54 AM, Fabien Thomas wrote: > Author: fabient > Date: Tue May 22 15:54:25 2018 > New Revision: 334054 > URL: https://svnweb.freebsd.org/changese

Re: svn commit: r333885 - head/cddl/contrib/opensolaris/tools/ctf/cvt

2018-05-19 Thread Conrad Meyer
This is super nitpicky, and apologies, but: On Sat, May 19, 2018 at 11:50 AM, Matt Macy wrote: > Author: mmacy > Date: Sat May 19 18:50:58 2018 > New Revision: 333885 > URL: https://svnweb.freebsd.org/changeset/base/333885 > > Log: > ctf dwarf: don't report "no dwarf entry" as if it were an err

Re: svn commit: r333840 - head/sys/kern

2018-05-19 Thread Conrad Meyer
On Sat, May 19, 2018 at 2:33 AM, Konstantin Belousov wrote: > On Sat, May 19, 2018 at 04:07:00AM +, Matt Macy wrote: >> Author: mmacy >> Date: Sat May 19 04:07:00 2018 >> New Revision: 333840 >> URL: https://svnweb.freebsd.org/changeset/base/333840 >> >> Log: >> filt_timerdetach: only assign

Re: svn commit: r333703 - head/sys/vm

2018-05-17 Thread Conrad Meyer
On Wed, May 16, 2018 at 9:27 PM, Mark Johnston wrote: > Author: markj > Date: Thu May 17 04:27:08 2018 > New Revision: 333703 > URL: https://svnweb.freebsd.org/changeset/base/333703 > > Log: > Fix a race in vm_page_pagequeue_lockptr(). > > The value of m->queue must be cached after comparing i

svn commit: r333683 - head/sys/teken

2018-05-16 Thread Conrad Meyer
Author: cem Date: Wed May 16 18:12:49 2018 New Revision: 333683 URL: https://svnweb.freebsd.org/changeset/base/333683 Log: teken: Unbreak syscons' use of teken Only vt(4) initializes these callbacks non-NULL at this time, so invoke the function pointers conditionally. Broken in r3336

Re: svn commit: r333500 - head/sys/kern

2018-05-12 Thread Conrad Meyer
On Sat, May 12, 2018 at 5:10 AM, Andrew Turner wrote: > >> On 11 May 2018, at 19:37, Matt Macy wrote: >> >> Author: mmacy >> Date: Fri May 11 18:37:14 2018 >> New Revision: 333500 >> URL: https://svnweb.freebsd.org/changeset/base/333500 >> >> Log: >> epoch(9): always set inited in epoch_init > >

Re: svn commit: r333461 - head/sys/amd64/amd64

2018-05-11 Thread Conrad Meyer
On Fri, May 11, 2018 at 3:07 AM, Konstantin Belousov wrote: > On FreeBSD, gcc configuration requires explicit --enable-gnu-indirect-function > option. I see it in e.g. lang/gcc7 port Makefile. > > On the other hand, I do not understand how devel/amd64-xtoolchain-gcc > and devel/powerpc64-xtoolcha

Re: svn commit: r333461 - head/sys/amd64/amd64

2018-05-11 Thread Conrad Meyer
PR here, for the curious: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228161 On Fri, May 11, 2018 at 11:00 AM, Conrad Meyer wrote: > On Fri, May 11, 2018 at 3:07 AM, Konstantin Belousov > wrote: >> On FreeBSD, gcc configuration requires explicit >> --enable-gnu

Re: svn commit: r333494 - head/share/man/man7

2018-05-11 Thread Conrad Meyer
On Fri, May 11, 2018 at 8:26 AM, Rodney W. Grimes wrote: >> @@ -67,7 +72,8 @@ Changes are first committed to CURRENT and then usuall >> to STABLE. >> Every few years the CURRENT branch is renamed to STABLE, and a new >> CURRENT is branched, with an incremented major version number. >> -Releases

Re: svn commit: r333461 - head/sys/amd64/amd64

2018-05-10 Thread Conrad Meyer
On Thu, May 10, 2018 at 8:01 AM, Konstantin Belousov wrote: > Author: kib > Date: Thu May 10 15:01:43 2018 > New Revision: 333461 > URL: https://svnweb.freebsd.org/changeset/base/333461 > > Log: > Make fpusave() and fpurestore() on amd64 ifuncs. > > From now on, linking amd64 kernel requires e

Re: svn commit: r333324 - in head/sys: amd64/amd64 conf

2018-05-07 Thread Conrad Meyer
On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes wrote: >> + * w...@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > If the original is by w...@tools.de, who is this version by? > Or is this simply copied from some other FreeBSD file? This is covered thoroughly in lines 1-10 of th

Re: svn commit: r333304 - head/sys/netinet

2018-05-06 Thread Conrad Meyer
FYI, Coverity can detect this kind of issue scanning the kernel (not just usrsctp). It was detected as CID 1385266 on FreeBSD's Coverity Scan. Best, Conrad On Sun, May 6, 2018 at 7:19 AM, Michael Tuexen wrote: > Author: tuexen > Date: Sun May 6 14:19:50 2018 > New Revision: 04 > URL: https

Re: svn commit: r333240 - in head/sys: powerpc/powerpc sys

2018-05-04 Thread Conrad Meyer
On Fri, May 4, 2018 at 8:53 AM, Brooks Davis wrote: > On Fri, May 04, 2018 at 04:00:48AM +, Mateusz Guzik wrote: >> Author: mjg >> Date: Fri May 4 04:00:48 2018 >> New Revision: 333240 >> URL: https://svnweb.freebsd.org/changeset/base/333240 >> >> Log: >> Allow __builtin_memmove instead of

Re: svn commit: r333140 - head/usr.sbin/bhyve

2018-05-01 Thread Conrad Meyer
On Tue, May 1, 2018 at 10:18 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Tue, May 1, 2018 at 8:59 AM, Rodney W. Grimes >> wrote: >> > The All rights reserved clause is an obsolete requirement from the >> > 1910 Buenos Aires Convention, and should not be used o

Re: svn commit: r333140 - head/usr.sbin/bhyve

2018-05-01 Thread Conrad Meyer
On Tue, May 1, 2018 at 8:59 AM, Rodney W. Grimes wrote: > The All rights reserved clause is an obsolete requirement from the > 1910 Buenos Aires Convention, and should not be used on new code > since 2000. Can you please provide a source for that claim? Thanks, Conrad ___

svn commit: r333087 - head/sys/amd64/amd64

2018-04-28 Thread Conrad Meyer
Author: cem Date: Sat Apr 28 17:55:28 2018 New Revision: 333087 URL: https://svnweb.freebsd.org/changeset/base/333087 Log: amd64/mp_machdep.c: Fix GCC build after r333059 GCC warns about the potentially confusing use of the binary AND ('&') operator with a left operand containing an addit

svn commit: r333086 - head/sys/modules/smartpqi

2018-04-28 Thread Conrad Meyer
Author: cem Date: Sat Apr 28 17:43:51 2018 New Revision: 333086 URL: https://svnweb.freebsd.org/changeset/base/333086 Log: smartpqi(4): Use conventional path to driver sources Modified: head/sys/modules/smartpqi/Makefile Modified: head/sys/modules/smartpqi/Makefile ==

svn commit: r333085 - head/sys/dev/smartpqi

2018-04-28 Thread Conrad Meyer
Author: cem Date: Sat Apr 28 17:43:20 2018 New Revision: 333085 URL: https://svnweb.freebsd.org/changeset/base/333085 Log: smartpqi(4): Unbreak GCC build Remove redundant declarations. Modified: head/sys/dev/smartpqi/smartpqi_cam.c head/sys/dev/smartpqi/smartpqi_ioctl.c head/sys/dev/

Re: svn commit: r332957 - head/sys/kern

2018-04-24 Thread Conrad Meyer
I am fine with any optimization to this path you like, so long as locks are neutered in panic and don't cause secondary panics. On Tue, Apr 24, 2018 at 4:22 PM, Mateusz Guzik wrote: > On Tue, Apr 24, 2018 at 8:41 PM, Conrad Meyer wrote: >> >> Author: cem >> Date: Tue A

svn commit: r332962 - head/sys/kern

2018-04-24 Thread Conrad Meyer
Author: cem Date: Tue Apr 24 19:10:51 2018 New Revision: 332962 URL: https://svnweb.freebsd.org/changeset/base/332962 Log: Do not totally silence suppressed secondary kasserts unless debug.kassert.do_log is disabled To totally silence and ignore secondary kassert violations after a primary

svn commit: r332960 - head/sys/kern

2018-04-24 Thread Conrad Meyer
Author: cem Date: Tue Apr 24 18:59:40 2018 New Revision: 332960 URL: https://svnweb.freebsd.org/changeset/base/332960 Log: Fix debug.kassert.do_log description text This has been an (incorrect) copy-paste duplicate of debug.kassert.warn_only since it was originally committed in r243980.

svn commit: r332959 - head/sys/kern

2018-04-24 Thread Conrad Meyer
Author: cem Date: Tue Apr 24 18:54:20 2018 New Revision: 332959 URL: https://svnweb.freebsd.org/changeset/base/332959 Log: panic: Optionally, trace secondary panics To diagnose and fix secondary panics, it is useful to have a stack trace. When panic tracing is enabled, optionally trace se

svn commit: r332957 - head/sys/kern

2018-04-24 Thread Conrad Meyer
Author: cem Date: Tue Apr 24 18:41:14 2018 New Revision: 332957 URL: https://svnweb.freebsd.org/changeset/base/332957 Log: lockmgr: Add missed neutering during panic r313683 introduced new lockmgr APIs that missed the panic-time neutering present in the rest of our locks. Correct that by

Re: svn commit: r332860 - head/sys/kern

2018-04-24 Thread Conrad Meyer
Next time you encounter something like this, please file a bug. There's no reason to have broken kernel dumps for a year. It took 10 minutes to diagnose. On Tue, Apr 24, 2018 at 10:38 AM, Andrew Gallatin wrote: > On 04/24/18 13:24, Jonathan T. Looney wrote: >> >> On Mon, Apr 23, 2018 at 6:04 PM,

Re: svn commit: r332789 - head/usr.sbin/pwd_mkdb

2018-04-22 Thread Conrad Meyer
Maybe Relnotes: yes? On Thu, Apr 19, 2018 at 1:25 PM, Ed Maste wrote: > Author: emaste > Date: Thu Apr 19 20:25:19 2018 > New Revision: 332789 > URL: https://svnweb.freebsd.org/changeset/base/332789 > > Log: > pwd_mkdb: warn that legacy support is deprecated (if specified) > > r283981 switche

Re: svn commit: r332860 - head/sys/kern

2018-04-21 Thread Conrad Meyer
On Sat, Apr 21, 2018 at 10:41 AM, Bruce Evans wrote: > panic() can't return, but I see that KASSERT() has already been broken > to use kassert_panic() which does return in some cases including this > new one. Oddly enough, I find myself agreeing with Bruce on this. That kassert_panic does not al

Re: svn commit: r332860 - head/sys/kern

2018-04-21 Thread Conrad Meyer
On Sat, Apr 21, 2018 at 10:05 AM, Jonathan T. Looney wrote: > Author: jtl > Date: Sat Apr 21 17:05:00 2018 > New Revision: 332860 > URL: https://svnweb.freebsd.org/changeset/base/332860 > > Log: > When running with INVARIANTS, the kernel contains extra checks. However, > these assumptions may

svn commit: r332853 - in head/sys: conf modules/blake2 modules/crypto

2018-04-20 Thread Conrad Meyer
Author: cem Date: Sat Apr 21 02:08:56 2018 New Revision: 332853 URL: https://svnweb.freebsd.org/changeset/base/332853 Log: blake2: Disable warnings (not just error) for code we will not modify Leave libb2 pristine and silence the warnings for mjg. Modified: head/sys/conf/files head/sys

Re: svn commit: r332813 - head/sys/fs/nfsclient

2018-04-20 Thread Conrad Meyer
On Fri, Apr 20, 2018 at 4:38 AM, Rick Macklem wrote: > Author: rmacklem > Date: Fri Apr 20 11:38:29 2018 > New Revision: 332813 > URL: https://svnweb.freebsd.org/changeset/base/332813 > > Log: > Fix use of pointer after being set NULL. > > Using a pointer after setting it NULL is probably not

Re: svn commit: r332796 - head/tools/tools/sortbench

2018-04-19 Thread Conrad Meyer
The commit log describes what the commit does, but not why it was made. What's the eventual goal / direction that this change leads to? (The Phabricator revision doesn't elaborate further either.) Thanks, Conrad On Thu, Apr 19, 2018 at 2:53 PM, Brooks Davis wrote: > Author: brooks > Date: Thu

<    4   5   6   7   8   9   10   11   12   13   >