svn commit: r304555 - head/sys/compat/cloudabi

2016-08-21 Thread Ed Schouten
Author: ed Date: Sun Aug 21 07:41:11 2016 New Revision: 304555 URL: https://svnweb.freebsd.org/changeset/base/304555 Log: Use memcpy() to copy 64-bit timestamps into the syscall return values. On 32-bit platforms, our 64-bit timestamps need to be split up across two registers. A simple

svn commit: r304554 - in head/sys: conf contrib/cloudabi modules/cloudabi64

2016-08-21 Thread Ed Schouten
Author: ed Date: Sun Aug 21 07:28:38 2016 New Revision: 304554 URL: https://svnweb.freebsd.org/changeset/base/304554 Log: Rewrite the vDSOs for CloudABI in assembly. The reason why the old vDSOs were written in C using inline assembly was purely because they were embedded in the C

svn commit: r304484 - head/sys/compat/cloudabi64

2016-08-19 Thread Ed Schouten
Author: ed Date: Fri Aug 19 17:54:06 2016 New Revision: 304484 URL: https://svnweb.freebsd.org/changeset/base/304484 Log: Regenerate system call table after r304483. Modified: head/sys/compat/cloudabi64/cloudabi64_proto.h head/sys/compat/cloudabi64/cloudabi64_syscall.h

svn commit: r304483 - head/sys/contrib/cloudabi

2016-08-19 Thread Ed Schouten
Author: ed Date: Fri Aug 19 17:53:37 2016 New Revision: 304483 URL: https://svnweb.freebsd.org/changeset/base/304483 Log: Use the proper value for svn:keywords. Pointy hat to:me Modified: Directory Properties: head/sys/contrib/cloudabi/syscalls64.master (props changed)

svn commit: r304481 - head/sys/contrib/cloudabi

2016-08-19 Thread Ed Schouten
Author: ed Date: Fri Aug 19 17:51:52 2016 New Revision: 304481 URL: https://svnweb.freebsd.org/changeset/base/304481 Log: Add missing SVN keywords keyword. Modified: Directory Properties: head/sys/contrib/cloudabi/syscalls64.master (props changed)

svn commit: r304478 - in head: sys/compat/cloudabi sys/compat/cloudabi64 sys/contrib/cloudabi usr.bin/truss

2016-08-19 Thread Ed Schouten
Author: ed Date: Fri Aug 19 17:49:35 2016 New Revision: 304478 URL: https://svnweb.freebsd.org/changeset/base/304478 Log: Import the new automatically generated system call table for CloudABI. Now that we've switched over to using the vDSO on CloudABI, it becomes a lot easier for us to

Re: svn commit: r304221 - head/sys/boot/efi/boot1

2016-08-16 Thread Ed Schouten
hen be sure to also add a cast to the argument itself. It may not necessarily be equal to an intmax_t. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.free

Re: svn commit: r304185 - in head/sys: compat/cloudabi compat/linux kern sys

2016-08-15 Thread Ed Schouten
2016-08-15 22:13 GMT+02:00 Konstantin Belousov <kostik...@gmail.com>: > Thank you, and esp. thank you for handling of linux.ko. And thank you for adding fdatasync() support in the first place. \o/ -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands Kv

svn commit: r304185 - in head/sys: compat/cloudabi compat/linux kern sys

2016-08-15 Thread Ed Schouten
Author: ed Date: Mon Aug 15 20:11:52 2016 New Revision: 304185 URL: https://svnweb.freebsd.org/changeset/base/304185 Log: Eliminate use of sys_fsync() and sys_fdatasync(). Make the kern_fsync() function public, so that it can be used by other parts of the kernel. Fix up existing

svn commit: r304182 - head/sys/compat/cloudabi

2016-08-15 Thread Ed Schouten
Author: ed Date: Mon Aug 15 19:42:21 2016 New Revision: 304182 URL: https://svnweb.freebsd.org/changeset/base/304182 Log: Let CloudABI use fdatasync() as well. Now that FreeBSD supports fdatasync() natively, we can tidy up CloudABI's equivalent system call to use that instead. Modified:

svn commit: r304175 - head/contrib/netbsd-tests/lib/libc/gen

2016-08-15 Thread Ed Schouten
Author: ed Date: Mon Aug 15 19:05:41 2016 New Revision: 304175 URL: https://svnweb.freebsd.org/changeset/base/304175 Log: Disable tests for non-standard behaviour of dirname(3)/basename(3). The NetBSD ATF tests explicitly check that these functions do not modify their input. These tests

svn commit: r304172 - releng/11.0/sys/arm64/arm64

2016-08-15 Thread Ed Schouten
Author: ed Date: Mon Aug 15 17:58:12 2016 New Revision: 304172 URL: https://svnweb.freebsd.org/changeset/base/304172 Log: MFC r303923: Make cpu_set_user_tls() work when called on the running thread. On all the other architectures, this function can also be called on the

svn commit: r304148 - stable/11/sys/arm64/arm64

2016-08-15 Thread Ed Schouten
Author: ed Date: Mon Aug 15 11:16:43 2016 New Revision: 304148 URL: https://svnweb.freebsd.org/changeset/base/304148 Log: MFC r303923: Make cpu_set_user_tls() work when called on the running thread. On all the other architectures, this function can also be called on the

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Ed Schouten
nion, it shouldn't exist in the first place. As soon as you need it, you should have very likely used LIST_*() instead. It would be nice if we could at one point get rid of those bad macros, but I guess I may be too optimistic about that. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch

Re: svn commit: r304011 - head/libexec/rtld-elf

2016-08-12 Thread Ed Schouten
those macros in that run in linear time should be removed. Why not just use the proper data structure? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.f

svn commit: r303988 - head/lib/libc/gen

2016-08-12 Thread Ed Schouten
Author: ed Date: Fri Aug 12 07:03:58 2016 New Revision: 303988 URL: https://svnweb.freebsd.org/changeset/base/303988 Log: Reimplement dirname(3) to be thread-safe. Now that we've updated the prototypes of the basename(3) and dirname(3) functions to conform to POSIX, let's go ahead and

svn commit: r303941 - in head/sys: amd64/cloudabi64 arm64/cloudabi64 compat/cloudabi compat/cloudabi64 conf modules/cloudabi modules/cloudabi64

2016-08-10 Thread Ed Schouten
Author: ed Date: Wed Aug 10 21:02:41 2016 New Revision: 303941 URL: https://svnweb.freebsd.org/changeset/base/303941 Log: Provide the CloudABI vDSO to its executables. CloudABI executables already provide support for passing in vDSOs. This functionality is used by the emulator for OS X

svn commit: r303923 - head/sys/arm64/arm64

2016-08-10 Thread Ed Schouten
Author: ed Date: Wed Aug 10 15:45:25 2016 New Revision: 303923 URL: https://svnweb.freebsd.org/changeset/base/303923 Log: Make cpu_set_user_tls() work when called on the running thread. On all the other architectures, this function can also be called on the currently running thread. In

svn commit: r303920 - in head: include lib/libcrypt secure/lib/libcrypt

2016-08-10 Thread Ed Schouten
Author: ed Date: Wed Aug 10 15:16:28 2016 New Revision: 303920 URL: https://svnweb.freebsd.org/changeset/base/303920 Log: Make libcrypt thread-safe. Add crypt_r(3). glibc has a pretty nice function called crypt_r(3), which is nothing more than crypt(3), but thread-safe. It accomplishes

svn commit: r303833 - head/sys/contrib/cloudabi

2016-08-08 Thread Ed Schouten
Author: ed Date: Mon Aug 8 13:15:37 2016 New Revision: 303833 URL: https://svnweb.freebsd.org/changeset/base/303833 Log: Import vDSO-related source files from the CloudABI repository. CloudABI executables that are emulated on Mac OS X do not invoke system calls through "syscall".

svn commit: r303818 - head/sys/contrib/cloudabi

2016-08-07 Thread Ed Schouten
Author: ed Date: Sun Aug 7 21:23:55 2016 New Revision: 303818 URL: https://svnweb.freebsd.org/changeset/base/303818 Log: Sync in the latest CloudABI constants and data types. The only change is the addition of AT_SYSINFO_EHDR, which can be used for providing a vDSO. Obtained from:

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Ed Schouten
security > team into compatibility team, by constantly restoring removed code, such > code quickly becomes outdated and may add new security holes even being > inactive. +1. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 _

Re: svn commit: r303746 - head/usr.bin/indent

2016-08-07 Thread Ed Schouten
t it's faster than bsearch() in this specific case, but if Linux compatibility is important, then I'd say we'd better stick to bsearch(). Thanks for sharing your thoughts! -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 _

Re: svn commit: r303746 - head/usr.bin/indent

2016-08-06 Thread Ed Schouten
Hi Pedro, 2016-08-04 17:27 GMT+02:00 Pedro F. Giffuni <p...@freebsd.org>: > Log: > indent(1): Use bsearch() for looking up type keywords. You're never doing any deletions, right? Would it make more sense to use hsearch_r() in that case? -- Ed Schouten <e...@nuxi.nl> Nuxi

svn commit: r303762 - stable/11/lib/libc/gen

2016-08-04 Thread Ed Schouten
Author: ed Date: Fri Aug 5 05:50:27 2016 New Revision: 303762 URL: https://svnweb.freebsd.org/changeset/base/303762 Log: MFC r303486: Mention that basename(3) and dirname(3) will change in the future. Update the existing manual pages for basename(3) and dirname(3) to mention

svn commit: r303700 - head/sys/kern

2016-08-03 Thread Ed Schouten
Author: ed Date: Wed Aug 3 06:35:58 2016 New Revision: 303700 URL: https://svnweb.freebsd.org/changeset/base/303700 Log: Re-add traling slash that was removed in r303699. I must have accidentally pressed some random key in vim. Modified: head/sys/kern/syscalls.master Modified:

svn commit: r303701 - in head/sys: compat/freebsd32 kern sys

2016-08-03 Thread Ed Schouten
Author: ed Date: Wed Aug 3 06:36:45 2016 New Revision: 303701 URL: https://svnweb.freebsd.org/changeset/base/303701 Log: Regenerate system call tables for r303699 and r303700. Modified: head/sys/compat/freebsd32/freebsd32_proto.h head/sys/compat/freebsd32/freebsd32_syscall.h

svn commit: r303699 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys

2016-08-03 Thread Ed Schouten
Author: ed Date: Wed Aug 3 06:33:04 2016 New Revision: 303699 URL: https://svnweb.freebsd.org/changeset/base/303699 Log: mprotect(): Change prototype to comply to POSIX. Our mprotect() function seems to take a "const void *" address to the pages whose permissions need to be adjusted.

svn commit: r303580 - in head: include lib/libc/gen usr.sbin/pw

2016-07-31 Thread Ed Schouten
Author: ed Date: Sun Jul 31 08:05:15 2016 New Revision: 303580 URL: https://svnweb.freebsd.org/changeset/base/303580 Log: Fix up setgrent(3) to have a POSIX-compliant prototype. Just like with freelocale(3), I haven't been able to find any piece of code that actually makes use of this

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-31 Thread Ed Schouten
head-amd64-default/p419204_s303419/logs/errors/nethack34-3.4.3_9.log > http://beefy4.nyi.freebsd.org/data/head-amd64-default/p419204_s303419/logs/errors/nethack36-3.6.0.log Will take care of those. Thanks for letting me know! -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Ne

Re: svn commit: r303560 - head/usr.sbin/uathload

2016-07-30 Thread Ed Schouten
2016-07-30 22:39 GMT+02:00 Bjoern A. Zeeb <b...@freebsd.org>: > Rename devname to udevname after including stdlib.h in r303445 > as gcc trips over the devname(3) and reports 'shadows a global declaration'. Whoops! Sorry about that! -- Ed Schouten <e...@nuxi.nl> Nuxi

Re: svn commit: r303524 - in head: include lib/libc/stdio

2016-07-30 Thread Ed Schouten
rts tree have been fixed, it is time to remove this > FreeBSDism > > While here remove the extra parenthesis surrounding dprintf(3) Thanks for working on this. This was also on my TODO list, but thanks for beating me to it! -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenb

svn commit: r303495 - in head: include/xlocale lib/libc/locale

2016-07-29 Thread Ed Schouten
Author: ed Date: Fri Jul 29 17:18:47 2016 New Revision: 303495 URL: https://svnweb.freebsd.org/changeset/base/303495 Log: Change the return type of freelocale(3) to void. Our version of this function currently returns an integer indicating failure or success, whereas POSIX specifies that

svn commit: r303486 - head/lib/libc/gen

2016-07-29 Thread Ed Schouten
Author: ed Date: Fri Jul 29 16:25:09 2016 New Revision: 303486 URL: https://svnweb.freebsd.org/changeset/base/303486 Log: Mention that basename(3) and dirname(3) will change in the future. Update the existing manual pages for basename(3) and dirname(3) to mention that in future versions

Re: svn commit: r303464 - in head/sys: amd64/linux amd64/linux32 compat/freebsd32 compat/svr4 i386/ibcs2 i386/linux kern

2016-07-28 Thread Ed Schouten
n normal usage, developers just > have to clean up the mess. Thank you! -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/s

svn commit: r303451 - in head: include lib/libc/gen

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 16:20:27 2016 New Revision: 303451 URL: https://svnweb.freebsd.org/changeset/base/303451 Log: Fix up prototypes of basename(3) and dirname(3) to comply to POSIX. POSIX allows these functions to be implemented in a way that the resulting string is stored in the

svn commit: r303450 - head/usr.bin/xinstall

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 16:06:37 2016 New Revision: 303450 URL: https://svnweb.freebsd.org/changeset/base/303450 Log: Pull a copy of the input string before calling basename() and dirname(). POSIX allows implementations of these functions to modify their input. Modified:

svn commit: r303449 - head/usr.sbin/newsyslog

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 16:02:30 2016 New Revision: 303449 URL: https://svnweb.freebsd.org/changeset/base/303449 Log: Clean up use of basename() and dirname(). Pull copies of the input pathname string before calling basename() and dirname() to make this comply to POSIX. Free these

svn commit: r303445 - head/usr.sbin/uathload

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 15:33:19 2016 New Revision: 303445 URL: https://svnweb.freebsd.org/changeset/base/303445 Log: Call basename() and dirname() in the POSIXly correct way. Pull copies of the input string, as these functions are allowed to modify them. Free the copies after

svn commit: r303444 - head/usr.bin/grep

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 15:19:47 2016 New Revision: 303444 URL: https://svnweb.freebsd.org/changeset/base/303444 Log: Call basename() in a portable way. Pull a copy of the filename string before calling basename(). Change the loop to not return on its own, so we can put a free()

svn commit: r303443 - head/usr.bin/sed

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 15:17:12 2016 New Revision: 303443 URL: https://svnweb.freebsd.org/changeset/base/303443 Log: Don't call basename() and dirname() in an unportable way. POSIX allows these functions to modify their input buffer, so that they have storage for the return value.

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-28 Thread Ed Schouten
bits anyway. The first thing it does is cast the argument to an uint32_t, so even if we didn't properly zero/size extend this, it wouldn't end up being used. Best regards, -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 _

svn commit: r303436 - in head/sys: kern sys

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 12:22:34 2016 New Revision: 303436 URL: https://svnweb.freebsd.org/changeset/base/303436 Log: Regenerate system call table for r303435. Modified: head/sys/kern/init_sysent.c head/sys/kern/syscalls.c head/sys/kern/systrace_args.c head/sys/sys/syscall.h

svn commit: r303435 - in head: lib/libc/sys sys/kern sys/sys

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 12:22:01 2016 New Revision: 303435 URL: https://svnweb.freebsd.org/changeset/base/303435 Log: Change the return type of msgrcv() to ssize_t as required by POSIX. It looks like the msgrcv() system call is already written in such a way that the size is

svn commit: r303428 - in head: include lib/libc/net

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 10:05:41 2016 New Revision: 303428 URL: https://svnweb.freebsd.org/changeset/base/303428 Log: Add NI_NUMERICSCOPE. POSIX also declares NI_NUMERICSCOPE, which makes getnameinfo() return a numerical scope identifier. The interesting thing is that support for

svn commit: r303427 - in head/include: . xlocale

2016-07-28 Thread Ed Schouten
Author: ed Date: Thu Jul 28 09:50:19 2016 New Revision: 303427 URL: https://svnweb.freebsd.org/changeset/base/303427 Log: Change type of MB_CUR_MAX and MB_CUR_MAX_L() to size_t. POSIX requires that MB_CUR_MAX expands to an expression of type size_t. It currently expands to an int. As

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Ed Schouten
low standards ;). Not only that. This change only changes arguments from one integer type to the other. As far as I know, such a change would not cause a compiler to generate (substantially) different diagnostics. If it turns out I'm mistaken I'll reconsider, but for now this should do. :-) -- Ed S

svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Ed Schouten
Author: ed Date: Tue Jul 26 20:11:29 2016 New Revision: 303342 URL: https://svnweb.freebsd.org/changeset/base/303342 Log: Fix typing of srandom() and initstate(). POSIX requires that these functions have an unsigned int for their first argument; not an unsigned long. My reasoning is

svn commit: r303340 - in head/sys: compat/freebsd32 kern sys

2016-07-26 Thread Ed Schouten
Author: ed Date: Tue Jul 26 17:23:49 2016 New Revision: 303340 URL: https://svnweb.freebsd.org/changeset/base/303340 Log: Add shmatt_t. It looks like our "struct shmid_ds::shm_nattch" deviates from the standard in the sense that it is a signed integer, whereas POSIX requires that it is

Re: svn commit: r303338 - head/sys/dev/vt

2016-07-26 Thread Ed Schouten
if (kbd != NULL) > vt_save_kbd_state(vw, kbd); > + mtx_unlock(); > } Would it make sense to put an mtx_assert(, MA_OWNED) in kbd_get_keyboard()? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenb

Re: svn commit: r303046 - head/lib/libc/locale

2016-07-19 Thread Ed Schouten
visibility as hidden. How does this interact with symbol versioning/mapping? Wouldn't our C library's symbol map already make these symbols hidden without any explicit annotation? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 __

svn commit: r302627 - in stable/11/sys: amd64/cloudabi64 arm64/cloudabi64

2016-07-12 Thread Ed Schouten
Author: ed Date: Tue Jul 12 06:25:28 2016 New Revision: 302627 URL: https://svnweb.freebsd.org/changeset/base/302627 Log: MFC r302448: Don't forget to set sa->narg for CloudABI system calls. It turns out that this value is not used within the system call code under normal

svn commit: r302448 - in head/sys: amd64/cloudabi64 arm64/cloudabi64

2016-07-08 Thread Ed Schouten
Author: ed Date: Fri Jul 8 20:09:21 2016 New Revision: 302448 URL: https://svnweb.freebsd.org/changeset/base/302448 Log: Don't forget to set sa->narg for CloudABI system calls. It turns out that this value is not used within the system call code under normal conditions, except when

Re: svn commit: r302364 - head/usr.sbin/bhyve

2016-07-05 Thread Ed Schouten
ion for this issue will be proposed after ^/stable/11 is forked. This problem shouldn't exist when using C11's _Static_assert(), right? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebs

Re: svn commit: r302252 - head/sys/kern

2016-07-04 Thread Ed Schouten
s-guaranteed-to-wipe-padded-areas https://gustedt.wordpress.com/2012/10/24/c11-defects-initialization-of-padding/ -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org

Re: svn commit: r302252 - head/sys/kern

2016-07-04 Thread Ed Schouten
2016-07-04 10:26 GMT+02:00 Ed Schouten <e...@nuxi.nl>: > It is valid. The ".field = value" construct is called a 'designator' > in C's grammar specification. Typo: this is called a 'designation'. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the N

Re: svn commit: r302252 - head/sys/kern

2016-07-04 Thread Ed Schouten
he same as: struct foo bar = { .field = { [123].something = 456, [124].somethingelse = 789, }, }; And: struct foo bar = { .field = { [123] = { .something = 456 }, [124] = { .somethingelse = 789 }, }, }; Best regards, -- Ed Schouten <

svn commit: r302193 - stable/10/lib/libc/stdlib

2016-06-25 Thread Ed Schouten
Author: ed Date: Sat Jun 25 10:08:04 2016 New Revision: 302193 URL: https://svnweb.freebsd.org/changeset/base/302193 Log: MFC r300775: Let l64a() properly null terminate its result. Though the buffer used by l64a() is initialized with null bytes, repetetive calls may end up

svn commit: r302008 - stable/10/include

2016-06-18 Thread Ed Schouten
Author: ed Date: Sat Jun 18 12:46:50 2016 New Revision: 302008 URL: https://svnweb.freebsd.org/changeset/base/302008 Log: MFC r300998: Add missing va_list to . It looks like va_list should always be defined when XSI is enabled. It moved over to the POSIX base in the 2008

svn commit: r302006 - stable/10/sys/sys

2016-06-18 Thread Ed Schouten
Author: ed Date: Sat Jun 18 12:44:14 2016 New Revision: 302006 URL: https://svnweb.freebsd.org/changeset/base/302006 Log: MFC r301406: Don't test for INKERNEL to check whether we're in kernel space. It turns out that actually defines a macro under this name, even when we're

svn commit: r301696 - head/contrib/atf

2016-06-08 Thread Ed Schouten
Author: ed Date: Wed Jun 8 20:54:56 2016 New Revision: 301696 URL: https://svnweb.freebsd.org/changeset/base/301696 Log: Don't let ATF call basename() and dirname() in a non-standard way. POSIX basename() and dirname() are allowed to overwrite the input buffer. The advantage of

svn commit: r301406 - head/sys/sys

2016-06-04 Thread Ed Schouten
Author: ed Date: Sat Jun 4 18:57:00 2016 New Revision: 301406 URL: https://svnweb.freebsd.org/changeset/base/301406 Log: Don't test for INKERNEL to check whether we're in kernel space. It turns out that actually defines a macro under this name, even when we're not in kernelspace. This

svn commit: r301167 - head/lib/libcasper/services/cap_grp

2016-06-01 Thread Ed Schouten
Author: ed Date: Wed Jun 1 20:45:21 2016 New Revision: 301167 URL: https://svnweb.freebsd.org/changeset/base/301167 Log: Don't call setgrent() in an unportable way. For FreeBSD 12, I'm considering updating setgrent() to have a function prototype that conforms to POSIX. FreeBSD seems to

Re: svn commit: r301071 - head/sys/sys

2016-06-01 Thread Ed Schouten
way there would have been a way to expose just pthread_t and pthread_attr_t without pulling in the rest. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r301110 - head/sys/sys

2016-06-01 Thread Ed Schouten
Author: ed Date: Wed Jun 1 07:45:03 2016 New Revision: 301110 URL: https://svnweb.freebsd.org/changeset/base/301110 Log: Define the id_t type as required by POSIX. It seems that all versions of POSIX that I could find require that defines id_t. Define it together with rlim_t. While

svn commit: r301071 - head/sys/sys

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 19:05:41 2016 New Revision: 301071 URL: https://svnweb.freebsd.org/changeset/base/301071 Log: Improve POSIX conformance of . - This header file has always depended on pthread_t, pthread_attr_t, struct timespec, size_t and uid_t. Only as of POSIX 2008, these

svn commit: r301081 - head/sys/sys

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 21:34:02 2016 New Revision: 301081 URL: https://svnweb.freebsd.org/changeset/base/301081 Log: Make RLIM_INFINITY usable without including . By using __uint64_t instead of uint64_t, this constant can also be used if is included on its own. Modified:

svn commit: r301066 - in head: include lib/libc/db/hash lib/libc/db/man

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 18:32:57 2016 New Revision: 301066 URL: https://svnweb.freebsd.org/changeset/base/301066 Log: Fix prototype of dbm_open(). The last argument of dbm_open() should be a mode_t according to POSIX; not an int. Reviewed by: pfg, kib Differential Revision:

svn commit: r301074 - head/sys/sys

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 19:24:32 2016 New Revision: 301074 URL: https://svnweb.freebsd.org/changeset/base/301074 Log: Add missing dependency on . The SHMLBA definition provided by this header file is defined as PAGE_SIZE. PAGE_SIZE is only available when is included. Modified:

Re: svn commit: r300999 - in head: include lib/libc/db/man

2016-05-31 Thread Ed Schouten
ews.freebsd.org/D6660 If anyone wants to share their thoughts on the proposed change, feel free to leave a comment. I'll hold off for a couple of days before submitting. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 __

svn commit: r301038 - head/sys/sys

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 13:32:33 2016 New Revision: 301038 URL: https://svnweb.freebsd.org/changeset/base/301038 Log: Make CMSG_*() work without having NULL available. The is not supposed to declare NULL, according to POSIX. Our implementation complies with that, meaning that we

svn commit: r301037 - head/sys/x86/include

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 13:31:19 2016 New Revision: 301037 URL: https://svnweb.freebsd.org/changeset/base/301037 Log: Implement _ALIGN() using internal integer types. The existing version depends on register_t and uintptr_t, which are only available when including headers such as .

svn commit: r301035 - head/include

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 12:29:21 2016 New Revision: 301035 URL: https://svnweb.freebsd.org/changeset/base/301035 Log: Make strfmon_l() work without requiring the use of . The strfmon_l() function provided by is also part of POSIX 2008's , so it should be exposed by default.

svn commit: r301030 - head/sys/x86/include

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 08:38:24 2016 New Revision: 301030 URL: https://svnweb.freebsd.org/changeset/base/301030 Log: Add missing dependency on . In r227474, this header file was changed to define SIG_ATOMIC_{MIN,MAX} in terms of LONG_{MIN,MAX}. Unlike all of the definitions in this

svn commit: r301029 - head/sys/x86/include

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 08:36:39 2016 New Revision: 301029 URL: https://svnweb.freebsd.org/changeset/base/301029 Log: Add missing dependency on . This header uses __INT_MIN and __INT_MAX, which is provided by . This is needed to make 's WCHAR_MIN and WCHAR_MAX work without

svn commit: r301026 - head/sys/sys

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 08:07:40 2016 New Revision: 301026 URL: https://svnweb.freebsd.org/changeset/base/301026 Log: Let define struct timespec. POSIX 2004 doesn't require that this header defines struct timespec, but does allow it. For FreeBSD, we would at least need a forward

svn commit: r301024 - head/sbin/swapon

2016-05-31 Thread Ed Schouten
Author: ed Date: Tue May 31 06:45:19 2016 New Revision: 301024 URL: https://svnweb.freebsd.org/changeset/base/301024 Log: Stop using the non-standard basename_r() function. This change makes the code use the POSIX basename() function. It has the advantage that (if implemented correctly),

Re: svn commit: r300998 - head/include

2016-05-30 Thread Ed Schouten
pts to do automated tests of POSIX header file conformance and this just happened to pop up. Do you want me to MFC it? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mai

svn commit: r300999 - in head: include lib/libc/db/man

2016-05-30 Thread Ed Schouten
Author: ed Date: Mon May 30 16:52:23 2016 New Revision: 300999 URL: https://svnweb.freebsd.org/changeset/base/300999 Log: Let dbm's datum::dptr use the right type. According to POSIX, it should use void *, not char *. Unfortunately, the dsize field also has the wrong type. It should be

svn commit: r300998 - head/include

2016-05-30 Thread Ed Schouten
Author: ed Date: Mon May 30 16:26:34 2016 New Revision: 300998 URL: https://svnweb.freebsd.org/changeset/base/300998 Log: Add missing va_list to . It looks like va_list should always be defined when XSI is enabled. It moved over to the POSIX base in the 2008 edition. Modified:

svn commit: r300997 - in head: include lib/libc/gen

2016-05-30 Thread Ed Schouten
Author: ed Date: Mon May 30 13:51:27 2016 New Revision: 300997 URL: https://svnweb.freebsd.org/changeset/base/300997 Log: Fix the signature of the psignal() function. POSIX 2008 added the psignal() function which has already been part of the BSDs for a long time. The only difference is,

svn commit: r300996 - head/include

2016-05-30 Thread Ed Schouten
Author: ed Date: Mon May 30 13:37:11 2016 New Revision: 300996 URL: https://svnweb.freebsd.org/changeset/base/300996 Log: Add missing types and constants to . According to POSIX, the netdb.h header must also provide in_addr_t and in_port_t. It should also provide IPPORT_RESERVED. Copy

svn commit: r300991 - head/sys/sys

2016-05-30 Thread Ed Schouten
Author: ed Date: Mon May 30 09:18:12 2016 New Revision: 300991 URL: https://svnweb.freebsd.org/changeset/base/300991 Log: Add missing restrict keywords to lio_listio(). Modified: head/sys/sys/aio.h Modified: head/sys/sys/aio.h

svn commit: r300986 - head/include

2016-05-30 Thread Ed Schouten
Author: ed Date: Mon May 30 07:50:57 2016 New Revision: 300986 URL: https://svnweb.freebsd.org/changeset/base/300986 Log: Add missing declaration of ino_t. POSIX requires that provides ino_t in the XSI case. In our case, this wasn't being exposed, as d_ino is a macro that expands to

svn commit: r300960 - head/contrib/binutils/include

2016-05-29 Thread Ed Schouten
Author: ed Date: Sun May 29 16:10:01 2016 New Revision: 300960 URL: https://svnweb.freebsd.org/changeset/base/300960 Log: Replace local prototype of basename() with an inclusion of . libiberty currently defines the prototype for basename() itself instead of using . It still uses the

svn commit: r300955 - head/include

2016-05-29 Thread Ed Schouten
Author: ed Date: Sun May 29 12:21:54 2016 New Revision: 300955 URL: https://svnweb.freebsd.org/changeset/base/300955 Log: Fix style of the libgen.h header. - Remove unneeded declarations of removed/unimplemented features. - Add missing tab after #define. - Add missing ! before trailing

svn commit: r300952 - head/usr.sbin/services_mkdb

2016-05-29 Thread Ed Schouten
Author: ed Date: Sun May 29 10:41:27 2016 New Revision: 300952 URL: https://svnweb.freebsd.org/changeset/base/300952 Log: Invoke the dirname() function in a POSIX compliant way. POSIX requires that the argument of dirname() is of type "char *". In other words, the input buffer can be

Re: svn commit: r300935 - head/usr.sbin/rpc.statd

2016-05-29 Thread Ed Schouten
this has absolutely no meaning. Also, as we already live in the year 2016, please use the following construct in case you really want to mark this function as no-return: #include static noreturn void usage(void) { ... } In public header files where you likely don't want to pollute the name

Re: svn commit: r300824 - head/lib/libmd

2016-05-27 Thread Ed Schouten
trying to interpret C code as C++. We have quite a lot of public header files that contain static inline functions that also work well in C++ mode. is a good example. > Your proposed macro seems ok, although it is pretty long for where it > would be used. Maybe __min_size()? Sure! --

Re: svn commit: r300824 - head/lib/libmd

2016-05-27 Thread Ed Schouten
n) #endif That way we can annotate this everwhere we'd want, without needing to care about compiler versions, languages, etc. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mai

svn commit: r300775 - head/lib/libc/stdlib

2016-05-26 Thread Ed Schouten
Author: ed Date: Thu May 26 20:55:15 2016 New Revision: 300775 URL: https://svnweb.freebsd.org/changeset/base/300775 Log: Let l64a() properly null terminate its result. Though the buffer used by l64a() is initialized with null bytes, repetetive calls may end up having trailing garbage of

svn commit: r300741 - head/usr.bin/ar

2016-05-26 Thread Ed Schouten
Author: ed Date: Thu May 26 13:49:40 2016 New Revision: 300741 URL: https://svnweb.freebsd.org/changeset/base/300741 Log: Make code compile when basename() is POSIX compliant. In addition to the previous change I made to ar.c, pull in another basename() related fix. This change is

Re: svn commit: r300731 - head/sys/netinet

2016-05-26 Thread Ed Schouten
comments, instead of referring to it as a "bit-slice sorter algorithm"? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/lis

svn commit: r300669 - head/usr.sbin/pmcstat

2016-05-25 Thread Ed Schouten
Author: ed Date: Wed May 25 08:45:03 2016 New Revision: 300669 URL: https://svnweb.freebsd.org/changeset/base/300669 Log: Make code compile when basename() is POSIX compliant. The POSIX basename() function is allowed to modify its input buffer, which means its argument is "char *". Pull

Re: svn commit: r300322 - head/bin/ed

2016-05-20 Thread Ed Schouten
be simplified to just calling arc4random_buf() on pvec, right? -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717 ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To

Re: svn commit: r300301 - head/contrib/gcc

2016-05-20 Thread Ed Schouten
Hi Pedro, 2016-05-20 16:36 GMT+02:00 Pedro F. Giffuni <p...@freebsd.org>: > + tree anon = NULL_TREE; This initialization shouldn't be needed, right? The value is always assigned before used. -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands Kv

svn commit: r300227 - head/usr.bin/ar

2016-05-19 Thread Ed Schouten
Author: ed Date: Thu May 19 20:03:01 2016 New Revision: 300227 URL: https://svnweb.freebsd.org/changeset/base/300227 Log: Make code compile when basename() is POSIX compliant. If basename() uses "char *", we shouldn't do the intermediate assignment, as that field is of type "const char

svn commit: r298876 - in head: lib/libutil sbin/hastd usr.bin/newgrp

2016-05-01 Thread Ed Schouten
Author: ed Date: Sun May 1 08:22:11 2016 New Revision: 298876 URL: https://svnweb.freebsd.org/changeset/base/298876 Log: Remove useless calls to basename(). There are a couple of places in the source three where we call basename() on constant strings. This is bad, because the prototype

svn commit: r298624 - head/usr.sbin/bsdinstall/partedit

2016-04-26 Thread Ed Schouten
Author: ed Date: Tue Apr 26 10:04:06 2016 New Revision: 298624 URL: https://svnweb.freebsd.org/changeset/base/298624 Log: Remove unportable calls to basename(). The POSIX version of basename() doesn't use a 'const char *' argument; the function may overwrite its input buffer. Instead of

Re: svn commit: r297602 - in head: sys/sys usr.bin/sed

2016-04-06 Thread Ed Schouten
2016-04-06 2:55 GMT+02:00 Pedro F. Giffuni <p...@freebsd.org>: > Fix sed functions 'i' and 'a' from discarding leading white space. Thank you! -- Ed Schouten <e...@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717

<    1   2   3   4   5   6   7   8   9   10   >