svn commit: r299659 - head/sys/boot/i386/zfsboot

Author: ngie Date: Fri May 13 11:18:29 2016 New Revision: 299659 URL: https://svnweb.freebsd.org/changeset/base/299659 Log: Remove unused const variable MFC after: 1 week Reported by: clang Sponsored by: EMC / Isilon Storage Division Modified: head/sys/boot/i386/zfsboot/zfsboot.c

svn commit: r299657 - head/sys/cddl/boot/zfs

Author: ngie Date: Fri May 13 11:15:33 2016 New Revision: 299657 URL: https://svnweb.freebsd.org/changeset/base/299657 Log: Include arpa/inet.h to get the htonl(3) definition MFC after: 2 weeks Reported by: clang Sponsored by: EMC / Isilon Storage Division Modified:

svn commit: r299655 - head/sys/boot/i386/common

Author: ngie Date: Fri May 13 10:59:46 2016 New Revision: 299655 URL: https://svnweb.freebsd.org/changeset/base/299655 Log: Add missing prototype for getchar(..) MFC after: 1 week Reported by: clang Sponsored by: EMC / Isilon Storage Division Modified:

svn commit: r299654 - head/lib/libc/tests/nss

Author: ngie Date: Fri May 13 10:52:02 2016 New Revision: 299654 URL: https://svnweb.freebsd.org/changeset/base/299654 Log: Read the contents of the snapshot files properly - Use fgetln instead of fgets; localize complexity related to fgetln(3) inside the loop. - Skip over blank

svn commit: r299652 - stable/9/lib/libkvm

Author: ngie Date: Fri May 13 09:54:15 2016 New Revision: 299652 URL: https://svnweb.freebsd.org/changeset/base/299652 Log: MFstable/10 r299651: MFC r298839: Fix memory allocation edgecases in kvm_argv(..) - Don't leak nbufp on realloc failure in kvm_argv - Catch malloc errors

svn commit: r299651 - stable/10/lib/libkvm

Author: ngie Date: Fri May 13 09:52:39 2016 New Revision: 299651 URL: https://svnweb.freebsd.org/changeset/base/299651 Log: MFC r298839: Fix memory allocation edgecases in kvm_argv(..) - Don't leak nbufp on realloc failure in kvm_argv - Catch malloc errors with bufp - Set buflen

svn commit: r299650 - stable/9/lib/libkvm

Author: ngie Date: Fri May 13 09:50:38 2016 New Revision: 299650 URL: https://svnweb.freebsd.org/changeset/base/299650 Log: MFstable/10 r299649: MFC r298842: Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails CID: 1341474 Modified: stable/9/lib/libkvm/kvm_amd64.c

svn commit: r299649 - stable/10/lib/libkvm

Author: ngie Date: Fri May 13 09:49:52 2016 New Revision: 299649 URL: https://svnweb.freebsd.org/changeset/base/299649 Log: MFC r298842: Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails CID: 1341474 Modified: stable/10/lib/libkvm/kvm_amd64.c Directory Properties:

svn commit: r299648 - stable/10/etc/rc.d

Author: ngie Date: Fri May 13 09:46:23 2016 New Revision: 299648 URL: https://svnweb.freebsd.org/changeset/base/299648 Log: MFC r298844: Make SERVERS REQUIRE clean when MK_KERBEROS==no Make kdc run BEFORE SERVERS instead of being REQUIREd by SERVERS, so systems that pedantically

svn commit: r299645 - in stable/9: share/man/man8 tools/build/mk

Author: ngie Date: Fri May 13 09:33:48 2016 New Revision: 299645 URL: https://svnweb.freebsd.org/changeset/base/299645 Log: MFstable/10 r299643: MFC r299162,r299163: r299162: Only install NIS section 8 manpages if MK_NIS != no r299163: Fix r299162

svn commit: r299644 - stable/9/sys/ufs/ufs

Author: ngie Date: Fri May 13 09:32:05 2016 New Revision: 299644 URL: https://svnweb.freebsd.org/changeset/base/299644 Log: MFstable/10 r299640: MFC r298463: Add FEATURE knob for testing for UFS extended attribute kernel support Support can be verified via

svn commit: r299643 - in stable/10: share/man/man8 tools/build/mk

Author: ngie Date: Fri May 13 09:31:40 2016 New Revision: 299643 URL: https://svnweb.freebsd.org/changeset/base/299643 Log: MFC r299162,r299163: r299162: Only install NIS section 8 manpages if MK_NIS != no r299163: Fix r299162 share/man/man8/Makefile: - Add

svn commit: r299640 - stable/10/sys/ufs/ufs

Author: ngie Date: Fri May 13 09:18:46 2016 New Revision: 299640 URL: https://svnweb.freebsd.org/changeset/base/299640 Log: MFC r298463: Add FEATURE knob for testing for UFS extended attribute kernel support Support can be verified via `feature_present("ufs_extattr")`, etc.

svn commit: r299639 - stable/9/contrib/bsnmp/snmp_mibII

Author: ngie Date: Fri May 13 09:16:01 2016 New Revision: 299639 URL: https://svnweb.freebsd.org/changeset/base/299639 Log: MFstable/10 r299638: MFC r298462: Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This will also now detect error conditions with

svn commit: r299638 - stable/10/contrib/bsnmp/snmp_mibII

Author: ngie Date: Fri May 13 09:14:43 2016 New Revision: 299638 URL: https://svnweb.freebsd.org/changeset/base/299638 Log: MFC r298462: Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This will also now detect error conditions with value->var.subs[sub -

svn commit: r299636 - stable/9/sys/dev/aacraid

Author: ngie Date: Fri May 13 09:07:42 2016 New Revision: 299636 URL: https://svnweb.freebsd.org/changeset/base/299636 Log: MFstable/10 r299635: MFC r298665: r298665 (by cem): aacraid(4): Fix some mostly trivial buffer overruns strcpy(3) emits a trailing nul byte, trampling

svn commit: r299635 - stable/10/sys/dev/aacraid

Author: ngie Date: Fri May 13 09:06:52 2016 New Revision: 299635 URL: https://svnweb.freebsd.org/changeset/base/299635 Log: MFC r298665: r298665 (by cem): aacraid(4): Fix some mostly trivial buffer overruns strcpy(3) emits a trailing nul byte, trampling fields after the intended

svn commit: r299634 - stable/10/sys/dev/ciss

Author: ngie Date: Fri May 13 09:05:29 2016 New Revision: 299634 URL: https://svnweb.freebsd.org/changeset/base/299634 Log: MFC r298670: r298670 (by cem): ciss(4): Fix overrun of array The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members. Most of the time

svn commit: r299633 - stable/9/sys/dev/sound/midi

Author: ngie Date: Fri May 13 09:02:28 2016 New Revision: 299633 URL: https://svnweb.freebsd.org/changeset/base/299633 Log: MFstable/10 r299632: MFC r298339: r298339 (by cem): sound(4): Don't use-after-free in midi module unload Also, use ANSI function parameter definitions

svn commit: r299632 - stable/10/sys/dev/sound/midi

Author: ngie Date: Fri May 13 09:01:20 2016 New Revision: 299632 URL: https://svnweb.freebsd.org/changeset/base/299632 Log: MFC r298339: r298339 (by cem): sound(4): Don't use-after-free in midi module unload Also, use ANSI function parameter definitions (void) while here. CID:

svn commit: r299631 - stable/9/sys/dev/sym

Author: ngie Date: Fri May 13 08:59:49 2016 New Revision: 299631 URL: https://svnweb.freebsd.org/changeset/base/299631 Log: MFstable/10 r299630: MFC r298340: r298340 (by cem): sym(4): Don't double-free 'sim' in failure case CID: 1006106 Modified:

svn commit: r299630 - stable/10/sys/dev/sym

Author: ngie Date: Fri May 13 08:58:49 2016 New Revision: 299630 URL: https://svnweb.freebsd.org/changeset/base/299630 Log: MFC r298340: r298340 (by cem): sym(4): Don't double-free 'sim' in failure case CID: 1006106 Modified: stable/10/sys/dev/sym/sym_hipd.c Directory

svn commit: r299629 - stable/10/sys/geom/part

Author: ngie Date: Fri May 13 08:54:08 2016 New Revision: 299629 URL: https://svnweb.freebsd.org/changeset/base/299629 Log: MFC r298671,r298672: r298671 (by cem): g_part_bsd64: Check for valid on-disk npartitions value This value is u32 on disk, but assigned to an int in memory.

svn commit: r299628 - stable/9/sys/netipsec

Author: ngie Date: Fri May 13 08:51:51 2016 New Revision: 299628 URL: https://svnweb.freebsd.org/changeset/base/299628 Log: MFstable/10 r299627: MFC r298676: r298676 (by cem): netipsec: Don't leak memory when deep copy fails CID: 1331693 Modified:

svn commit: r299627 - stable/10/sys/netipsec

Author: ngie Date: Fri May 13 08:49:29 2016 New Revision: 299627 URL: https://svnweb.freebsd.org/changeset/base/299627 Log: MFC r298676: r298676 (by cem): netipsec: Don't leak memory when deep copy fails CID: 1331693 Modified: stable/10/sys/netipsec/ipsec.c Directory

svn commit: r299626 - stable/9/sys/kern

Author: ngie Date: Fri May 13 08:46:13 2016 New Revision: 299626 URL: https://svnweb.freebsd.org/changeset/base/299626 Log: MFstable/10 r299625: MFC r298677: r298677 (by cem): subr_mbpool: Don't free bogus pointer in error paths An mbpool is allocated with a contiguous array of

svn commit: r299625 - stable/10/sys/kern

Author: ngie Date: Fri May 13 08:44:59 2016 New Revision: 299625 URL: https://svnweb.freebsd.org/changeset/base/299625 Log: MFC r298677: r298677 (by cem): subr_mbpool: Don't free bogus pointer in error paths An mbpool is allocated with a contiguous array of mbpages. Freeing an

svn commit: r299624 - stable/9/sys/dev/pty

Author: ngie Date: Fri May 13 08:42:21 2016 New Revision: 299624 URL: https://svnweb.freebsd.org/changeset/base/299624 Log: MFstable/10 r299623: MFC r298337: r298337 (by cem): pty(4): Use strlcpy to guarantee destination buffer isn't overrun The devtoname() name is strcpyed

svn commit: r299623 - stable/10/sys/dev/pty

Author: ngie Date: Fri May 13 08:41:09 2016 New Revision: 299623 URL: https://svnweb.freebsd.org/changeset/base/299623 Log: MFC r298337: r298337 (by cem): pty(4): Use strlcpy to guarantee destination buffer isn't overrun The devtoname() name is strcpyed into a small stack buffer.

svn commit: r299622 - stable/10/sys/dev/drm2

Author: ngie Date: Fri May 13 08:39:33 2016 New Revision: 299622 URL: https://svnweb.freebsd.org/changeset/base/299622 Log: MFC r298334: r298334 (by cem): drm2(4): Fix double-free in low-memory error path Reallocf frees 'block'; don't attempt to free it again. CID:

svn commit: r299621 - stable/10/sys/dev/iscsi_initiator

Author: ngie Date: Fri May 13 08:36:33 2016 New Revision: 299621 URL: https://svnweb.freebsd.org/changeset/base/299621 Log: MFC r298669: r298669 (by cem): iscsi_initiator(4): Fix use-after-free, double-free ism_stop() already destroys and frees 'sp', including a call to

svn commit: r299620 - stable/9/sys/rpc/rpcsec_gss

Author: ngie Date: Fri May 13 08:34:53 2016 New Revision: 299620 URL: https://svnweb.freebsd.org/changeset/base/299620 Log: MFstable/10 r299619: MFC r298336: r298336 (by cem): kgssapi(4): Fix string overrun in Kerberos principal construction 'buf.value' was previously treated

svn commit: r299619 - stable/10/sys/rpc/rpcsec_gss

Author: ngie Date: Fri May 13 08:30:26 2016 New Revision: 299619 URL: https://svnweb.freebsd.org/changeset/base/299619 Log: MFC r298336: r298336 (by cem): kgssapi(4): Fix string overrun in Kerberos principal construction 'buf.value' was previously treated as a nul-terminated string,

svn commit: r299617 - in stable/10/sys/kgssapi: . krb5

Author: ngie Date: Fri May 13 08:25:06 2016 New Revision: 299617 URL: https://svnweb.freebsd.org/changeset/base/299617 Log: MFC r295134,r298338,r298655: r295134 (by cem): kcrypto_aes: Use separate sessions for AES and SHA1 Some hardware supports AES acceleration but not SHA1,

svn commit: r299618 - stable/9/sys/sys

Author: ngie Date: Fri May 13 08:25:17 2016 New Revision: 299618 URL: https://svnweb.freebsd.org/changeset/base/299618 Log: MFstable/10 r299616: MFC r298333: r298333 (by cem): Make Racct macro slightly more gracious given RACCT_UNDEFINED rctl_string_to_rule could previously

svn commit: r299616 - stable/10/sys/sys

Author: ngie Date: Fri May 13 08:17:42 2016 New Revision: 299616 URL: https://svnweb.freebsd.org/changeset/base/299616 Log: MFC r298333: r298333 (by cem): Make Racct macro slightly more gracious given RACCT_UNDEFINED rctl_string_to_rule could previously index below the zeroth

svn commit: r299615 - stable/10/sys/net

Author: ngie Date: Fri May 13 08:04:57 2016 New Revision: 299615 URL: https://svnweb.freebsd.org/changeset/base/299615 Log: MFC r298328: r298328 (by cem): bpf_getdltlist: Don't overrun 'lst' 'lst' is allocated with 'n1' members. 'n' indexes 'lst'. So 'n == n1' is an invalid

svn commit: r299614 - stable/9/sys/kern

Author: ngie Date: Fri May 13 08:04:03 2016 New Revision: 299614 URL: https://svnweb.freebsd.org/changeset/base/299614 Log: MFstable/10 r299613: MFC r298678: r298678 (by cem): posix4_mib: Don't overrun facility_initialized array The facility_initialized and facility arrays are

svn commit: r299613 - stable/10/sys/kern

Author: ngie Date: Fri May 13 07:56:14 2016 New Revision: 299613 URL: https://svnweb.freebsd.org/changeset/base/299613 Log: MFC r298678: r298678 (by cem): posix4_mib: Don't overrun facility_initialized array The facility_initialized and facility arrays are the same size and were

svn commit: r299169 - in head: etc/rc.d tools/build/mk

Author: ngie Date: Fri May 6 09:18:09 2016 New Revision: 299169 URL: https://svnweb.freebsd.org/changeset/base/299169 Log: Only install etc/rc.d/{rfcomm_pppd_server,sdpd} if MK_BLUETOOTH != no These are bluetooth specific services MFC after: 1 week Sponsored by: EMC / Isilon

svn commit: r299163 - in head: share/man/man8 tools/build/mk

Author: ngie Date: Fri May 6 08:53:24 2016 New Revision: 299163 URL: https://svnweb.freebsd.org/changeset/base/299163 Log: Fix r299162 share/man/man8/Makefile: - Add src.opts.mk so MK_NIS can be tested - Fix typo in MK_NIS conditional tools/build/mk/OptionalObsoleteFiles.inc: -

svn commit: r299162 - in head: share/man/man8 tools/build/mk

Author: ngie Date: Fri May 6 08:42:33 2016 New Revision: 299162 URL: https://svnweb.freebsd.org/changeset/base/299162 Log: Only install NIS section 8 manpages if MK_NIS != no MFC after: 1 week Sponsored by: EMC / Isilon Storage Division Modified: head/share/man/man8/Makefile

svn commit: r299112 - stable/9/lib/libcam

Author: ngie Date: Thu May 5 08:17:55 2016 New Revision: 299112 URL: https://svnweb.freebsd.org/changeset/base/299112 Log: MFstable/10 r299111: MFC r297999: Clean up trailing whitespace in lib/libcam; no functional change Modified: stable/9/lib/libcam/camlib.c

svn commit: r299111 - stable/10/lib/libcam

Author: ngie Date: Thu May 5 08:11:36 2016 New Revision: 299111 URL: https://svnweb.freebsd.org/changeset/base/299111 Log: MFC r297999: Clean up trailing whitespace in lib/libcam; no functional change Modified: stable/10/lib/libcam/camlib.c stable/10/lib/libcam/camlib.h Directory

svn commit: r299108 - head/sys/sys

Author: ngie Date: Thu May 5 02:51:31 2016 New Revision: 299108 URL: https://svnweb.freebsd.org/changeset/base/299108 Log: Revert r299096 The change broke buildworld when building lib/libkvm This change likely needs to be run through a ports -exp run as a sanity check, as it might

svn commit: r299094 - in head: bin/cat/tests bin/date/tests bin/dd/tests bin/expr/tests bin/ls/tests bin/mv/tests bin/pax/tests bin/pkill/tests bin/sh/tests bin/sh/tests/builtins bin/sh/tests/error...

Author: ngie Date: Wed May 4 23:20:53 2016 New Revision: 299094 URL: https://svnweb.freebsd.org/changeset/base/299094 Log: Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installed after r298107 Summary of changes: - Replace all instances of FILES/TESTS with

svn commit: r299088 - head

Author: ngie Date: Wed May 4 21:15:28 2016 New Revision: 299088 URL: https://svnweb.freebsd.org/changeset/base/299088 Log: Default NO_INSTALLEXTRAKERNELS to yes, not no The old (^/stable/9) default was yes, not no ("no" was the new default introduced recently that broke POLA). Restore

svn commit: r299086 - head

Author: ngie Date: Wed May 4 21:00:41 2016 New Revision: 299086 URL: https://svnweb.freebsd.org/changeset/base/299086 Log: Default NO_INSTALLEXTRAKERNELS to "no" to unbreak the build MFC after: soon (was insta-MFCed -_-..) Pointyhat to: glebius Sponsored by: EMC / Isilon Storage

svn commit: r299059 - stable/10/contrib/netbsd-tests/lib/libc/sys

Author: ngie Date: Wed May 4 07:39:23 2016 New Revision: 299059 URL: https://svnweb.freebsd.org/changeset/base/299059 Log: MFC r298366: Fix coverity issues with contrib/netbsd-tests/lib/libc/sys/t_connect.c - Ensure socket(2) calls succeed - Don't leak slist allocated by earlier

svn commit: r299058 - stable/10/tests/sys/posixshm

Author: ngie Date: Wed May 4 07:37:02 2016 New Revision: 299058 URL: https://svnweb.freebsd.org/changeset/base/299058 Log: MFC r298304: Fix issues identified by Coverity - Always munmap memory regions after mmap'ing them. - Make sure getpagesize() returns a value greater than 0 and

svn commit: r299057 - stable/10/tests/sys/vm

Author: ngie Date: Wed May 4 07:35:43 2016 New Revision: 299057 URL: https://svnweb.freebsd.org/changeset/base/299057 Log: MFC r298301: Fix leaks and test for getpagesize() returning == -1 - close file descriptors after use. - Always munmap memory regions after mmap'ing them. -

svn commit: r299056 - stable/10/sbin/camcontrol

Author: ngie Date: Wed May 4 07:33:58 2016 New Revision: 299056 URL: https://svnweb.freebsd.org/changeset/base/299056 Log: MFC r298758: Remove logically impossible test in scsidoinquiry(..) It was already done 4 lines prior and the value of error didn't change CID: 1011236

svn commit: r299024 - stable/10/lib/libcam

Author: ngie Date: Wed May 4 00:39:03 2016 New Revision: 299024 URL: https://svnweb.freebsd.org/changeset/base/299024 Log: MFC r298753: Fix va_list handling - Add missing va_end's after corresponding va_start's to cleanup state - Eliminate questionable bzero'ing of va_list passed

svn commit: r299023 - stable/9/contrib/bsnmp/gensnmptree

Author: ngie Date: Wed May 4 00:35:41 2016 New Revision: 299023 URL: https://svnweb.freebsd.org/changeset/base/299023 Log: MFstable/10 r299022: MFC r298450: Simplify always evaluated branch (`e != NULL`) - xalloc(..) ensures that e will be non-null via malloc + err. - `e` is

svn commit: r299022 - stable/10/contrib/bsnmp/gensnmptree

Author: ngie Date: Wed May 4 00:34:45 2016 New Revision: 299022 URL: https://svnweb.freebsd.org/changeset/base/299022 Log: MFC r298450: Simplify always evaluated branch (`e != NULL`) - xalloc(..) ensures that e will be non-null via malloc + err. - `e` is already dereferenced above,

svn commit: r299021 - stable/10/lib/libc/tests/stdio

Author: ngie Date: Wed May 4 00:30:36 2016 New Revision: 299021 URL: https://svnweb.freebsd.org/changeset/base/299021 Log: MFC r298311,r298312: r298311: Make sure fmemopen succeeds in :test_append_binary_pos before calling ftell on the FILE object This fixes potential null

svn commit: r299020 - stable/10/contrib/netbsd-tests/lib/libc/ssp

Author: ngie Date: Wed May 4 00:29:05 2016 New Revision: 299020 URL: https://svnweb.freebsd.org/changeset/base/299020 Log: MFC r298368,r298660: r298368: Fix coverity issue with contrib/netbsd-tests/lib/libc/ssp/h_read.c Ensure opening /dev/zero succeeds. Abort the test if it

svn commit: r299019 - stable/9/contrib/bsnmp/snmpd

Author: ngie Date: Wed May 4 00:26:47 2016 New Revision: 299019 URL: https://svnweb.freebsd.org/changeset/base/299019 Log: MFstable/10 r299018: MFC r298448,r298464: r298448: Don't leak `string` in parse_define(..) when a macro has been found and the parser token != TOK_ASSIGN

svn commit: r299018 - stable/10/contrib/bsnmp/snmpd

Author: ngie Date: Wed May 4 00:25:20 2016 New Revision: 299018 URL: https://svnweb.freebsd.org/changeset/base/299018 Log: MFC r298448,r298464: r298448: Don't leak `string` in parse_define(..) when a macro has been found and the parser token != TOK_ASSIGN CID: 1007187, 1007188

svn commit: r299017 - stable/9/usr.sbin/bsnmpd/tools/libbsnmptools

Author: ngie Date: Wed May 4 00:19:46 2016 New Revision: 299017 URL: https://svnweb.freebsd.org/changeset/base/299017 Log: MFstable/10 r299016: MFC r298451,r298452,r298507,r298750: r298451: Don't use `entry` after free in the "already in lists" case Return with 0 as it

svn commit: r299016 - stable/10/usr.sbin/bsnmpd/tools/libbsnmptools

Author: ngie Date: Wed May 4 00:14:50 2016 New Revision: 299016 URL: https://svnweb.freebsd.org/changeset/base/299016 Log: MFC r298451,r298452,r298507,r298750: r298451: Don't use `entry` after free in the "already in lists" case Return with 0 as it isn't an error. CID:

svn commit: r299015 - head/sys/dev/ioat

Author: ngie Date: Tue May 3 23:56:52 2016 New Revision: 299015 URL: https://svnweb.freebsd.org/changeset/base/299015 Log: Use DEVMETHOD_END ({ NULL, NULL }) instead of hardcoding { 0, 0 } Sponsored by: EMC / Isilon Storage Division Modified: head/sys/dev/ioat/ioat.c Modified:

svn commit: r298864 - head/share/mk

Author: ngie Date: Sat Apr 30 21:32:29 2016 New Revision: 298864 URL: https://svnweb.freebsd.org/changeset/base/298864 Log: Allow FILESGROUPS to be specified more than once by pruning out duplicates MFC after: 2 weeks Sponsored by: EMC / Isilon Storage Division Modified:

svn commit: r298844 - head/etc/rc.d

Author: ngie Date: Sat Apr 30 09:50:08 2016 New Revision: 298844 URL: https://svnweb.freebsd.org/changeset/base/298844 Log: Make SERVERS REQUIRE clean when MK_KERBEROS==no Make kdc run BEFORE SERVERS instead of being REQUIREd by SERVERS, so systems that pedantically check REQUIREs

svn commit: r298843 - stable/9/sbin/ping6

Author: ngie Date: Sat Apr 30 09:43:01 2016 New Revision: 298843 URL: https://svnweb.freebsd.org/changeset/base/298843 Log: MFstable/10 r272871: r272871 (by hrs): MFC r271909: Revert changes in r269180. It could cause -c N option to enter an infinite loop if no reply packet is

svn commit: r298842 - head/lib/libkvm

Author: ngie Date: Sat Apr 30 09:32:19 2016 New Revision: 298842 URL: https://svnweb.freebsd.org/changeset/base/298842 Log: Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails MFC after: 1 week Reported by: Coverity CID: 1341474 Sponsored by: EMC / Isilon Storage Division

svn commit: r298841 - head/lib/libkvm

Author: ngie Date: Sat Apr 30 09:31:01 2016 New Revision: 298841 URL: https://svnweb.freebsd.org/changeset/base/298841 Log: Remove a -Wunused-but-set-variable variable -- `pa` Reported by: gcc 5.x Sponsored by: EMC / Isilon Storage Division Modified: head/lib/libkvm/kvm_sparc64.c

svn commit: r298840 - in head: . lib/libkvm

Author: ngie Date: Sat Apr 30 09:21:13 2016 New Revision: 298840 URL: https://svnweb.freebsd.org/changeset/base/298840 Log: Remove kvm_getfiles(3) This libcall has been broken since (at least) r174989/8.0-RELEASE. Bump SHLIB_MAJOR for the change Differential Revision:

svn commit: r298839 - head/lib/libkvm

Author: ngie Date: Sat Apr 30 09:13:26 2016 New Revision: 298839 URL: https://svnweb.freebsd.org/changeset/base/298839 Log: Fix memory allocation edgecases in kvm_argv(..) - Don't leak nbufp on realloc failure in kvm_argv - Catch malloc errors with bufp - Set buflen last in the "buflen

svn commit: r298758 - head/sbin/camcontrol

Author: ngie Date: Thu Apr 28 21:17:23 2016 New Revision: 298758 URL: https://svnweb.freebsd.org/changeset/base/298758 Log: Remove logically impossible test in scsidoinquiry(..) It was already done 4 lines prior and the value of error didn't change MFC after: 3 days Reported by:

svn commit: r298753 - head/lib/libcam

Author: ngie Date: Thu Apr 28 18:41:55 2016 New Revision: 298753 URL: https://svnweb.freebsd.org/changeset/base/298753 Log: Fix va_list handling - Add missing va_end's after corresponding va_start's to cleanup state - Eliminate questionable bzero'ing of va_list passed in to

svn commit: r298750 - head/usr.sbin/bsnmpd/tools/libbsnmptools

Author: ngie Date: Thu Apr 28 17:57:17 2016 New Revision: 298750 URL: https://svnweb.freebsd.org/changeset/base/298750 Log: Use a better idiom for finding UTC prefixed timezones Instead of copy-pasting the string literal for "UTC" 3 times and using strlen, use a static char[3] buffer and

svn commit: r298660 - head/contrib/netbsd-tests/lib/libc/ssp

Author: ngie Date: Tue Apr 26 19:21:35 2016 New Revision: 298660 URL: https://svnweb.freebsd.org/changeset/base/298660 Log: Fix up r298368 Remove the semicolon accidentally added after the new conditional that tests that /dev/zero is opened successfully. MFC after: 1 week X-MFC

svn commit: r298507 - head/usr.sbin/bsnmpd/tools/libbsnmptools

Author: ngie Date: Sat Apr 23 08:10:04 2016 New Revision: 298507 URL: https://svnweb.freebsd.org/changeset/base/298507 Log: Fix looking for "UTC" at start of ptr by using strnmp instead of improperly unrolled equivalent CID: 1347118 MFC after: 1 week Reported by: Coverity Sponsored

svn commit: r298503 - in stable/10: kerberos5/lib/libroken share/mk

Author: ngie Date: Sat Apr 23 07:09:23 2016 New Revision: 298503 URL: https://svnweb.freebsd.org/changeset/base/298503 Log: MFC r297282,r297456,r298012,r298013,r298014: r297282 (by bdrewery): We don't have a CPPFLAGS, COPTS or CPUFLAGS. r297456 (by bdrewery): We don't

svn commit: r298491 - stable/10/lib/msun/tests

Author: ngie Date: Fri Apr 22 21:32:01 2016 New Revision: 298491 URL: https://svnweb.freebsd.org/changeset/base/298491 Log: MFC r297836: Fix appending -O0 to CFLAGS The previous method would completely nerf CFLAGS once bsd.progs.mk had recursed into the per-PROG logic and make the

svn commit: r298490 - stable/10/tests/sys/file

Author: ngie Date: Fri Apr 22 21:30:42 2016 New Revision: 298490 URL: https://svnweb.freebsd.org/changeset/base/298490 Log: MFC r298024,r298196: r298024: Set test_argv to NULL, not 0, if not executing a specific test r298196: Minor cosmetic cleanup - Remove spurious

svn commit: r298489 - stable/9/lib/libc/gen

Author: ngie Date: Fri Apr 22 21:28:50 2016 New Revision: 298489 URL: https://svnweb.freebsd.org/changeset/base/298489 Log: MFstable/10 r298488: MFC r298303: Remove trailing whitespace and use `nitems(mib)` instead of `2` when calling sysctl(3) Modified:

svn commit: r298488 - stable/10/lib/libc/gen

Author: ngie Date: Fri Apr 22 21:26:15 2016 New Revision: 298488 URL: https://svnweb.freebsd.org/changeset/base/298488 Log: MFC r298303: Remove trailing whitespace and use `nitems(mib)` instead of `2` when calling sysctl(3) Modified: stable/10/lib/libc/gen/getpagesize.c Directory

svn commit: r298485 - head/lib/libkvm

Author: ngie Date: Fri Apr 22 18:05:34 2016 New Revision: 298485 URL: https://svnweb.freebsd.org/changeset/base/298485 Log: Fix up pointer issues with lib/libkvm In particular, - avoid dereferencing NULL pointers - test pointers against NULL, not 0 - test for errout == NULL in the

svn commit: r298464 - head/contrib/bsnmp/snmpd

Author: ngie Date: Fri Apr 22 08:11:26 2016 New Revision: 298464 URL: https://svnweb.freebsd.org/changeset/base/298464 Log: Use `sizeof(*uuser)` instead of `sizeof(struct usm_user)` for consistency with the rest of the users in the file No functional change MFC after: 3 days

svn commit: r298463 - head/sys/ufs/ufs

Author: ngie Date: Fri Apr 22 08:09:27 2016 New Revision: 298463 URL: https://svnweb.freebsd.org/changeset/base/298463 Log: Add FEATURE knob for testing for UFS extended attribute kernel support Support can be verified via `feature_present("ufs_extattr")`, etc. Differential Revision:

svn commit: r298462 - head/contrib/bsnmp/snmp_mibII

Author: ngie Date: Fri Apr 22 07:51:38 2016 New Revision: 298462 URL: https://svnweb.freebsd.org/changeset/base/298462 Log: Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This will also now detect error conditions with value->var.subs[sub - 1] ==

svn commit: r298452 - head/usr.sbin/bsnmpd/tools/libbsnmptools

Author: ngie Date: Fri Apr 22 06:01:11 2016 New Revision: 298452 URL: https://svnweb.freebsd.org/changeset/base/298452 Log: Don't try to free `string` (stack allocated char[]) Fix minor style with warnx call while in the neighborhood MFC after: 1 week CID: 1009683 Reported by:

svn commit: r298451 - head/usr.sbin/bsnmpd/tools/libbsnmptools

Author: ngie Date: Fri Apr 22 05:52:40 2016 New Revision: 298451 URL: https://svnweb.freebsd.org/changeset/base/298451 Log: Don't use `entry` after free in the "already in lists" case Return with 0 as it isn't an error. MFC after: 1 week CID: 1006085 Reported by: Coverity

svn commit: r298450 - head/contrib/bsnmp/gensnmptree

Author: ngie Date: Fri Apr 22 05:24:15 2016 New Revision: 298450 URL: https://svnweb.freebsd.org/changeset/base/298450 Log: Simplify always evaluated branch (`e != NULL`) - xalloc(..) ensures that e will be non-null via malloc + err. - `e` is already dereferenced above, so logically it's

svn commit: r298448 - head/contrib/bsnmp/snmpd

Author: ngie Date: Fri Apr 22 05:14:12 2016 New Revision: 298448 URL: https://svnweb.freebsd.org/changeset/base/298448 Log: Don't leak `string` in parse_define(..) when a macro has been found and the parser token != TOK_ASSIGN MFC after: 1 week CID: 1007187, 1007188 Reported by:

svn commit: r298434 - head/lib/msun/tests

Author: ngie Date: Thu Apr 21 19:59:55 2016 New Revision: 298434 URL: https://svnweb.freebsd.org/changeset/base/298434 Log: Completely disable fmaxmin_test (follow up to r297952) COMPILER_TYPE/COMPILER_VERSION doesn't get passed down properly at buildworld/installworld with older build

svn commit: r298368 - head/contrib/netbsd-tests/lib/libc/ssp

Author: ngie Date: Wed Apr 20 20:48:54 2016 New Revision: 298368 URL: https://svnweb.freebsd.org/changeset/base/298368 Log: Fix coverity issue with contrib/netbsd-tests/lib/libc/ssp/h_read.c Ensure opening /dev/zero succeeds. Abort the test if it doesn't. Also, use _PATH_DEVZERO

svn commit: r298366 - head/contrib/netbsd-tests/lib/libc/sys

Author: ngie Date: Wed Apr 20 20:43:05 2016 New Revision: 298366 URL: https://svnweb.freebsd.org/changeset/base/298366 Log: Fix coverity issues with contrib/netbsd-tests/lib/libc/sys/t_connect.c - Ensure socket(2) calls succeed - Don't leak slist allocated by earlier socket(2) call

svn commit: r298315 - head/sbin/savecore

Author: ngie Date: Wed Apr 20 00:49:49 2016 New Revision: 298315 URL: https://svnweb.freebsd.org/changeset/base/298315 Log: Don't leak fd on sectorsize malloc failure Also, call endfsent after calling getfsent (i.e. when not explicitly called with a swap device) for code cleanliness

svn commit: r298312 - head/lib/libc/tests/stdio

Author: ngie Date: Wed Apr 20 00:19:04 2016 New Revision: 298312 URL: https://svnweb.freebsd.org/changeset/base/298312 Log: Fix double fclose of `fp1` when freopen fails freopen handles closing file descriptors on error, with the exception of fdopen'ed descriptors, so closing an already

svn commit: r298311 - head/lib/libc/tests/stdio

Author: ngie Date: Tue Apr 19 23:59:10 2016 New Revision: 298311 URL: https://svnweb.freebsd.org/changeset/base/298311 Log: Make sure fmemopen succeeds in :test_append_binary_pos before calling ftell on the FILE object This fixes potential null pointer dereferences on failure CID:

svn commit: r298304 - head/tests/sys/posixshm

Author: ngie Date: Tue Apr 19 23:15:47 2016 New Revision: 298304 URL: https://svnweb.freebsd.org/changeset/base/298304 Log: Fix issues identified by Coverity - Always munmap memory regions after mmap'ing them. - Make sure getpagesize() returns a value greater than 0 and use a cached

svn commit: r298303 - head/lib/libc/gen

Author: ngie Date: Tue Apr 19 22:59:21 2016 New Revision: 298303 URL: https://svnweb.freebsd.org/changeset/base/298303 Log: Remove trailing whitespace and use `nitems(mib)` instead of `2` when calling sysctl(3) MFC after: 3 days Sponsored by: EMC / Isilon Storage Division Modified:

svn commit: r298301 - head/tests/sys/vm

Author: ngie Date: Tue Apr 19 22:25:14 2016 New Revision: 298301 URL: https://svnweb.freebsd.org/changeset/base/298301 Log: Fix leaks and test for getpagesize() returning == -1 - close file descriptors after use. - Always munmap memory regions after mmap'ing them. - Make sure

svn commit: r298196 - head/tests/sys/file

Author: ngie Date: Mon Apr 18 07:48:27 2016 New Revision: 298196 URL: https://svnweb.freebsd.org/changeset/base/298196 Log: Minor cosmetic cleanup - Remove spurious trailing whitespace in licensing header - Remove unnecessary semi-colon after comment [*] MFC after: 3 days

svn commit: r298024 - head/tests/sys/file

Author: ngie Date: Fri Apr 15 02:53:52 2016 New Revision: 298024 URL: https://svnweb.freebsd.org/changeset/base/298024 Log: Set test_argv to NULL, not 0, if not executing a specific test MFC after: 1 week Submitted by: pfg Sponsored by: EMC / Isilon Storage Division Modified:

svn commit: r298023 - in head/sys: cam/ata sys

Author: ngie Date: Fri Apr 15 02:36:14 2016 New Revision: 298023 URL: https://svnweb.freebsd.org/changeset/base/298023 Log: Fix typos (intenral -> internal) in comments Modified: head/sys/cam/ata/ata_da.c head/sys/sys/module.h Modified: head/sys/cam/ata/ata_da.c

svn commit: r298019 - stable/10/contrib/netbsd-tests/lib/libc/sys

Author: ngie Date: Fri Apr 15 01:20:14 2016 New Revision: 298019 URL: https://svnweb.freebsd.org/changeset/base/298019 Log: MFC r297637: Disable the NetBSD-specific EFAULT requirements test in gettimeofday_err FreeBSD doesn't specifically list this as a supported error, and in some

<    1   2   3   4   5   6   7   8   9   10   >