Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib

2020-01-13 Thread Toomas Soome via svn-src-all
> On 13. Jan 2020, at 20:45, Ian Lepore wrote: > > On Mon, 2020-01-13 at 20:43 +0200, Toomas Soome wrote: >>> On 13. Jan 2020, at 20:31, Ian Lepore wrote: >>> >>> On Mon, 2020-01-13 at 18:22 +, Toomas Soome wrote: >>>> Author: tsoome >&

Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib

2020-01-13 Thread Toomas Soome via svn-src-all
> On 13. Jan 2020, at 20:31, Ian Lepore wrote: > > On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Mon Jan 13 18:22:54 2020 >> New Revision: 356693 >> URL: https://svnweb.freebsd.org/changeset/base/356693 >> >&g

svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib

2020-01-13 Thread Toomas Soome
Author: tsoome Date: Mon Jan 13 18:22:54 2020 New Revision: 356693 URL: https://svnweb.freebsd.org/changeset/base/356693 Log: loader: allocate properly aligned buffer for network packet Use memalign(4, size) to ensure we have properly aligned buffer. MFC after:2 weeks Modified:

svn commit: r356572 - stable/11/stand/i386/libi386

2020-01-09 Thread Toomas Soome
Author: tsoome Date: Thu Jan 9 21:40:59 2020 New Revision: 356572 URL: https://svnweb.freebsd.org/changeset/base/356572 Log: MFC r356570: loader: bioscd probe can get sector size 0 With buggy BIOS, it may happen we get sector size reported 0 for cd, and then the default 512 is used,

svn commit: r356571 - stable/12/stand/i386/libi386

2020-01-09 Thread Toomas Soome
Author: tsoome Date: Thu Jan 9 21:37:50 2020 New Revision: 356571 URL: https://svnweb.freebsd.org/changeset/base/356571 Log: MFC r356570: loader: bioscd probe can get sector size 0 With buggy BIOS, it may happen we get sector size reported 0 for cd, and then the default 512 is used,

svn commit: r356570 - head/stand/i386/libi386

2020-01-09 Thread Toomas Soome
Author: tsoome Date: Thu Jan 9 21:21:08 2020 New Revision: 356570 URL: https://svnweb.freebsd.org/changeset/base/356570 Log: loader: bioscd probe can get sector size 0 With buggy BIOS, it may happen we get sector size reported 0 for cd, and then the default 512 is used, which is quite

svn commit: r356424 - head/stand/libsa/zfs

2020-01-06 Thread Toomas Soome
Author: tsoome Date: Mon Jan 6 19:35:22 2020 New Revision: 356424 URL: https://svnweb.freebsd.org/changeset/base/356424 Log: loader: update zfsimpl.c from illumos review suggestions Add extra comments and update error handling. MFH: 1 week Modified:

Re: svn commit: r356031 - head/stand/i386/gptboot

2019-12-23 Thread Toomas Soome via svn-src-all
The only limit set by specification is: A minimum of 16,384 bytes of space must be reserved for the GPT Partition Entry Array. >From this size and array entry size we do get 128, but specification does not >limit the max number. rgds, toomas > On 23. Dec 2019, at 00:33, Ian Lepore wrote: >

svn commit: r356027 - stable/12/stand/efi/libefi

2019-12-22 Thread Toomas Soome
Author: tsoome Date: Sun Dec 22 20:36:57 2019 New Revision: 356027 URL: https://svnweb.freebsd.org/changeset/base/356027 Log: MFC r355844: loader.efi: efi_readkey_ex needs to key despite the shift status or toggle status From UEFI specification 2.8, page 434: "It should also be noted

svn commit: r356003 - in stable/12: stand/libsa/zfs sys/cddl/boot/zfs

2019-12-22 Thread Toomas Soome
Author: tsoome Date: Sun Dec 22 08:22:02 2019 New Revision: 356003 URL: https://svnweb.freebsd.org/changeset/base/356003 Log: MFC r354283, r354323, r354363, r354364, r354593, r355773, r355786: loader: we do not support booting from pool with log device loader: factor out label and

svn commit: r355929 - stable/12/stand/common

2019-12-20 Thread Toomas Soome
Author: tsoome Date: Fri Dec 20 08:15:55 2019 New Revision: 355929 URL: https://svnweb.freebsd.org/changeset/base/355929 Log: MFC r355702: loader: vdisk dereference after free print out the information and then free the memory used. Modified: stable/12/stand/common/vdisk.c Directory

svn commit: r355928 - stable/12/stand/common

2019-12-20 Thread Toomas Soome
Author: tsoome Date: Fri Dec 20 08:12:44 2019 New Revision: 355928 URL: https://svnweb.freebsd.org/changeset/base/355928 Log: MFC r355703: loader: clean up devopen and devclose a bit devopen should undo setup of f->f_dev in case of error. devclose can just call free(). Modified:

svn commit: r355927 - stable/12/stand/libsa

2019-12-19 Thread Toomas Soome
Author: tsoome Date: Fri Dec 20 07:40:28 2019 New Revision: 355927 URL: https://svnweb.freebsd.org/changeset/base/355927 Log: MFC r355713: loader: cd9660_open() warn: is 'buf' large enough for 'struct iso_primary_descriptor'? We do allocate amount of memory (void * or char *), and then

svn commit: r355844 - head/stand/efi/libefi

2019-12-17 Thread Toomas Soome
Author: tsoome Date: Tue Dec 17 08:30:11 2019 New Revision: 355844 URL: https://svnweb.freebsd.org/changeset/base/355844 Log: loader.efi: efi_readkey_ex needs to key despite the shift status or toggle status From UEFI specification 2.8, page 434: "It should also be noted that certain

svn commit: r355786 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-12-15 Thread Toomas Soome
Author: tsoome Date: Sun Dec 15 21:52:40 2019 New Revision: 355786 URL: https://svnweb.freebsd.org/changeset/base/355786 Log: loader: rewrite zfs vdev initialization In some cases the pool discovery will get stuck in infinite loop while setting up the vdev children. To fix, we split

svn commit: r355773 - head/stand/libsa/zfs

2019-12-15 Thread Toomas Soome
Author: tsoome Date: Sun Dec 15 14:09:49 2019 New Revision: 355773 URL: https://svnweb.freebsd.org/changeset/base/355773 Log: loader: zfsimpl.c cstyle cleanup No functional changes intended. MFC after:1 week Modified: head/stand/libsa/zfs/zfsimpl.c Modified:

svn commit: r355713 - head/stand/libsa

2019-12-13 Thread Toomas Soome
Author: tsoome Date: Fri Dec 13 12:36:16 2019 New Revision: 355713 URL: https://svnweb.freebsd.org/changeset/base/355713 Log: loader: cd9660_open() warn: is 'buf' large enough for 'struct iso_primary_descriptor'? We do allocate amount of memory (void * or char *), and then assign this

svn commit: r355703 - head/stand/common

2019-12-13 Thread Toomas Soome
Author: tsoome Date: Fri Dec 13 08:41:37 2019 New Revision: 355703 URL: https://svnweb.freebsd.org/changeset/base/355703 Log: loader: clean up devopen and devclose a bit devopen should undo setup of f->f_dev in case of error. devclose can just call free(). MFC after:1 week

svn commit: r355702 - head/stand/common

2019-12-13 Thread Toomas Soome
Author: tsoome Date: Fri Dec 13 08:20:20 2019 New Revision: 355702 URL: https://svnweb.freebsd.org/changeset/base/355702 Log: loader: vdisk dereference after free print out the information and then free the memory used. MFC after:1 week Modified: head/stand/common/vdisk.c

svn commit: r355571 - stable/12/stand/efi/libefi

2019-12-09 Thread Toomas Soome
Author: tsoome Date: Mon Dec 9 21:10:18 2019 New Revision: 355571 URL: https://svnweb.freebsd.org/changeset/base/355571 Log: MFC r355347: loader: ReadKeyStrokeEx may return partial keystrokes In some systems we can receive no scancode nor unicodechar values. PR: 240760

svn commit: r355560 - in stable/12/stand/efi: include libefi

2019-12-09 Thread Toomas Soome
Author: tsoome Date: Mon Dec 9 16:21:26 2019 New Revision: 355560 URL: https://svnweb.freebsd.org/changeset/base/355560 Log: MFC r355224, r355308, r355392: loader.efi: efipart needs better support detecting nested partitions Just as disks can have nested partitions, the same happens

svn commit: r355441 - head/stand/efi/loader

2019-12-06 Thread Toomas Soome
Author: tsoome Date: Fri Dec 6 09:50:29 2019 New Revision: 355441 URL: https://svnweb.freebsd.org/changeset/base/355441 Log: loader.efi: print ImageBase so we know where we are Output a bit of debugging aid. Modified: head/stand/efi/loader/main.c Modified: head/stand/efi/loader/main.c

svn commit: r355392 - head/stand/efi/libefi

2019-12-04 Thread Toomas Soome
Author: tsoome Date: Wed Dec 4 16:41:00 2019 New Revision: 355392 URL: https://svnweb.freebsd.org/changeset/base/355392 Log: loader: clean up efipart filter expressions Small cleanup based on illumos review. Modified: head/stand/efi/libefi/efipart.c Modified:

svn commit: r355347 - head/stand/efi/libefi

2019-12-03 Thread Toomas Soome
Author: tsoome Date: Tue Dec 3 18:36:39 2019 New Revision: 355347 URL: https://svnweb.freebsd.org/changeset/base/355347 Log: loader: ReadKeyStrokeEx may return partial keystrokes In some systems we can receive no scancode nor unicodechar values. PR: 240760 Reported by:

svn commit: r355308 - head/stand/efi/libefi

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 21:08:59 2019 New Revision: 355308 URL: https://svnweb.freebsd.org/changeset/base/355308 Log: loader.efi: fix cd boot for cisco C220M3 Reported by: Chris Ross MFC after:1w Modified: head/stand/efi/libefi/efipart.c Modified:

svn commit: r355292 - stable/12

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 15:44:36 2019 New Revision: 355292 URL: https://svnweb.freebsd.org/changeset/base/355292 Log: MFC r355291: Fix mergeinfo. Modified: Directory Properties: stable/12/ (props changed) ___ svn-src-all@freebsd.org

svn commit: r355291 - head/cddl/lib/libzpool

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 15:37:06 2019 New Revision: 355291 URL: https://svnweb.freebsd.org/changeset/base/355291 Log: libzpool: use CFLAGS.lz4.c to build lz4.o and lz4.pico Clean up this Makefile a bit. Modified: head/cddl/lib/libzpool/Makefile Modified:

svn commit: r355290 - stable/12/cddl/lib/libzpool

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 15:28:06 2019 New Revision: 355290 URL: https://svnweb.freebsd.org/changeset/base/355290 Log: libzpool: lz4.c build needs CFLAGS.lz4.c For some reason the setup from CURRENT did not work, probably I did mix something up. Modified:

svn commit: r355286 - stable/12/sys/conf

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 12:26:47 2019 New Revision: 355286 URL: https://svnweb.freebsd.org/changeset/base/355286 Log: MFC r354267: r354264 did mix up the directory path The correct path is sys/cddl/contrib/opensolaris/common/lz4, not sys/cddl/contrib/opensolaris/lz4

svn commit: r355285 - in stable/12: cddl/lib/libzpool stand/efi/boot1 stand/i386/gptzfsboot stand/i386/zfsboot stand/libsa stand/libsa/zfs sys/cddl/boot/zfs sys/cddl/contrib/opensolaris/common/lz4 ...

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 11:44:39 2019 New Revision: 355285 URL: https://svnweb.freebsd.org/changeset/base/355285 Log: MFC r354253, r354254, r354264, r354265 Remove duplicate lz4 implementations Port illumos change: https://www.illumos.org/issues/11667 Move lz4.c out of zfs

svn commit: r355284 - in stable/12/stand/efi: boot1 gptboot

2019-12-02 Thread Toomas Soome
Author: tsoome Date: Mon Dec 2 09:57:07 2019 New Revision: 355284 URL: https://svnweb.freebsd.org/changeset/base/355284 Log: r353501 did mimerge r350654 boot1 and gptboot were left out Replace left over BS->HandleProtocol by OpenProtocolByHandle. Reported by: Harry Schmalzbauer

svn commit: r355224 - in head/stand/efi: include libefi

2019-11-30 Thread Toomas Soome
Author: tsoome Date: Sat Nov 30 09:11:28 2019 New Revision: 355224 URL: https://svnweb.freebsd.org/changeset/base/355224 Log: loader.efi: efipart needs better support detecting nested partitions Just as disks can have nested partitions, the same happens with cd devices, so we need to

svn commit: r354818 - stable/12/stand/common

2019-11-18 Thread Toomas Soome
Author: tsoome Date: Mon Nov 18 16:40:03 2019 New Revision: 354818 URL: https://svnweb.freebsd.org/changeset/base/354818 Log: MFC r354746: loader: add support for hybrid PMBR for GPT partition table Note hybrid table is nor really UEFI specification compliant. Sample hybrid

svn commit: r354817 - stable/12/stand/efi/libefi

2019-11-18 Thread Toomas Soome
Author: tsoome Date: Mon Nov 18 16:37:21 2019 New Revision: 354817 URL: https://svnweb.freebsd.org/changeset/base/354817 Log: MFC r354743, r354766: loader: r354415 did miss to sort subpaths below the partitions loader: remove unused variable from efipart.c Modified:

svn commit: r354766 - head/stand/efi/libefi

2019-11-16 Thread Toomas Soome
Author: tsoome Date: Sat Nov 16 08:16:50 2019 New Revision: 354766 URL: https://svnweb.freebsd.org/changeset/base/354766 Log: loader: remove unused variable from efipart.c Modified: head/stand/efi/libefi/efipart.c Modified: head/stand/efi/libefi/efipart.c

svn commit: r354746 - head/stand/common

2019-11-15 Thread Toomas Soome
Author: tsoome Date: Fri Nov 15 20:43:39 2019 New Revision: 354746 URL: https://svnweb.freebsd.org/changeset/base/354746 Log: loader: add support for hybrid PMBR for GPT partition table Note hybrid table is nor really UEFI specification compliant. Sample hybrid partition table: >

svn commit: r354743 - head/stand/efi/libefi

2019-11-15 Thread Toomas Soome
Author: tsoome Date: Fri Nov 15 18:57:00 2019 New Revision: 354743 URL: https://svnweb.freebsd.org/changeset/base/354743 Log: loader: r354415 did miss to sort subpaths below the partitions Tested on actual system (MBP with UEFI 1.10). Modified: head/stand/efi/libefi/efipart.c Modified:

svn commit: r354704 - stable/12/stand/efi/libefi

2019-11-14 Thread Toomas Soome
Author: tsoome Date: Thu Nov 14 09:39:03 2019 New Revision: 354704 URL: https://svnweb.freebsd.org/changeset/base/354704 Log: MFC r354435: loader: implement fallback efi_devpath_to_name() UEFI 1.10 on macs does not seem to provide devpath to name translation, provide our own (limited)

svn commit: r354674 - stable/12/stand/efi/libefi

2019-11-12 Thread Toomas Soome
Author: tsoome Date: Wed Nov 13 07:04:11 2019 New Revision: 354674 URL: https://svnweb.freebsd.org/changeset/base/354674 Log: MFC: r354415 loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths The macos does create Vendor Media devices on top of APFS container (like partition table

svn commit: r354635 - head/stand/libsa/zfs

2019-11-12 Thread Toomas Soome
Author: tsoome Date: Tue Nov 12 10:02:39 2019 New Revision: 354635 URL: https://svnweb.freebsd.org/changeset/base/354635 Log: reverting r354594 In our case the structure is more complex and simple static initializer will upset compiler diagnostics - using memset is still better than

svn commit: r354594 - head/stand/libsa/zfs

2019-11-10 Thread Toomas Soome
Author: tsoome Date: Sun Nov 10 15:07:36 2019 New Revision: 354594 URL: https://svnweb.freebsd.org/changeset/base/354594 Log: loader: use struct initializer in vdev_probe(). Hopefully it is a bit more clear this way. Modified: head/stand/libsa/zfs/zfsimpl.c Modified:

svn commit: r354593 - head/stand/libsa/zfs

2019-11-10 Thread Toomas Soome
Author: tsoome Date: Sun Nov 10 15:03:59 2019 New Revision: 354593 URL: https://svnweb.freebsd.org/changeset/base/354593 Log: loader: memory leak in vdev_label_read_config() We need to free the allocated buffer for label. Modified: head/stand/libsa/zfs/zfsimpl.c Modified:

svn commit: r354590 - in stable/12: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-10 Thread Toomas Soome
Author: tsoome Date: Sun Nov 10 09:32:17 2019 New Revision: 354590 URL: https://svnweb.freebsd.org/changeset/base/354590 Log: MFC r354279: loader: calculate physical vdev psize from asize Since physical device asize is calculated from psize and the asize is stored in pool label, we can

svn commit: r354535 - head/stand/i386/libi386

2019-11-08 Thread Toomas Soome
Author: tsoome Date: Fri Nov 8 12:19:03 2019 New Revision: 354535 URL: https://svnweb.freebsd.org/changeset/base/354535 Log: cstyle cleanup for i386_copy.c No functional changes are intended. Modified: head/stand/i386/libi386/i386_copy.c Modified: head/stand/i386/libi386/i386_copy.c

Re: svn commit: r354435 - head/stand/efi/libefi

2019-11-07 Thread Toomas Soome via svn-src-all
> On 7. Nov 2019, at 17:29, Warner Losh wrote: > > > > On Thu, Nov 7, 2019 at 4:17 AM Toomas Soome <mailto:tso...@freebsd.org>> wrote: > Author: tsoome > Date: Thu Nov 7 11:17:03 2019 > New Revision: 354435 > URL: https://svnweb.freebsd

svn commit: r354435 - head/stand/efi/libefi

2019-11-07 Thread Toomas Soome
Author: tsoome Date: Thu Nov 7 11:17:03 2019 New Revision: 354435 URL: https://svnweb.freebsd.org/changeset/base/354435 Log: loader: implement fallback efi_devpath_to_name() UEFI 1.10 on macs does not seem to provide devpath to name translation, provide our own (limited) version, so we

svn commit: r354415 - head/stand/efi/libefi

2019-11-06 Thread Toomas Soome
Author: tsoome Date: Wed Nov 6 21:13:10 2019 New Revision: 354415 URL: https://svnweb.freebsd.org/changeset/base/354415 Log: loader.efi: HARDDRIVE_DEVICE_PATH may have subpaths The macos does create Vendor Media devices on top of APFS container (like partition table inside the

svn commit: r354364 - head/stand/libsa/zfs

2019-11-05 Thread Toomas Soome
Author: tsoome Date: Tue Nov 5 18:35:13 2019 New Revision: 354364 URL: https://svnweb.freebsd.org/changeset/base/354364 Log: loader: clean up the noise around log device We are ignoring log device but we also do want to have clean code. Modified: head/stand/libsa/zfs/zfs.c

svn commit: r354363 - head/stand/libsa/zfs

2019-11-05 Thread Toomas Soome
Author: tsoome Date: Tue Nov 5 18:07:30 2019 New Revision: 354363 URL: https://svnweb.freebsd.org/changeset/base/354363 Log: loader: populate nvl with data even when label_txg is 0 We actually do not use that data, at least not now, but we want to avoid possible surprises. Modified:

svn commit: r354332 - head/stand/common

2019-11-04 Thread Toomas Soome
Author: tsoome Date: Mon Nov 4 12:20:19 2019 New Revision: 354332 URL: https://svnweb.freebsd.org/changeset/base/354332 Log: loader: show APFS partition type name Add small visual aid in lsdev output. Modified: head/stand/common/part.c head/stand/common/part.h Modified:

svn commit: r354330 - stable/12/stand/libsa

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Mon Nov 4 06:35:48 2019 New Revision: 354330 URL: https://svnweb.freebsd.org/changeset/base/354330 Log: MFC r354237: loader: asprinf does crash arm64 due to missing NULL pointer check PCHAR macro needs to check if d is NULL. Modified:

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome via svn-src-all
> On 4. Nov 2019, at 03:42, Alexander Motin wrote: > > On 03.11.2019 20:19, Xin Li wrote: >> On 2019-11-03 15:30, Ravi Pokala wrote: >>> Uh >>> >>> I've had a log device in my boot-pool for months, and have booted without >>> issue: >>> >>>[threepio:~] rpokala% zpool status zroot

svn commit: r354324 - head/stand/libsa/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 21:36:29 2019 New Revision: 354324 URL: https://svnweb.freebsd.org/changeset/base/354324 Log: loader: allow booting from pool with log device Apparently people are using log with boot pool, so we can not just error out there. Still we will need to

svn commit: r354323 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 21:19:52 2019 New Revision: 354323 URL: https://svnweb.freebsd.org/changeset/base/354323 Log: loader: factor out label and uberblock load from vdev_probe, add MMP checks Clean up the label read. Modified: head/stand/libsa/zfs/zfsimpl.c

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome via svn-src-all
> On 3. Nov 2019, at 19:42, Andriy Gapon wrote: > > On 03/11/2019 15:25, Toomas Soome wrote: >> Author: tsoome >> Date: Sun Nov 3 13:25:47 2019 >> New Revision: 354283 >> URL: https://svnweb.freebsd.org/changeset/base/354283 >> >> Log: >> l

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome via svn-src-all
55 AM Andriy Gapon wrote: >> >> On 03/11/2019 15:25, Toomas Soome wrote: >>> Author: tsoome >>> Date: Sun Nov 3 13:25:47 2019 >>> New Revision: 354283 >>> URL: https://svnweb.freebsd.org/changeset/base/354283 >>> >>> Log: >&g

svn commit: r354284 - head/stand/libsa/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 14:36:16 2019 New Revision: 354284 URL: https://svnweb.freebsd.org/changeset/base/354284 Log: loader: zfs.c is missing malloc checks, fix it malloc() can return NULL, we need to check the return value. Modified: head/stand/libsa/zfs/zfs.c Modified:

svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 13:25:47 2019 New Revision: 354283 URL: https://svnweb.freebsd.org/changeset/base/354283 Log: loader: we do not support booting from pool with log device If pool has log device, stop there and tell about it. Modified: head/stand/libsa/zfs/zfs.c

svn commit: r354282 - head/stand/libsa/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 13:03:47 2019 New Revision: 354282 URL: https://svnweb.freebsd.org/changeset/base/354282 Log: loader: should check malloc in zfs_dev_open malloc can return NULL. Modified: head/stand/libsa/zfs/zfs.c Modified: head/stand/libsa/zfs/zfs.c

svn commit: r354279 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 11:09:06 2019 New Revision: 354279 URL: https://svnweb.freebsd.org/changeset/base/354279 Log: loader: calculate physical vdev psize from asize Since physical device asize is calculated from psize and the asize is stored in pool label, we can use asize to

svn commit: r354278 - head/stand/userboot/test

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 09:14:29 2019 New Revision: 354278 URL: https://svnweb.freebsd.org/changeset/base/354278 Log: loader: userboot/test should accept more than one disk allow to specify multiple -d options, test -d disk1 -d disk2 .. Modified: head/stand/userboot/test/test.c

svn commit: r354277 - stable/12/sys/cddl/boot/zfs

2019-11-03 Thread Toomas Soome
Author: tsoome Date: Sun Nov 3 07:11:09 2019 New Revision: 354277 URL: https://svnweb.freebsd.org/changeset/base/354277 Log: MFC: r354127 loader: zio_checksum_verify should check byteswap We do have both native and byteswap checksum callbacks in place but the selection is not

svn commit: r354267 - head/sys/conf

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 21:52:45 2019 New Revision: 354267 URL: https://svnweb.freebsd.org/changeset/base/354267 Log: r354264 did mix up the directory path The correct path is sys/cddl/contrib/opensolaris/common/lz4, not sys/cddl/contrib/opensolaris/lz4 Reported by: Michael

svn commit: r354265 - in head: cddl/lib/libzpool sys/cddl/contrib/opensolaris/common/lz4

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 21:02:54 2019 New Revision: 354265 URL: https://svnweb.freebsd.org/changeset/base/354265 Log: r354253 did miss the fact that libzpool is built as fake kernel We build libzpool as kernel like, use _FAKE_KERNEL check to include kernel api in libzpool.

svn commit: r354264 - head/sys/conf

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 20:46:45 2019 New Revision: 354264 URL: https://svnweb.freebsd.org/changeset/base/354264 Log: r354253 did miss the updates to sys/conf/files and sys/conf/kern.pre.mk Reported by: Brandon Bergren Modified: head/sys/conf/files head/sys/conf/kern.pre.mk

svn commit: r354254 - head/sys/cddl/boot/zfs

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 15:08:19 2019 New Revision: 354254 URL: https://svnweb.freebsd.org/changeset/base/354254 Log: r354253 did miss lz4.c from sys/cddl/boot/zfs. Deleted: head/sys/cddl/boot/zfs/lz4.c ___ svn-src-all@freebsd.org mailing

svn commit: r354253 - in head: cddl/lib/libzpool stand/efi/boot1 stand/i386/gptzfsboot stand/i386/zfsboot stand/libsa stand/libsa/zfs sys/cddl/boot/zfs sys/cddl/contrib/opensolaris/common/lz4 sys/c...

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 12:28:04 2019 New Revision: 354253 URL: https://svnweb.freebsd.org/changeset/base/354253 Log: Remove duplicate lz4 implementations Port illumos change: https://www.illumos.org/issues/11667 Move lz4.c out of zfs tree to opensolaris/common/lz4, adjust it

svn commit: r354252 - head/stand/i386/libi386

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 10:53:23 2019 New Revision: 354252 URL: https://svnweb.freebsd.org/changeset/base/354252 Log: loader: libi386/comconsole.c cstyle cleanup Only cstyle, no functional changes. Modified: head/stand/i386/libi386/comconsole.c Modified:

svn commit: r354249 - in head/stand/efi: include libefi loader

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 09:50:36 2019 New Revision: 354249 URL: https://svnweb.freebsd.org/changeset/base/354249 Log: loader: fall back to term_emu on efi console with serial backend In case of efi console having serial backend (video + serial or only serial), we need to stick

svn commit: r354248 - stable/12/stand/libsa/zfs

2019-11-02 Thread Toomas Soome
Author: tsoome Date: Sat Nov 2 09:22:20 2019 New Revision: 354248 URL: https://svnweb.freebsd.org/changeset/base/354248 Log: MFC r354119: loader: rs_alloc() may return NULL rs_alloc() in zfs reader code may return NULL, so we need to check the return value and error out if needed.

svn commit: r354237 - head/stand/libsa

2019-11-01 Thread Toomas Soome
Author: tsoome Date: Fri Nov 1 06:54:07 2019 New Revision: 354237 URL: https://svnweb.freebsd.org/changeset/base/354237 Log: loader: asprinf does crash arm64 due to missing NULL pointer check PCHAR macro needs to check if d is NULL. MFC after:3 days Modified:

svn commit: r354127 - head/sys/cddl/boot/zfs

2019-10-27 Thread Toomas Soome
Author: tsoome Date: Sun Oct 27 08:35:29 2019 New Revision: 354127 URL: https://svnweb.freebsd.org/changeset/base/354127 Log: loader: zio_checksum_verify should check byteswap We do have both native and byteswap checksum callbacks in place but the selection is not wired. MFC after:

svn commit: r354119 - head/stand/libsa/zfs

2019-10-26 Thread Toomas Soome
Author: tsoome Date: Sat Oct 26 18:29:02 2019 New Revision: 354119 URL: https://svnweb.freebsd.org/changeset/base/354119 Log: loader: rs_alloc() may return NULL rs_alloc() in zfs reader code may return NULL, so we need to check the return value and error out if needed. MFC after:1

svn commit: r354114 - stable/12/stand/libsa/zfs

2019-10-26 Thread Toomas Soome
Author: tsoome Date: Sat Oct 26 10:33:21 2019 New Revision: 354114 URL: https://svnweb.freebsd.org/changeset/base/354114 Log: MFC r353757: loader: zfs_fmtdev can crash when pool discovery did fail and we have no spa When zfs probe did fail and no spa was created, but zfs_fmtdev() is

svn commit: r354015 - head/stand/userboot/test

2019-10-24 Thread Toomas Soome
Author: tsoome Date: Thu Oct 24 07:49:33 2019 New Revision: 354015 URL: https://svnweb.freebsd.org/changeset/base/354015 Log: userboot/test should use PRIx64 as one would expect from prefix 0x Test is printing decimal value after prefix 0x. Modified: head/stand/userboot/test/test.c

svn commit: r353757 - head/stand/libsa/zfs

2019-10-19 Thread Toomas Soome
Author: tsoome Date: Sat Oct 19 08:08:06 2019 New Revision: 353757 URL: https://svnweb.freebsd.org/changeset/base/353757 Log: loader: zfs_fmtdev can crash when pool discovery did fail and we have no spa When zfs probe did fail and no spa was created, but zfs_fmtdev() is called, we will

svn commit: r353544 - head/stand/efi/boot1

2019-10-15 Thread Toomas Soome
Author: tsoome Date: Tue Oct 15 08:33:05 2019 New Revision: 353544 URL: https://svnweb.freebsd.org/changeset/base/353544 Log: boot1.efi: provide generic exit() and stub getchar() panic() is expecting us to have exit and getchar, lets provide those. Modified: head/stand/efi/boot1/boot1.c

svn commit: r353543 - in releng/12.1/stand: efi/boot1 efi/include efi/libefi efi/loader efi/loader/arch/i386 libsa

2019-10-15 Thread Toomas Soome
Author: tsoome Date: Tue Oct 15 06:19:33 2019 New Revision: 353543 URL: https://svnweb.freebsd.org/changeset/base/353543 Log: loader.efi: efipart needs to use ioalign UEFI specification 2.7A, EFI_BLOCK_IO_PROTOCOL, page 566. The ioalign property does define the alignment of data

svn commit: r353501 - in stable/12/stand: efi/boot1 efi/include efi/libefi efi/loader efi/loader/arch/i386 libsa

2019-10-14 Thread Toomas Soome
Author: tsoome Date: Mon Oct 14 19:17:00 2019 New Revision: 353501 URL: https://svnweb.freebsd.org/changeset/base/353501 Log: loader.efi: Block IO should honor align_io MFC: r347195, r350654, r350655, r350656, r351274, r351630, r351637 r352421, r352439, r352443, r352444, r352445,

Re: svn commit: r353341 - head/cddl/contrib/opensolaris/cmd/zpool

2019-10-09 Thread Toomas Soome via svn-src-all
> On 9. Oct 2019, at 14:34, Andriy Gapon wrote: > > Author: avg > Date: Wed Oct 9 11:34:16 2019 > New Revision: 353341 > URL: https://svnweb.freebsd.org/changeset/base/353341 > > Log: > zfs: document large_dnode feature > > The text is copied from illumos. > The conversion to mdoc is

svn commit: r353146 - head/stand/efi/libefi

2019-10-06 Thread Toomas Soome
Author: tsoome Date: Sun Oct 6 18:38:58 2019 New Revision: 353146 URL: https://svnweb.freebsd.org/changeset/base/353146 Log: loader.efi: for text mode, use STM to scroll the whole screen Since local UEFI console is implemented on top of framebuffer, we need to avoid redrawing the whole

svn commit: r352740 - head/sys/kern

2019-09-26 Thread Toomas Soome
Author: tsoome Date: Thu Sep 26 07:19:26 2019 New Revision: 352740 URL: https://svnweb.freebsd.org/changeset/base/352740 Log: kernel terminal should initialize fg and bg variables before calling TUNABLE_INT_FETCH We have two ways to check if kenv variable exists - either we check return

svn commit: r352739 - head/sys/dev/vt/hw/fb

2019-09-26 Thread Toomas Soome
Author: tsoome Date: Thu Sep 26 07:14:54 2019 New Revision: 352739 URL: https://svnweb.freebsd.org/changeset/base/352739 Log: vt: use proper return value check with TUNABLE_INT_FETCH The TUNABLE_INT_FETCH is macro around getenv_int() and we will get return value 0 or 1 for failure or

svn commit: r352681 - in head/sys/dev/vt: . hw/fb

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 13:24:31 2019 New Revision: 352681 URL: https://svnweb.freebsd.org/changeset/base/352681 Log: vt: use colors from terminal emulator Instead of hardcoded colors, use terminal state. This also means, we need to record the pointer to terminal state with

svn commit: r352680 - head/sys/kern

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 13:21:07 2019 New Revision: 352680 URL: https://svnweb.freebsd.org/changeset/base/352680 Log: kernel: terminal_init() should check for teken colors from kenv Check for teken.fg_color and teken.bg_color and prepare the color attributes accordingly.

svn commit: r352670 - in head/stand: efi/libefi i386/libi386

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 07:36:35 2019 New Revision: 352670 URL: https://svnweb.freebsd.org/changeset/base/352670 Log: loader: fix indentation in efi_console and vidconsole Remove extra tab. Reported by: yuripv Modified: head/stand/efi/libefi/efi_console.c

svn commit: r352669 - in head/stand: efi/libefi i386/libi386

2019-09-25 Thread Toomas Soome
Author: tsoome Date: Wed Sep 25 07:09:25 2019 New Revision: 352669 URL: https://svnweb.freebsd.org/changeset/base/352669 Log: loader: add teken.fg_color and teken.bg_color variables Add settable variables to control teken default color attributes. The supported colors are 0-7 or basic

svn commit: r352601 - head/stand/lua

2019-09-22 Thread Toomas Soome
Author: tsoome Date: Sun Sep 22 17:39:20 2019 New Revision: 352601 URL: https://svnweb.freebsd.org/changeset/base/352601 Log: loader_lua: lua color changes should end with reset The color change should have reset sequence, not switch to white. Modified: head/stand/lua/color.lua

svn commit: r352599 - head/stand/forth

2019-09-22 Thread Toomas Soome
Author: tsoome Date: Sun Sep 22 16:10:25 2019 New Revision: 352599 URL: https://svnweb.freebsd.org/changeset/base/352599 Log: loader_4th: menu items need to reset color attribute, not switch to white Forth menu kernel and BE entries, instead of resetting the color attribute, are

svn commit: r352548 - head/stand/libsa

2019-09-19 Thread Toomas Soome
Author: tsoome Date: Fri Sep 20 05:22:34 2019 New Revision: 352548 URL: https://svnweb.freebsd.org/changeset/base/352548 Log: loader: fix typo in zalloc. Modified: head/stand/libsa/zalloc.c Modified: head/stand/libsa/zalloc.c

svn commit: r352454 - head/stand/forth

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 18:05:33 2019 New Revision: 352454 URL: https://svnweb.freebsd.org/changeset/base/352454 Log: loader: provide u> and xemit words if needed We have external interpreter (userboot.so) which may be lagging behind with updates and may be missing u> xemit

svn commit: r352451 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 16:16:46 2019 New Revision: 352451 URL: https://svnweb.freebsd.org/changeset/base/352451 Log: loader: revert r352421 As insisted by kib, malloc(0) is quite legal. Modified: head/stand/libsa/zalloc_malloc.c Modified: head/stand/libsa/zalloc_malloc.c

svn commit: r352446 - head/stand/efi/libefi

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 13:50:25 2019 New Revision: 352446 URL: https://svnweb.freebsd.org/changeset/base/352446 Log: loader.efi: efipart needs to use ioalign UEFI specification 2.7A, EFI_BLOCK_IO_PROTOCOL, page 566. The ioalign property does define the alignment of data

svn commit: r352445 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 13:15:27 2019 New Revision: 352445 URL: https://svnweb.freebsd.org/changeset/base/352445 Log: loader: add memalign() to libsa Implement memalign(size_t alignment, size_t size) to allocate aligned memory. Modified: head/stand/libsa/stand.h

svn commit: r352444 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 13:07:02 2019 New Revision: 352444 URL: https://svnweb.freebsd.org/changeset/base/352444 Log: loader: stand.h should define reallocf as Reallocf Use the same approach as other zalloc functions. Modified: head/stand/libsa/stand.h Modified:

svn commit: r352443 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 11:35:53 2019 New Revision: 352443 URL: https://svnweb.freebsd.org/changeset/base/352443 Log: loader: cstyle cleanup libsa zalloc sources Clean up libstand zalloc* sources. Note that it is not 100% whitespace cleanup. I also reduced block in znalloc and

svn commit: r352439 - head/stand/libsa

2019-09-17 Thread Toomas Soome
Author: tsoome Date: Tue Sep 17 09:47:35 2019 New Revision: 352439 URL: https://svnweb.freebsd.org/changeset/base/352439 Log: loader: factor out guard location setup from Realloc To simplify and make it easier to read, use ga_Bytes field from guard structure. Modified:

Re: svn commit: r352421 - head/stand/libsa

2019-09-17 Thread Toomas Soome via svn-src-all
> On 17 Sep 2019, at 11:56, Konstantin Belousov wrote: > > On Mon, Sep 16, 2019 at 08:28:09PM +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Mon Sep 16 20:28:08 2019 >> New Revision: 352421 >> URL: https://svnweb.freebsd.org/changeset/base/352421

svn commit: r352421 - head/stand/libsa

2019-09-16 Thread Toomas Soome
Author: tsoome Date: Mon Sep 16 20:28:08 2019 New Revision: 352421 URL: https://svnweb.freebsd.org/changeset/base/352421 Log: loader: Malloc(0) should return NULL. We really should not allocate anything with size 0. Modified: head/stand/libsa/zalloc_malloc.c Modified:

svn commit: r352420 - head/stand/forth

2019-09-16 Thread Toomas Soome
Author: tsoome Date: Mon Sep 16 20:26:53 2019 New Revision: 352420 URL: https://svnweb.freebsd.org/changeset/base/352420 Log: loader_4th: scan_buffer can leave empty string on stack When the file processing is done, we will have string with lenght 0 in stack and we will attempt to

<    1   2   3   4   5   6   >