Re: svn commit: r253636 - head/sys/vm

2013-07-25 Thread mdf
On Thu, Jul 25, 2013 at 4:43 AM, David Chisnall thera...@freebsd.orgwrote: However(), memset is to be preferred in this idiom because the compiler provides better diagnostics in the case of error: bzero.c:9:22: warning: 'memset' call operates on objects of type 'struct foo' while the

Re: svn commit: r252376 - head/lib/libutil

2013-06-29 Thread mdf
On Sat, Jun 29, 2013 at 9:36 AM, Tim Kientzle kient...@freebsd.org wrote: On Jun 29, 2013, at 9:19 AM, Konstantin Belousov wrote: On Sat, Jun 29, 2013 at 03:52:49PM +, Tim Kientzle wrote: Author: kientzle Date: Sat Jun 29 15:52:48 2013 New Revision: 252376 URL:

Re: svn commit: r252032 - head/sys/amd64/include

2013-06-24 Thread mdf
[snipping everything about counter64, atomic ops, cycles, etc.] I wonder if the idea explained in this paper: http://static.usenix.org/event/usenix03/tech/freenix03/full_papers/mcgarry/mcgarry_html/ Which seems to be used in FreeBSD for some ARM atomics:

Re: svn commit: r250986 - head/sys/dev/usb

2013-05-25 Thread mdf
On Sat, May 25, 2013 at 10:09 AM, Hans Petter Selasky hsela...@freebsd.orgwrote: Author: hselasky Date: Sat May 25 17:09:58 2013 New Revision: 250986 URL: http://svnweb.freebsd.org/changeset/base/250986 Log: Fix some statical clang analyzer warnings. Modified:

Re: svn commit: r250249 - in stable/8/sys: . amd64/amd64 dev/sound i386/i386 kern

2013-05-06 Thread mdf
On Mon, May 6, 2013 at 6:59 AM, John Baldwin j...@freebsd.org wrote: On Saturday, May 04, 2013 3:06:12 pm Dimitry Andric wrote: On May 4, 2013, at 20:51, m...@freebsd.org wrote: On Sat, May 4, 2013 at 11:49 AM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Sat May 4 18

Re: svn commit: r250249 - in stable/8/sys: . amd64/amd64 dev/sound i386/i386 kern

2013-05-04 Thread mdf
On Sat, May 4, 2013 at 11:49 AM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Sat May 4 18:49:04 2013 New Revision: 250249 URL: http://svnweb.freebsd.org/changeset/base/250249 Log: MFC r248933: Use a shared lock for VOP_GETEXTATTR, as it is a read-like operation

Re: svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-05 Thread mdf
On Fri, Apr 5, 2013 at 8:21 AM, Bruce Evans b...@optusnet.com.au wrote: This method works well in userland too. Instead of assert() or abort(), use an null dereference, or more portably, a signal Digressing quite a bit, doesn't abort() send a signal already, i.e. SIGABRT? And doesn't

Re: svn commit: r248649 - in head: share/man/man9 sys/kern sys/sys

2013-03-23 Thread mdf
On Sat, Mar 23, 2013 at 8:11 AM, Will Andrews w...@freebsd.org wrote: Author: will Date: Sat Mar 23 15:11:53 2013 New Revision: 248649 URL: http://svnweb.freebsd.org/changeset/base/248649 Log: Extend taskqueue(9) to enable per-taskqueue callbacks. The scope of these callbacks is

Re: svn commit: r248649 - in head: share/man/man9 sys/kern sys/sys

2013-03-23 Thread mdf
On Sat, Mar 23, 2013 at 9:45 AM, Will Andrews w...@firepipe.net wrote: I agree about the name length, it is a bit obnoxious. However, it is also descriptive. TQCB strikes me as perhaps a bit too far in the other direction. How about TQ_CALLBACK_? Is there an existing (pseudo) convention

Re: svn commit: r247014 - head/lib/libc/stdlib

2013-02-20 Thread mdf
On Tue, Feb 19, 2013 at 3:57 PM, Giorgos Keramidas keram...@freebsd.org wrote: Author: keramida (doc committer) Date: Tue Feb 19 23:57:39 2013 New Revision: 247014 URL: http://svnweb.freebsd.org/changeset/base/247014 Log: Add a sample program that shows how a custom comparison function

Re: svn commit: r244663 - stable/9

2012-12-29 Thread mdf
On Sat, Dec 29, 2012 at 6:38 PM, Benjamin Kaduk bjkf...@gmail.com wrote: On Sat, Dec 29, 2012 at 5:44 AM, Robert N. M. Watson rwat...@freebsd.org wrote: When we talked to various VFS maintainers, looked at the past change history there, and looked at the set of third-party file systems

Re: svn commit: r244112 - head/sys/kern

2012-12-13 Thread mdf
On Thu, Dec 13, 2012 at 1:42 AM, Andriy Gapon a...@freebsd.org wrote: on 13/12/2012 09:16 Adrian Chadd said the following: Hi, I think the fundamental problem here is we have some pretty different ideas of what KASSERT should be, versus what it actually is in various parts of the code. Oh,

Re: svn commit: r243134 - head/sys/sys

2012-11-16 Thread mdf
On Thu, Nov 15, 2012 at 10:25 PM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Fri Nov 16 06:25:20 2012 New Revision: 243134 URL: http://svnweb.freebsd.org/changeset/base/243134 Log: Alphabetically reorder the forward-declarations of the structures. Add the declaration

Re: svn commit: r241471 - head/share/man/man9

2012-10-12 Thread mdf
On Thu, Oct 11, 2012 at 9:55 PM, Gleb Smirnoff gleb...@freebsd.org wrote: On Fri, Oct 12, 2012 at 01:31:03AM +, Kevin Lo wrote: K Author: kevlo K Date: Fri Oct 12 01:31:02 2012 K New Revision: 241471 K URL: http://svn.freebsd.org/changeset/base/241471 K K Log: K Since the moduledata

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread mdf
On Tue, Oct 9, 2012 at 10:16 AM, David Chisnall thera...@freebsd.org wrote: On 9 Oct 2012, at 17:33, Andrey Chernov wrote: Do you check assembler output for _both_ cases? In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread mdf
On Sun, Sep 16, 2012 at 2:53 AM, Alexey Dokuchaev da...@freebsd.org wrote: On Sun, Sep 16, 2012 at 10:37:56AM +0100, Chris Rees wrote: On 16 September 2012 10:28, Alexey Dokuchaev da...@freebsd.org wrote: I thought preferred and more style(9) compliant way to code [empty endless loop] is:

Re: svn commit: r238502 - in head/sys: kern vm

2012-07-15 Thread mdf
On Sun, Jul 15, 2012 at 1:29 PM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Sun Jul 15 20:29:48 2012 New Revision: 238502 URL: http://svn.freebsd.org/changeset/base/238502 Log: Fix a bug with memguard(9) on 32-bit architectures without a VM_KMEM_MAX_SIZE. The code

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread mdf
On Fri, Jun 1, 2012 at 2:14 AM, Bruce Evans b...@optusnet.com.au wrote: +SYSCTL_OID(_vm, OID_AUTO, swap_free, CTLTYPE_INT|CTLFLAG_RD|CTLFLAG_MPSAFE, +               NULL, 0, sysctl_vm_swap_free, Q, +               Blocks of free swap storage.); Bug 9 is a style bug.  I didn't even know that

Re: svn commit: r235797 - head/contrib/gcc

2012-05-22 Thread mdf
On Tue, May 22, 2012 at 1:05 PM, Bruce Evans b...@optusnet.com.au wrote: On Tue, 22 May 2012, David E. O'Brien wrote: Log:  Do not incorrectly warn when printing a quad_t using %qd on 64-bit platforms. I think I like this, since it is technically correct, and will find a different set of

Re: svn commit: r231220 - head/sys/sys

2012-02-08 Thread mdf
On Wed, Feb 8, 2012 at 10:36 AM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Wed Feb  8 18:36:07 2012 New Revision: 231220 URL: http://svn.freebsd.org/changeset/base/231220 Log:  Trim 8 unused bytes from struct vnode on 64-bit architectures. Doesn't this change the KBI?

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread mdf
On Sat, Dec 17, 2011 at 5:14 AM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Sat Dec 17 13:14:44 2011 New Revision: 228625 URL: http://svn.freebsd.org/changeset/base/228625 Log:  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the  shared secret, and use

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread mdf
On Sat, Dec 17, 2011 at 1:54 PM, Dimitry Andric d...@freebsd.org wrote: On 2011-12-17 22:32, m...@freebsd.org wrote: ...  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the  shared secret, and use long long format to snprintf a time_t. If casting is necessary, style

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-23 Thread mdf
On Tue, Nov 22, 2011 at 11:34 PM, Mikolaj Golub troc...@freebsd.org wrote: Author: trociny Date: Wed Nov 23 07:34:09 2011 New Revision: 227873 URL: http://svn.freebsd.org/changeset/base/227873 Log:  Fix build, hopefully.  Reviewed by:  kib Modified:  

Re: svn commit: r227812 - head/lib/libc/string

2011-11-21 Thread mdf
On Mon, Nov 21, 2011 at 6:50 PM, Eitan Adler ead...@freebsd.org wrote: Author: eadler (ports committer) Date: Tue Nov 22 02:50:24 2011 New Revision: 227812 URL: http://svn.freebsd.org/changeset/base/227812 Log:  - fix some style(9) nits with my last commit  - add a comment explaining why I

Re: svn commit: r227588 - in head: share/man/man9 sys/kern sys/sys

2011-11-16 Thread mdf
On Wed, Nov 16, 2011 at 1:51 PM, Pawel Jakub Dawidek p...@freebsd.org wrote: Author: pjd Date: Wed Nov 16 21:51:17 2011 New Revision: 227588 URL: http://svn.freebsd.org/changeset/base/227588 Log:  Constify arguments for locking KPIs where possible.  This enables locking consumers to pass

Re: svn commit: r227541 - head/sys/dev/usb/controller

2011-11-15 Thread mdf
On Tue, Nov 15, 2011 at 12:48 PM, Hans Petter Selasky hsela...@freebsd.org wrote: Author: hselasky Date: Tue Nov 15 20:48:57 2011 New Revision: 227541 URL: http://svn.freebsd.org/changeset/base/227541 Log:  Some brands of XHCI controllers needs more time to reset. ... and since there's no

Re: svn commit: r227541 - head/sys/dev/usb/controller

2011-11-15 Thread mdf
On Tue, Nov 15, 2011 at 1:02 PM, Hans Petter Selasky hsela...@c2i.net wrote: For USB compliant operation, the USB stack requires hz to be greater or equal to 250 hz, to put it like that. Mostly a requirement in USB gadget/device mode. Really? That's news to me. Is that documented somewhere?

Re: svn commit: r227541 - head/sys/dev/usb/controller

2011-11-15 Thread mdf
On Tue, Nov 15, 2011 at 1:20 PM, m...@freebsd.org wrote: On Tue, Nov 15, 2011 at 1:02 PM, Hans Petter Selasky hsela...@c2i.net wrote: For USB compliant operation, the USB stack requires hz to be greater or equal to 250 hz, to put it like that. Mostly a requirement in USB gadget/device mode.

Re: svn commit: r227541 - head/sys/dev/usb/controller

2011-11-15 Thread mdf
On Tue, Nov 15, 2011 at 1:22 PM, Hans Petter Selasky hsela...@c2i.net wrote: On Tuesday 15 November 2011 22:20:18 m...@freebsd.org wrote: On Tue, Nov 15, 2011 at 1:02 PM, Hans Petter Selasky hsela...@c2i.net wrote: For USB compliant operation, the USB stack requires hz to be greater or

Re: svn commit: r227541 - head/sys/dev/usb/controller

2011-11-15 Thread mdf
On Tue, Nov 15, 2011 at 1:22 PM, Hans Petter Selasky hsela...@c2i.net wrote: On Tuesday 15 November 2011 22:20:18 m...@freebsd.org wrote: On Tue, Nov 15, 2011 at 1:02 PM, Hans Petter Selasky hsela...@c2i.net wrote: For USB compliant operation, the USB stack requires hz to be greater or

Re: svn commit: r227473 - head/sbin/geom/class/multipath

2011-11-13 Thread mdf
On Sun, Nov 13, 2011 at 2:46 PM, Garrett Cooper yaneg...@gmail.com wrote: On Sun, Nov 13, 2011 at 2:08 PM, Pawel Jakub Dawidek p...@freebsd.org wrote: On Sat, Nov 12, 2011 at 12:16:23PM -0800, Garrett Cooper wrote: On Sat, Nov 12, 2011 at 12:01 PM, Alexander Motin m...@freebsd.org wrote:

Re: svn commit: r222537 - in head/sys: kern sys

2011-05-31 Thread mdf
On Tue, May 31, 2011 at 10:29 AM, Kenneth D. Merry k...@freebsd.org wrote: Author: ken Date: Tue May 31 17:29:58 2011 New Revision: 222537 URL: http://svn.freebsd.org/changeset/base/222537 Log:  Fix apparent garbage in the message buffer.  While we have had a fix in place (options

Re: svn commit: r222537 - in head/sys: kern sys

2011-05-31 Thread mdf
On Tue, May 31, 2011 at 2:46 PM, Kenneth D. Merry k...@freebsd.org wrote: On Tue, May 31, 2011 at 14:00:18 -0700, m...@freebsd.org wrote: On Tue, May 31, 2011 at 10:29 AM, Kenneth D. Merry k...@freebsd.org wrote: Author: ken Date: Tue May 31 17:29:58 2011 New Revision: 222537 URL:

Re: svn commit: r222537 - in head/sys: kern sys

2011-05-31 Thread mdf
On Tue, May 31, 2011 at 3:11 PM, Kenneth D. Merry k...@freebsd.org wrote: On Tue, May 31, 2011 at 15:02:37 -0700, m...@freebsd.org wrote: On Tue, May 31, 2011 at 2:46 PM, Kenneth D. Merry k...@freebsd.org wrote: On Tue, May 31, 2011 at 14:00:18 -0700, m...@freebsd.org wrote: On Tue, May 31,

Re: svn commit: r221853 - in head/sys: dev/md dev/null sys vm

2011-05-31 Thread mdf
On Tue, May 31, 2011 at 2:48 PM, Pieter de Goeje pie...@degoeje.nl wrote: On Sunday 29 May 2011 05:01:57 m...@freebsd.org wrote: On Sat, May 28, 2011 at 12:03 PM, Pieter de Goeje pie...@degoeje.nl wrote: To me it looks like it's not able to cache the zeroes anymore. Is this intentional? I

Re: svn commit: r221853 - in head/sys: dev/md dev/null sys vm

2011-05-30 Thread mdf
On Mon, May 30, 2011 at 8:25 AM, Bruce Evans b...@optusnet.com.au wrote: On Sat, 28 May 2011 m...@freebsd.org wrote: On Sat, May 28, 2011 at 12:03 PM, Pieter de Goeje pie...@degoeje.nl wrote: On Friday 13 May 2011 20:48:01 Matthew D Fleming wrote: Author: mdf Date: Fri May 13 18:48:00

Re: svn commit: r221853 - in head/sys: dev/md dev/null sys vm

2011-05-28 Thread mdf
On Sat, May 28, 2011 at 12:03 PM, Pieter de Goeje pie...@degoeje.nl wrote: On Friday 13 May 2011 20:48:01 Matthew D Fleming wrote: Author: mdf Date: Fri May 13 18:48:00 2011 New Revision: 221853 URL: http://svn.freebsd.org/changeset/base/221853 Log:   Usa a globally visible region of zeros

Re: svn commit: r222084 - head/contrib/gperf/src

2011-05-18 Thread mdf
On Wed, May 18, 2011 at 2:31 PM, Dimitry Andric d...@freebsd.org wrote: On 2011-05-18 23:16, Pawel Jakub Dawidek wrote: On Wed, May 18, 2011 at 09:06:20PM +, Ben Laurie wrote: Author: benl Date: Wed May 18 21:06:20 2011 New Revision: 222084 URL:

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread mdf
On Mon, May 16, 2011 at 9:18 AM, Poul-Henning Kamp p...@freebsd.org wrote: Author: phk Date: Mon May 16 16:18:40 2011 New Revision: 221993 URL: http://svn.freebsd.org/changeset/base/221993 Log:  Change the length quantities of sbufs to be ssize_t rather than int. Why? I don't object at

Re: svn commit: r221604 - head/usr.sbin/usbdump

2011-05-07 Thread mdf
On Sat, May 7, 2011 at 9:36 AM, Hans Petter Selasky hsela...@c2i.net wrote: On Saturday 07 May 2011 18:28:24 Hans Petter Selasky wrote:   - Use memcpy() instead of bcopy(). - Use memset() instead of bzero(). Why? It usually falls through to the same code in libc. Is there some

Re: svn commit: r220755 - in head: . contrib/gcc/doc contrib/gcc/objc contrib/libobjc etc/mtree gnu/lib gnu/lib/libobjc gnu/usr.bin/cc gnu/usr.bin/cc/cc1obj gnu/usr.bin/cc/cc_tools gnu/usr.bin/cc/doc

2011-04-19 Thread mdf
Trimming since I have a mostly-unrelated question... On Tue, Apr 19, 2011 at 5:40 AM, John Baldwin j...@freebsd.org wrote: On Monday, April 18, 2011 3:59:45 pm Warner Losh wrote: In this case, there was a new kernel thing just after, so it turned out OK. But let's not gratuitously bump the

Re: svn commit: r220791 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys

2011-04-18 Thread mdf
On Mon, Apr 18, 2011 at 12:28 PM, Kostik Belousov kostik...@gmail.com wrote: On Mon, Apr 18, 2011 at 04:32:22PM +, Matthew D Fleming wrote: Author: mdf Date: Mon Apr 18 16:32:22 2011 New Revision: 220791 URL: http://svn.freebsd.org/changeset/base/220791 Log:   Add the posix_fallocate(2

Re: svn commit: r220791 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys

2011-04-18 Thread mdf
On Mon, Apr 18, 2011 at 12:47 PM, Pawel Jakub Dawidek p...@freebsd.org wrote: On Mon, Apr 18, 2011 at 10:28:10PM +0300, Kostik Belousov wrote: +   if (offset + len vap-va_size) { +           VATTR_NULL(vap); +           vap-va_size = offset + len; +           error = VOP_SETATTR(vp, vap,

Re: svn commit: r220791 - in head: lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys

2011-04-18 Thread mdf
2011/4/18 Kostik Belousov kostik...@gmail.com: On Mon, Apr 18, 2011 at 12:49:38PM -0700, m...@freebsd.org wrote: On Mon, Apr 18, 2011 at 12:28 PM, Kostik Belousov kostik...@gmail.com wrote: On Mon, Apr 18, 2011 at 04:32:22PM +, Matthew D Fleming wrote: Author: mdf Date: Mon Apr 18 16

Re: svn commit: r218685 - head/sys/dev/acpica

2011-02-14 Thread mdf
On Mon, Feb 14, 2011 at 10:33 AM, John Baldwin j...@freebsd.org wrote: On Monday, February 14, 2011 12:20:20 pm Matthew D Fleming wrote: Author: mdf Date: Mon Feb 14 17:20:20 2011 New Revision: 218685 URL: http://svn.freebsd.org/changeset/base/218685 Log:   Prevent reading from

Re: svn commit: r218424 - in head/sys: dev/sio kern pc98/cbus sys ufs/ffs

2011-02-08 Thread mdf
On Tue, Feb 8, 2011 at 1:18 AM, Kostik Belousov kostik...@gmail.com wrote: On Tue, Feb 08, 2011 at 12:16:36AM +, Matthew D Fleming wrote: Author: mdf Date: Tue Feb  8 00:16:36 2011 New Revision: 218424 URL: http://svn.freebsd.org/changeset/base/218424 Log:   Based on discussions

Re: svn commit: r218195 - in head/sys: amd64/amd64 arm/arm i386/i386 ia64/ia64 kern mips/mips powerpc/powerpc sparc64/sparc64 sun4v/sun4v sys ufs/ffs

2011-02-03 Thread mdf
On Thu, Feb 3, 2011 at 4:50 AM, John Baldwin j...@freebsd.org wrote: On Thursday, February 03, 2011 2:47:20 am Juli Mallett wrote: On Wed, Feb 2, 2011 at 08:35, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Wed Feb  2 16:35:10 2011 New Revision: 218195 URL: http

Re: svn commit: r217830 - head/share/man/man9

2011-01-26 Thread mdf
On Wed, Jan 26, 2011 at 1:37 AM, Robert Watson rwat...@freebsd.org wrote: On Tue, 25 Jan 2011, Matthew D Fleming wrote: .Dv SBUF_AUTOEXTEND . .Pp The +.Fn sbuf_new_for_sysctl +function will set up an sbuf with a drain function to use +.Fn SYSCTL_OUT +when the internal buffer fills. +The

Re: svn commit: r217830 - head/share/man/man9

2011-01-26 Thread mdf
On Wed, Jan 26, 2011 at 9:55 AM, Robert N. M. Watson rwat...@freebsd.org wrote: On 26 Jan 2011, at 17:12, m...@freebsd.org wrote: Hmm.  Is this description missing mention of how wiring failures are handled? (Also, it should probably mention that this call can sleep for potentially quite

Re: svn commit: r217830 - head/share/man/man9

2011-01-26 Thread mdf
On Wed, Jan 26, 2011 at 1:10 PM, Robert N. M. Watson rwat...@freebsd.org wrote: On 26 Jan 2011, at 18:29, m...@freebsd.org wrote: I suppose an important question is now often we see this actually failing I don't believe we've ever seen a memory failure relating to sysctls at Isilon and

Re: svn commit: r217830 - head/share/man/man9

2011-01-26 Thread mdf
On Wed, Jan 26, 2011 at 1:19 PM, Robert N. M. Watson rwat...@freebsd.org wrote: On 26 Jan 2011, at 21:14, m...@freebsd.org wrote: The kinds of cases I worry about are things like the tcp connection monitoring sysctls. Most systems have a dozen, hundred, or a thousand connections. Some have

Re: svn commit: r217748 - head/sys/netinet/cc

2011-01-23 Thread mdf
For sbuf use for a sysctl you can use sbuf_init_for_sysctl() which will, instead of growing, push the current data out using SYSCTL_OUT to a wired user buffer. There's a few examples in the vm/ code. This can sometimes significantly simplify the code since there's no need to worry about held

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread mdf
On Sat, Jan 15, 2011 at 6:55 AM, Bruce Evans b...@optusnet.com.au wrote: On Sat, 15 Jan 2011, Garrett Cooper wrote: On Fri, Jan 14, 2011 at 10:27 PM, Bruce Evans b...@optusnet.com.au wrote: On Fri, 14 Jan 2011, Garrett Cooper wrote: On Fri, Jan 14, 2011 at 6:42 PM, Bruce Evans

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-15 Thread mdf
On Sat, Jan 15, 2011 at 7:06 PM, Bruce Evans b...@optusnet.com.au wrote: On Sat, 15 Jan 2011 m...@freebsd.org wrote: On Sat, Jan 15, 2011 at 6:55 AM, Bruce Evans b...@optusnet.com.au wrote: The printing is done entirely in user-space, so it's not too bad.  I had figured to upcast everything

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread mdf
On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans b...@optusnet.com.au wrote: On Thu, 13 Jan 2011 m...@freebsd.org wrote: There appear to be 330 uses of SYSCTL and QUAD on the same line in CURRENT.  This seems reasonable to change them to S64, U64 and X64 so they correctly reflect the size they

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-14 Thread mdf
On Thu, Jan 13, 2011 at 9:56 PM, Bruce Evans b...@optusnet.com.au wrote: On Thu, 13 Jan 2011, Matthew D Fleming wrote: Log:  Add a 64-bit hex-printed sysctl(9) since there is at least one place in  the code that wanted it.  It is named X64 rather than XQUAD since the  quad name is a

Re: svn commit: r217369 - in head/sys: cam/scsi sys

2011-01-13 Thread mdf
wrote: Author: mdf Date: Thu Jan 13 18:20:33 2011 New Revision: 217369 URL: http://svn.freebsd.org/changeset/base/217369 Log:  Add a 64-bit hex-printed sysctl(9) since there is at least one place in  the code that wanted it.  It is named X64 rather than XQUAD since the  quad name

Re: svn commit: r217330 - head/sys/x86/x86

2011-01-12 Thread mdf
On Wed, Jan 12, 2011 at 1:21 PM, John Baldwin j...@freebsd.org wrote: On Wednesday, January 12, 2011 4:08:50 pm Matthew D Fleming wrote: Author: mdf Date: Wed Jan 12 21:08:49 2011 New Revision: 217330 URL: http://svn.freebsd.org/changeset/base/217330 Log:   Fix a brain fart.  Since

Re: svn commit: r217330 - head/sys/x86/x86

2011-01-12 Thread mdf
On Wed, Jan 12, 2011 at 4:06 PM, Bruce Evans b...@optusnet.com.au wrote: On Wed, 12 Jan 2011, John Baldwin wrote: Log:  Fix a brain fart.  Since this file is shared between i386 and amd64, a  bus_size_t may be 32 or 64 bits.  Change the bounce_zone alignment field  to explicitly be 32 bits,

Re: svn commit: r217269 - in stable/8/sys: kern sys

2011-01-11 Thread mdf
Gah! Forgot to mention this is a MFC of r216616. On Tue, Jan 11, 2011 at 9:26 AM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Tue Jan 11 17:26:36 2011 New Revision: 217269 URL: http://svn.freebsd.org/changeset/base/217269 Log:  Move the fail_point_entry definition from

Re: svn commit: r216616 - in head/sys: kern sys

2010-12-21 Thread mdf
On Tue, Dec 21, 2010 at 8:29 AM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Tue Dec 21 16:29:58 2010 New Revision: 216616 URL: http://svn.freebsd.org/changeset/base/216616 Log:  Move the fail_point_entry definition from fail.h to kern_fail.c, which  allows putting

Re: svn commit: r216616 - in head/sys: kern sys

2010-12-21 Thread mdf
On Tue, Dec 21, 2010 at 8:52 AM, Stefan Farfeleder stef...@freebsd.org wrote: On Tue, Dec 21, 2010 at 04:29:58PM +, Matthew D Fleming wrote: Author: mdf Date: Tue Dec 21 16:29:58 2010 New Revision: 216616 URL: http://svn.freebsd.org/changeset/base/216616 Log:   Move

Re: svn commit: r216016 - head/sys/sparc64/include

2010-12-07 Thread mdf
On Tue, Dec 7, 2010 at 5:41 AM, Marius Strobl mar...@alchemy.franken.de wrote: On Mon, Dec 06, 2010 at 02:30:01PM -0800, m...@freebsd.org wrote: On Mon, Dec 6, 2010 at 2:07 PM, Marius Strobl mar...@alchemy.franken.de wrote: [lots of snip] With that one the kernel now survies

Re: svn commit: r216016 - head/sys/sparc64/include

2010-12-06 Thread mdf
On Mon, Dec 6, 2010 at 2:07 PM, Marius Strobl mar...@alchemy.franken.de wrote: [lots of snip] With that one the kernel now survies memguard_init() but then panics right afterwards when kmeminit() calls kmem_suballoc(): KDB: debugger backends: ddb KDB: current backend: ddb Copyright (c)

Re: svn commit: r216161 - in head/sys: amd64/amd64 i386/i386

2010-12-03 Thread mdf
On Fri, Dec 3, 2010 at 1:54 PM, Jung-uk Kim j...@freebsd.org wrote: Author: jkim Date: Fri Dec  3 21:54:10 2010 New Revision: 216161 URL: http://svn.freebsd.org/changeset/base/216161 Log:  Explicitly initialize TSC frequency.  To calibrate TSC frequency, we use  DELAY(9) and it may use TSC

Re: svn commit: r213322 - head/sys/kern

2010-10-01 Thread mdf
On Fri, Oct 1, 2010 at 9:34 AM, Andriy Gapon a...@freebsd.org wrote: Author: avg Date: Fri Oct  1 09:34:41 2010 New Revision: 213322 URL: http://svn.freebsd.org/changeset/base/213322 Log:  sysctls in kern_shutdown: add twin tunables  also make couple of sysctl-controlled variables static

Re: svn commit: r213305 - in head/sys: gdb kern sys

2010-09-30 Thread mdf
On Thu, Sep 30, 2010 at 10:05 AM, Andriy Gapon a...@freebsd.org wrote: Author: avg Date: Thu Sep 30 17:05:23 2010 New Revision: 213305 URL: http://svn.freebsd.org/changeset/base/213305 Log:  there must be only one SYSINIT with SI_SUB_RUN_SCHEDULER+SI_ORDER_ANY order  

Re: svn commit: r212964 - head/sys/kern

2010-09-21 Thread mdf
On Tue, Sep 21, 2010 at 8:07 AM, Andriy Gapon a...@freebsd.org wrote: Author: avg Date: Tue Sep 21 15:07:44 2010 New Revision: 212964 URL: http://svn.freebsd.org/changeset/base/212964 Log:  kdb_backtrace: stack(9)-based code to print backtrace without any backend  The idea is to add KDB

Re: svn commit: r212964 - head/sys/kern

2010-09-21 Thread mdf
On Tue, Sep 21, 2010 at 8:40 AM, Andriy Gapon a...@freebsd.org wrote: on 21/09/2010 18:27 Andriy Gapon said the following: on 21/09/2010 18:17 m...@freebsd.org said the following: I'd recommend using stack_print_ddb(), as that avoids any locking which may hang depending on how the kernel

Re: svn commit: r212478 - head/sys/kern

2010-09-11 Thread mdf
On Sat, Sep 11, 2010 at 7:42 PM, Alexander Kabaev k...@freebsd.org wrote: Author: kan Date: Sat Sep 11 19:42:50 2010 New Revision: 212478 URL: http://svn.freebsd.org/changeset/base/212478 Log:  Add missing pointer increment to sbuf_cat. Modified:  head/sys/kern/subr_sbuf.c Modified:

Re: svn commit: r212439 - head/sys/fs/nfs

2010-09-11 Thread mdf
On Sun, Sep 12, 2010 at 12:41 AM, Rick Macklem rmack...@uoguelph.ca wrote: Then, fid_reserved is no more reserved ? Should we rename it ? Comment for fid_reserved about longword alignment is wrong. Well, it's actually more broken than that. fid_len - Most file systems set it to the size of

Re: svn commit: r212368 - head/sys/dev/pci

2010-09-09 Thread mdf
On Thu, Sep 9, 2010 at 11:19 AM, John Baldwin j...@freebsd.org wrote: Author: jhb Date: Thu Sep  9 18:19:15 2010 New Revision: 212368 URL: http://svn.freebsd.org/changeset/base/212368 Log:  - Rename the constant for the Master Data Parity Error flag in the    PCI status register to map its

Re: svn commit: r212182 - head/sys/kern

2010-09-06 Thread mdf
On Mon, Sep 6, 2010 at 6:45 AM, Bruce Evans b...@optusnet.com.au wrote: On Fri, 3 Sep 2010, pluknet wrote: On 3 September 2010 21:23, Matthew D Fleming m...@freebsd.org wrote: Log:  Fix user-space libsbuf build.  Why isn't CTASSERT available to  user-space? Well, user headers shouldn't be

Re: svn commit: r212182 - head/sys/kern

2010-09-03 Thread mdf
On Fri, Sep 3, 2010 at 10:23 AM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Fri Sep  3 17:23:26 2010 New Revision: 212182 URL: http://svn.freebsd.org/changeset/base/212182 Log:  Fix user-space libsbuf build.  Why isn't CTASSERT available to  user-space? Sorry

Re: svn commit: r212153 - head/sys/kern

2010-09-02 Thread mdf
On Thu, Sep 2, 2010 at 9:23 AM, Matthew D Fleming m...@freebsd.org wrote: Author: mdf Date: Thu Sep  2 16:23:05 2010 New Revision: 212153 URL: http://svn.freebsd.org/changeset/base/212153 Log:  Fix UP build. Noticed by b.f. (bf1783 at gmail dot com) We apologize for the inconvenience

Re: svn commit: r212115 - head/sys/kern

2010-09-01 Thread mdf
On Wed, Sep 1, 2010 at 2:31 PM, John Baldwin j...@freebsd.org wrote: On Wednesday, September 01, 2010 4:32:48 pm Matthew D Fleming wrote: Author: mdf Date: Wed Sep  1 20:32:47 2010 New Revision: 212115 URL: http://svn.freebsd.org/changeset/base/212115 Log:   Fix a bug with sched_affinity

Re: svn commit: r211463 - head/usr.bin/grep

2010-08-18 Thread mdf
On Wed, Aug 18, 2010 at 10:40 AM, Gabor Kovesdan ga...@freebsd.org wrote: Author: gabor Date: Wed Aug 18 17:40:10 2010 New Revision: 211463 URL: http://svn.freebsd.org/changeset/base/211463 Log:  - Refactor file reading code to use pure syscalls and an internal buffer    instead of stdio.  

Re: svn commit: r211304 - head/lib/libutil

2010-08-14 Thread mdf
On Sat, Aug 14, 2010 at 2:34 PM, Dag-Erling Smorgrav d...@freebsd.org wrote: Author: des Date: Sat Aug 14 14:34:36 2010 New Revision: 211304 URL: http://svn.freebsd.org/changeset/base/211304 Log:  Simplify expand_number() by combining the (unrolled) loop with the  switch.  Since

Re: svn commit: r211284 - head/sys/kern

2010-08-13 Thread mdf
On Fri, Aug 13, 2010 at 12:20 PM, Pawel Jakub Dawidek p...@freebsd.org wrote: Author: pjd Date: Fri Aug 13 19:20:35 2010 New Revision: 211284 URL: http://svn.freebsd.org/changeset/base/211284 Log:  Simplify taskqueue_drain() by using proved macros. Thanks! This was on my to-do list since

Re: svn commit: r209578 - head/sys/sys

2010-06-29 Thread mdf
2010/6/29 Kostik Belousov kostik...@gmail.com: On Mon, Jun 28, 2010 at 02:07:02PM -0700, Matthew Fleming wrote: On Mon, Jun 28, 2010 at 10:59 AM, Konstantin Belousov k...@freebsd.org wrote: Author: kib Date: Mon Jun 28 17:59:45 2010 New Revision: 209578 URL:

Re: svn commit: r209119 - head/sys/sys

2010-06-14 Thread mdf
BTW, one reason I liked BSD code more than gnu code is that it didn't use so many macros.  Macros should only exist when they are not just syntactic sugar, like DPCPU_SUM() and unlike CPU_FOREACH(). As a style question, I do understand (generally) why too many macros make the code confusing.

Re: svn commit: r209119 - head/sys/sys

2010-06-13 Thread mdf
On Sun, Jun 13, 2010 at 10:10 AM, Pawel Jakub Dawidek p...@freebsd.org wrote: On Sun, Jun 13, 2010 at 02:39:55AM +, Lawrence Stewart wrote: Author: lstewart Date: Sun Jun 13 02:39:55 2010 New Revision: 209119 URL: http://svn.freebsd.org/changeset/base/209119 Log:   Add a utility macro