Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Andrey Zonov
On 7/28/12 2:09 AM, Adrian Chadd wrote: Hi, Can you please revert this commit for now? * it has some netmap stuff in it that isn't related to the commit; * it's causing panics due to lock recursion; I can confirm panics with the latest HEAD running under ESX. _mtx_lock_sleep: recursed on

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Garrett Cooper
On Tue, Jul 31, 2012 at 8:13 AM, Andrey Zonov and...@zonov.org wrote: On 7/28/12 2:09 AM, Adrian Chadd wrote: Hi, Can you please revert this commit for now? * it has some netmap stuff in it that isn't related to the commit; * it's causing panics due to lock recursion; I can confirm

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread John Baldwin
On Tuesday, July 31, 2012 11:16:07 am Garrett Cooper wrote: On Tue, Jul 31, 2012 at 8:13 AM, Andrey Zonov and...@zonov.org wrote: On 7/28/12 2:09 AM, Adrian Chadd wrote: Hi, Can you please revert this commit for now? * it has some netmap stuff in it that isn't related to the commit;

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Jack Vogel
Yes, I agree John, that was ugly, I'm already taking care of it with my changes, I'll send you a copy to check out. Jack On Tue, Jul 31, 2012 at 9:12 AM, John Baldwin j...@freebsd.org wrote: On Tuesday, July 31, 2012 11:16:07 am Garrett Cooper wrote: On Tue, Jul 31, 2012 at 8:13 AM, Andrey

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Garrett Cooper
On Tue, Jul 31, 2012 at 9:20 AM, Jack Vogel jfvo...@gmail.com wrote: Yes, I agree John, that was ugly, I'm already taking care of it with my changes, I'll send you a copy to check out. Like so: --- //depot/user/gcooper/atf-head/src/sys/dev/e1000/if_lem.c 2012-07-25 17:11:00.0 +++

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Jack Vogel
No, like so: --- if_lem.c2012-07-31 18:32:50.0 -0700 +++ if_lem.jfv.c2012-07-31 18:31:25.0 -0700 @@ -1,6 +1,6 @@ /** - Copyright (c) 2001-2011, Intel Corporation + Copyright (c) 2001-2012,

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread John Baldwin
On Tuesday, July 31, 2012 12:29:32 pm Garrett Cooper wrote: On Tue, Jul 31, 2012 at 9:20 AM, Jack Vogel jfvo...@gmail.com wrote: Yes, I agree John, that was ugly, I'm already taking care of it with my changes, I'll send you a copy to check out. Like so: ---

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread John Baldwin
On Tuesday, July 31, 2012 1:46:59 pm Jack Vogel wrote: No, like so: This looks good to me. The 82574 is supported by em(4) and not lem(4) it seems, hence removing that? -- John Baldwin ___ svn-src-all@freebsd.org mailing list

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-31 Thread Jack Vogel
Right, that code got left in lem when i split it off from em by mistake, just cleaning that up. Will commit this then. Jack On Tue, Jul 31, 2012 at 11:09 AM, John Baldwin j...@freebsd.org wrote: On Tuesday, July 31, 2012 1:46:59 pm Jack Vogel wrote: No, like so: This looks good to me.

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-30 Thread John Baldwin
On Wednesday, July 25, 2012 7:28:15 am Luigi Rizzo wrote: Author: luigi Date: Wed Jul 25 11:28:15 2012 New Revision: 238765 URL: http://svn.freebsd.org/changeset/base/238765 Log: Use legacy interrupts as a default. This gives up to 10% speedup when used in qemu (and this driver is for

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-30 Thread Jack Vogel
I have some changes that are needed anyway, I will change this to a tuneable. Jack On Mon, Jul 30, 2012 at 11:45 AM, John Baldwin j...@freebsd.org wrote: On Wednesday, July 25, 2012 7:28:15 am Luigi Rizzo wrote: Author: luigi Date: Wed Jul 25 11:28:15 2012 New Revision: 238765 URL:

Re: svn commit: r238765 - head/sys/dev/e1000

2012-07-27 Thread Adrian Chadd
Hi, Can you please revert this commit for now? * it has some netmap stuff in it that isn't related to the commit; * it's causing panics due to lock recursion; * it likely has other issues you haven't yet found. :) Adrian On 25 July 2012 04:28, Luigi Rizzo lu...@freebsd.org wrote: Author: