Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-13 Thread John Baldwin
On Tuesday, February 12, 2013 2:43:32 am Hans Petter Selasky wrote: On Monday 11 February 2013 17:33:02 John Baldwin wrote: On Sunday, February 10, 2013 5:36:17 am Hans Petter Selasky wrote: Author: hselasky Date: Sun Feb 10 10:36:16 2013 New Revision: 246614 URL:

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-13 Thread Hans Petter Selasky
Hi, On Wednesday 13 February 2013 16:53:02 John Baldwin wrote: You shouldn't call routines that can drain like if_detach() or destroy_dev() or the like while holding any mutexes period. I think you need a 0) step which is detach external consumers including cdev's (destroy_dev()) and

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-13 Thread John Baldwin
On Wednesday, February 13, 2013 11:04:58 am Hans Petter Selasky wrote: Hi, On Wednesday 13 February 2013 16:53:02 John Baldwin wrote: You shouldn't call routines that can drain like if_detach() or destroy_dev() or the like while holding any mutexes period. I think you need a 0) step

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-12 Thread Adrian Chadd
Well, how are you preventing the detach from running _during_ an ioctl()? Have you eliminated the race, or just narrowed it? Adrian ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-12 Thread Hans Petter Selasky
On Tuesday 12 February 2013 09:08:44 Adrian Chadd wrote: Well, how are you preventing the detach from running _during_ an ioctl()? Have you eliminated the race, or just narrowed it? Hi, This is not handled, like you suggest. I'm not sure what the best approach is, but probably we need to

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-12 Thread Adrian Chadd
Well, it's a bigger architectural problem with things that are more complicated than ethernet drivers. :-) Adrian ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-11 Thread John Baldwin
On Sunday, February 10, 2013 5:36:17 am Hans Petter Selasky wrote: Author: hselasky Date: Sun Feb 10 10:36:16 2013 New Revision: 246614 URL: http://svnweb.freebsd.org/changeset/base/246614 Log: - Streamline detach logic in wlan drivers, so that freed memory cannot be used during

Re: svn commit: r246614 - head/sys/dev/usb/wlan

2013-02-11 Thread Hans Petter Selasky
On Monday 11 February 2013 17:33:02 John Baldwin wrote: On Sunday, February 10, 2013 5:36:17 am Hans Petter Selasky wrote: Author: hselasky Date: Sun Feb 10 10:36:16 2013 New Revision: 246614 URL: http://svnweb.freebsd.org/changeset/base/246614 Log: - Streamline detach logic in