Re: svn commit: r349391 - head/sys/kern

2019-07-17 Thread Alan Somers
On Wed, Jul 17, 2019 at 8:07 AM Bruce Evans wrote: > > On Tue, 16 Jul 2019, Alan Somers wrote: > > > On Tue, Jul 16, 2019 at 3:48 AM Bruce Evans wrote: > >> > >> On Mon, 15 Jul 2019, John Baldwin wrote: > >>> ... > >>> I'm not sure which variants are most readable: > >> ... > >>> C) > >>>if

Re: svn commit: r349391 - head/sys/kern

2019-07-17 Thread Bruce Evans
On Tue, 16 Jul 2019, Alan Somers wrote: On Tue, Jul 16, 2019 at 3:48 AM Bruce Evans wrote: On Mon, 15 Jul 2019, John Baldwin wrote: ... I'm not sure which variants are most readable: ... C) if (fp->f_seqcount + howmany(resid, 16384) < fp->f_seqcount) fp->f_seqcount =

Re: svn commit: r349391 - head/sys/kern

2019-07-16 Thread Alan Somers
On Tue, Jul 16, 2019 at 3:48 AM Bruce Evans wrote: > > On Mon, 15 Jul 2019, John Baldwin wrote: > > > On 7/14/19 12:08 PM, Conrad Meyer wrote: > >> > >> This change restores the possible overflow beyond IO_SEQMAX that the > >> removed conditional prevented. > >> > >> On Tue, Jun 25, 2019 at 12:44

Re: svn commit: r349391 - head/sys/kern

2019-07-16 Thread Bruce Evans
On Mon, 15 Jul 2019, John Baldwin wrote: On 7/14/19 12:08 PM, Conrad Meyer wrote: This change restores the possible overflow beyond IO_SEQMAX that the removed conditional prevented. On Tue, Jun 25, 2019 at 12:44 PM Alan Somers wrote: I thought the same for a while on Tue, Jan 25, then

Re: svn commit: r349391 - head/sys/kern

2019-07-15 Thread John Baldwin
On 7/14/19 12:08 PM, Conrad Meyer wrote: > Hi Alan, > > This change restores the possible overflow beyond IO_SEQMAX that the > removed conditional prevented. > > On Tue, Jun 25, 2019 at 12:44 PM Alan Somers wrote: >> >> Author: asomers >> Date: Tue Jun 25 19:44:22 2019 >> New Revision: 349391

Re: svn commit: r349391 - head/sys/kern

2019-07-14 Thread Conrad Meyer
Hi Alan, This change restores the possible overflow beyond IO_SEQMAX that the removed conditional prevented. On Tue, Jun 25, 2019 at 12:44 PM Alan Somers wrote: > > Author: asomers > Date: Tue Jun 25 19:44:22 2019 > New Revision: 349391 > URL: https://svnweb.freebsd.org/changeset/base/349391 >