Re: svn commit: r193475 - head/sbin/kldload

2009-06-05 Thread Stanislav Sedov
On Thu, 4 Jun 2009 23:43:08 + (UTC) Benno Rice be...@freebsd.org mentioned: + if (path == NULL) { + err(1, allocating %lu bytes for the path, + (unsigned long)pathlen + 1); ^^ Why convert pathlen to unsigned long here?

Re: svn commit: r193475 - head/sbin/kldload

2009-06-05 Thread Bruce Evans
On Fri, 5 Jun 2009, Stanislav Sedov wrote: On Thu, 4 Jun 2009 23:43:08 + (UTC) Benno Rice be...@freebsd.org mentioned: [... not quoted] The broken pathname lookup and broken path separator should be in the BUGS section (also in kld syscall manpages). The namespace for the `file'

Re: svn commit: r193475 - head/sbin/kldload

2009-06-05 Thread Jilles Tjoelker
On Fri, Jun 05, 2009 at 06:52:07PM +1000, Bruce Evans wrote: Well, %z might be wrong since only the pathlen variable is of type size_t. The expression `pathlen + 1' has type: __binarypromoteof(__typeof(pathlen), int)), so if size_t is smaller than int then the promotions are non-null

svn commit: r193475 - head/sbin/kldload

2009-06-04 Thread Benno Rice
Author: benno Date: Thu Jun 4 23:43:08 2009 New Revision: 193475 URL: http://svn.freebsd.org/changeset/base/193475 Log: Perform some checking on the requested list of modules to warn people if they try to load modules by filename out of the current directory where the module in question