Author: luigi
Date: Mon Feb 1 14:13:44 2010
New Revision: 203343
URL: http://svn.freebsd.org/changeset/base/203343
Log:
use u_char instead of u_int for short bitfields.
For our compiler the two constructs are completely equivalent, but
some compilers (including MSC and tcc) use the base
On Mon, 1 Feb 2010, Luigi Rizzo wrote:
Log:
use u_char instead of u_int for short bitfields.
This clobbers my ip.h rev.1.15 and tcp.h rev.1.9 (1998), which fixed
the type of these struct members. In C, bit-fields have type _Bool,
int, signed int or unsigned int. Other types are
I concur with Bruce's assessment. Leave well enough alone. We don't
support those other compilers in the rest of the tree.
In particular, ARM generally gets broken when people naively monkey
with these sorts of thing. I'll be quite put-out if this is another
such change. Did you test it?
In message: 20100202012830.b1...@besplex.bde.org
Bruce Evans b...@optusnet.com.au writes:
: Rev.1.30 attempted to fix this by also adding the __aligned(4)
: attribute.
: I haven't checked that this works. It adds additional unportability
: and
: ugliness.
__packed is necessary for
On Mon, Feb 01, 2010 at 10:38:03AM -0700, M. Warner Losh wrote:
I concur with Bruce's assessment. Leave well enough alone. We don't
support those other compilers in the rest of the tree.
These are userland-visible system headers so the change is not for
building the system but for building
In message: 20100201183923.ga32...@onelab2.iet.unipi.it
Luigi Rizzo ri...@iet.unipi.it writes:
: On Mon, Feb 01, 2010 at 10:38:03AM -0700, M. Warner Losh wrote:
: I concur with Bruce's assessment. Leave well enough alone. We don't
: support those other compilers in the rest of the
On Mon, Feb 01, 2010 at 12:03:07PM -0700, M. Warner Losh wrote:
In message: 20100201183923.ga32...@onelab2.iet.unipi.it
Luigi Rizzo ri...@iet.unipi.it writes:
: On Mon, Feb 01, 2010 at 10:38:03AM -0700, M. Warner Losh wrote:
: I concur with Bruce's assessment. Leave well enough
On Mon, 1 Feb 2010, M. Warner Losh wrote:
In message: 20100202012830.b1...@besplex.bde.org
Bruce Evans b...@optusnet.com.au writes:
: Rev.1.30 attempted to fix this by also adding the __aligned(4)
: attribute.
: I haven't checked that this works. It adds additional unportability
:
