Re: svn commit: r217748 - head/sys/netinet/cc

2011-01-23 Thread Lawrence Stewart
Hi Matthew, On 01/24/11 02:39, m...@freebsd.org wrote: > For sbuf use for a sysctl you can use sbuf_init_for_sysctl() which I assume you mean sbuf_new_for_sysctl() that's in kern/kern_sysctl.c? It would be useful to document this function in sbuf(9) - I wasn't aware of it and didn't find it when

Re: svn commit: r217748 - head/sys/netinet/cc

2011-01-23 Thread mdf
For sbuf use for a sysctl you can use sbuf_init_for_sysctl() which will, instead of growing, push the current data out using SYSCTL_OUT to a wired user buffer. There's a few examples in the vm/ code. This can sometimes significantly simplify the code since there's no need to worry about held mute

svn commit: r217748 - head/sys/netinet/cc

2011-01-23 Thread Lawrence Stewart
Author: lstewart Date: Sun Jan 23 13:00:25 2011 New Revision: 217748 URL: http://svn.freebsd.org/changeset/base/217748 Log: An sbuf configured with SBUF_AUTOEXTEND will call malloc with M_WAITOK when a write to the buffer causes it to overflow. We therefore can't hold the CC list rwlock over