Re: svn commit: r221993 - in head/sys: kern sys

2011-05-17 Thread Poul-Henning Kamp
In message 20110516211954.gj48...@deviant.kiev.zoral.com.ua, Kostik Belousov writes: The bump was also needed after the r212367. Lets do one for two changes. I have a few more changes coming, before the bump should happen. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-17 Thread Poul-Henning Kamp
In message 201105161747.40824@freebsd.org, John Baldwin writes: Yes I know, but sbufs are used on platforms where %z is not available so I prefer to use %jd, in particular since this is only assert strings. Really? They have %j but not %z? intmax_t is newer than size_t. Appearantly. --

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-17 Thread Poul-Henning Kamp
In message 20110516211954.gj48...@deviant.kiev.zoral.com.ua, Kostik Belousov writes: struct sbuf is exposed to the libsubf.so consumers. I think that libsbuf.so version shall be bumped (since no symver compat can be provided, due to lack of versioning for libsbuf). The bump was also needed

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-17 Thread Kostik Belousov
On Tue, May 17, 2011 at 01:36:11PM +, Poul-Henning Kamp wrote: In message 20110516211954.gj48...@deviant.kiev.zoral.com.ua, Kostik Belousov writes: struct sbuf is exposed to the libsubf.so consumers. I think that libsbuf.so version shall be bumped (since no symver compat can be

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-17 Thread Warner Losh
On May 17, 2011, at 7:44 AM, Kostik Belousov wrote: On Tue, May 17, 2011 at 01:36:11PM +, Poul-Henning Kamp wrote: In message 20110516211954.gj48...@deviant.kiev.zoral.com.ua, Kostik Belousov writes: struct sbuf is exposed to the libsubf.so consumers. I think that libsbuf.so

svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread Poul-Henning Kamp
Author: phk Date: Mon May 16 16:18:40 2011 New Revision: 221993 URL: http://svn.freebsd.org/changeset/base/221993 Log: Change the length quantities of sbufs to be ssize_t rather than int. Constify a couple of arguments. Modified: head/sys/kern/subr_sbuf.c head/sys/sys/sbuf.h

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread mdf
On Mon, May 16, 2011 at 9:18 AM, Poul-Henning Kamp p...@freebsd.org wrote: Author: phk Date: Mon May 16 16:18:40 2011 New Revision: 221993 URL: http://svn.freebsd.org/changeset/base/221993 Log:  Change the length quantities of sbufs to be ssize_t rather than int. Why? I don't object at

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread Pawel Jakub Dawidek
On Mon, May 16, 2011 at 04:18:40PM +, Poul-Henning Kamp wrote: Author: phk Date: Mon May 16 16:18:40 2011 New Revision: 221993 URL: http://svn.freebsd.org/changeset/base/221993 Log: Change the length quantities of sbufs to be ssize_t rather than int. Constify a couple of

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread Poul-Henning Kamp
In message 20110516193833.ga2...@garage.freebsd.pl, Pawel Jakub Dawidek write s: -(wrote past end of sbuf (%d =3D %d), s-s_len, s-s_size)); +(wrote past end of sbuf (%jd =3D %jd), +(intmax_t)s-s_len, (intmax_t)s-s_size)); For ssize_t we have %zd. Yes I know, but sbufs

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread Poul-Henning Kamp
In message BANLkTin15ap=l5q6ji45b8-eqm9gg7q...@mail.gmail.com, m...@freebsd.or g writes: Log: Change the length quantities of sbufs to be ssize_t rather than int. Why? Do we really expect someone to put more than 2GB into something that is a string buffer? That is exactly why I am doing it.

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread Kostik Belousov
On Mon, May 16, 2011 at 04:18:40PM +, Poul-Henning Kamp wrote: Author: phk Date: Mon May 16 16:18:40 2011 New Revision: 221993 URL: http://svn.freebsd.org/changeset/base/221993 Log: Change the length quantities of sbufs to be ssize_t rather than int. Constify a couple of

Re: svn commit: r221993 - in head/sys: kern sys

2011-05-16 Thread John Baldwin
On Monday, May 16, 2011 4:27:11 pm Poul-Henning Kamp wrote: In message 20110516193833.ga2...@garage.freebsd.pl, Pawel Jakub Dawidek write s: - (wrote past end of sbuf (%d =3D %d), s-s_len, s-s_size)); + (wrote past end of sbuf (%jd =3D %jd), + (intmax_t)s-s_len,